Home | Search
Login

Builder Win7 Debug (NVIDIA) Build #22660 Microsoft Windows

Results:

build successful exception slave lost exception gles2_conform_gl_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1

Trigger Info:

Got Revision1d0a55f1e40f35413ad4191a26e996a2e6473f20

Execution:

Steps and Logfiles:

Show:
  1. ( 3 hrs 43 mins ) steps
    running steps via annotated script
    exception
    slave
    lost
  2. ( 9 mins 22 secs ) update_scripts
    update_scripts
  3. ( 3 ms ) LUCI Migration
    LUCI Migration
  4. ( 4 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 2 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 1 ms ) taskkill
    taskkill
  7. ( 1 ms ) makedirs checkout path
    makedirs checkout path
  8. ( 3 mins 8 secs ) bot_update
    bot_update
    [70GB/249GB used (28%)]
  9. ( 1 ms ) ensure_goma
    ensure_goma
  10. ( 1 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  11. ( 1 ms ) swarming.py --version
    swarming.py --version
    0.10.2
  12. ( 23 secs ) gclient runhooks
    gclient runhooks
  13. ( 1 ms ) get compile targets for scripts
    get compile targets for scripts
  14. ( 6 secs ) read test spec (chromium.gpu.fyi.json)
    read test spec (chromium.gpu.fyi.json)
    path: E:\b\c\b\Win7_Debug__NVIDIA_\src\testing\buildbot\chromium.gpu.fyi.json
  15. ( 19 secs ) build directory
    build directory
  16. ( 1 mins 49 secs ) extract build
    extract build
  17. ( 5 ms ) find isolated tests
    find isolated tests
  18. ( 3 ms ) test_pre_run
    test_pre_run
  19. ( 5 ms ) test_pre_run.[trigger] context_lost_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] context_lost_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  20. ( 3 mins 28 secs ) context_lost_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    context_lost_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:03:17.635780
    Total tests: 6
    * Passed: 5 (5 expected, 0 unexpected)
    * Skipped: 1 (1 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  21. ( 1 ms ) Upload to test-results [context_lost_tests on NVIDIA GPU on Windows]
    Upload to test-results [context_lost_tests on NVIDIA GPU on Windows]
  22. ( 1 ms ) test_pre_run (2)
    test_pre_run (2)
  23. ( 1 ms ) test_pre_run.[trigger] depth_capture_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] depth_capture_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  24. ( 2 mins 56 secs ) depth_capture_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    depth_capture_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:48.333680
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  25. ( 3 ms ) Upload to test-results [depth_capture_tests on NVIDIA GPU on Windows]
    Upload to test-results [depth_capture_tests on NVIDIA GPU on Windows]
  26. ( 3 ms ) test_pre_run (3)
    test_pre_run (3)
  27. ( 5 ms ) test_pre_run.[trigger] gpu_process_launch_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] gpu_process_launch_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  28. ( 2 mins 48 secs ) gpu_process_launch_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    gpu_process_launch_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:32.103480
    Total tests: 13
    * Passed: 13 (13 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  29. ( 2 ms ) Upload to test-results [gpu_process_launch_tests on NVIDIA GPU on Windows]
    Upload to test-results [gpu_process_launch_tests on NVIDIA GPU on Windows]
  30. ( 1 ms ) test_pre_run (4)
    test_pre_run (4)
  31. ( 2 ms ) test_pre_run.[trigger] hardware_accelerated_feature_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] hardware_accelerated_feature_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  32. ( 1 mins 45 secs ) hardware_accelerated_feature_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    hardware_accelerated_feature_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:01:39.718110
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  33. ( 3 ms ) Upload to test-results [hardware_accelerated_feature_tests on NVIDIA GPU on Windows]
    Upload to test-results [hardware_accelerated_feature_tests on NVIDIA GPU on Windows]
  34. ( 3 ms ) test_pre_run (5)
    test_pre_run (5)
  35. ( 5 ms ) test_pre_run.[trigger] info_collection_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] info_collection_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  36. ( 14 mins 56 secs ) info_collection_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    info_collection_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Pending time: 0:11:55.165650
    Shard duration: 0:02:49.919510
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  37. ( 3 ms ) Upload to test-results [info_collection_tests on NVIDIA GPU on Windows]
    Upload to test-results [info_collection_tests on NVIDIA GPU on Windows]
  38. ( 3 ms ) test_pre_run (6)
    test_pre_run (6)
  39. ( 5 ms ) test_pre_run.[trigger] maps_pixel_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] maps_pixel_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  40. ( 4 mins 31 secs ) maps_pixel_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    maps_pixel_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:04:12.871770
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  41. ( 3 ms ) Upload to test-results [maps_pixel_test on NVIDIA GPU on Windows]
    Upload to test-results [maps_pixel_test on NVIDIA GPU on Windows]
  42. ( 3 ms ) test_pre_run (7)
    test_pre_run (7)
  43. ( 5 ms ) test_pre_run.[trigger] pixel_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] pixel_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  44. ( 7 mins 11 secs ) pixel_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    pixel_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Pending time: 0:01:57.046460
    Shard duration: 0:05:04.276240
    Total tests: 46
    * Passed: 46 (46 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  45. ( 3 ms ) Upload to test-results [pixel_test on NVIDIA GPU on Windows]
    Upload to test-results [pixel_test on NVIDIA GPU on Windows]
  46. ( 3 ms ) test_pre_run (8)
    test_pre_run (8)
  47. ( 5 ms ) test_pre_run.[trigger] screenshot_sync_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] screenshot_sync_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  48. ( 15 mins 34 secs ) screenshot_sync_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    screenshot_sync_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Pending time: 0:12:42.685020
    Shard duration: 0:02:29.971510
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  49. ( 1 ms ) Upload to test-results [screenshot_sync_tests on NVIDIA GPU on Windows]
    Upload to test-results [screenshot_sync_tests on NVIDIA GPU on Windows]
  50. ( 1 ms ) test_pre_run (9)
    test_pre_run (9)
  51. ( 1 ms ) test_pre_run.[trigger] trace_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] trace_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  52. ( 6 mins 40 secs ) trace_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    trace_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Pending time: 0:01:21.634380
    Shard duration: 0:05:08.166010
    Total tests: 32
    * Passed: 16 (16 expected, 0 unexpected)
    * Skipped: 16 (16 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  53. ( 3 ms ) Upload to test-results [trace_test on NVIDIA GPU on Windows]
    Upload to test-results [trace_test on NVIDIA GPU on Windows]
  54. ( 3 ms ) test_pre_run (10)
    test_pre_run (10)
  55. ( 6 ms ) test_pre_run.[trigger] webgl_conformance_d3d11_passthrough_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] webgl_conformance_d3d11_passthrough_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  56. ( 23 mins 45 secs ) webgl_conformance_d3d11_passthrough_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    webgl_conformance_d3d11_passthrough_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max pending time: 0:02:05.143120 (shard #1)
    Max shard duration: 0:21:28.007330 (shard #1)
    Total tests: 921
    * Passed: 912 (912 expected, 0 unexpected)
    * Skipped: 9 (9 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  57. ( 1 ms ) Upload to test-results [webgl_conformance_d3d11_passthrough_tests on NVIDIA GPU on Windows]
    Upload to test-results [webgl_conformance_d3d11_passthrough_tests on NVIDIA GPU on Windows]
  58. ( 4 ms ) test_pre_run (11)
    test_pre_run (11)
  59. ( 5 secs ) test_pre_run.[trigger] webgl_conformance_d3d9_passthrough_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] webgl_conformance_d3d9_passthrough_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  60. ( 18 mins 54 secs ) webgl_conformance_d3d9_passthrough_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    webgl_conformance_d3d9_passthrough_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:18:38.634150 (shard #1)
    Total tests: 921
    * Passed: 911 (911 expected, 0 unexpected)
    * Skipped: 10 (10 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  61. ( 4 ms ) Upload to test-results [webgl_conformance_d3d9_passthrough_tests on NVIDIA GPU on Windows]
    Upload to test-results [webgl_conformance_d3d9_passthrough_tests on NVIDIA GPU on Windows]
  62. ( 3 ms ) test_pre_run (12)
    test_pre_run (12)
  63. ( 5 ms ) test_pre_run.[trigger] webgl_conformance_d3d9_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] webgl_conformance_d3d9_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  64. ( 17 mins 45 secs ) webgl_conformance_d3d9_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    webgl_conformance_d3d9_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:17:19.870350 (shard #1)
    Total tests: 921
    * Passed: 909 (909 expected, 0 unexpected)
    * Skipped: 12 (12 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  65. ( 7 secs ) Upload to test-results [webgl_conformance_d3d9_tests on NVIDIA GPU on Windows]
    Upload to test-results [webgl_conformance_d3d9_tests on NVIDIA GPU on Windows]
  66. ( 3 ms ) test_pre_run (13)
    test_pre_run (13)
  67. ( 4 ms ) test_pre_run.[trigger] webgl_conformance_gl_passthrough_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] webgl_conformance_gl_passthrough_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  68. ( 28 mins 7 secs ) webgl_conformance_gl_passthrough_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    webgl_conformance_gl_passthrough_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max pending time: 0:01:24.033160 (shard #1)
    Max shard duration: 0:26:28.147000 (shard #1)
    Total tests: 921
    * Passed: 912 (912 expected, 0 unexpected)
    * Skipped: 9 (9 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  69. ( 4 ms ) Upload to test-results [webgl_conformance_gl_passthrough_tests on NVIDIA GPU on Windows]
    Upload to test-results [webgl_conformance_gl_passthrough_tests on NVIDIA GPU on Windows]
  70. ( 3 ms ) test_pre_run (14)
    test_pre_run (14)
  71. ( 5 ms ) test_pre_run.[trigger] webgl_conformance_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] webgl_conformance_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  72. ( 40 mins 54 secs ) webgl_conformance_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    webgl_conformance_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max pending time: 0:19:50.129460 (shard #1)
    Max shard duration: 0:20:54.880520 (shard #1)
    Total tests: 921
    * Passed: 912 (912 expected, 0 unexpected)
    * Skipped: 9 (9 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  73. ( 4 ms ) Upload to test-results [webgl_conformance_tests on NVIDIA GPU on Windows]
    Upload to test-results [webgl_conformance_tests on NVIDIA GPU on Windows]
  74. ( 3 ms ) test_pre_run (15)
    test_pre_run (15)
  75. ( 5 ms ) test_pre_run.[trigger] angle_end2end_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] angle_end2end_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  76. ( 7 mins 11 secs ) angle_end2end_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    angle_end2end_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:06:55.889520
  77. ( 9 secs ) Upload to test-results [angle_end2end_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1]
    Upload to test-results [angle_end2end_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1]
  78. ( 4 ms ) test_pre_run (16)
    test_pre_run (16)
  79. ( 6 ms ) test_pre_run.[trigger] angle_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] angle_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  80. ( 4 mins 20 secs ) angle_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    angle_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:04:12.646480
  81. ( 8 secs ) Upload to test-results [angle_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1]
    Upload to test-results [angle_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1]
  82. ( 3 ms ) test_pre_run (17)
    test_pre_run (17)
  83. ( 5 ms ) test_pre_run.[trigger] angle_white_box_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] angle_white_box_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  84. ( 17 secs ) angle_white_box_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    angle_white_box_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 11s
  85. ( 5 secs ) Upload to test-results [angle_white_box_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1]
    Upload to test-results [angle_white_box_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1]
  86. ( 7 ms ) test_pre_run (18)
    test_pre_run (18)
  87. ( 11 ms ) test_pre_run.[trigger] gl_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] gl_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  88. ( 33 secs ) gl_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    gl_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 29s
  89. ( 5 secs ) Upload to test-results [gl_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1]
    Upload to test-results [gl_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1]
  90. ( 5 ms ) test_pre_run (19)
    test_pre_run (19)
  91. ( 9 ms ) test_pre_run.[trigger] gl_tests_passthrough on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] gl_tests_passthrough on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  92. ( 19 secs ) gl_tests_passthrough on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    gl_tests_passthrough on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 16s
  93. ( 3 ms ) Upload to test-results [gl_tests_passthrough on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1]
    Upload to test-results [gl_tests_passthrough on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1]
  94. ( 3 ms ) test_pre_run (20)
    test_pre_run (20)
  95. ( 4 ms ) test_pre_run.[trigger] gl_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] gl_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  96. ( 12 secs ) gl_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    gl_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 6s
  97. ( 1 ms ) Upload to test-results [gl_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1]
    Upload to test-results [gl_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1]
  98. ( 1 ms ) test_pre_run (21)
    test_pre_run (21)
  99. ( 2 ms ) test_pre_run.[trigger] gles2_conform_d3d9_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] gles2_conform_d3d9_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  100. ( 2 mins 30 secs ) gles2_conform_d3d9_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    gles2_conform_d3d9_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:20.462750
  101. ( 4 ms ) Upload to test-results [gles2_conform_d3d9_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1]
    Upload to test-results [gles2_conform_d3d9_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1]
  102. ( 4 ms ) test_pre_run (22)
    test_pre_run (22)
  103. ( 5 ms ) test_pre_run.[trigger] gles2_conform_gl_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] gles2_conform_gl_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  104. ( 44 secs ) gles2_conform_gl_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    gles2_conform_gl_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromium/bb/chromium.gpu.fyi/Win7_Debug__NVIDIA_/22660/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.gpu.fyi/Win7_Debug__NVIDIA_/22660" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "2f23f35afb94cd94f0f73192893982eb6ff83f02" Annotation(bot_update)
got_buildtools_revision null Annotation(bot_update)
got_nacl_revision "8ad1515975c09beebd2e9ea69c1f9c5ba88a5bbf" Annotation(bot_update)
got_revision "1d0a55f1e40f35413ad4191a26e996a2e6473f20" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#536341}" Annotation(bot_update)
got_swarming_client_revision null Annotation(bot_update)
got_v8_revision "94c67e1998e38a3e2c41e4c3e6949915e5bb3a97" Annotation(bot_update)
got_v8_revision_cp "refs/heads/6.6.234@{#1}" Annotation(bot_update)
got_webrtc_revision "ab86e7ffe2106c086cde631eee1418f2c128b05b" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#21992}" Annotation(bot_update)
swarm_hashes {"angle_end2end_tests":"0d1ce3e2bb7c4d7c5b775fae2e68a3bd67002a82","angle_unittests":"0dc900d4b8bea6991848d96b400d0d7ec20b20d8","angle_white_box_tests":"13317ebead9d3c261f7cfad9c93c02af3ace3ec7","gl_tests":"f97e3efa3231d24a83bf7d7cd3fdf505df1d1bd9","gl_unittests":"86942a30b0dcafe63529eac5a9ec74f0784cfae9","gles2_conform_test":"ad9bf6fa64ebc19af27cf1caa7caf00eb5590e17","gpu_unittests":"a6779e746e5c9e40b796dee2e98eb2711abf0bba","swiftshader_unittests":"5bf553443a1357a3a6896356755c2e6b91aa1cdb","telemetry_gpu_integration_test":"982363a75f3f775702490230f5b50bdc19bdc8d1","video_decode_accelerator_unittest":"2497698f5799ee5d5651711b8a5cadabe7cb0c91"} Annotation(find isolated tests)
build_data_dir "E:\\b\\rr\\tmpl7580j" Annotation(steps)
build_id "buildbot/chromium.gpu.fyi/Win7 Debug (NVIDIA)/22660" Annotation(steps)
builder_id "master.chromium.gpu.fyi:Win7 Debug (NVIDIA)" Annotation(steps)
blamelist ["bashi@chromium.org","bratell@opera.com","droger@chromium.org","dvadym@chromium.org","ericrk@chromium.org","futhark@chromium.org","gab@chromium.org","gambard@chromium.org","grunell@chromium.org","hikarun@google.com","joelhockey@chromium.org","kinuko@chromium.org","ksakamoto@chromium.org","lfg@chromium.org","mef@chromium.org","msramek@chromium.org","mstensho@chromium.org","nisse@chromium.org","niwa@google.com","rakina@chromium.org","rhalavati@chromium.org","rsorokin@chromium.org","skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","skobes@chromium.org","szager@chromium.org","tangltom@chromium.org","tedchoc@google.com","tkent@chromium.org","treib@chromium.org","v8-autoroll@chromium.org","vabr@chromium.org","webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","yhirano@chromium.org","yukishiino@chromium.org","yuzus@chromium.org","zhuoyu.qian@samsung.com"] Build
branch "master" Build
buildnumber 22660 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1518515947 Build
revision "1d0a55f1e40f35413ad4191a26e996a2e6473f20" Build
slavename "vm83-m1" BuildSlave
buildername "Win7 Debug (NVIDIA)" Builder
git_revision "1d0a55f1e40f35413ad4191a26e996a2e6473f20" Change
parent_buildername "GPU Win Builder (dbg)" ParentBuild
parent_buildnumber 67402 ParentBuild
parent_got_angle_revision "7b17fa189b43360f4bcd3cafa2481c28abb1f877" ParentBuild
parent_got_buildtools_revision null ParentBuild
parent_got_nacl_revision "8ad1515975c09beebd2e9ea69c1f9c5ba88a5bbf" ParentBuild
parent_got_revision "1d0a55f1e40f35413ad4191a26e996a2e6473f20" ParentBuild
parent_got_revision_cp "refs/heads/master@{#536341}" ParentBuild
parent_got_swarming_client_revision null ParentBuild
parent_got_v8_revision "94c67e1998e38a3e2c41e4c3e6949915e5bb3a97" ParentBuild
parent_got_v8_revision_cp "refs/heads/6.6.234@{#1}" ParentBuild
parent_got_webrtc_revision "ab86e7ffe2106c086cde631eee1418f2c128b05b" ParentBuild
parent_got_webrtc_revision_cp "refs/heads/master@{#21992}" ParentBuild
parent_mastername "chromium.gpu.fyi" ParentBuild
buildbotURL "https://build.chromium.org/p/chromium.gpu.fyi/" master.cfg
mastername "chromium.gpu.fyi" master.cfg
workdir "E:\\b\\build\\slave/Win7_Debug__NVIDIA_" slave

Blamelist:

  1. (yhiranoohnoyoudont@chromium.org)
  2. (drogerohnoyoudont@chromium.org)
  3. (gabohnoyoudont@chromium.org)
  4. (ericrkohnoyoudont@chromium.org)
  5. (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  6. (hikarunohnoyoudont@google.com)
  7. (joelhockeyohnoyoudont@chromium.org)
  8. (zhuoyu.qianohnoyoudont@samsung.com)
  9. (ksakamotoohnoyoudont@chromium.org)
  10. (rakinaohnoyoudont@chromium.org)
  11. (zhuoyu.qianohnoyoudont@samsung.com)
  12. (zhuoyu.qianohnoyoudont@samsung.com)
  13. (bashiohnoyoudont@chromium.org)
  14. (tkentohnoyoudont@chromium.org)
  15. (gambardohnoyoudont@chromium.org)
  16. (yuzusohnoyoudont@chromium.org)
  17. (kinukoohnoyoudont@chromium.org)
  18. (zhuoyu.qianohnoyoudont@samsung.com)
  19. (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  20. (yukishiinoohnoyoudont@chromium.org)
  21. (rhalavatiohnoyoudont@chromium.org)
  22. (tkentohnoyoudont@chromium.org)
  23. (niwaohnoyoudont@google.com)
  24. (skobesohnoyoudont@chromium.org)
  25. (gabohnoyoudont@chromium.org)
  26. (joelhockeyohnoyoudont@chromium.org)
  27. (lfgohnoyoudont@chromium.org)
  28. (bratellohnoyoudont@opera.com)
  29. (grunellohnoyoudont@chromium.org)
  30. (mstenshoohnoyoudont@chromium.org)
  31. (futharkohnoyoudont@chromium.org)
  32. (szagerohnoyoudont@chromium.org)
  33. (rsorokinohnoyoudont@chromium.org)
  34. (nisseohnoyoudont@chromium.org)
  35. (yuzusohnoyoudont@chromium.org)
  36. (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  37. (tedchocohnoyoudont@google.com)
  38. (msramekohnoyoudont@chromium.org)
  39. (v8-autorollohnoyoudont@chromium.org)
  40. (dvadymohnoyoudont@chromium.org)
  41. (vabrohnoyoudont@chromium.org)
  42. (treibohnoyoudont@chromium.org)
  43. (tangltomohnoyoudont@chromium.org)
  44. (mefohnoyoudont@chromium.org)

Timing:

Create N/A
Start Tuesday, 13-Feb-18 12:57:53 UTC
End Tuesday, 13-Feb-18 16:41:30 UTC
Pending N/A
Execution 3 hrs 43 mins

All Changes:

  1. Have URLLoader use ResourceScheduler

    Changed by yhiranoohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 08:56:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c9f631add3cbe4c285f81c298b0c571ceabfc148

    Comments

    Have URLLoader use ResourceScheduler
    
    With this CL, content::URLLoader consults ResourceScheduler when it
    starts loading.
    
    ResourceScheduler with URLLoader works as similar to that with
    ResourceDispatcherHost, but there are some differences.
    
     - A ResourceScheduler::Client is created for a
       NetworkURLLoaderFactory in contrast to a RenderView in the existing
       path.
     - We don't provide "deperecated" signals. Part of them are moved to
       the renderer (RendererSideResourceScheduler), and others are no
    ...skip...
    tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    Change-Id: I9b8b4448682b05cf57874dfcf68b1c3fbee9c386
    Reviewed-on: https://chromium-review.googlesource.com/867816
    Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Randy Smith <rdsmith@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536298}

    Changed files

    • content/browser/loader/navigation_url_loader_network_service_unittest.cc
    • content/child/blink_platform_impl.cc
    • ios/web/browser_state.mm
    • services/network/BUILD.gn
    • services/network/network_context.cc
    • services/network/network_context.h
    • services/network/resource_scheduler.cc
    • services/network/resource_scheduler.h
    • services/network/resource_scheduler_client.cc
    • services/network/resource_scheduler_client.h
    • services/network/resource_scheduler_unittest.cc
    • services/network/url_loader.cc
    • services/network/url_loader.h
    • services/network/url_loader_factory.cc
    • services/network/url_loader_factory.h
    • services/network/url_loader_unittest.cc
  2. Revert "[Dice] Remove the SyncSetupInProgressHandle from DiceTurnSyncOnHelper"

    Changed by drogerohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 09:00:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f61bb396dd785ff9aac68a87eee10daa7a99b747

    Comments

    Revert "[Dice] Remove the SyncSetupInProgressHandle from DiceTurnSyncOnHelper"
    
    This reverts commit 2501f6f4e07ac2662c894a1c404de5bb5d8b3680.
    Which was reviewed here: https://chromium-review.googlesource.com/c/chromium/src/+/868012
    That change was causing issues with Sync not starting, as well as problems
    in the UI because this signal was used to disable buttons.
    
    Some tests that were added in the meantime need to be updated.
    To do this, this CL makes GetSetupInProgressHandle() mockable, but still
    lea
    ...skip...
    g the
    gmock documentation:
    https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#delegating-calls-to-a-parent-class
    
    Bug: 810520
    Change-Id: Ib7c3990cc8c04e38a0e3906fdbb3e25a341ad648
    Reviewed-on: https://chromium-review.googlesource.com/913269
    Reviewed-by: Nicolas Zea <zea@chromium.org>
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: David Roger <droger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536299}

    Changed files

    • chrome/browser/ui/webui/settings/people_handler_unittest.cc
    • chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.cc
    • chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.h
    • chrome/browser/ui/webui/signin/dice_turn_sync_on_helper_unittest.cc
    • components/browser_sync/profile_sync_service_mock.cc
    • components/browser_sync/profile_sync_service_mock.h
  3. Fix toplevel.flow for TaskScheduler tasks.

    Changed by gabohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 09:01:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 153eb02201c6bf2eca3eaa26d69de52eba60bc19

    Comments

    Fix toplevel.flow for TaskScheduler tasks.
    
    First TaskTracker wasn't even using a fixed TaskAnnotator instance.
    
    Second, it turns out that TaskAnnotator depends on a unique
    |sequence_num| but TaskScheduler doesn't use nor set
    PendingTask::sequence_num. While this is unfortunate and a bit of an
    overreaching assumption, TaskScheduler is the only task system where
    this isn't true. Thus, it's not worthwhile to refactor how this is
    done at this time. This CL makes this assumption true for TaskScheduler
    tas
    ...skip...
    ixing the
    above issues. Will address this independently.
    Discussion @ https://groups.google.com/a/chromium.org/d/topic/benchmarking-dev/y_cK75SrevE/discussion
    
    Example trace with this CL @ crbug.com/811035#c7
    
    R=fdoray@chromium.org
    
    Bug: 811035
    Change-Id: I77f3ace2eca2b07f1e74f7f79cb35f6d8077931c
    Reviewed-on: https://chromium-review.googlesource.com/913950
    Commit-Queue: Gabriel Charette <gab@chromium.org>
    Reviewed-by: François Doray <fdoray@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536300}

    Changed files

    • base/task_scheduler/task.cc
    • base/task_scheduler/task_tracker.cc
    • base/task_scheduler/task_tracker.h
  4. Account for bottom controls height in scrolling pending tree workaround

    Changed by ericrkohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 09:05:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 885ad6282f8ce39f2415f23a9c2ff0e042792739

    Comments

    Account for bottom controls height in scrolling pending tree workaround
    
    We previously landed a fix to address edge cases where the top bar was
    hidden but the pending tree wasn't updated to account for the new size.
    This workaround needs to be applied for the bottom bar as well.
    
    R=vmpstr@chromium.org
    
    Bug: 794456, 806032
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
    Change-Id: I8bf88667b7f1032f56ebd55226821e74ba902306
    Reviewed-on: https://chromium-review.googlesource.com/915046
    Reviewed-by: vmpstr <vmpstr@chromium.org>
    Commit-Queue: Eric Karl <ericrk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536301}

    Changed files

    • cc/layers/picture_layer_impl.cc
  5. Roll src/third_party/skia/ 82040a9a0..a36db6984 (11 commits)

    Changed by skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Tuesday, 13-Feb-18 09:05:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2488971ff406d2eef88931b20c4d1150a11b92fc

    Comments

    Roll src/third_party/skia/ 82040a9a0..a36db6984 (11 commits)
    
    https://skia.googlesource.com/skia.git/+log/82040a9a056c..a36db6984e76
    
    $ git log 82040a9a0..a36db6984 --date=short --no-merges --format='%ad %ae %s'
    2018-02-12 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 56d4c1d2d..9a5217ca4 (2 commits)
    2018-02-12 bungeman Add text rendering related overrides to Viewer.
    2018-02-12 reed underflow makes it hard to compute proper radii
    2018-02-12 kjlubick Blacklist OOM test on Chromecast
    2018-0
    ...skip...
    omium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
    TBR=caryclark@chromium.org
    
    Change-Id: I87b45a7144476ed80d2231a8d4c64c8395038584
    Reviewed-on: https://chromium-review.googlesource.com/915134
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#536302}

    Changed files

    • DEPS
  6. Rewrite editing/deleting/5126166.html to utilize selection_test()

    Changed by hikarunohnoyoudont@google.com
    Changed at Tuesday, 13-Feb-18 09:06:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 56ec3919e39ed98f9ef8ea8bfcab45b2e19088c1

    Comments

    Rewrite editing/deleting/5126166.html to utilize selection_test()
    
    This patch changes "5126166.html" to utilize |selection_test()| for ease
    of maintenance.
    
    Following patch will rename this test file to
    "delete_selection_ends_inside_empty_table_cell.html" to provide hint
    about what this test file verifies.
    
    Change-Id: I7df776be36ca3a5a0f378bc9ddba2c0dca23bee7
    Reviewed-on: https://chromium-review.googlesource.com/907712
    Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
    Reviewed-by: Yoichi Osato <yoichio@chromium.org>
    Commit-Queue: Hikaru Nishida <hikarun@google.com>
    Cr-Commit-Position: refs/heads/master@{#536303}

    Changed files

    • third_party/WebKit/LayoutTests/editing/deleting/5126166.html
    • third_party/WebKit/LayoutTests/platform/linux/editing/deleting/5126166-expected.png
    • third_party/WebKit/LayoutTests/platform/linux/editing/deleting/5126166-expected.txt
    • third_party/WebKit/LayoutTests/platform/mac/editing/deleting/5126166-expected.png
    • third_party/WebKit/LayoutTests/platform/mac/editing/deleting/5126166-expected.txt
    • third_party/WebKit/LayoutTests/platform/win/editing/deleting/5126166-expected.png
    • third_party/WebKit/LayoutTests/platform/win/editing/deleting/5126166-expected.txt
  7. Reduce QuickView files-metadata-entry mid and right pad to stop mod time wrap

    Changed by joelhockeyohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 09:07:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab4392b2386796ddc709e543c8337ceaf9e377f5

    Comments

    Reduce QuickView files-metadata-entry mid and right pad to stop mod time wrap
    
    Changed middle and right padding from 32px to 16px.  Value can now
    increase by 32px from 128px to 160px.  Left padding stays at 32px
    which is consistent with the rest of the UI.
    
    Value is now wide enough to hold typical English Modified Time string
    "Aug 24, 2017, 10:30 AM" without wrapping.  Will also help any other
    language with long strings.
    
    Bug: 640135
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: I68c2f907027415cad375116ff376c83eec156425
    Reviewed-on: https://chromium-review.googlesource.com/910750
    Reviewed-by: Naoki Fukino <fukino@chromium.org>
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536304}

    Changed files

    • ui/file_manager/file_manager/foreground/elements/files_metadata_entry.html
  8. Expose SelectionHasStyle() as a static funtion of |EditingStyle|.

    Changed by zhuoyu.qianohnoyoudont@samsung.com
    Changed at Tuesday, 13-Feb-18 09:07:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3b703ba20033b05a4e00ddb7d1e49bca2a9a761f

    Comments

    Expose SelectionHasStyle() as a static funtion of |EditingStyle|.
    
    Move Editor::SelectionHasStyle() to EditingStyle. Expose it as a static
    funtion. Make |Editor| simpler for improving code health.
    
    Bug: 672405
    
    Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
    Change-Id: I8c3da99cbcd67a38eaaacdad6e07a10aee95534a
    Reviewed-on: https://chromium-review.googlesource.com/913049
    Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536305}

    Changed files

    • third_party/WebKit/Source/core/editing/EditingStyle.cpp
    • third_party/WebKit/Source/core/editing/EditingStyle.h
    • third_party/WebKit/Source/core/editing/Editor.cpp
    • third_party/WebKit/Source/core/editing/Editor.h
    • third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
    • third_party/WebKit/Source/core/page/ContextMenuController.cpp
  9. Add unit tests for DataPipeToSourceStream

    Changed by ksakamotoohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 09:08:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 13ed54d5ae20105ed97c30354209274cdff5d680

    Comments

    Add unit tests for DataPipeToSourceStream
    
    Bug: 803774
    Change-Id: Ifcf83eea0673946a2f13872c9d739eeed14add44
    Reviewed-on: https://chromium-review.googlesource.com/915482
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536306}

    Changed files

    • content/browser/loader/data_pipe_to_source_stream.h
    • content/browser/loader/data_pipe_to_source_stream_unittest.cc
    • content/test/BUILD.gn
  10. Add Constructor for CSSStyleSheet behind flag

    Changed by rakinaohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 09:08:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3c0a7b3e71ccddb844e486f9af1053897c5fefbe

    Comments

    Add Constructor for CSSStyleSheet behind flag
    
    Expose constructor method for CSS Stylesheet behind a runtime flag.
    Spec draft: https://wicg.github.io/construct-stylesheets/#dom-cssstylesheet-cssstylesheet
    
    Bug: 807560
    Change-Id: Ie8099ef6eca1c38fd3782dee238e866455949e78
    Reviewed-on: https://chromium-review.googlesource.com/898762
    Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
    Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536307}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/css/cssom/interfaces-expected.txt
    • third_party/WebKit/LayoutTests/fast/css/CSSStyleSheet-constructable.html
    • third_party/WebKit/Source/bindings/core/v8/BUILD.gn
    • third_party/WebKit/Source/core/BUILD.gn
    • third_party/WebKit/Source/core/core_idl_files.gni
    • third_party/WebKit/Source/core/css/CSSStyleSheet.cpp
    • third_party/WebKit/Source/core/css/CSSStyleSheet.h
    • third_party/WebKit/Source/core/css/CSSStyleSheet.idl
    • third_party/WebKit/Source/core/css/CSSStyleSheetInit.idl
    • third_party/WebKit/Source/core/css/CSSStyleSheetTest.cpp
    • third_party/WebKit/Source/core/css/StyleSheetCandidate.cpp
    • third_party/WebKit/Source/platform/runtime_enabled_features.json5
  11. Migrate CanDHTML{Copy,Cut}() to Enabled{Copy,Cut}().

    Changed by zhuoyu.qianohnoyoudont@samsung.com
    Changed at Tuesday, 13-Feb-18 09:09:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6d000d46d7ddc2a268b2fa18142211b9a4957797

    Comments

    Migrate CanDHTML{Copy,Cut}() to Enabled{Copy,Cut}().
    
    Editor::CanDHTMLCopy() is called by EnabledCopy() and
    Editor::CanDHTMLCut() is called by EnabledCut() in EditorCommand.cpp.
    Move them to make |Editor| class simpler for improving code health.
    
    Bug: 672405
    
    Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
    Change-Id: I20d034e9d9adfdc283d58cfc451c2e22340cdc27
    Reviewed-on: https://chromium-review.googlesource.com/910752
    Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536308}

    Changed files

    • third_party/WebKit/Source/core/editing/Editor.cpp
    • third_party/WebKit/Source/core/editing/Editor.h
    • third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
  12. Move WriteImageNodeToPasteboard to EditingUtilities.

    Changed by zhuoyu.qianohnoyoudont@samsung.com
    Changed at Tuesday, 13-Feb-18 09:12:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision deb4a13220db89bebd3d1837f7c8fb6cb7a7b8e6

    Comments

    Move WriteImageNodeToPasteboard to EditingUtilities.
    
    Move WriteImageNodeToPasteboard() to make |Editor| class simpler for
    improving code health.
    
    Bug: 672405
    
    Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
    Change-Id: Id3e7ae73aa59e3ad012592b7ec5c7762196cfb21
    Reviewed-on: https://chromium-review.googlesource.com/907813
    Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536309}

    Changed files

    • third_party/WebKit/Source/core/editing/EditingUtilities.cpp
    • third_party/WebKit/Source/core/editing/EditingUtilities.h
    • third_party/WebKit/Source/core/editing/Editor.cpp
  13. Add null check in FetchEvent::HasPendingActivity()

    Changed by bashiohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 09:15:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 724f30f09274b49fb7ea58c4704ab0ae1e8b3399

    Comments

    Add null check in FetchEvent::HasPendingActivity()
    
    |preload_response_property_| could be null when HasPendingActivity()
    is called because we could run GC while constructing FetchEvent.
    This CL adds a null check for |preload_response_property_|.
    
    Bug: 810654
    Change-Id: Ic2544dd0cdda648658fbf7f91f03a363c50d22a9
    Reviewed-on: https://chromium-review.googlesource.com/910475
    Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
    Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536310}

    Changed files

    • third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp
  14. custom-elements: document.importNode() for customized built-in elements should work

    Changed by tkentohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 09:16:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f0cda17a0152e95bf0f247fbe5723b878e8746f4

    Comments

    custom-elements: document.importNode() for customized built-in elements should work
    
    importNode() implementation should pass "is" value to "create an
    element" algorithm.
    
    WPT: Add a new test for importNode().
    
    Bug: 807871
    Change-Id: Id60c5577b5899aeac66b819986c34a28978e24d9
    Reviewed-on: https://chromium-review.googlesource.com/915744
    Reviewed-by: Yoichi Osato <yoichio@chromium.org>
    Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536311}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/custom-elements/upgrading/Document-importNode.html
    • third_party/WebKit/Source/core/dom/Document.cpp
  15. Delete WebToolbar and associated code

    Changed by gambardohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 09:20:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b27a605e3a83977afada8ef379149ab3edc7fa09

    Comments

    Delete WebToolbar and associated code
    
    This CL deletes the code related to the WebToolbar, replaced by the
    CleanToolbar. It also removes the code related to the SafeAreaToolbar,
    enabled by default with the new toolbar.
    
    Bug: 788705
    Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    Change-Id: I8df04ba9f85333d0789e0a6c27a55d0cc78da9c4
    Reviewed-on: https://chromium-review.googlesource.com/905511
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Mark Cogan <marq@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536312}

    Changed files

    • ios/chrome/browser/BUILD.gn
    • ios/chrome/browser/about_flags.mm
    • ios/chrome/browser/ios_chrome_flag_descriptions.cc
    • ios/chrome/browser/ios_chrome_flag_descriptions.h
    • ios/chrome/browser/ui/BUILD.gn
    • ios/chrome/browser/ui/browser_view_controller.h
    • ios/chrome/browser/ui/browser_view_controller.mm
    • ios/chrome/browser/ui/browser_view_controller_dependency_factory.h
    • ios/chrome/browser/ui/browser_view_controller_dependency_factory.mm
    • ios/chrome/browser/ui/browser_view_controller_testing.h
    • ios/chrome/browser/ui/browser_view_controller_testing.mm
    • ios/chrome/browser/ui/browser_view_controller_unittest.mm
    • ios/chrome/browser/ui/bubble/bubble_view_anchor_point_provider.h
    • ios/chrome/browser/ui/history_popup/requirements/BUILD.gn
    • ios/chrome/browser/ui/history_popup/requirements/tab_history_positioner.h
    • ios/chrome/browser/ui/history_popup/tab_history_legacy_coordinator.h
    • ios/chrome/browser/ui/history_popup/tab_history_legacy_coordinator.mm
    • ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm
    • ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.h
    • ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.mm
    • ios/chrome/browser/ui/omnibox/omnibox_popup_positioner.h
    • ios/chrome/browser/ui/omnibox/omnibox_popup_presenter.mm
    • ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
    • ios/chrome/browser/ui/omnibox_perftest.mm
    • ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm
    • ios/chrome/browser/ui/stack_view/stack_view_controller.mm
    • ios/chrome/browser/ui/toolbar/BUILD.gn
    • ios/chrome/browser/ui/toolbar/adaptive/BUILD.gn
    • ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_coordinator.h
    • ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.mm
    • ios/chrome/browser/ui/toolbar/adaptive/toolbar_coordinator_adaptor.h
    • ios/chrome/browser/ui/toolbar/adaptive/toolbar_coordinator_adaptor.mm
    • ios/chrome/browser/ui/toolbar/clean/toolbar_button_updater.h
    • ios/chrome/browser/ui/toolbar/clean/toolbar_button_updater.mm
    • ios/chrome/browser/ui/toolbar/clean/toolbar_coordinator.mm
    • ios/chrome/browser/ui/toolbar/legacy_toolbar_coordinator.h
    • ios/chrome/browser/ui/toolbar/legacy_toolbar_coordinator.mm
    • ios/chrome/browser/ui/toolbar/legacy_toolbar_view.mm
    • ios/chrome/browser/ui/toolbar/public/BUILD.gn
    • ios/chrome/browser/ui/toolbar/public/abstract_toolbar.h
    • ios/chrome/browser/ui/toolbar/public/abstract_web_toolbar.h
    • ios/chrome/browser/ui/toolbar/public/legacy_toolbar_coordinator.h
    • ios/chrome/browser/ui/toolbar/public/primary_toolbar_coordinator.h
    • ios/chrome/browser/ui/toolbar/public/toolbar.h
    • ios/chrome/browser/ui/toolbar/public/toolbar_controller_base_feature.h
    • ios/chrome/browser/ui/toolbar/public/toolbar_controller_base_feature.mm
    • ios/chrome/browser/ui/toolbar/public/toolbar_coordinating.h
    • ios/chrome/browser/ui/toolbar/public/toolbar_utils.mm
    • ios/chrome/browser/ui/toolbar/toolbar_adapter.h
    • ios/chrome/browser/ui/toolbar/toolbar_adapter.mm
    • ios/chrome/browser/ui/toolbar/toolbar_controller.h
    • ios/chrome/browser/ui/toolbar/toolbar_controller.mm
    • ios/chrome/browser/ui/toolbar/toolbar_private_base_feature.h
    • ios/chrome/browser/ui/toolbar/toolbar_private_base_feature.mm
    • ios/chrome/browser/ui/toolbar/web_toolbar_controller.h
    • ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
    • ios/chrome/browser/ui/toolbar/web_toolbar_controller_private.h
    • ios/chrome/browser/ui/toolbar/web_toolbar_controller_unittest.mm
    • ios/chrome/browser/ui/toolbar/web_toolbar_delegate.h
    • ios/chrome/browser/ui/ui_util.h
    • ios/chrome/browser/ui/ui_util.mm
  16. Move a flaky timing out case to resource loading list in leak detection

    Changed by yuzusohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 09:25:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c7828befd11d73d29b91b14547c7f7f3e1a38977

    Comments

    Move a flaky timing out case to resource loading list in leak detection
    
    This CL moves a test case which fails from time to time because of timing out to resource-loading-list in Leak Detection.
    This should stop the flakiness of the test.
    
    Change-Id: I393cfc6bf61200cfbd866553880495905ca156ff
    Reviewed-on: https://chromium-review.googlesource.com/914986
    Reviewed-by: Keishi Hattori <keishi@chromium.org>
    Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536313}

    Changed files

    • tools/perf/contrib/leak_detection/page_sets.py
  17. Fix SignedExchangeHeaderParser::Signature's casing

    Changed by kinukoohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 09:26:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 147584c5b2adf33a6e0160bd23aeace6be62fb07

    Comments

    Fix SignedExchangeHeaderParser::Signature's casing
    
    Change-Id: If79ccc77183a01860d9866f6186b2e9923593d19
    Reviewed-on: https://chromium-review.googlesource.com/915682
    Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536314}

    Changed files

    • content/browser/loader/signed_exchange_header_parser.cc
    • content/browser/loader/signed_exchange_header_parser.h
    • content/browser/loader/signed_exchange_header_parser_unittest.cc
  18. Move TidyUpHTMLStructure() to EditingCommandsUtilities

    Changed by zhuoyu.qianohnoyoudont@samsung.com
    Changed at Tuesday, 13-Feb-18 09:30:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 16bd4066cd8263e8b6c4d2a26d19f98b26e5fec8

    Comments

    Move TidyUpHTMLStructure() to EditingCommandsUtilities
    
    Move TidyUpHTMLStructure() to make |Editor| class simpler for improving
    code health. Move the related tests to EditingCommandsUtilitiesTest.
    
    Bug: 672405
    
    Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
    Change-Id: I48b56a330d085b24f0b64280d0ee60d6b672c464
    Reviewed-on: https://chromium-review.googlesource.com/908388
    Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536315}

    Changed files

    • third_party/WebKit/Source/core/editing/Editor.cpp
    • third_party/WebKit/Source/core/editing/EditorTest.cpp
    • third_party/WebKit/Source/core/editing/commands/DocumentExecCommand.cpp
    • third_party/WebKit/Source/core/editing/commands/EditingCommandsUtilities.cpp
    • third_party/WebKit/Source/core/editing/commands/EditingCommandsUtilities.h
    • third_party/WebKit/Source/core/editing/commands/EditingCommandsUtilitiesTest.cpp
  19. Roll src/third_party/webrtc/ 1370e309e..ef76e5a06 (2 commits)

    Changed by webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Tuesday, 13-Feb-18 09:31:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4402134e68e443b37121258c8f91b7d497379d3a

    Comments

    Roll src/third_party/webrtc/ 1370e309e..ef76e5a06 (2 commits)
    
    https://webrtc.googlesource.com/src.git/+log/1370e309e720..ef76e5a06207
    
    $ git log 1370e309e..ef76e5a06 --date=short --no-merges --format='%ad %ae %s'
    
    Created with:
      roll-dep src/third_party/webrtc
    
    
    The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the cur
    ...skip...
    hromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: Id48e8d6c217c0ca5fd45a61423b831dfc71cb15d
    Reviewed-on: https://chromium-review.googlesource.com/915107
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#536316}

    Changed files

    • DEPS
  20. Geolocation: Fixes lifetime management of Geolocation / GeoNotifier.

    Changed by yukishiinoohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 09:39:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2baecef17c63ed7055b1e2b346d7a8cf1ad380c7

    Comments

    Geolocation: Fixes lifetime management of Geolocation / GeoNotifier.
    
    Fixes so that GeoNotifier's timer may be active only when the
    GeoNotifier is owned by the Geolocation.  Added some mechanisms
    (customized timer and container) to enforce this invariant
    condition.
    
    The current implementation allows GeoNotifier's timer to fire
    regardless of whether or not the GeoNotifier is still owned by
    the Geolocation.  However, the underlying v8::Functions inside
    GeoNotifier are made alive with wrapper-tracing, an
    ...skip...
    olocation owns GeoNotifiers.
    
    This patch makes sure that the Geolocation owns GeoNotifiers
    otherwise GeoNotifier's timer stops.
    
    Bug: 792604
    Change-Id: I6578d22e974f295073b324667f1758707eaacd35
    Reviewed-on: https://chromium-review.googlesource.com/903644
    Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
    Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
    Reviewed-by: Reilly Grant <reillyg@chromium.org>
    Reviewed-by: Miguel Casas <mcasas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536317}

    Changed files

    • third_party/WebKit/Source/modules/geolocation/GeoNotifier.cpp
    • third_party/WebKit/Source/modules/geolocation/GeoNotifier.h
    • third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
    • third_party/WebKit/Source/modules/geolocation/Geolocation.h
    • third_party/WebKit/Source/modules/geolocation/GeolocationWatchers.cpp
    • third_party/WebKit/Source/modules/geolocation/GeolocationWatchers.h
  21. Add trafic annotation to Devtools.

    Changed by rhalavatiohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 09:49:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 758319976d0e21ad1272b174b49097364bf2bc5b

    Comments

    Add trafic annotation to Devtools.
    
    Network traffic annotation is added to socket writes of:
    components/ui_devtools/devtools_server.cc
    content/browser/devtools/devtools_http_handler.cc
    
    Bug: 656607
    Change-Id: I52d8b1ab769bc3beb482dd58e96146d8380d37b4
    Reviewed-on: https://chromium-review.googlesource.com/910909
    Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
    Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536318}

    Changed files

    • components/ui_devtools/devtools_server.cc
    • content/browser/devtools/devtools_http_handler.cc
    • tools/metrics/histograms/enums.xml
    • tools/traffic_annotation/summary/annotations.xml
  22. custom-elements: Make CustomElement::CreateUncustomizedOrUndefinedElement a template

    Changed by tkentohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 09:55:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 318b76247ccda684eed8937f498bf67bb1414bd9

    Comments

    custom-elements: Make CustomElement::CreateUncustomizedOrUndefinedElement a template
    
    to optimize CustomElement::CreateCustomElement() code path, which
    doesn't need |is| check and IsValidName() check.
    
    Bug: 806641
    Change-Id: I5f77d98c789e4773b8d1895463fe749f70970a13
    Reviewed-on: https://chromium-review.googlesource.com/915885
    Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536319}

    Changed files

    • third_party/WebKit/Source/core/html/custom/CustomElement.cpp
    • third_party/WebKit/Source/core/html/custom/CustomElement.h
  23. Create an async version of ConvertPathToArcUrl.

    Changed by niwaohnoyoudont@google.com
    Changed at Tuesday, 13-Feb-18 10:13:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 667150e532b9abe93dbe8b1941e59039b962bef2

    Comments

    Create an async version of ConvertPathToArcUrl.
    
    Unlike ConvertPathToArcUrl, the new version can convert file paths under ARC media directories as well.
    
    Bug: chromium:767982
    Bug: chromium:748186
    Test: unit_tests
    Change-Id: I3356b12884766c0314d5faafdff5cc8beb21fb9b
    Reviewed-on: https://chromium-review.googlesource.com/906222
    Commit-Queue: Satoshi Niwa <niwa@chromium.org>
    Reviewed-by: Daichi Hirono <hirono@chromium.org>
    Reviewed-by: Shuhei Takahashi <nya@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536320}

    Changed files

    • chrome/browser/chromeos/file_manager/path_util.cc
    • chrome/browser/chromeos/file_manager/path_util.h
    • chrome/browser/chromeos/file_manager/path_util_unittest.cc
  24. Revert "Enable root layer scrolling."

    Changed by skobesohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 10:15:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 066296a5708f57ba89b68605ae8e65292eb77d4d

    Comments

    Revert "Enable root layer scrolling."
    
    The flip to status: stable served its purpose by uncovering a number of
    functional regressions and crash reports (http://bit.ly/rls-bugs).  Now
    let's disable RLS on trunk while we investigate and address these.
    
    This reverts http://crrev.com/535636.
    
    Bug: 417782
    Change-Id: I49a7b06b9593edb0d410301b3e3d3f8e86b0e6ef
    Reviewed-on: https://chromium-review.googlesource.com/915130
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Commit-Queue: Steve Kobes <skobes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536321}

    Changed files

    • third_party/WebKit/Source/platform/runtime_enabled_features.json5
  25. Reland "Add a trace event when a task scheduler worker is active."

    Changed by gabohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 10:24:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8c1fb16b6c55d7fbce3f2c90b56b70e6966b2290

    Comments

    Reland "Add a trace event when a task scheduler worker is active."
    
    This is a reland of d641a6adecc1dddf67823f2b424b6ebac79bce02.
    
    It was reverted per causing data races in MemoryDumpManagerTests
    as they re-initialized the MemoryDumpManager instance after scheduler
    workers had been brought up (and the workers using tracing prior to
    receiving a task -- which previously acted as a sync point -- is
    now highlighting this initialization race).
    
    Original change's description:
    > Add a trace event when a task
    ...skip...
     François Doray <fdoray@chromium.org>
    > Commit-Queue: Gabriel Charette <gab@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#536177}
    
    Bug: 811035, 811482
    Change-Id: If3a7b1dbfa8d50cec97b7b98e88c68f26f9813ec
    
    TBR=fdoray@chromium.org
    
    Change-Id: If3a7b1dbfa8d50cec97b7b98e88c68f26f9813ec
    Reviewed-on: https://chromium-review.googlesource.com/915941
    Reviewed-by: Primiano Tucci <primiano@chromium.org>
    Commit-Queue: Primiano Tucci <primiano@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536322}

    Changed files

    • base/task_scheduler/scheduler_worker.cc
    • base/trace_event/memory_dump_manager_unittest.cc
  26. Add |create| option to create pak file from directory

    Changed by joelhockeyohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 10:24:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 350b23cb99ea461720fb920cb2427b9844931a4b

    Comments

    Add |create| option to create pak file from directory
    
    This is the opposite command to |extract|.
    Any files in given directory with filename that can be converted to
    int are added to pak file.
    
    Change-Id: I63b7e2d5c2292f0c83533c8398d345e00f07bb7e
    Reviewed-on: https://chromium-review.googlesource.com/912053
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536323}

    Changed files

    • tools/grit/pak_util.py
  27. Prevent browser from sending empty ScreenInfo to the renderer.

    Changed by lfgohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 10:29:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6ccadf770766e89c3683ae8ce12235e06a953906

    Comments

    Prevent browser from sending empty ScreenInfo to the renderer.
    
    Bug: 801091, 804046
    Change-Id: Ic7d3aab009421db239e979f0b6d64c701a044f46
    Reviewed-on: https://chromium-review.googlesource.com/911598
    Reviewed-by: Fady Samuel <fsamuel@chromium.org>
    Reviewed-by: Nasko Oskov <nasko@chromium.org>
    Commit-Queue: Nasko Oskov <nasko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536324}

    Changed files

    • content/browser/frame_host/cross_process_frame_connector.cc
    • content/browser/frame_host/render_widget_host_view_guest.cc
    • content/browser/frame_host/render_widget_host_view_guest.h
    • content/browser/renderer_host/render_widget_host_impl.cc
    • content/browser/renderer_host/render_widget_host_view_base.cc
    • content/browser/renderer_host/render_widget_host_view_base.h
    • content/browser/renderer_host/render_widget_host_view_child_frame.cc
    • content/browser/renderer_host/render_widget_host_view_child_frame.h
    • content/public/browser/render_widget_host_view.h
    • content/renderer/render_widget.cc
  28. Renamed an enum value DEBUG->DEVTOOLS to avoid a Windows macro

    Changed by bratellohnoyoudont@opera.com
    Changed at Tuesday, 13-Feb-18 10:31:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eecc399ea2271020f2e25a8125b5ca99ff588244

    Comments

    Renamed an enum value DEBUG->DEVTOOLS to avoid a Windows macro
    
    Windows's ATL headers (atldef.h) does
    #ifdef _DEBUG
    #define DEBUG
    #endif
    
    which makes it hard to also use the word DEBUG in code that might
    intentionally or accidentally be compiled with that header. This
    happened in jumbo build experiments where many cc files are compiled
    in the same translation unit for dramatically faster compilation.
    
    This preparatory patch for jumbo in chrome/browser renames an
    enum value from WebappInstallSource::DEBUG to
    WebappInstallSource::DEVTOOLS.
    
    Bug: 746957
    Change-Id: I128018246b94310c0cee67eaa404ab7749bd3ae0
    Reviewed-on: https://chromium-review.googlesource.com/902042
    Reviewed-by: Dominick Ng <dominickn@chromium.org>
    Commit-Queue: Daniel Bratell <bratell@opera.com>
    Cr-Commit-Position: refs/heads/master@{#536325}

    Changed files

    • chrome/browser/android/webapk/webapk_metrics.cc
    • chrome/browser/banners/app_banner_manager.cc
    • chrome/browser/banners/app_banner_manager_browsertest.cc
    • chrome/browser/installable/installable_metrics.cc
    • chrome/browser/installable/installable_metrics.h
  29. Split getUserMedia track start failure UMA stats bucket into audio and video.

    Changed by grunellohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 10:36:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8a68f8a307ee8b54b70d121130d1414c61a0d3c7

    Comments

    Split getUserMedia track start failure UMA stats bucket into audio and video.
    
    The histogram WebRTC.UserMediaRequest.Result is replaced with WebRTC.UserMediaRequest.Result2.
    
    Also:
    * Add a missing histogram enum value for kill switch on in the now deprecated histogram.
    * Un-deprecate MEDIA_DEVICE_INVALID_SECURITY_ORIGIN_DEPRECATED because usage of it was added after "deprecation".
    
    Bug: 810369
    Change-Id: Ic527f96a709c121ed4108e98a5336a633ebbe797
    Reviewed-on: https://chromium-review.googlesource.com/908452
    Commit-Queue: Henrik Grunell <grunell@chromium.org>
    Reviewed-by: Greg Kerr <kerrnel@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Reviewed-by: Guido Urdaneta <guidou@chromium.org>
    Reviewed-by: Mark Pearson <mpearson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536326}

    Changed files

    • content/browser/renderer_host/media/media_stream_dispatcher_host.cc
    • content/common/media/media_stream.mojom
    • content/common/media/media_stream_typemap_traits.cc
    • content/public/common/media_stream_request.h
    • content/renderer/media/stream/media_stream_video_capturer_source.cc
    • content/renderer/media/stream/media_stream_video_source.cc
    • content/renderer/media/stream/mock_media_stream_video_source.cc
    • content/renderer/media/stream/user_media_client_impl_unittest.cc
    • content/renderer/media/stream/user_media_processor.cc
    • content/renderer/media/webrtc/webrtc_uma_histograms.cc
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml
  30. Remove passing virtual/layout_ng/ tests failure expectations

    Changed by mstenshoohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 10:39:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 42f7a0e6fd631bc8bf51fe54152f919161c1e2bf

    Comments

    Remove passing virtual/layout_ng/ tests failure expectations
    
    They have all been removed from the flag-specific expecation file for
    LayoutNG recently.
    
    TBR=kojii@chromium.org
    
    Change-Id: I9a594c81cb25355805f82d59aca8ec9163cfe60e
    Reviewed-on: https://chromium-review.googlesource.com/916043
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536327}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  31. Handle ::slotted in ComputeLinkMatchType.

    Changed by futharkohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 10:48:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6046b2ee9ada67bd73ec1dd619a2f5a134c4c6af

    Comments

    Handle ::slotted in ComputeLinkMatchType.
    
    We skipped the selector list for ::slotted looking for :visited and
    :link pseudo classes and ended up applying such rules with both :visited
    and :link style.
    
    Bug: 808392
    Change-Id: I85956902f3ca9cea01c96ef5c56ccf7f0ee23671
    Reviewed-on: https://chromium-review.googlesource.com/904903
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536328}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/css/css-scoping/slotted-link.html
    • third_party/WebKit/Source/core/css/CSSSelector.cpp
    • third_party/WebKit/Source/core/css/CSSSelector.h
    • third_party/WebKit/Source/core/css/RuleSet.cpp
  32. [RootLayerScrolls] Speculative fix for crasher

    Changed by szagerohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 10:52:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dae6f0ca22561ab9cef4a0e46d37faf67333a460

    Comments

    [RootLayerScrolls] Speculative fix for crasher
    
    The call from PaintLayerScrollableArea::Dispose into
    TopDocumentRootScrollerController::DidDisposeScrollableArea can call
    back into the PLSA's ScrollAnchor, which may point to a LayoutObject
    which has already been deleted.
    
    The ScrollAnchor is no longer needed, so clear it out aggressively.
    
    BUG=811144
    R=skobes@chromium.org,bokan@chromium.org
    
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
    Change-Id: I2121105ed0b4118f966c25682236649d33d3c055
    Reviewed-on: https://chromium-review.googlesource.com/914864
    Commit-Queue: Stefan Zager <szager@chromium.org>
    Reviewed-by: Steve Kobes <skobes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536329}

    Changed files

    • third_party/WebKit/Source/core/frame/LocalFrameView.cpp
    • third_party/WebKit/Source/core/frame/LocalFrameView.h
    • third_party/WebKit/Source/core/layout/ScrollAnchor.cpp
    • third_party/WebKit/Source/core/layout/ScrollAnchor.h
    • third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
  33. Move select function into separate file

    Changed by rsorokinohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 10:53:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ad400418b67c2ed73d1ba6f2b4c6545f9ac28d3b

    Comments

    Move select function into separate file
    
    It allows to use it both on the oobe and login screens
    Also runs callback on pressing arrows
    
    BUG=chromium:805908
    TEST=manual
    
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: Iae406bf9af0d52e6ff83cd391bc40db35d076b6e
    Reviewed-on: https://chromium-review.googlesource.com/908550
    Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
    Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536330}

    Changed files

    • chrome/browser/resources/chromeos/login/compiled_resources2.gyp
    • chrome/browser/resources/chromeos/login/login_non_lock_shared.js
    • chrome/browser/resources/chromeos/login/oobe.js
    • chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.js
    • chrome/browser/resources/chromeos/login/oobe_screen_network.js
    • chrome/browser/resources/chromeos/login/oobe_select.js
    • chrome/browser/resources/chromeos/login/oobe_welcome.js
    • chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.js
  34. Wire up the media::kNewEncodeCpuLoadEstimator feature to chrome://flags.

    Changed by nisseohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 10:55:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 090866a107f7559ddc8f77c7965449167b8a7f3e

    Comments

    Wire up the media::kNewEncodeCpuLoadEstimator feature to chrome://flags.
    
    Needed for evaluation on ChromeOS. It is a follow up to
    https://chromium-review.googlesource.com/c/chromium/src/+/870119
    
    Bug: webrtc:8504
    Change-Id: Icbb79b169a4e06b612431500955528148a432366
    Reviewed-on: https://chromium-review.googlesource.com/911068
    Reviewed-by: Henrik Boström <hbos@chromium.org>
    Commit-Queue: Niels Möller <nisse@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536331}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • tools/metrics/histograms/enums.xml
  35. Add ArrayBuffer to UKM Report

    Changed by yuzusohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 11:03:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7a6cb7cdb76a86d4d414ddc0be1f3a9a9f6ef088

    Comments

    Add ArrayBuffer to UKM Report
    
    This CL adds the size of ArrayBuffer size(MB) to UKM report.
    UKM review document: https://docs.google.com/document/d/1WqJEtCoZQIuLaUu55riE4Cwh_9H0a_zRbl7gcGoW-Rs/edit?usp=sharing
    
    BUG=810293
    
    Change-Id: Ifc609c4224b4d380bc52732bf8e23f7dcdb34d28
    Reviewed-on: https://chromium-review.googlesource.com/908176
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Reviewed-by: Steven Holte <holte@chromium.org>
    Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536332}

    Changed files

    • chrome/browser/metrics/process_memory_metrics_emitter.cc
    • chrome/browser/metrics/process_memory_metrics_emitter_unittest.cc
    • tools/metrics/ukm/ukm.xml
  36. Roll src/third_party/webrtc/ ef76e5a06..ab86e7ffe (1 commit)

    Changed by webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Tuesday, 13-Feb-18 11:14:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ac039a7277ad6e4b2055a98e323a30dd3ba9ab2c

    Comments

    Roll src/third_party/webrtc/ ef76e5a06..ab86e7ffe (1 commit)
    
    https://webrtc.googlesource.com/src.git/+log/ef76e5a06207..ab86e7ffe210
    
    $ git log ef76e5a06..ab86e7ffe --date=short --no-merges --format='%ad %ae %s'
    
    Created with:
      roll-dep src/third_party/webrtc
    
    
    The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the curr
    ...skip...
    hromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: If048c953f724bc4f21ea9609884a8f0a57597274
    Reviewed-on: https://chromium-review.googlesource.com/916082
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#536333}

    Changed files

    • DEPS
  37. Do not check FEATURE_APP_WIDGET before JB_MR2.

    Changed by tedchocohnoyoudont@google.com
    Changed at Tuesday, 13-Feb-18 11:21:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 39da7b05cca9bc5783670f107d16e4968ef9596d

    Comments

    Do not check FEATURE_APP_WIDGET before JB_MR2.
    
    BUG=810846
    
    Change-Id: I8f8f56cf9e1eeb714cf355cea098ee2af2ad84e8
    Reviewed-on: https://chromium-review.googlesource.com/916084
    Commit-Queue: Ted Choc <tedchoc@chromium.org>
    Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536334}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetProvider.java
    • chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java
  38. Add markusheintz@ as a consent_auditor/ OWNER.

    Changed by msramekohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 11:23:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 12e745e11be2fad7863a114cd734c4a42bcac7de

    Comments

    Add markusheintz@ as a consent_auditor/ OWNER.
    
    Bug: 781765
    Change-Id: I9b81c47b604bfa6f57a34ae4bca3c87955bb1ea3
    Reviewed-on: https://chromium-review.googlesource.com/870212
    Reviewed-by: Christian Dullweber <dullweber@chromium.org>
    Reviewed-by: Markus Heintz <markusheintz@chromium.org>
    Commit-Queue: Markus Heintz <markusheintz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536335}

    Changed files

    • components/consent_auditor/OWNERS
  39. Update V8 to version 6.6.234.

    Changed by v8-autorollohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 11:26:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 48f44cebeac989425320dacd001b3cb5bdbd6eef

    Comments

    Update V8 to version 6.6.234.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/466765c5..94c67e19
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromiu
    ...skip...
    ional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org
    
    Change-Id: I25619ab29e6c76d4ef09fd391763837e8f5bc137
    Reviewed-on: https://chromium-review.googlesource.com/914604
    Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
    Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536336}

    Changed files

    • DEPS
  40. IOS Autofill small clean-ups.

    Changed by dvadymohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 11:29:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fae7ccb327eeb9d300b9e9b540d436e7471f7023

    Comments

    IOS Autofill small clean-ups.
    
    I'm working on using some Autofill code in Password Manager and found
    some things that could be improved
    (https://chromium-review.googlesource.com/c/chromium/src/+/901664).
    1.Form method is not used anymore, so we can remove extracting it.
    2.When forms are extracted from JS, instead of just returning list of
    forms, an object with "forms" property is created. So we have 1 more level
    indirection without any good reason. This CL changed to returning a list.
    
    Bug: 782224
    Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    Change-Id: I93d1f4ba07b7a27486c0956a3f477bbcc12e5301
    Reviewed-on: https://chromium-review.googlesource.com/913571
    Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
    Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536337}

    Changed files

    • components/autofill/ios/browser/autofill_agent.mm
    • components/autofill/ios/browser/resources/autofill_controller.js
    • ios/chrome/browser/autofill/autofill_controller_js_unittest.mm
    • ios/chrome/browser/autofill/js_autofill_manager_unittest.mm
  41. [Android password settings] Fix export cancellation

    Changed by vabrohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 11:57:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 212d3064f916278e6d5245efdab3a92b62a9b8b5

    Comments

    [Android password settings] Fix export cancellation
    
    Chrome displays a warning dialog if the user requests exporting their
    passwords. The dialog allows the user to cancel the export. This CL
    ensures that the cancellation does properly update the inner state so
    that the export menu item gets re-enabled.
    
    The CL also refactors the test a little: a block of code was used
    repeatedly for checking the state of the export menu item, now it
    is a helper method.
    
    Bug: 811307
    Change-Id: I32112f056f84f410b0b862b9530a3fe756983512
    Reviewed-on: https://chromium-review.googlesource.com/914883
    Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
    Commit-Queue: Vaclav Brozek <vabr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536338}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferencesTest.java
  42. Mark fast/events/hit-test-counts.html as flaky on Win Debug

    Changed by treibohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 12:03:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a2ba02870355fcc3dc2d9a2f0dcf8ee830337a9c

    Comments

    Mark fast/events/hit-test-counts.html as flaky on Win Debug
    
    TBR=eirage
    
    Bug: 811708
    Change-Id: I6a9fa22fd0deab2077490378c2bca8f06dd4c046
    Reviewed-on: https://chromium-review.googlesource.com/915346
    Reviewed-by: Marc Treib <treib@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536339}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  43. Add unit tests for the image fetcher in AccountFetcherService

    Changed by tangltomohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 12:09:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c4b145d71ba3017dc49ff76fff67d210623e51cd

    Comments

    Add unit tests for the image fetcher in AccountFetcherService
    
    This CL adds unit tests for the image fetcher added with
    crrev.com/c/870598.
    
    Bug: 786369
    Change-Id: I6540813262ec5dd8439d555cb53aaa6d6dcc859a
    Reviewed-on: https://chromium-review.googlesource.com/899244
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536340}

    Changed files

    • components/image_fetcher/core/image_data_fetcher.cc
    • components/image_fetcher/core/image_data_fetcher.h
    • components/image_fetcher/core/image_data_fetcher_unittest.cc
    • components/image_fetcher/ios/ios_image_data_fetcher_wrapper_unittest.mm
    • components/signin/core/browser/BUILD.gn
    • components/signin/core/browser/account_tracker_service.cc
    • components/signin/core/browser/account_tracker_service.h
    • components/signin/core/browser/account_tracker_service_unittest.cc
    • components/signin/core/browser/fake_account_fetcher_service.cc
    • components/signin/core/browser/fake_account_fetcher_service.h
  44. [Cronet] Native API code generator tweaks for better naming.

    Changed by mefohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 12:14:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1d0a55f1e40f35413ad4191a26e996a2e6473f20

    Comments

    [Cronet] Native API code generator tweaks for better naming.
    
    - Replace XYZ_Context type with Cronet_ClientContext.
    - Generate XYZ_SetClientContext / XYZ_GetClientContext implementation.
    - Rename XYZ_CreateStub functions to XYZ_CreateWith.
    - Rename CharString to Cronet_String.
    - Rename RawDataPtr to Cronet_RawDataPtr.
    
    Bug: 786559
    Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ia7b650007a993bade59eae7c70b33eed5214bac2
    Reviewed-on: https://chromium-review.googlesource.com/912331
    Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
    Commit-Queue: Misha Efimov <mef@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536341}

    Changed files

    • components/cronet/native/buffer.cc
    • components/cronet/native/buffer_test.cc
    • components/cronet/native/engine.cc
    • components/cronet/native/engine.h
    • components/cronet/native/executors_test.cc
    • components/cronet/native/generated/cronet.idl_c.h
    • components/cronet/native/generated/cronet.idl_impl_interface.cc
    • components/cronet/native/generated/cronet.idl_impl_interface.h
    • components/cronet/native/generated/cronet.idl_impl_interface_unittest.cc
    • components/cronet/native/generated/cronet.idl_impl_struct.cc
    • components/cronet/native/generated/cronet.idl_impl_struct.h
    • components/cronet/native/runnables.cc
    • components/cronet/native/runnables.h
    • components/cronet/native/runnables_unittest.cc
    • components/cronet/native/test_util.cc
    • components/cronet/tools/generators/c_templates/module_c.h.tmpl
    • components/cronet/tools/generators/c_templates/module_impl_interface.cc.tmpl
    • components/cronet/tools/generators/c_templates/module_impl_interface.h.tmpl
    • components/cronet/tools/generators/c_templates/module_impl_interface_unittest.cc.tmpl
    • components/cronet/tools/generators/cronet_c_generator.py