Home | Search
Login

Builder Linux Debug (NVIDIA) Build #42101

Results:

build successful exception slave lost exception gl_tests on NVIDIA GPU on Linux on Ubuntu

Trigger Info:

Got Revisionfe64540e01311889d266c94de15b594e3e0f21cc

Execution:

Steps and Logfiles:

Show:
  1. ( 1 hrs 4 mins ) steps
    running steps via annotated script
    exception
    slave
    lost
  2. ( 5 secs ) update_scripts
    update_scripts
  3. ( 7 ms ) LUCI Migration
    LUCI Migration
  4. ( 7 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 2 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 1 ms ) makedirs checkout path
    makedirs checkout path
  7. ( 2 mins 11 secs ) bot_update
    bot_update
    [51GB/492GB used (10%)]
  8. ( 1 ms ) ensure_goma
    ensure_goma
  9. ( 1 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  10. ( 1 ms ) swarming.py --version
    swarming.py --version
    0.10.2
  11. ( 21 secs ) gclient runhooks
    gclient runhooks
  12. ( 1 ms ) get compile targets for scripts
    get compile targets for scripts
  13. ( 2 ms ) read test spec (chromium.gpu.fyi.json)
    read test spec (chromium.gpu.fyi.json)
    path: /b/c/b/Linux_Debug__NVIDIA_/src/testing/buildbot/chromium.gpu.fyi.json
  14. ( 1 ms ) build directory
    build directory
  15. ( 37 secs ) extract build
    extract build
  16. ( 2 ms ) find isolated tests
    find isolated tests
  17. ( 1 ms ) test_pre_run
    test_pre_run
  18. ( 1 ms ) test_pre_run.[trigger] context_lost_tests on NVIDIA GPU on Linux on Ubuntu
    test_pre_run.[trigger] context_lost_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
  19. ( 1 mins 46 secs ) context_lost_tests on NVIDIA GPU on Linux on Ubuntu
    context_lost_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 0:01:48.819220
    Total tests: 6
    * Passed: 6 (6 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  20. ( 6 ms ) Upload to test-results [context_lost_tests on NVIDIA GPU on Linux]
    Upload to test-results [context_lost_tests on NVIDIA GPU on Linux]
  21. ( 6 ms ) test_pre_run (2)
    test_pre_run (2)
  22. ( 8 ms ) test_pre_run.[trigger] depth_capture_tests on NVIDIA GPU on Linux on Ubuntu
    test_pre_run.[trigger] depth_capture_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
  23. ( 56 secs ) depth_capture_tests on NVIDIA GPU on Linux on Ubuntu
    depth_capture_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 50s
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  24. ( 3 ms ) Upload to test-results [depth_capture_tests on NVIDIA GPU on Linux]
    Upload to test-results [depth_capture_tests on NVIDIA GPU on Linux]
  25. ( 3 ms ) test_pre_run (3)
    test_pre_run (3)
  26. ( 5 ms ) test_pre_run.[trigger] gpu_process_launch_tests on NVIDIA GPU on Linux on Ubuntu
    test_pre_run.[trigger] gpu_process_launch_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
  27. ( 4 mins 28 secs ) gpu_process_launch_tests on NVIDIA GPU on Linux on Ubuntu
    gpu_process_launch_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 0:04:19.154900
    Total tests: 13
    * Passed: 13 (13 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  28. ( 3 ms ) Upload to test-results [gpu_process_launch_tests on NVIDIA GPU on Linux]
    Upload to test-results [gpu_process_launch_tests on NVIDIA GPU on Linux]
  29. ( 3 ms ) test_pre_run (4)
    test_pre_run (4)
  30. ( 5 ms ) test_pre_run.[trigger] hardware_accelerated_feature_tests on NVIDIA GPU on Linux on Ubuntu
    test_pre_run.[trigger] hardware_accelerated_feature_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
  31. ( 35 secs ) hardware_accelerated_feature_tests on NVIDIA GPU on Linux on Ubuntu
    hardware_accelerated_feature_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 30s
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  32. ( 3 ms ) Upload to test-results [hardware_accelerated_feature_tests on NVIDIA GPU on Linux]
    Upload to test-results [hardware_accelerated_feature_tests on NVIDIA GPU on Linux]
  33. ( 3 ms ) test_pre_run (5)
    test_pre_run (5)
  34. ( 5 ms ) test_pre_run.[trigger] info_collection_tests on NVIDIA GPU on Linux on Ubuntu
    test_pre_run.[trigger] info_collection_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
  35. ( 36 secs ) info_collection_tests on NVIDIA GPU on Linux on Ubuntu
    info_collection_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 32s
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  36. ( 3 ms ) Upload to test-results [info_collection_tests on NVIDIA GPU on Linux]
    Upload to test-results [info_collection_tests on NVIDIA GPU on Linux]
  37. ( 3 ms ) test_pre_run (6)
    test_pre_run (6)
  38. ( 5 ms ) test_pre_run.[trigger] maps_pixel_test on NVIDIA GPU on Linux on Ubuntu
    test_pre_run.[trigger] maps_pixel_test on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
  39. ( 1 mins 13 secs ) maps_pixel_test on NVIDIA GPU on Linux on Ubuntu
    maps_pixel_test on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 0:01:10.155410
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  40. ( 4 ms ) Upload to test-results [maps_pixel_test on NVIDIA GPU on Linux]
    Upload to test-results [maps_pixel_test on NVIDIA GPU on Linux]
  41. ( 3 ms ) test_pre_run (7)
    test_pre_run (7)
  42. ( 5 ms ) test_pre_run.[trigger] pixel_test on NVIDIA GPU on Linux on Ubuntu
    test_pre_run.[trigger] pixel_test on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
  43. ( 9 mins 27 secs ) pixel_test on NVIDIA GPU on Linux on Ubuntu
    pixel_test on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 0:09:13.720400
    Total tests: 44
    * Passed: 44 (44 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  44. ( 4 ms ) Upload to test-results [pixel_test on NVIDIA GPU on Linux]
    Upload to test-results [pixel_test on NVIDIA GPU on Linux]
  45. ( 3 ms ) test_pre_run (8)
    test_pre_run (8)
  46. ( 5 ms ) test_pre_run.[trigger] screenshot_sync_tests on NVIDIA GPU on Linux on Ubuntu
    test_pre_run.[trigger] screenshot_sync_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
  47. ( 2 mins 58 secs ) screenshot_sync_tests on NVIDIA GPU on Linux on Ubuntu
    screenshot_sync_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 0:02:53.948880
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  48. ( 1 ms ) Upload to test-results [screenshot_sync_tests on NVIDIA GPU on Linux]
    Upload to test-results [screenshot_sync_tests on NVIDIA GPU on Linux]
  49. ( 1 ms ) test_pre_run (9)
    test_pre_run (9)
  50. ( 2 ms ) test_pre_run.[trigger] trace_test on NVIDIA GPU on Linux on Ubuntu
    test_pre_run.[trigger] trace_test on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
  51. ( 5 mins 43 secs ) trace_test on NVIDIA GPU on Linux on Ubuntu
    trace_test on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 0:05:38.853330
    Total tests: 32
    * Passed: 16 (16 expected, 0 unexpected)
    * Skipped: 16 (16 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  52. ( 1 ms ) Upload to test-results [trace_test on NVIDIA GPU on Linux]
    Upload to test-results [trace_test on NVIDIA GPU on Linux]
  53. ( 1 ms ) test_pre_run (10)
    test_pre_run (10)
  54. ( 2 ms ) test_pre_run.[trigger] webgl_conformance_gl_passthrough_tests on NVIDIA GPU on Linux on Ubuntu
    test_pre_run.[trigger] webgl_conformance_gl_passthrough_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
  55. ( 18 mins 30 secs ) webgl_conformance_gl_passthrough_tests on NVIDIA GPU on Linux on Ubuntu
    webgl_conformance_gl_passthrough_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Max shard duration: 0:18:17.360200 (shard #1)
    Total tests: 921
    * Passed: 913 (913 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  56. ( 4 ms ) Upload to test-results [webgl_conformance_gl_passthrough_tests on NVIDIA GPU on Linux]
    Upload to test-results [webgl_conformance_gl_passthrough_tests on NVIDIA GPU on Linux]
  57. ( 3 ms ) test_pre_run (11)
    test_pre_run (11)
  58. ( 5 ms ) test_pre_run.[trigger] webgl_conformance_tests on NVIDIA GPU on Linux on Ubuntu
    test_pre_run.[trigger] webgl_conformance_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
  59. ( 11 mins 34 secs ) webgl_conformance_tests on NVIDIA GPU on Linux on Ubuntu
    webgl_conformance_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Max shard duration: 0:11:18.730790 (shard #1)
    Total tests: 921
    * Passed: 913 (913 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  60. ( 1 ms ) Upload to test-results [webgl_conformance_tests on NVIDIA GPU on Linux]
    Upload to test-results [webgl_conformance_tests on NVIDIA GPU on Linux]
  61. ( 1 ms ) test_pre_run (12)
    test_pre_run (12)
  62. ( 2 ms ) test_pre_run.[trigger] angle_end2end_tests on NVIDIA GPU on Linux on Ubuntu
    test_pre_run.[trigger] angle_end2end_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
  63. ( 2 ms ) angle_end2end_tests on NVIDIA GPU on Linux on Ubuntu
    angle_end2end_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 0:02:02.464320
  64. ( 7 secs ) Upload to test-results [angle_end2end_tests on NVIDIA GPU on Linux on Ubuntu]
    Upload to test-results [angle_end2end_tests on NVIDIA GPU on Linux on Ubuntu]
  65. ( 1 ms ) test_pre_run (13)
    test_pre_run (13)
  66. ( 3 ms ) test_pre_run.[trigger] angle_unittests on NVIDIA GPU on Linux on Ubuntu
    test_pre_run.[trigger] angle_unittests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
  67. ( 3 ms ) angle_unittests on NVIDIA GPU on Linux on Ubuntu
    angle_unittests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 0:02:44.314090
  68. ( 5 secs ) Upload to test-results [angle_unittests on NVIDIA GPU on Linux on Ubuntu]
    Upload to test-results [angle_unittests on NVIDIA GPU on Linux on Ubuntu]
  69. ( 1 ms ) test_pre_run (14)
    test_pre_run (14)
  70. ( 2 ms ) test_pre_run.[trigger] gl_tests on NVIDIA GPU on Linux on Ubuntu
    test_pre_run.[trigger] gl_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
  71. ( 57 secs ) gl_tests on NVIDIA GPU on Linux on Ubuntu
    gl_tests on NVIDIA GPU on Linux on Ubuntu

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromium/bb/chromium.gpu.fyi/Linux_Debug__NVIDIA_/42101/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.gpu.fyi/Linux_Debug__NVIDIA_/42101" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "2f23f35afb94cd94f0f73192893982eb6ff83f02" Annotation(bot_update)
got_buildtools_revision null Annotation(bot_update)
got_nacl_revision "8ad1515975c09beebd2e9ea69c1f9c5ba88a5bbf" Annotation(bot_update)
got_revision "fe64540e01311889d266c94de15b594e3e0f21cc" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#536358}" Annotation(bot_update)
got_swarming_client_revision null Annotation(bot_update)
got_v8_revision "94c67e1998e38a3e2c41e4c3e6949915e5bb3a97" Annotation(bot_update)
got_v8_revision_cp "refs/heads/6.6.234@{#1}" Annotation(bot_update)
got_webrtc_revision "27a0741fd29d7f517685ee762a33d7cf6487c785" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#21993}" Annotation(bot_update)
swarm_hashes {"angle_end2end_tests":"7d4ffbc88ef2049cc3576ac4533d34b1420f97a2","angle_unittests":"25acfcf2a07a6e561306b75f32051721d46fab1f","gl_tests":"7866265284dfc0d3e0a0cbde66f931df789228fa","gl_unittests":"16c67580943fcc8663d0b9a940fd9be65af29cb3","gles2_conform_test":"873fe567b2057576c7043eefae54a005b37d470e","swiftshader_unittests":"0deda76a9db0de981939b89ec148bb83ae5885df","telemetry_gpu_integration_test":"d21e610ec6eb6ca04832ff572d06ac7c17fea2f0"} Annotation(find isolated tests)
build_data_dir "/b/rr/tmpmSO4c5" Annotation(steps)
build_id "buildbot/chromium.gpu.fyi/Linux Debug (NVIDIA)/42101" Annotation(steps)
builder_id "master.chromium.gpu.fyi:Linux Debug (NVIDIA)" Annotation(steps)
blamelist ["asimjour@chromium.org","blundell@chromium.org","csharrison@chromium.org","lfg@chromium.org","nator@chromium.org","skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","tdresser@chromium.org","treib@chromium.org"] Build
branch "master" Build
buildnumber 42101 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1518532809 Build
revision "fe64540e01311889d266c94de15b594e3e0f21cc" Build
slavename "slave64-c1" BuildSlave
buildername "Linux Debug (NVIDIA)" Builder
git_revision "fe64540e01311889d266c94de15b594e3e0f21cc" Change
parent_buildername "GPU Linux Builder (dbg)" ParentBuild
parent_buildnumber 100846 ParentBuild
parent_got_angle_revision "d9ed9c1af38569d3de4224373faef9ac946153dc" ParentBuild
parent_got_buildtools_revision null ParentBuild
parent_got_nacl_revision "8ad1515975c09beebd2e9ea69c1f9c5ba88a5bbf" ParentBuild
parent_got_revision "fe64540e01311889d266c94de15b594e3e0f21cc" ParentBuild
parent_got_revision_cp "refs/heads/master@{#536358}" ParentBuild
parent_got_swarming_client_revision null ParentBuild
parent_got_v8_revision "94c67e1998e38a3e2c41e4c3e6949915e5bb3a97" ParentBuild
parent_got_v8_revision_cp "refs/heads/6.6.234@{#1}" ParentBuild
parent_got_webrtc_revision "27a0741fd29d7f517685ee762a33d7cf6487c785" ParentBuild
parent_got_webrtc_revision_cp "refs/heads/master@{#21993}" ParentBuild
parent_mastername "chromium.gpu.fyi" ParentBuild
buildbotURL "https://build.chromium.org/p/chromium.gpu.fyi/" master.cfg
mastername "chromium.gpu.fyi" master.cfg
workdir "/b/build/slave/Linux_Debug__NVIDIA_" slave

Blamelist:

  1. (lfgohnoyoudont@chromium.org)
  2. (blundellohnoyoudont@chromium.org)
  3. (treibohnoyoudont@chromium.org)
  4. (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  5. (csharrisonohnoyoudont@chromium.org)
  6. (asimjourohnoyoudont@chromium.org)
  7. (natorohnoyoudont@chromium.org)
  8. (tdresserohnoyoudont@chromium.org)

Timing:

Create N/A
Start Tuesday, 13-Feb-18 15:36:48 UTC
End Tuesday, 13-Feb-18 16:41:30 UTC
Pending N/A
Execution 1 hrs 4 mins

All Changes:

  1. Ensure that an OOPIF renderer knows its size before layout.

    Changed by lfgohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 14:26:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5d27a36230aea4b3664f8b5345b09bb0690a3ff

    Comments

    Ensure that an OOPIF renderer knows its size before layout.
    
    This patch blocks an OOPIF HTML parser until the corresponding
    RenderWidget has received its size from the browser.
    
    This patch also implements replication of the frame's size to the
    browser process. This allows the optimization of remote to remote
    transfers, where the browser knows the frame's size before commiting
    the navigation on the new renderer. It also optimizes some cases where
    the parent renderer is able to perform layout before the
    ...skip...
    rong
    size information to the renderer, making sure that the resize IPC is
    not sent before the size has arrived from the parent renderer.
    
    Bug: 801091,804046
    
    Change-Id: I5448a0953d582b37922f2a0d979d106f56dd1cc2
    Reviewed-on: https://chromium-review.googlesource.com/882021
    Commit-Queue: Lucas Gadani <lfg@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Nasko Oskov <nasko@chromium.org>
    Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536351}

    Changed files

    • content/browser/frame_host/cross_process_frame_connector.cc
    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/frame_host/render_frame_host_impl.h
    • content/browser/frame_host/render_frame_host_manager.cc
    • content/browser/frame_host/render_frame_proxy_host.cc
    • content/browser/frame_host/render_frame_proxy_host.h
    • content/browser/frame_host/render_widget_host_view_guest.cc
    • content/browser/frame_host/render_widget_host_view_guest.h
    • content/browser/renderer_host/frame_connector_delegate.cc
    • content/browser/renderer_host/frame_connector_delegate.h
    • content/browser/renderer_host/render_widget_host_impl.cc
    • content/browser/renderer_host/render_widget_host_view_base.cc
    • content/browser/renderer_host/render_widget_host_view_base.h
    • content/browser/renderer_host/render_widget_host_view_child_frame.cc
    • content/browser/renderer_host/render_widget_host_view_child_frame.h
    • content/browser/site_per_process_browsertest.cc
    • content/common/frame.mojom
    • content/renderer/render_frame_impl.cc
    • content/renderer/render_frame_impl.h
    • content/test/test_render_frame.cc
    • third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
    • third_party/WebKit/Source/core/exported/LocalFrameClientImpl.h
    • third_party/WebKit/Source/core/frame/FrameTestHelpers.cpp
    • third_party/WebKit/Source/core/frame/LocalFrameClient.h
    • third_party/WebKit/Source/core/frame/LocalFrameView.cpp
    • third_party/WebKit/Source/core/frame/WebFrameWidgetBase.h
    • third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp
    • third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.h
    • third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
    • third_party/WebKit/Source/core/loader/DocumentLoader.cpp
    • third_party/WebKit/Source/core/loader/DocumentLoader.h
    • third_party/WebKit/public/web/WebFrameClient.h
  2. [NTP Snippets] Remove usage of internal signin classes in factories

    Changed by blundellohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 14:27:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fe56cf921b0b202657ef1d5bfbb2b25de4f44019

    Comments

    [NTP Snippets] Remove usage of internal signin classes in factories
    
    This CL eliminates the minimal usage of SigninManager in the
    ContentSuggestionsService factories on Android and iOS, replacing that
    usage with equivalent usage of IdentityManager. It also eliminates
    the dependencies on SigninManager and ProfileOAuth2TokenService
    entirely.
    
    To test the minimal usage change, I verified that the first remote
    snippets fetch done on Android on cold start of the browser was
    authenticated if the user was si
    ...skip...
    the user
    was not signed in.
    
    TBR=gambard@chromium.org
    
    Bug: 798413
    Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    Change-Id: Ifb79778ef385441634e7624a1c99d366a579b0b2
    Reviewed-on: https://chromium-review.googlesource.com/904043
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Jan Krcal <jkrcal@chromium.org>
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536352}

    Changed files

    • chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
    • ios/chrome/browser/ntp_snippets/BUILD.gn
    • ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc
    • ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory_util.cc
  3. Revert "Clean up of memory instrumentation interface."

    Changed by treibohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 14:30:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1c849e92aef656ed495be99af74442c75243789c

    Comments

    Revert "Clean up of memory instrumentation interface."
    
    This reverts commit 99b4a583f634ba382fd597cda1148cc4299dc2e0.
    
    Reason for revert: Breaks Memlog/MemlogBrowserTest.EndToEnd/13 on Windows; see crbug.com/811711
    
    Original change's description:
    > Clean up of memory instrumentation interface.
    > 
    > This CL cleans up both the public interface and private implementation of memory
    > instrumentation. It is in preparation for allowing memory instrumentation to
    > asynchronously add heap dumps to traces.
    > 
    
    ...skip...
    iano@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#536263}
    
    TBR=dcheng@chromium.org,isherman@chromium.org,primiano@chromium.org,erikchen@chromium.org,lalitm@chromium.org
    
    Change-Id: I6ba2c5548b4fcd2950a3e0a1734a10140c6c152a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 758739, 811711
    Reviewed-on: https://chromium-review.googlesource.com/916063
    Reviewed-by: Marc Treib <treib@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536353}

    Changed files

    • chrome/browser/metrics/process_memory_metrics_emitter_unittest.cc
    • chrome/browser/profiling_host/background_profiling_triggers_unittest.cc
    • chrome/browser/profiling_host/profiling_test_driver.cc
    • chrome/profiling/memlog_connection_manager.cc
    • chrome/profiling/memlog_connection_manager.h
    • chrome/profiling/profiling_service.cc
    • chrome/profiling/profiling_service.h
    • services/resource_coordinator/memory_instrumentation/coordinator_impl.cc
    • services/resource_coordinator/memory_instrumentation/coordinator_impl.h
    • services/resource_coordinator/memory_instrumentation/coordinator_impl_unittest.cc
    • services/resource_coordinator/memory_instrumentation/queued_request.cc
    • services/resource_coordinator/memory_instrumentation/queued_request.h
    • services/resource_coordinator/memory_instrumentation/queued_request_dispatcher.cc
    • services/resource_coordinator/memory_instrumentation/queued_request_dispatcher.h
    • services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation_mojom_traits.cc
    • services/resource_coordinator/public/mojom/memory_instrumentation/memory_instrumentation.mojom
  4. Roll src/third_party/skia/ a36db6984..1fb2da5e4 (1 commit)

    Changed by skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Tuesday, 13-Feb-18 14:45:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 22c5ccd98a8991f0c047df1bc36a217f350316e9

    Comments

    Roll src/third_party/skia/ a36db6984..1fb2da5e4 (1 commit)
    
    https://skia.googlesource.com/skia.git/+log/a36db6984e76..1fb2da5e4e66
    
    $ git log a36db6984..1fb2da5e4 --date=short --no-merges --format='%ad %ae %s'
    2018-02-13 borenet [infra] Update to Go 1.9.4
    
    Created with:
      roll-dep src/third_party/skia
    
    
    The AutoRoll server is located here: https://autoroll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing fail
    ...skip...
    omium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
    TBR=caryclark@chromium.org
    
    Change-Id: I9e19f94116966e46c5c6d9d11971f88f2245b91f
    Reviewed-on: https://chromium-review.googlesource.com/916103
    Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#536354}

    Changed files

    • DEPS
  5. [subresource_filter] Enable Better Ads filtering by default

    Changed by csharrisonohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 14:47:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7aede3dfb938e2e451b3d2c044dd3fe46e331de3

    Comments

    [subresource_filter] Enable Better Ads filtering by default
    
    This enables both the filtering on better ads violating sites, and
    also the feature which turns on the "Ads" setting.
    
    Note that we still only sync the SUBRESOURCE_FILTER threat type
    on chrome branded builds.
    
    Bug: 737201
    Change-Id: Icafe2d5ae1e995d18668a29ed5c3b9fca6fd20f4
    Reviewed-on: https://chromium-review.googlesource.com/910669
    Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
    Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
    Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536355}

    Changed files

    • chrome/browser/subresource_filter/subresource_filter_content_settings_manager_unittest.cc
    • chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc
    • components/subresource_filter/core/browser/subresource_filter_features.cc
    • components/subresource_filter/core/browser/subresource_filter_features_unittest.cc
  6. PermissionDialog: Separate the dialog from control

    Changed by asimjourohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 14:49:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 28042407186a5000da43bc3eb4cd23ed669f5432

    Comments

    PermissionDialog: Separate the dialog from control
    
    This is the first step towards moving PermissionController to
    use  ModalDialogViews for Permission controller behind a flag.
    This CL separates the PermissionDialogController and
    PermissionDialogView.
    
    BUG=811134
    
    Change-Id: I72101f3c329aa74bb57de8a38c2365a3dac32c47
    Reviewed-on: https://chromium-review.googlesource.com/912699
    Reviewed-by: Dominick Ng <dominickn@chromium.org>
    Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536356}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java
    • chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogView.java
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionTestRule.java
  7. Configure token invalidation period using Finch

    Changed by natorohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 15:10:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c3d792e75d9fdf0885a13679b69c616103dca8a1

    Comments

    Configure token invalidation period using Finch
    
    and use it to conditionally skip GCM registration
    (if the token is still fresh).
    Also add a unit test to verify intended behavior.
    Additionally, add a UMA metric to note whether a
    GCM registration request was because of a stale
    token.
    
    Bug: 799483
    Change-Id: I994ff79d13b82ed845a4aaed97f91ed8674e62e6
    Reviewed-on: https://chromium-review.googlesource.com/908488
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Reviewed-by: Mark Pearson <mpearson@chromium.org>
    Commit-Queue: Mugdha Lakhani <nator@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536357}

    Changed files

    • components/gcm_driver/BUILD.gn
    • components/gcm_driver/features.cc
    • components/gcm_driver/features.h
    • components/gcm_driver/gcm_client_impl.cc
    • components/gcm_driver/gcm_client_impl_unittest.cc
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml
  8. Report First Input Delay across OOPIFs, report First Input Timestamp.

    Changed by tdresserohnoyoudont@chromium.org
    Changed at Tuesday, 13-Feb-18 15:20:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fe64540e01311889d266c94de15b594e3e0f21cc

    Comments

    Report First Input Delay across OOPIFs, report First Input Timestamp.
    
    Previously we only reported for documents in the same process.
    
    Adds InteractiveTiming.FirstInputTimestamp UKM,
    PageLoad.InteractiveTiming.FirstInputTimestamp UMA.
    
    Bug: 803935, 808089
    Change-Id: I182d764257c6ad215c585b938f11a47c88c00b32
    Reviewed-on: https://chromium-review.googlesource.com/901802
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
    Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536358}

    Changed files

    • chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
    • chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
    • chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
    • chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
    • chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
    • chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
    • chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
    • chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
    • chrome/browser/page_load_metrics/page_load_metrics_observer.h
    • chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc
    • chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h
    • chrome/browser/page_load_metrics/page_load_tracker.cc
    • chrome/common/page_load_metrics/page_load_metrics.mojom
    • chrome/common/page_load_metrics/page_load_timing.cc
    • chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
    • third_party/WebKit/Source/core/exported/WebPerformance.cpp
    • third_party/WebKit/Source/core/exported/WebViewTest.cpp
    • third_party/WebKit/Source/core/loader/InteractiveDetector.cpp
    • third_party/WebKit/Source/core/loader/InteractiveDetector.h
    • third_party/WebKit/Source/core/loader/InteractiveDetectorTest.cpp
    • third_party/WebKit/Source/core/page/PageWidgetDelegate.cpp
    • third_party/WebKit/Source/core/page/PageWidgetDelegate.h
    • third_party/WebKit/Source/core/timing/PerformanceTiming.cpp
    • third_party/WebKit/Source/core/timing/PerformanceTiming.h
    • third_party/WebKit/public/web/WebPerformance.h
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml
    • tools/metrics/ukm/ukm.xml