Home | Search
Login

Builder ToTMac Build #2444 Apple OSX

Results:

build successful

Trigger Info:

Got Revision79b4157706b6b2d702d4a431efe3e16a4d72bfc2

Execution:

Steps and Logfiles:

Show:
  1. ( 5 hrs 41 mins ) steps
    running steps via annotated script
  2. ( 5 secs ) update_scripts
    update_scripts
  3. ( 1 ms ) LUCI Migration
    LUCI Migration
  4. ( 1 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 1 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 1 ms ) report builders
    report builders
     
    running builder/tester 'ToTMac' on master 'chromium.clang'
  7. ( 1 ms ) makedirs checkout path
    makedirs checkout path
  8. ( 4 mins 39 secs ) bot_update
    bot_update
    [323GB/931GB used (34%)]
  9. ( 2 ms ) swarming.py --version
    swarming.py --version
    0.14
  10. ( 2 ms ) ensure_installed
    ensure_installed
  11. ( 31 mins 44 secs ) gclient runhooks
    gclient runhooks
  12. ( 1 ms ) get compile targets for scripts
    get compile targets for scripts
  13. ( 1 ms ) read test spec (chromium.clang.json)
    read test spec (chromium.clang.json)
    path: /b/c/b/ToTMac/src/testing/buildbot/chromium.clang.json
  14. ( 1 ms ) clean isolated files
    clean isolated files
  15. ( 1 ms ) lookup GN args
    lookup GN args
     
    clang_use_chrome_plugins = false
    is_clang = true
    is_component_build = true
    is_debug = false
    llvm_force_head_revision = true
    symbol_level = 1
  16. ( 16 secs ) generate_build_files
    generate_build_files
  17. ( 1 ms ) clang_revision
    clang_revision
  18. ( 4 hrs 35 mins ) compile
    compile
  19. ( 8 secs ) compile confirm no-op
    compile confirm no-op
  20. ( 17 secs ) upload_ninja_log
    upload_ninja_log
  21. ( 46 secs ) isolate webkit_layout_tests_exparchive
    isolate webkit_layout_tests_exparchive
  22. ( 1 mins 36 secs ) isolate tests
    isolate tests
  23. ( 1 ms ) find isolated tests
    find isolated tests
  24. ( 1 ms ) test_pre_run
    test_pre_run
  25. ( 1 ms ) test_pre_run.[trigger] accessibility_unittests
    test_pre_run.[trigger] accessibility_unittests
    Run on OS: 'Mac-10.13'
  26. ( 1 ms ) test_pre_run.[trigger] angle_unittests
    test_pre_run.[trigger] angle_unittests
    Run on OS: 'Mac-10.13'
  27. ( 1 ms ) test_pre_run.[trigger] app_shell_unittests
    test_pre_run.[trigger] app_shell_unittests
    Run on OS: 'Mac-10.13'
  28. ( 1 ms ) test_pre_run.[trigger] base_unittests
    test_pre_run.[trigger] base_unittests
    Run on OS: 'Mac-10.13'
  29. ( 1 ms ) test_pre_run.[trigger] blink_common_unittests
    test_pre_run.[trigger] blink_common_unittests
    Run on OS: 'Mac-10.13'
  30. ( 1 ms ) test_pre_run.[trigger] blink_fuzzer_unittests
    test_pre_run.[trigger] blink_fuzzer_unittests
    Run on OS: 'Mac-10.13'
  31. ( 1 ms ) test_pre_run.[trigger] blink_heap_unittests
    test_pre_run.[trigger] blink_heap_unittests
    Run on OS: 'Mac-10.13'
  32. ( 5 secs ) test_pre_run.[trigger] blink_platform_unittests
    test_pre_run.[trigger] blink_platform_unittests
    Run on OS: 'Mac-10.13'
  33. ( 1 ms ) test_pre_run.[trigger] boringssl_crypto_tests
    test_pre_run.[trigger] boringssl_crypto_tests
    Run on OS: 'Mac-10.13'
  34. ( 1 ms ) test_pre_run.[trigger] boringssl_ssl_tests
    test_pre_run.[trigger] boringssl_ssl_tests
    Run on OS: 'Mac-10.13'
  35. ( 7 secs ) test_pre_run.[trigger] network_service_browser_tests
    test_pre_run.[trigger] network_service_browser_tests
    Run on OS: 'Mac-10.13'
  36. ( 2 ms ) test_pre_run.[trigger] webui_polymer2_browser_tests
    test_pre_run.[trigger] webui_polymer2_browser_tests
    Run on OS: 'Mac-10.13'
  37. ( 1 ms ) test_pre_run.[trigger] cacheinvalidation_unittests
    test_pre_run.[trigger] cacheinvalidation_unittests
    Run on OS: 'Mac-10.13'
  38. ( 1 ms ) test_pre_run.[trigger] capture_unittests
    test_pre_run.[trigger] capture_unittests
    Run on OS: 'Mac-10.13'
  39. ( 1 ms ) test_pre_run.[trigger] cast_unittests
    test_pre_run.[trigger] cast_unittests
    Run on OS: 'Mac-10.13'
  40. ( 1 ms ) test_pre_run.[trigger] cc_unittests
    test_pre_run.[trigger] cc_unittests
    Run on OS: 'Mac-10.13'
  41. ( 5 secs ) test_pre_run.[trigger] chrome_app_unittests
    test_pre_run.[trigger] chrome_app_unittests
    Run on OS: 'Mac-10.13'
  42. ( 1 ms ) test_pre_run.[trigger] chromedriver_unittests
    test_pre_run.[trigger] chromedriver_unittests
    Run on OS: 'Mac-10.13'
  43. ( 1 ms ) test_pre_run.[trigger] components_browsertests
    test_pre_run.[trigger] components_browsertests
    Run on OS: 'Mac-10.13'
  44. ( 1 ms ) test_pre_run.[trigger] network_service_components_browsertests
    test_pre_run.[trigger] network_service_components_browsertests
    Run on OS: 'Mac-10.13'
  45. ( 1 ms ) test_pre_run.[trigger] components_unittests
    test_pre_run.[trigger] components_unittests
    Run on OS: 'Mac-10.13'
  46. ( 1 ms ) test_pre_run.[trigger] content_browsertests
    test_pre_run.[trigger] content_browsertests
    Run on OS: 'Mac-10.13'
  47. ( 1 ms ) test_pre_run.[trigger] network_service_content_browsertests
    test_pre_run.[trigger] network_service_content_browsertests
    Run on OS: 'Mac-10.13'
  48. ( 1 ms ) test_pre_run.[trigger] perfetto_content_browsertests
    test_pre_run.[trigger] perfetto_content_browsertests
    Run on OS: 'Mac-10.13'
  49. ( 5 secs ) test_pre_run.[trigger] content_unittests
    test_pre_run.[trigger] content_unittests
    Run on OS: 'Mac-10.13'
  50. ( 2 ms ) test_pre_run.[trigger] crashpad_tests
    test_pre_run.[trigger] crashpad_tests
    Run on OS: 'Mac-10.13'
  51. ( 1 ms ) test_pre_run.[trigger] cronet_tests
    test_pre_run.[trigger] cronet_tests
    Run on OS: 'Mac-10.13'
  52. ( 1 ms ) test_pre_run.[trigger] cronet_unittests
    test_pre_run.[trigger] cronet_unittests
    Run on OS: 'Mac-10.13'
  53. ( 1 ms ) test_pre_run.[trigger] crypto_unittests
    test_pre_run.[trigger] crypto_unittests
    Run on OS: 'Mac-10.13'
  54. ( 1 ms ) test_pre_run.[trigger] device_unittests
    test_pre_run.[trigger] device_unittests
    Run on OS: 'Mac-10.13'
  55. ( 1 ms ) test_pre_run.[trigger] display_unittests
    test_pre_run.[trigger] display_unittests
    Run on OS: 'Mac-10.13'
  56. ( 1 ms ) test_pre_run.[trigger] events_unittests
    test_pre_run.[trigger] events_unittests
    Run on OS: 'Mac-10.13'
  57. ( 5 secs ) test_pre_run.[trigger] extensions_browsertests
    test_pre_run.[trigger] extensions_browsertests
    Run on OS: 'Mac-10.13'
  58. ( 1 ms ) test_pre_run.[trigger] network_service_extensions_browsertests
    test_pre_run.[trigger] network_service_extensions_browsertests
    Run on OS: 'Mac-10.13'
  59. ( 1 ms ) test_pre_run.[trigger] extensions_unittests
    test_pre_run.[trigger] extensions_unittests
    Run on OS: 'Mac-10.13'
  60. ( 1 ms ) test_pre_run.[trigger] filesystem_service_unittests
    test_pre_run.[trigger] filesystem_service_unittests
    Run on OS: 'Mac-10.13'
  61. ( 1 ms ) test_pre_run.[trigger] gcm_unit_tests
    test_pre_run.[trigger] gcm_unit_tests
    Run on OS: 'Mac-10.13'
  62. ( 1 ms ) test_pre_run.[trigger] gfx_unittests
    test_pre_run.[trigger] gfx_unittests
    Run on OS: 'Mac-10.13'
  63. ( 1 ms ) test_pre_run.[trigger] gin_unittests
    test_pre_run.[trigger] gin_unittests
    Run on OS: 'Mac-10.13'
  64. ( 1 ms ) test_pre_run.[trigger] google_apis_unittests
    test_pre_run.[trigger] google_apis_unittests
    Run on OS: 'Mac-10.13'
  65. ( 5 secs ) test_pre_run.[trigger] gpu_unittests
    test_pre_run.[trigger] gpu_unittests
    Run on OS: 'Mac-10.13'
  66. ( 1 ms ) test_pre_run.[trigger] headless_browsertests
    test_pre_run.[trigger] headless_browsertests
    Run on OS: 'Mac-10.13'
  67. ( 1 ms ) test_pre_run.[trigger] headless_unittests
    test_pre_run.[trigger] headless_unittests
    Run on OS: 'Mac-10.13'
  68. ( 1 ms ) test_pre_run.[trigger] interactive_ui_tests
    test_pre_run.[trigger] interactive_ui_tests
    Run on OS: 'Mac-10.13'
  69. ( 1 ms ) test_pre_run.[trigger] network_service_interactive_ui_tests
    test_pre_run.[trigger] network_service_interactive_ui_tests
    Run on OS: 'Mac-10.13'
  70. ( 1 ms ) test_pre_run.[trigger] webui_polymer2_interactive_ui_tests
    test_pre_run.[trigger] webui_polymer2_interactive_ui_tests
    Run on OS: 'Mac-10.13'
  71. ( 1 ms ) test_pre_run.[trigger] ipc_tests
    test_pre_run.[trigger] ipc_tests
    Run on OS: 'Mac-10.13'
  72. ( 5 secs ) test_pre_run.[trigger] jingle_unittests
    test_pre_run.[trigger] jingle_unittests
    Run on OS: 'Mac-10.13'
  73. ( 1 ms ) test_pre_run.[trigger] latency_unittests
    test_pre_run.[trigger] latency_unittests
    Run on OS: 'Mac-10.13'
  74. ( 1 ms ) test_pre_run.[trigger] leveldb_service_unittests
    test_pre_run.[trigger] leveldb_service_unittests
    Run on OS: 'Mac-10.13'
  75. ( 1 ms ) test_pre_run.[trigger] libjingle_xmpp_unittests
    test_pre_run.[trigger] libjingle_xmpp_unittests
    Run on OS: 'Mac-10.13'
  76. ( 1 ms ) test_pre_run.[trigger] media_blink_unittests
    test_pre_run.[trigger] media_blink_unittests
    Run on OS: 'Mac-10.13'
  77. ( 1 ms ) test_pre_run.[trigger] media_service_unittests
    test_pre_run.[trigger] media_service_unittests
    Run on OS: 'Mac-10.13'
  78. ( 1 ms ) test_pre_run.[trigger] media_unittests
    test_pre_run.[trigger] media_unittests
    Run on OS: 'Mac-10.13'
  79. ( 1 ms ) test_pre_run.[trigger] message_center_unittests
    test_pre_run.[trigger] message_center_unittests
    Run on OS: 'Mac-10.13'
  80. ( 2 ms ) test_pre_run.[trigger] midi_unittests
    test_pre_run.[trigger] midi_unittests
    Run on OS: 'Mac-10.13'
  81. ( 5 secs ) test_pre_run.[trigger] mojo_unittests
    test_pre_run.[trigger] mojo_unittests
    Run on OS: 'Mac-10.13'
  82. ( 1 ms ) test_pre_run.[trigger] nacl_loader_unittests
    test_pre_run.[trigger] nacl_loader_unittests
    Run on OS: 'Mac-10.13'
  83. ( 1 ms ) test_pre_run.[trigger] native_theme_unittests
    test_pre_run.[trigger] native_theme_unittests
    Run on OS: 'Mac-10.13'
  84. ( 1 ms ) test_pre_run.[trigger] net_unittests
    test_pre_run.[trigger] net_unittests
    Run on OS: 'Mac-10.13'
  85. ( 1 ms ) test_pre_run.[trigger] pdf_unittests
    test_pre_run.[trigger] pdf_unittests
    Run on OS: 'Mac-10.13'
  86. ( 1 ms ) test_pre_run.[trigger] ppapi_unittests
    test_pre_run.[trigger] ppapi_unittests
    Run on OS: 'Mac-10.13'
  87. ( 1 ms ) test_pre_run.[trigger] printing_unittests
    test_pre_run.[trigger] printing_unittests
    Run on OS: 'Mac-10.13'
  88. ( 1 ms ) test_pre_run.[trigger] remoting_unittests
    test_pre_run.[trigger] remoting_unittests
    Run on OS: 'Mac-10.13'
  89. ( 5 secs ) test_pre_run.[trigger] sandbox_mac_unittests
    test_pre_run.[trigger] sandbox_mac_unittests
    Run on OS: 'Mac-10.13'
  90. ( 1 ms ) test_pre_run.[trigger] service_manager_unittests
    test_pre_run.[trigger] service_manager_unittests
    Run on OS: 'Mac-10.13'
  91. ( 1 ms ) test_pre_run.[trigger] services_unittests
    test_pre_run.[trigger] services_unittests
    Run on OS: 'Mac-10.13'
  92. ( 1 ms ) test_pre_run.[trigger] shell_dialogs_unittests
    test_pre_run.[trigger] shell_dialogs_unittests
    Run on OS: 'Mac-10.13'
  93. ( 1 ms ) test_pre_run.[trigger] skia_unittests
    test_pre_run.[trigger] skia_unittests
    Run on OS: 'Mac-10.13'
  94. ( 1 ms ) test_pre_run.[trigger] snapshot_unittests
    test_pre_run.[trigger] snapshot_unittests
    Run on OS: 'Mac-10.13'
  95. ( 1 ms ) test_pre_run.[trigger] sql_unittests
    test_pre_run.[trigger] sql_unittests
    Run on OS: 'Mac-10.13'
  96. ( 1 ms ) test_pre_run.[trigger] storage_unittests
    test_pre_run.[trigger] storage_unittests
    Run on OS: 'Mac-10.13'
  97. ( 1 ms ) test_pre_run.[trigger] sync_integration_tests
    test_pre_run.[trigger] sync_integration_tests
    Run on OS: 'Mac-10.13'
  98. ( 5 secs ) test_pre_run.[trigger] ui_base_unittests
    test_pre_run.[trigger] ui_base_unittests
    Run on OS: 'Mac-10.13'
  99. ( 1 ms ) test_pre_run.[trigger] ui_touch_selection_unittests
    test_pre_run.[trigger] ui_touch_selection_unittests
    Run on OS: 'Mac-10.13'
  100. ( 1 ms ) test_pre_run.[trigger] unit_tests
    test_pre_run.[trigger] unit_tests
    Run on OS: 'Mac-10.13'
  101. ( 1 ms ) test_pre_run.[trigger] url_unittests
    test_pre_run.[trigger] url_unittests
    Run on OS: 'Mac-10.13'
  102. ( 1 ms ) test_pre_run.[trigger] views_unittests
    test_pre_run.[trigger] views_unittests
    Run on OS: 'Mac-10.13'
  103. ( 1 ms ) test_pre_run.[trigger] viz_unittests
    test_pre_run.[trigger] viz_unittests
    Run on OS: 'Mac-10.13'
  104. ( 1 ms ) test_pre_run.[trigger] webkit_unit_tests
    test_pre_run.[trigger] webkit_unit_tests
    Run on OS: 'Mac-10.13'
  105. ( 5 secs ) test_pre_run.[trigger] wtf_unittests
    test_pre_run.[trigger] wtf_unittests
    Run on OS: 'Mac-10.13'
  106. ( 1 ms ) test_pre_run.[trigger] chromedriver_py_tests
    test_pre_run.[trigger] chromedriver_py_tests
    Run on OS: 'Mac-10.13'
  107. ( 1 ms ) test_pre_run.[trigger] chromedriver_replay_unittests
    test_pre_run.[trigger] chromedriver_replay_unittests
    Run on OS: 'Mac-10.13'
  108. ( 1 ms ) test_pre_run.[trigger] components_perftests
    test_pre_run.[trigger] components_perftests
    Run on OS: 'Mac-10.13'
  109. ( 1 ms ) test_pre_run.[trigger] content_shell_crash_test
    test_pre_run.[trigger] content_shell_crash_test
    Run on OS: 'Mac-10.13'
  110. ( 1 ms ) test_pre_run.[trigger] metrics_python_tests
    test_pre_run.[trigger] metrics_python_tests
    Run on OS: 'Mac-10.13'
  111. ( 1 ms ) test_pre_run.[trigger] telemetry_gpu_unittests
    test_pre_run.[trigger] telemetry_gpu_unittests
    Run on OS: 'Mac-10.13'
  112. ( 7 secs ) test_pre_run.[trigger] telemetry_perf_unittests
    test_pre_run.[trigger] telemetry_perf_unittests
    Run on OS: 'Mac-10.13'
  113. ( 1 ms ) test_pre_run.[trigger] telemetry_unittests
    test_pre_run.[trigger] telemetry_unittests
    Run on OS: 'Mac-10.13'
  114. ( 1 ms ) test_pre_run.[trigger] views_perftests
    test_pre_run.[trigger] views_perftests
    Run on OS: 'Mac-10.13'
  115. ( 7 secs ) test_pre_run.[trigger] webkit_layout_tests
    test_pre_run.[trigger] webkit_layout_tests
    Run on OS: 'Mac-10.13'
  116. ( 1 ms ) test_pre_run.[trigger] webkit_python_tests
    test_pre_run.[trigger] webkit_python_tests
    Run on OS: 'Mac-10.13'
  117. ( 1 ms ) sizes
    sizes
    sizes
    <div class="BuildResultInfo">
    </div>
  118. ( 5 secs ) wait for tasks
    wait for tasks
  119. ( 2 ms ) snapshot_unittests
    snapshot_unittests
    Run on OS: 'Mac-10.13'
    Pending time: 11s
    Shard duration: 10s
  120. ( 1 ms ) Upload to test-results [snapshot_unittests]
    Upload to test-results [snapshot_unittests]
  121. ( 2 ms ) blink_platform_unittests
    blink_platform_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 48s
  122. ( 8 secs ) Upload to test-results [blink_platform_unittests]
    Upload to test-results [blink_platform_unittests]
  123. ( 3 ms ) device_unittests
    device_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 16s
  124. ( 1 ms ) Upload to test-results [device_unittests]
    Upload to test-results [device_unittests]
  125. ( 2 ms ) message_center_unittests
    message_center_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 12s
  126. ( 5 secs ) Upload to test-results [message_center_unittests]
    Upload to test-results [message_center_unittests]
  127. ( 3 ms ) sql_unittests
    sql_unittests
    Run on OS: 'Mac-10.13'
    Pending time: 11s
    Shard duration: 10s
  128. ( 1 ms ) Upload to test-results [sql_unittests]
    Upload to test-results [sql_unittests]
  129. ( 2 ms ) crashpad_tests
    crashpad_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 13s
  130. ( 5 secs ) Upload to test-results [crashpad_tests]
    Upload to test-results [crashpad_tests]
  131. ( 3 ms ) webkit_python_tests
    webkit_python_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 21s
    Total tests: 1590
    * Passed: 1590 (1590 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  132. ( 1 ms ) Upload to test-results [webkit_python_tests]
    Upload to test-results [webkit_python_tests]
  133. ( 6 secs ) blink_common_unittests
    blink_common_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 13s
  134. ( 1 ms ) Upload to test-results [blink_common_unittests]
    Upload to test-results [blink_common_unittests]
  135. ( 2 ms ) chromedriver_unittests
    chromedriver_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 16s
  136. ( 1 ms ) Upload to test-results [chromedriver_unittests]
    Upload to test-results [chromedriver_unittests]
  137. ( 5 secs ) cacheinvalidation_unittests
    cacheinvalidation_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 12s
  138. ( 1 ms ) Upload to test-results [cacheinvalidation_unittests]
    Upload to test-results [cacheinvalidation_unittests]
  139. ( 2 ms ) gfx_unittests
    gfx_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 20s
  140. ( 9 secs ) Upload to test-results [gfx_unittests]
    Upload to test-results [gfx_unittests]
  141. ( 3 ms ) mojo_unittests
    mojo_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 20s
  142. ( 1 ms ) Upload to test-results [mojo_unittests]
    Upload to test-results [mojo_unittests]
  143. ( 6 secs ) app_shell_unittests
    app_shell_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 23s
  144. ( 1 ms ) Upload to test-results [app_shell_unittests]
    Upload to test-results [app_shell_unittests]
  145. ( 2 ms ) cast_unittests
    cast_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 22s
  146. ( 1 ms ) Upload to test-results [cast_unittests]
    Upload to test-results [cast_unittests]
  147. ( 6 secs ) google_apis_unittests
    google_apis_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 15s
  148. ( 1 ms ) Upload to test-results [google_apis_unittests]
    Upload to test-results [google_apis_unittests]
  149. ( 2 ms ) libjingle_xmpp_unittests
    libjingle_xmpp_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 21s
  150. ( 1 ms ) Upload to test-results [libjingle_xmpp_unittests]
    Upload to test-results [libjingle_xmpp_unittests]
  151. ( 5 secs ) skia_unittests
    skia_unittests
    Run on OS: 'Mac-10.13'
    Pending time: 11s
    Shard duration: 11s
  152. ( 1 ms ) Upload to test-results [skia_unittests]
    Upload to test-results [skia_unittests]
  153. ( 2 ms ) network_service_components_browsertests
    network_service_components_browsertests
    Run on OS: 'Mac-10.13'
    Shard duration: 37s
  154. ( 2 ms ) Upload to test-results [network_service_components_browsertests]
    Upload to test-results [network_service_components_browsertests]
  155. ( 5 secs ) ppapi_unittests
    ppapi_unittests
    Run on OS: 'Mac-10.13'
    Pending time: 12s
    Shard duration: 12s
  156. ( 1 ms ) Upload to test-results [ppapi_unittests]
    Upload to test-results [ppapi_unittests]
  157. ( 2 ms ) media_service_unittests
    media_service_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 13s
  158. ( 1 ms ) Upload to test-results [media_service_unittests]
    Upload to test-results [media_service_unittests]
  159. ( 5 secs ) midi_unittests
    midi_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 12s
  160. ( 1 ms ) Upload to test-results [midi_unittests]
    Upload to test-results [midi_unittests]
  161. ( 2 ms ) leveldb_service_unittests
    leveldb_service_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 10s
  162. ( 1 ms ) Upload to test-results [leveldb_service_unittests]
    Upload to test-results [leveldb_service_unittests]
  163. ( 4 secs ) perfetto_content_browsertests
    perfetto_content_browsertests
    Run on OS: 'Mac-10.13'
    Shard duration: 27s
  164. ( 1 ms ) Upload to test-results [perfetto_content_browsertests]
    Upload to test-results [perfetto_content_browsertests]
  165. ( 2 ms ) url_unittests
    url_unittests
    Run on OS: 'Mac-10.13'
    Pending time: 10s
    Shard duration: 10s
  166. ( 1 ms ) Upload to test-results [url_unittests]
    Upload to test-results [url_unittests]
  167. ( 5 secs ) cronet_tests
    cronet_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 15s
  168. ( 1 ms ) Upload to test-results [cronet_tests]
    Upload to test-results [cronet_tests]
  169. ( 2 ms ) components_browsertests
    components_browsertests
    Run on OS: 'Mac-10.13'
    Shard duration: 34s
  170. ( 1 ms ) Upload to test-results [components_browsertests]
    Upload to test-results [components_browsertests]
  171. ( 4 secs ) gcm_unit_tests
    gcm_unit_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 16s
  172. ( 1 ms ) Upload to test-results [gcm_unit_tests]
    Upload to test-results [gcm_unit_tests]
  173. ( 2 ms ) headless_unittests
    headless_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 15s
  174. ( 1 ms ) Upload to test-results [headless_unittests]
    Upload to test-results [headless_unittests]
  175. ( 2 ms ) printing_unittests
    printing_unittests
    Run on OS: 'Mac-10.13'
    Pending time: 12s
    Shard duration: 10s
  176. ( 6 secs ) Upload to test-results [printing_unittests]
    Upload to test-results [printing_unittests]
  177. ( 4 ms ) metrics_python_tests
    metrics_python_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 10s
    Total tests: 74
    * Passed: 74 (74 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  178. ( 1 ms ) Upload to test-results [metrics_python_tests]
    Upload to test-results [metrics_python_tests]
  179. ( 4 ms ) chromedriver_replay_unittests
    chromedriver_replay_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 11s
    Total tests: 33
    * Passed: 33 (33 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  180. ( 1 ms ) Upload to test-results [chromedriver_replay_unittests]
    Upload to test-results [chromedriver_replay_unittests]
  181. ( 7 secs ) gpu_unittests
    gpu_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 23s
  182. ( 5 secs ) Upload to test-results [gpu_unittests]
    Upload to test-results [gpu_unittests]
  183. ( 3 ms ) service_manager_unittests
    service_manager_unittests
    Run on OS: 'Mac-10.13'
    Pending time: 12s
    Shard duration: 12s
  184. ( 1 ms ) Upload to test-results [service_manager_unittests]
    Upload to test-results [service_manager_unittests]
  185. ( 2 ms ) chrome_app_unittests
    chrome_app_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 21s
  186. ( 5 secs ) Upload to test-results [chrome_app_unittests]
    Upload to test-results [chrome_app_unittests]
  187. ( 3 ms ) accessibility_unittests
    accessibility_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 13s
  188. ( 1 ms ) Upload to test-results [accessibility_unittests]
    Upload to test-results [accessibility_unittests]
  189. ( 2 ms ) boringssl_ssl_tests
    boringssl_ssl_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 11s
  190. ( 5 secs ) Upload to test-results [boringssl_ssl_tests]
    Upload to test-results [boringssl_ssl_tests]
  191. ( 3 ms ) extensions_unittests
    extensions_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 38s
  192. ( 1 ms ) Upload to test-results [extensions_unittests]
    Upload to test-results [extensions_unittests]
  193. ( 5 secs ) media_blink_unittests
    media_blink_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 24s
  194. ( 1 ms ) Upload to test-results [media_blink_unittests]
    Upload to test-results [media_blink_unittests]
  195. ( 3 ms ) sandbox_mac_unittests
    sandbox_mac_unittests
    Run on OS: 'Mac-10.13'
    Pending time: 12s
    Shard duration: 12s
  196. ( 5 secs ) Upload to test-results [sandbox_mac_unittests]
    Upload to test-results [sandbox_mac_unittests]
  197. ( 5 ms ) wtf_unittests
    wtf_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 10s
  198. ( 1 ms ) Upload to test-results [wtf_unittests]
    Upload to test-results [wtf_unittests]
  199. ( 2 ms ) pdf_unittests
    pdf_unittests
    Run on OS: 'Mac-10.13'
    Pending time: 10s
    Shard duration: 11s
  200. ( 5 secs ) Upload to test-results [pdf_unittests]
    Upload to test-results [pdf_unittests]
  201. ( 3 ms ) jingle_unittests
    jingle_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 14s
  202. ( 1 ms ) Upload to test-results [jingle_unittests]
    Upload to test-results [jingle_unittests]
  203. ( 3 ms ) gin_unittests
    gin_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 11s
  204. ( 1 ms ) Upload to test-results [gin_unittests]
    Upload to test-results [gin_unittests]
  205. ( 6 secs ) nacl_loader_unittests
    nacl_loader_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 17s
  206. ( 1 ms ) Upload to test-results [nacl_loader_unittests]
    Upload to test-results [nacl_loader_unittests]
  207. ( 3 ms ) base_unittests
    base_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 38s
  208. ( 11 secs ) Upload to test-results [base_unittests]
    Upload to test-results [base_unittests]
  209. ( 3 ms ) crypto_unittests
    crypto_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 12s
  210. ( 1 ms ) Upload to test-results [crypto_unittests]
    Upload to test-results [crypto_unittests]
  211. ( 3 ms ) events_unittests
    events_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 13s
  212. ( 5 secs ) Upload to test-results [events_unittests]
    Upload to test-results [events_unittests]
  213. ( 3 ms ) native_theme_unittests
    native_theme_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 10s
  214. ( 1 ms ) Upload to test-results [native_theme_unittests]
    Upload to test-results [native_theme_unittests]
  215. ( 3 ms ) latency_unittests
    latency_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 11s
  216. ( 1 ms ) Upload to test-results [latency_unittests]
    Upload to test-results [latency_unittests]
  217. ( 7 secs ) boringssl_crypto_tests
    boringssl_crypto_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 15s
  218. ( 1 ms ) Upload to test-results [boringssl_crypto_tests]
    Upload to test-results [boringssl_crypto_tests]
  219. ( 3 ms ) cronet_unittests
    cronet_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 16s
  220. ( 5 secs ) Upload to test-results [cronet_unittests]
    Upload to test-results [cronet_unittests]
  221. ( 3 ms ) blink_heap_unittests
    blink_heap_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 26s
  222. ( 1 ms ) Upload to test-results [blink_heap_unittests]
    Upload to test-results [blink_heap_unittests]
  223. ( 3 ms ) ipc_tests
    ipc_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 17s
  224. ( 5 secs ) Upload to test-results [ipc_tests]
    Upload to test-results [ipc_tests]
  225. ( 3 ms ) ui_touch_selection_unittests
    ui_touch_selection_unittests
    Run on OS: 'Mac-10.13'
    Pending time: 11s
    Shard duration: 10s
  226. ( 1 ms ) Upload to test-results [ui_touch_selection_unittests]
    Upload to test-results [ui_touch_selection_unittests]
  227. ( 3 ms ) blink_fuzzer_unittests
    blink_fuzzer_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 14s
  228. ( 1 ms ) Upload to test-results [blink_fuzzer_unittests]
    Upload to test-results [blink_fuzzer_unittests]
  229. ( 5 secs ) display_unittests
    display_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 13s
  230. ( 1 ms ) Upload to test-results [display_unittests]
    Upload to test-results [display_unittests]
  231. ( 3 ms ) capture_unittests
    capture_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 17s
  232. ( 7 secs ) Upload to test-results [capture_unittests]
    Upload to test-results [capture_unittests]
  233. ( 3 ms ) filesystem_service_unittests
    filesystem_service_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 11s
  234. ( 1 ms ) Upload to test-results [filesystem_service_unittests]
    Upload to test-results [filesystem_service_unittests]
  235. ( 3 ms ) shell_dialogs_unittests
    shell_dialogs_unittests
    Run on OS: 'Mac-10.13'
    Pending time: 11s
    Shard duration: 13s
  236. ( 1 ms ) Upload to test-results [shell_dialogs_unittests]
    Upload to test-results [shell_dialogs_unittests]
  237. ( 5 secs ) wait for tasks (2)
    wait for tasks (2)
  238. ( 4 ms ) telemetry_gpu_unittests
    telemetry_gpu_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 51s
    Total tests: 38
    * Passed: 38 (38 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  239. ( 7 secs ) Upload to test-results [telemetry_gpu_unittests]
    Upload to test-results [telemetry_gpu_unittests]
  240. ( 3 ms ) content_unittests
    content_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:15.005762
  241. ( 11 secs ) Upload to test-results [content_unittests]
    Upload to test-results [content_unittests]
  242. ( 4 ms ) components_perftests
    components_perftests
    Run on OS: 'Mac-10.13'
    Shard duration: 36s
    Total tests: n/a
     
  243. ( 4 ms ) views_perftests
    views_perftests
    Run on OS: 'Mac-10.13'
    Shard duration: 12s
    Total tests: n/a
     
  244. ( 3 ms ) headless_browsertests
    headless_browsertests
    Run on OS: 'Mac-10.13'
    Shard duration: 42s
  245. ( 5 secs ) Upload to test-results [headless_browsertests]
    Upload to test-results [headless_browsertests]
  246. ( 3 ms ) remoting_unittests
    remoting_unittests
    Run on OS: 'Mac-10.13'
    Pending time: 12s
    Shard duration: 22s
  247. ( 1 ms ) Upload to test-results [remoting_unittests]
    Upload to test-results [remoting_unittests]
  248. ( 5 secs ) extensions_browsertests
    extensions_browsertests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:30.799010
  249. ( 1 ms ) Upload to test-results [extensions_browsertests]
    Upload to test-results [extensions_browsertests]
  250. ( 3 ms ) ui_base_unittests
    ui_base_unittests
    Run on OS: 'Mac-10.13'
    Pending time: 12s
    Shard duration: 17s
  251. ( 1 ms ) Upload to test-results [ui_base_unittests]
    Upload to test-results [ui_base_unittests]
  252. ( 9 secs ) unit_tests
    unit_tests
    Run on OS: 'Mac-10.13'
    Pending time: 11s
    Shard duration: 0:02:34.244175
  253. ( 10 secs ) Upload to test-results [unit_tests]
    Upload to test-results [unit_tests]
  254. ( 3 ms ) storage_unittests
    storage_unittests
    Run on OS: 'Mac-10.13'
    Pending time: 12s
    Shard duration: 14s
  255. ( 1 ms ) Upload to test-results [storage_unittests]
    Upload to test-results [storage_unittests]
  256. ( 5 secs ) views_unittests
    views_unittests
    Run on OS: 'Mac-10.13'
    Pending time: 10s
    Shard duration: 24s
  257. ( 1 ms ) Upload to test-results [views_unittests]
    Upload to test-results [views_unittests]
  258. ( 3 ms ) network_service_extensions_browsertests
    network_service_extensions_browsertests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:33.697100
  259. ( 5 secs ) Upload to test-results [network_service_extensions_browsertests]
    Upload to test-results [network_service_extensions_browsertests]
  260. ( 3 ms ) angle_unittests
    angle_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:34.028871
  261. ( 12 secs ) Upload to test-results [angle_unittests]
    Upload to test-results [angle_unittests]
  262. ( 4 ms ) content_shell_crash_test
    content_shell_crash_test
    Run on OS: 'Mac-10.13'
    Shard duration: 45s
    Total tests: n/a
     
  263. ( 3 ms ) media_unittests
    media_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 39s
  264. ( 10 secs ) Upload to test-results [media_unittests]
    Upload to test-results [media_unittests]
  265. ( 3 ms ) services_unittests
    services_unittests
    Run on OS: 'Mac-10.13'
    Pending time: 11s
    Shard duration: 36s
  266. ( 5 secs ) Upload to test-results [services_unittests]
    Upload to test-results [services_unittests]
  267. ( 3 ms ) viz_unittests
    viz_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:08.377713
  268. ( 1 ms ) Upload to test-results [viz_unittests]
    Upload to test-results [viz_unittests]
  269. ( 17 secs ) webkit_unit_tests
    webkit_unit_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:27.536798
  270. ( 14 secs ) Upload to test-results [webkit_unit_tests]
    Upload to test-results [webkit_unit_tests]
  271. ( 3 ms ) cc_unittests
    cc_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:14.036410
  272. ( 8 secs ) Upload to test-results [cc_unittests]
    Upload to test-results [cc_unittests]
  273. ( 7 secs ) components_unittests
    components_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:02:04.900288
  274. ( 16 secs ) Upload to test-results [components_unittests]
    Upload to test-results [components_unittests]
  275. ( 3 ms ) webui_polymer2_interactive_ui_tests
    webui_polymer2_interactive_ui_tests
    Run on OS: 'Mac-10.13'
    Pending time: 10s
    Shard duration: 0:01:41.668217
  276. ( 1 ms ) Upload to test-results [webui_polymer2_interactive_ui_tests]
    Upload to test-results [webui_polymer2_interactive_ui_tests]
  277. ( 2 ms ) wait for tasks (3)
    wait for tasks (3)
  278. ( 6 secs ) webui_polymer2_browser_tests
    webui_polymer2_browser_tests
    Run on OS: 'Mac-10.13'
    Max shard duration: 0:04:40.206613 (shard #3)
    Min shard duration: 0:03:35.068150 (shard #1)
  279. ( 6 secs ) Upload to test-results [webui_polymer2_browser_tests]
    Upload to test-results [webui_polymer2_browser_tests]
  280. ( 14 secs ) net_unittests
    net_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:04:27.475648
  281. ( 32 secs ) Upload to test-results [net_unittests]
    Upload to test-results [net_unittests]
  282. ( 4 ms ) chromedriver_py_tests
    chromedriver_py_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:04:37.347937
    Total tests: 145
    * Passed: 145 (145 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  283. ( 1 ms ) Upload to test-results [chromedriver_py_tests]
    Upload to test-results [chromedriver_py_tests]
  284. ( 2 ms ) wait for tasks (4)
    wait for tasks (4)
  285. ( 3 ms ) interactive_ui_tests
    interactive_ui_tests
    Run on OS: 'Mac-10.13'
    Max shard duration: 0:06:30.373185 (shard #2)
    Min shard duration: 0:06:12.863606 (shard #1)
  286. ( 6 secs ) Upload to test-results [interactive_ui_tests]
    Upload to test-results [interactive_ui_tests]
  287. ( 3 ms ) network_service_interactive_ui_tests
    network_service_interactive_ui_tests
    Run on OS: 'Mac-10.13'
    Max shard duration: 0:07:18.610690 (shard #2)
    Min shard duration: 0:05:37.705377 (shard #1)
  288. ( 1 ms ) Upload to test-results [network_service_interactive_ui_tests]
    Upload to test-results [network_service_interactive_ui_tests]
  289. ( 2 mins 12 secs ) wait for tasks (5)
    wait for tasks (5)
  290. ( 13 secs ) network_service_browser_tests
    network_service_browser_tests
    Run on OS: 'Mac-10.13'
    Max shard duration: 0:09:58.266635 (shard #0)
    Min shard duration: 0:07:00.787965 (shard #9)
  291. ( 32 secs ) Upload to test-results [network_service_browser_tests]
    Upload to test-results [network_service_browser_tests]
  292. ( 3 ms ) sync_integration_tests
    sync_integration_tests
    Run on OS: 'Mac-10.13'
    Pending time: 12s
    Shard duration: 0:09:06.301159
  293. ( 1 ms ) Upload to test-results [sync_integration_tests]
    Upload to test-results [sync_integration_tests]
  294. ( 2 mins 5 secs ) wait for tasks (6)
    wait for tasks (6)
  295. ( 3 ms ) network_service_content_browsertests
    network_service_content_browsertests
    Run on OS: 'Mac-10.13'
    Max shard duration: 0:11:48.782856 (shard #0)
    Min shard duration: 0:09:35.308078 (shard #1)
  296. ( 10 secs ) Upload to test-results [network_service_content_browsertests]
    Upload to test-results [network_service_content_browsertests]
  297. ( 1 mins 57 secs ) wait for tasks (7)
    wait for tasks (7)
  298. ( 7 mins 49 secs ) webkit_layout_tests
    webkit_layout_tests
    Run on OS: 'Mac-10.13'
    Max shard duration: 0:13:02.325015 (shard #4)
    Min shard duration: 0:10:05.597369 (shard #9)
    Total tests: 91880
    * Passed: 78257 (78190 expected, 67 unexpected)
    * Skipped: 10781 (10781 expected, 0 unexpected)
    * Failed: 2717 (2717 expected, 0 unexpected)
    * Flaky: 125 (124 expected, >>>1 unexpected<<<)
     
    Unexpected Flakes:
    * external/wpt/preload/dynamic-adding-preload-imagesrcset.tentative.html
     
  299. ( 1 mins 12 secs ) Upload to test-results [webkit_layout_tests]
    Upload to test-results [webkit_layout_tests]
  300. ( 28 secs ) archive results for webkit_layout_tests
    archive results for webkit_layout_tests
  301. ( 2 ms ) wait for tasks (8)
    wait for tasks (8)
  302. ( 4 ms ) telemetry_perf_unittests
    telemetry_perf_unittests
    Run on OS: 'Mac-10.13'
    Max pending time: 10s (shard #1)
    Max shard duration: 0:14:23.115784 (shard #7)
    Min shard duration: 0:03:15.986325 (shard #11)
    Total tests: 310
    * Passed: 233 (233 expected, 0 unexpected)
    * Skipped: 77 (77 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  303. ( 1 ms ) Upload to test-results [telemetry_perf_unittests]
    Upload to test-results [telemetry_perf_unittests]
  304. ( 6 secs ) content_browsertests
    content_browsertests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:19:50.176497
  305. ( 5 secs ) Upload to test-results [content_browsertests]
    Upload to test-results [content_browsertests]
  306. ( 19 secs ) telemetry_unittests
    telemetry_unittests
    Run on OS: 'Mac-10.13'
    Max shard duration: 0:24:11.537048 (shard #2)
    Min shard duration: 0:05:08.656442 (shard #3)
    Total tests: 1147
    * Passed: 1051 (1051 expected, 0 unexpected)
    * Skipped: 96 (96 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  307. ( 1 ms ) Upload to test-results [telemetry_unittests]
    Upload to test-results [telemetry_unittests]
  308. ( 2 ms ) Tests statistics
    Tests statistics
     
    Stats
    Total shards: 139
    Total runtime: 7:30:18.701946
     
  309. ( 2 ms ) recipe result
    recipe result

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromium/bb/chromium.clang/ToTMac/2444/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.clang/ToTMac/2444" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "d300548fcc2858fab34b7a744a000c48be845d06" Annotation(bot_update)
got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" Annotation(bot_update)
got_dawn_revision "5aacd29d5e7ed44d3cb0d1c690fbd0fc5152978f" Annotation(bot_update)
got_nacl_revision "17af1e818981ebf2c492a678d4d31c9e1ee37fc7" Annotation(bot_update)
got_revision "79b4157706b6b2d702d4a431efe3e16a4d72bfc2" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#614447}" Annotation(bot_update)
got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" Annotation(bot_update)
got_v8_revision "f5137533bdfac762e980b17eb7b4a2433dd07d1d" Annotation(bot_update)
got_v8_revision_cp "refs/heads/7.3.39@{#1}" Annotation(bot_update)
got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#25919}" Annotation(bot_update)
got_clang_revision "348520" Annotation(clang_revision)
swarm_hashes {"accessibility_unittests":"21be96c05425a338fe48869cd1d41eaf8c714853","angle_unittests":"7e52726fa8b7642c6c59c3a28ad19b907b2a9ad0","app_shell_unittests":"e25beaac283e66ad59229670bb9e2d264abec106","base_unittests":"0a4c85f03f1fb3108da2766adc407c568589d6d3","blink_common_unittests":"69eac1d9a89b467b939fc803d104405eb6a46e2c","blink_fuzzer_unittests":"f66b965b6443615d0483017e7e1a2eb198bb558d","blink_heap_unittests":"2ce9c74f7134169162a1ce0168a8744aab4bca51","blink_platform_unittests":"9b1ede4f1c048aa433dab97c9a16c92d6bb8132b","boringssl_crypto_tests":"b56b6d53e38cbe24f423c7207c1f86ef5de636b8","boringssl_ssl_tests":"1d7dac62123f53972fc73cb6187f28ffcad94a1f","browser_tests":"94fe7cbab3375ca8fc65d281ca69cce48eaa17ca","cacheinvalidation_unittests":"75a2cad39fe40ff895c3658a2819d0b440ea9cae","capture_unittests":"390b66994301869a23297ff4889f9efbce50529b","cast_unittests":"1e3a6ce4981b87fa0b50da9160dd0500bef9b75b","cc_unittests":"ddb8d25f271e27b08b0715e0ba9c21775e0a1833","chrome_app_unittests":"e49c8d63da041de8ef9139bc7edf33d5e3a7bb0f","chromedriver_py_tests":"7ba52cd5f5b7023165b647aa1b4908a1af79d101","chromedriver_replay_unittests":"2c79475fcfea940e6a9329f898a5d864d316a076","chromedriver_unittests":"c472bd43975a6bebf50b7fd666c257cfb2d5b332","components_browsertests":"c0f3877cddfeee8af1656253a18f6a5b95a4dac4","components_perftests":"87ee38f76ec9fa45b68acdb5f62320721c291e73","components_unittests":"3e0abec523089e2380a51f8efa8275adb08012f5","content_browsertests":"7ac13da53770d54a681866f6c4ca9d43d731f163","content_shell_crash_test":"83ba16c637c70ec3544a9dfbe5469f09b34a4b0e","content_unittests":"c65a2563e9d6ee919b950c3f9b9ae5ccc54f4bd2","crashpad_tests":"765a12cc463be36291c3a83c3d224d71f1bb210f","cronet_tests":"f9fc8fa573b86b5bccaab1fa29909ee6d94a34a6","cronet_unittests":"507747d95a1fb0192f5d5f9c16e7a7330f72c8f3","crypto_unittests":"5db77e25e5eed3df78af3da4f5679b7ed513ba2e","device_unittests":"d4965621644051555afa4ce74077c14cae03b04e","display_unittests":"e12f44ea13071f322ecf54b8f46e74db1f077618","events_unittests":"2ecfd055c58f75cb853951c279c863faf6c1dc24","extensions_browsertests":"3e40512269af5cb986ee81eca167120e7493edab","extensions_unittests":"c4e787171f07a7e05552b0643de95f20c53bc30c","filesystem_service_unittests":"0dc6656b568ecc38e6aac9149813046552bbd2e6","gcm_unit_tests":"3dbf9dd1e7e7da5a70fbe84fce8be0e1e6daee41","gfx_unittests":"22bbdc4adde2babcc6c27c315a0cb31c0ef0b212","gin_unittests":"41368ec0002cb9b0854cb1a885bef36f790dc28f","google_apis_unittests":"ae2cc359df0906442321624a96acf806cc0608c9","gpu_unittests":"0a1ac75026718483d5f0aa2b32ad0a5047a7e493","headless_browsertests":"8aa2052c7900a4a6f14b44e7178c2fafa8cbbec0","headless_unittests":"08c1f559fc9b8e4e3bd87b2aaed84010b5194e46","interactive_ui_tests":"24b2d82d9e960750e68a5e1bc3e96c44c1986020","ipc_tests":"99b914774158c3d5bde72cc4ffcdcd7391206843","jingle_unittests":"f333c8e935b97af43e86cd637aef5f9f41b4572c","latency_unittests":"63f8429c1eb946e7a93bbb783d88ebc64e352f98","leveldb_service_unittests":"3908e60445d19aed8b82c1aa35386180260c38c1","libjingle_xmpp_unittests":"bef958d3c692e4fe6d8db55667b5fb3f85f6115d","media_blink_unittests":"76ec2a6f25761967412e4d8b573ee8d9801668f0","media_service_unittests":"4c27b3e0dcc8a1aecc1eb9a493872f298b9d62f3","media_unittests":"dda63a42287d23751537e102c873ce0d3eb9b322","message_center_unittests":"67fb8e1e887ccd08093f07ef2a594c482f27db39","metrics_python_tests":"2056aa288e61169d34d413308effcb672d41de12","midi_unittests":"d6081d9a7feab799a19b6a50b6f61a2e8c89f9d8","mojo_unittests":"a773d2afd59ed81b17361f1a7ee4042acc894f15","nacl_loader_unittests":"3e40f69ae6aec168220ac92eff87ae218f59cf48","native_theme_unittests":"f33dfc9d1d6f888594f0bcaf4354774f63a7462a","net_unittests":"c7083f93fa5c3040909609bddd3bd91ef5a6c4c8","pdf_unittests":"9d83a505a29f9b35c59d2752550252f94ad941c0","ppapi_unittests":"ceb08137d4c2f88b914d42b01183eec057c1f920","printing_unittests":"ad475b01b7526c7af14c5a0191f40619ec844f35","remoting_unittests":"3797a5f00db6f8e0cace46894fb1dab5d626e247","sandbox_mac_unittests":"cff3c53e6970debc3045f44b5c5eadb4d71c555f","service_manager_unittests":"0ec5f2e34f74097dab566d130127f264a18f57e2","services_unittests":"e1fe73993efe09fbaf028c38d78396a9b45f4b7d","shell_dialogs_unittests":"1f9720407d36fc9a8f008c5888f2b6a410515140","skia_unittests":"c09d0c14d50da6b774b85702ec134c7c187f350a","snapshot_unittests":"4cfbd3d4c838b61902a85baab51115d589f13664","sql_unittests":"37f9c8a433f6bb325c0ba71237802f0883b63f60","storage_unittests":"ea51f69ecdd3a019ed597ebbaac547e3299805b9","sync_integration_tests":"54fd0b392cf1309da8f3ed7bfa12c06b14c5eaec","telemetry_gpu_unittests":"622a89a2bdf3526502f9bafd6cf854dc35947888","telemetry_perf_unittests":"edfffac29b59ce5de72d415a477f5c28ffe1ff9f","telemetry_unittests":"b1037d11911d6fc8c2a9580f1c3e708ee45d0b6b","ui_base_unittests":"bc882834e3e53d4b873a4e89999943fefb06ddd8","ui_touch_selection_unittests":"e30fa7bf2f7361d945ce72143720d49dbc516dc1","unit_tests":"3a786955e19281d22d890b0d5ee39f5f24d1fd46","url_unittests":"4b2abeb9a27f80cdb768787dbe627ba3ed53009a","views_perftests":"9bd281ed56112812c66e512fd740c13ff384f90c","views_unittests":"983661fe70a88470abe5c710376fff66b7da93cb","viz_unittests":"4b75ae95ede1d164d490f99b8dafa126652586e3","webkit_layout_tests_exparchive":"ca6ad9940a958ec0f2c4867bf77a01271a5c8e1d","webkit_python_tests":"6eef4ec15e90a92493b478d83036a64f28d6d87c","webkit_unit_tests":"711b4bb57bb60adb2e418189a456732d1f5637fc","wtf_unittests":"607d96fa3715ea26ff024f79ba3e416cd69b2161"} Annotation(find isolated tests)
swarm_hashes_refs/heads/master(at){#614447}_without_patch {"accessibility_unittests":"21be96c05425a338fe48869cd1d41eaf8c714853","angle_unittests":"7e52726fa8b7642c6c59c3a28ad19b907b2a9ad0","app_shell_unittests":"e25beaac283e66ad59229670bb9e2d264abec106","base_unittests":"0a4c85f03f1fb3108da2766adc407c568589d6d3","blink_common_unittests":"69eac1d9a89b467b939fc803d104405eb6a46e2c","blink_fuzzer_unittests":"f66b965b6443615d0483017e7e1a2eb198bb558d","blink_heap_unittests":"2ce9c74f7134169162a1ce0168a8744aab4bca51","blink_platform_unittests":"9b1ede4f1c048aa433dab97c9a16c92d6bb8132b","boringssl_crypto_tests":"b56b6d53e38cbe24f423c7207c1f86ef5de636b8","boringssl_ssl_tests":"1d7dac62123f53972fc73cb6187f28ffcad94a1f","browser_tests":"94fe7cbab3375ca8fc65d281ca69cce48eaa17ca","cacheinvalidation_unittests":"75a2cad39fe40ff895c3658a2819d0b440ea9cae","capture_unittests":"390b66994301869a23297ff4889f9efbce50529b","cast_unittests":"1e3a6ce4981b87fa0b50da9160dd0500bef9b75b","cc_unittests":"ddb8d25f271e27b08b0715e0ba9c21775e0a1833","chrome_app_unittests":"e49c8d63da041de8ef9139bc7edf33d5e3a7bb0f","chromedriver_py_tests":"7ba52cd5f5b7023165b647aa1b4908a1af79d101","chromedriver_replay_unittests":"2c79475fcfea940e6a9329f898a5d864d316a076","chromedriver_unittests":"c472bd43975a6bebf50b7fd666c257cfb2d5b332","components_browsertests":"c0f3877cddfeee8af1656253a18f6a5b95a4dac4","components_perftests":"87ee38f76ec9fa45b68acdb5f62320721c291e73","components_unittests":"3e0abec523089e2380a51f8efa8275adb08012f5","content_browsertests":"7ac13da53770d54a681866f6c4ca9d43d731f163","content_shell_crash_test":"83ba16c637c70ec3544a9dfbe5469f09b34a4b0e","content_unittests":"c65a2563e9d6ee919b950c3f9b9ae5ccc54f4bd2","crashpad_tests":"765a12cc463be36291c3a83c3d224d71f1bb210f","cronet_tests":"f9fc8fa573b86b5bccaab1fa29909ee6d94a34a6","cronet_unittests":"507747d95a1fb0192f5d5f9c16e7a7330f72c8f3","crypto_unittests":"5db77e25e5eed3df78af3da4f5679b7ed513ba2e","device_unittests":"d4965621644051555afa4ce74077c14cae03b04e","display_unittests":"e12f44ea13071f322ecf54b8f46e74db1f077618","events_unittests":"2ecfd055c58f75cb853951c279c863faf6c1dc24","extensions_browsertests":"3e40512269af5cb986ee81eca167120e7493edab","extensions_unittests":"c4e787171f07a7e05552b0643de95f20c53bc30c","filesystem_service_unittests":"0dc6656b568ecc38e6aac9149813046552bbd2e6","gcm_unit_tests":"3dbf9dd1e7e7da5a70fbe84fce8be0e1e6daee41","gfx_unittests":"22bbdc4adde2babcc6c27c315a0cb31c0ef0b212","gin_unittests":"41368ec0002cb9b0854cb1a885bef36f790dc28f","google_apis_unittests":"ae2cc359df0906442321624a96acf806cc0608c9","gpu_unittests":"0a1ac75026718483d5f0aa2b32ad0a5047a7e493","headless_browsertests":"8aa2052c7900a4a6f14b44e7178c2fafa8cbbec0","headless_unittests":"08c1f559fc9b8e4e3bd87b2aaed84010b5194e46","interactive_ui_tests":"24b2d82d9e960750e68a5e1bc3e96c44c1986020","ipc_tests":"99b914774158c3d5bde72cc4ffcdcd7391206843","jingle_unittests":"f333c8e935b97af43e86cd637aef5f9f41b4572c","latency_unittests":"63f8429c1eb946e7a93bbb783d88ebc64e352f98","leveldb_service_unittests":"3908e60445d19aed8b82c1aa35386180260c38c1","libjingle_xmpp_unittests":"bef958d3c692e4fe6d8db55667b5fb3f85f6115d","media_blink_unittests":"76ec2a6f25761967412e4d8b573ee8d9801668f0","media_service_unittests":"4c27b3e0dcc8a1aecc1eb9a493872f298b9d62f3","media_unittests":"dda63a42287d23751537e102c873ce0d3eb9b322","message_center_unittests":"67fb8e1e887ccd08093f07ef2a594c482f27db39","metrics_python_tests":"2056aa288e61169d34d413308effcb672d41de12","midi_unittests":"d6081d9a7feab799a19b6a50b6f61a2e8c89f9d8","mojo_unittests":"a773d2afd59ed81b17361f1a7ee4042acc894f15","nacl_loader_unittests":"3e40f69ae6aec168220ac92eff87ae218f59cf48","native_theme_unittests":"f33dfc9d1d6f888594f0bcaf4354774f63a7462a","net_unittests":"c7083f93fa5c3040909609bddd3bd91ef5a6c4c8","pdf_unittests":"9d83a505a29f9b35c59d2752550252f94ad941c0","ppapi_unittests":"ceb08137d4c2f88b914d42b01183eec057c1f920","printing_unittests":"ad475b01b7526c7af14c5a0191f40619ec844f35","remoting_unittests":"3797a5f00db6f8e0cace46894fb1dab5d626e247","sandbox_mac_unittests":"cff3c53e6970debc3045f44b5c5eadb4d71c555f","service_manager_unittests":"0ec5f2e34f74097dab566d130127f264a18f57e2","services_unittests":"e1fe73993efe09fbaf028c38d78396a9b45f4b7d","shell_dialogs_unittests":"1f9720407d36fc9a8f008c5888f2b6a410515140","skia_unittests":"c09d0c14d50da6b774b85702ec134c7c187f350a","snapshot_unittests":"4cfbd3d4c838b61902a85baab51115d589f13664","sql_unittests":"37f9c8a433f6bb325c0ba71237802f0883b63f60","storage_unittests":"ea51f69ecdd3a019ed597ebbaac547e3299805b9","sync_integration_tests":"54fd0b392cf1309da8f3ed7bfa12c06b14c5eaec","telemetry_gpu_unittests":"622a89a2bdf3526502f9bafd6cf854dc35947888","telemetry_perf_unittests":"edfffac29b59ce5de72d415a477f5c28ffe1ff9f","telemetry_unittests":"b1037d11911d6fc8c2a9580f1c3e708ee45d0b6b","ui_base_unittests":"bc882834e3e53d4b873a4e89999943fefb06ddd8","ui_touch_selection_unittests":"e30fa7bf2f7361d945ce72143720d49dbc516dc1","unit_tests":"3a786955e19281d22d890b0d5ee39f5f24d1fd46","url_unittests":"4b2abeb9a27f80cdb768787dbe627ba3ed53009a","views_perftests":"9bd281ed56112812c66e512fd740c13ff384f90c","views_unittests":"983661fe70a88470abe5c710376fff66b7da93cb","viz_unittests":"4b75ae95ede1d164d490f99b8dafa126652586e3","webkit_layout_tests_exparchive":"ca6ad9940a958ec0f2c4867bf77a01271a5c8e1d","webkit_python_tests":"6eef4ec15e90a92493b478d83036a64f28d6d87c","webkit_unit_tests":"711b4bb57bb60adb2e418189a456732d1f5637fc","wtf_unittests":"607d96fa3715ea26ff024f79ba3e416cd69b2161"} Annotation(isolate tests)
build_data_dir "/b/rr/tmpX8OWSY" Annotation(steps)
build_id "buildbot/chromium.clang/ToTMac/2444" Annotation(steps)
builder_id "master.chromium.clang:ToTMac" Annotation(steps)
blamelist ["3su6n15k.default@developer.gserviceaccount.com","abenner@google.com","acostinas@google.com","agrieve@chromium.org","alexclarke@chromium.org","anastasi@google.com","andrewxu@chromium.org","andruud@chromium.org","anthonyvd@chromium.org","arbesser@google.com","bialpio@chromium.org","billorr@chromium.org","bsazonov@chromium.org","carlscab@google.com","cduvall@chromium.org","chromium-autoroll@skia-public.iam.gserviceaccount.com","chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com","chuanl@google.com","cmp@chromium.org","dbatyai@inf.u-szeged.hu","djean@google.com","dominickn@chromium.org","droger@chromium.org","ellyjones@chromium.org","erikchen@chromium.org","etiennep@chromium.org","eugenebut@google.com","fhorschig@chromium.org","grunell@chromium.org","guidou@chromium.org","harringtond@chromium.org","hinoka@chromium.org","hongchan@chromium.org","huanzhong@google.com","ikilpatrick@chromium.org","ios-autoroller@chromium.org","jbroman@chromium.org","jdoerrie@chromium.org","jonross@chromium.org","jperaza@chromium.org","juncai@chromium.org","junho0924.seo@lge.com","jyasskin@chromium.org","kdillon@chromium.org","kkhorimoto@chromium.org","kmackay@chromium.org","kmilka@chromium.org","kuznetsovs@yandex-team.ru","luoe@chromium.org","mamir@chromium.org","masonfreed@chromium.org","mlamouri@chromium.org","mmoroz@chromium.org","mrsuyi@chromium.org","mukai@chromium.org","nednguyen@google.com","nektar@chromium.org","newcomer@chromium.org","nhiroki@chromium.org","noel@chromium.org","npm@chromium.org","penghuang@chromium.org","raphael.kubo.da.costa@intel.com","reed@google.com","reillyg@chromium.org","rkgibson@google.com","rogerm@chromium.org","sebsg@chromium.org","sinhak@chromium.org","sky@chromium.org","smaier@chromium.org","stevenjb@chromium.org","szermatt@chromium.org","tikuta@chromium.org","tkent@chromium.org","tonikitoo@igalia.com","twellington@chromium.org","vmpstr@chromium.org","wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com","xidachen@chromium.org","xiyuan@chromium.org","yhirano@chromium.org","yigu@chromium.org"] Build
branch "master" Build
buildnumber 2444 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src.git" Build
requestedAt 1544094977 Build
revision "79b4157706b6b2d702d4a431efe3e16a4d72bfc2" Build
slavename "build98-m1" BuildSlave
buildername "ToTMac" Builder
git_revision "79b4157706b6b2d702d4a431efe3e16a4d72bfc2" Change
scheduler "chromium_src_commits" Scheduler
buildbotURL "https://build.chromium.org/p/chromium.clang/" master.cfg
mastername "chromium.clang" master.cfg
workdir "/b/build/slave/ToTMac" slave

Blamelist:

  1. (rkgibsonohnoyoudont@google.com)
  2. (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  3. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  4. (dbatyaiohnoyoudont@inf.u-szeged.hu)
  5. (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  6. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  7. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  8. (carlscabohnoyoudont@google.com)
  9. (alexclarkeohnoyoudont@chromium.org)
  10. (drogerohnoyoudont@chromium.org)
  11. (huanzhongohnoyoudont@google.com)
  12. (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  13. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  14. (tonikitooohnoyoudont@igalia.com)
  15. (reedohnoyoudont@google.com)
  16. (alexclarkeohnoyoudont@chromium.org)
  17. (alexclarkeohnoyoudont@chromium.org)
  18. (erikchenohnoyoudont@chromium.org)
  19. (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  20. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  21. (tkentohnoyoudont@chromium.org)
  22. (alexclarkeohnoyoudont@chromium.org)
  23. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  24. (agrieveohnoyoudont@chromium.org)
  25. (fhorschigohnoyoudont@chromium.org)
  26. (yhiranoohnoyoudont@chromium.org)
  27. (jbromanohnoyoudont@chromium.org)
  28. (junho0924.seoohnoyoudont@lge.com)
  29. (carlscabohnoyoudont@google.com)
  30. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  31. (chuanlohnoyoudont@google.com)
  32. (3su6n15k.defaultohnoyoudont@developer.gserviceaccount.com)
  33. (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  34. (nhirokiohnoyoudont@chromium.org)
  35. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  36. (tikutaohnoyoudont@chromium.org)
  37. (dominicknohnoyoudont@chromium.org)
  38. (alexclarkeohnoyoudont@chromium.org)
  39. (agrieveohnoyoudont@chromium.org)
  40. (mrsuyiohnoyoudont@chromium.org)
  41. (acostinasohnoyoudont@google.com)
  42. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  43. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  44. (kuznetsovsohnoyoudont@yandex-team.ru)
  45. (raphael.kubo.da.costaohnoyoudont@intel.com)
  46. (tikutaohnoyoudont@chromium.org)
  47. (npmohnoyoudont@chromium.org)
  48. (raphael.kubo.da.costaohnoyoudont@intel.com)
  49. (noelohnoyoudont@chromium.org)
  50. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  51. (xiyuanohnoyoudont@chromium.org)
  52. (penghuangohnoyoudont@chromium.org)
  53. (yiguohnoyoudont@chromium.org)
  54. (arbesserohnoyoudont@google.com)
  55. (carlscabohnoyoudont@google.com)
  56. (carlscabohnoyoudont@google.com)
  57. (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  58. (jbromanohnoyoudont@chromium.org)
  59. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  60. (vmpstrohnoyoudont@chromium.org)
  61. (carlscabohnoyoudont@google.com)
  62. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  63. (mrsuyiohnoyoudont@chromium.org)
  64. (jdoerrieohnoyoudont@chromium.org)
  65. (andruudohnoyoudont@chromium.org)
  66. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  67. (tikutaohnoyoudont@chromium.org)
  68. (ellyjonesohnoyoudont@chromium.org)
  69. (tikutaohnoyoudont@chromium.org)
  70. (masonfreedohnoyoudont@chromium.org)
  71. (arbesserohnoyoudont@google.com)
  72. (anthonyvdohnoyoudont@chromium.org)
  73. (ellyjonesohnoyoudont@chromium.org)
  74. (harringtondohnoyoudont@chromium.org)
  75. (carlscabohnoyoudont@google.com)
  76. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  77. (rogermohnoyoudont@chromium.org)
  78. (guidouohnoyoudont@chromium.org)
  79. (xidachenohnoyoudont@chromium.org)
  80. (juncaiohnoyoudont@chromium.org)
  81. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  82. (djeanohnoyoudont@google.com)
  83. (nednguyenohnoyoudont@google.com)
  84. (grunellohnoyoudont@chromium.org)
  85. (sebsgohnoyoudont@chromium.org)
  86. (jonrossohnoyoudont@chromium.org)
  87. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  88. (stevenjbohnoyoudont@chromium.org)
  89. (bsazonovohnoyoudont@chromium.org)
  90. (szermattohnoyoudont@chromium.org)
  91. (smaierohnoyoudont@chromium.org)
  92. (kkhorimotoohnoyoudont@chromium.org)
  93. (ios-autorollerohnoyoudont@chromium.org)
  94. (eugenebutohnoyoudont@google.com)
  95. (mlamouriohnoyoudont@chromium.org)
  96. (mamirohnoyoudont@chromium.org)
  97. (andrewxuohnoyoudont@chromium.org)
  98. (etiennepohnoyoudont@chromium.org)
  99. (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  100. (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  101. (agrieveohnoyoudont@chromium.org)
  102. (sinhakohnoyoudont@chromium.org)
  103. (chuanlohnoyoudont@google.com)
  104. (bialpioohnoyoudont@chromium.org)
  105. (bsazonovohnoyoudont@chromium.org)
  106. (hinokaohnoyoudont@chromium.org)
  107. (skyohnoyoudont@chromium.org)
  108. (reillygohnoyoudont@chromium.org)
  109. (billorrohnoyoudont@chromium.org)
  110. (anastasiohnoyoudont@google.com)
  111. (luoeohnoyoudont@chromium.org)
  112. (hongchanohnoyoudont@chromium.org)
  113. (ikilpatrickohnoyoudont@chromium.org)
  114. (jperazaohnoyoudont@chromium.org)
  115. (twellingtonohnoyoudont@chromium.org)
  116. (newcomerohnoyoudont@chromium.org)
  117. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  118. (skyohnoyoudont@chromium.org)
  119. (kmilkaohnoyoudont@chromium.org)
  120. (etiennepohnoyoudont@chromium.org)
  121. (nektarohnoyoudont@chromium.org)
  122. (mukaiohnoyoudont@chromium.org)
  123. (juncaiohnoyoudont@chromium.org)
  124. (reillygohnoyoudont@chromium.org)
  125. (cmpohnoyoudont@chromium.org)
  126. (mmorozohnoyoudont@chromium.org)
  127. (jyasskinohnoyoudont@chromium.org)
  128. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  129. (cduvallohnoyoudont@chromium.org)
  130. (kdillonohnoyoudont@chromium.org)
  131. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  132. (abennerohnoyoudont@google.com)
  133. (jbromanohnoyoudont@chromium.org)
  134. (kmackayohnoyoudont@chromium.org)

Timing:

Create N/A
Start Thursday, 06-Dec-18 19:33:04 UTC
End Friday, 07-Dec-18 01:14:50 UTC
Pending N/A
Execution 5 hrs 41 mins

All Changes:

  1. [iOS] Disable omnibox drag on iPhone

    Changed by rkgibsonohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 11:14:49 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 4b3f8cea2710992c552785fa2a57097576acce3e

    Comments

    [iOS] Disable omnibox drag on iPhone
    
    This CL disables dragging text out of the omnibox on iPhone because
    there is nowhere to drag the text to.
    
    Bug: 834778
    Change-Id: Ic5c731b8c5400c40e7357c5ff25e5a8e45f3e544
    Reviewed-on: https://chromium-review.googlesource.com/c/1363194
    Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
    Commit-Queue: Robbie Gibson <rkgibson@google.com>
    Cr-Commit-Position: refs/heads/master@{#614314}

    Changed files

    • ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
  2. Import wpt@0347da3996b8eb6c4aef1104291efcc5d5356e6d

    Changed by wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 11:25:20 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 00c7d1a7ee854a01504eff67389ce6bf972fbb5b

    Comments

    Import wpt@0347da3996b8eb6c4aef1104291efcc5d5356e6d
    
    Using wpt-import in Chromium 8fea47aacf80c5e06dc7246a9b3673525cf14b62.
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    NOAUTOREVERT=true
    TBR=raphael.kubo.da.costa
    
    No-Export: true
    Change-Id: I1f6ad756eb6eafe1416332c08f6f9edd7b030f93
    Reviewed-on: https://chromium-review.googlesource.com/c/1365077
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614315}

    Changed files

    • third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
    • third_party/blink/web_tests/external/wpt/event-timing/idlharness.any-expected.txt
    • third_party/blink/web_tests/external/wpt/event-timing/idlharness.any.serviceworker-expected.txt
    • third_party/blink/web_tests/external/wpt/event-timing/idlharness.any.sharedworker-expected.txt
    • third_party/blink/web_tests/external/wpt/event-timing/idlharness.any.worker-expected.txt
    • third_party/blink/web_tests/external/wpt/interfaces/event-timing.idl
  3. Roll src/third_party/skia 6d59568196c0..7c4a9b7c7e0e (3 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 11:34:51 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision e853d5eefbfcfc22851ff8b2f11f669cfa657207

    Comments

    Roll src/third_party/skia 6d59568196c0..7c4a9b7c7e0e (3 commits)
    
    https://skia.googlesource.com/skia.git/+log/6d59568196c0..7c4a9b7c7e0e
    
    
    git log 6d59568196c0..7c4a9b7c7e0e --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset
    2018-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 96bd8fdf36e5..8f1b7a66a5e3 (3 commits)
    2018-12-06 herb@google.com Embed SkPath in SkGlyph::PathD
    ...skip...
    ;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jcgregorio@chromium.org
    
    Change-Id: I498a50fb1a2fc65424f50214ad9a19d1a004788c
    Reviewed-on: https://chromium-review.googlesource.com/c/1365171
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614316}

    Changed files

    • DEPS
  4. Enable gold linker for arm64 linux builds

    Changed by dbatyaiohnoyoudont@inf.u-szeged.hu
    Changed at Thursday, 06-Dec-18 11:42:00 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 55fbf5947b5c36906b186bed99b4d029f87d4df3

    Comments

    Enable gold linker for arm64 linux builds
    
    Arm64 builds for chromeos do not currently use gold when linking.
    This change enables gold, which results in smaller binary size.
    
    Bug: 878565
    Change-Id: I70f24490ac010ce58bcc6fd1441ade63288147ad
    Reviewed-on: https://chromium-review.googlesource.com/c/1341913
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Peter Gal <pgal.u-szeged@partner.samsung.com>
    Cr-Commit-Position: refs/heads/master@{#614317}

    Changed files

    • build/config/compiler/compiler.gni
  5. Roll src-internal ed9aa80dbd6e..ddbf9b06e56d (3 commits)

    Changed by chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 11:44:01 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision c3ab799cfe5c295341dd092769ec59df1d10b5e2

    Comments

    Roll src-internal ed9aa80dbd6e..ddbf9b06e56d (3 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ed9aa80dbd6e..ddbf9b06e56d
    
    
    Created with:
      gclient setdep -r src-internal@ddbf9b06e56d
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ib4c1d177947f216078337b7a96776a364e186e1e
    Reviewed-on: https://chromium-review.googlesource.com/c/1365491
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614318}

    Changed files

    • DEPS
  6. Roll src/third_party/webrtc c60a77731d68..518add35a8f3 (2 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 11:51:40 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 9578862335ad0c8697867c4e8a3aedce9746bd7d

    Comments

    Roll src/third_party/webrtc c60a77731d68..518add35a8f3 (2 commits)
    
    https://webrtc.googlesource.com/src.git/+log/c60a77731d68..518add35a8f3
    
    
    git log c60a77731d68..518add35a8f3 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 68c6b982a7..d6dec3971c (614157:614285)
    2018-12-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 48afe1fce1..68c6b982a7 (614046:614157)
    
    
    Created with:
      
    ...skip...
    omium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:None,chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: Ie8e88fd34dcfea01fdf9936668312881d8648d7e
    Reviewed-on: https://chromium-review.googlesource.com/c/1365490
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614319}

    Changed files

    • DEPS
  7. Roll src/third_party/catapult 924d5cbc6627..285509d0e41e (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 12:14:08 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 24c8eb2bc2374d9dbcbf8ba39a1ad61cdb2d92e4

    Comments

    Roll src/third_party/catapult 924d5cbc6627..285509d0e41e (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/924d5cbc6627..285509d0e41e
    
    
    git log 924d5cbc6627..285509d0e41e --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 dtu@chromium.org [pinpoint] Add cpython to CIPD packages for Swarming tasks.
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@285509d0e41e
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
    
    Documentation for the Auto
    ...skip...
    linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:911511
    TBR=sullivan@chromium.org
    
    Change-Id: If17883c4c319c61a837806e819bd0b6c4bdbee28
    Reviewed-on: https://chromium-review.googlesource.com/c/1365412
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614320}

    Changed files

    • DEPS
  8. Fix race in scheduler fuzzer

    Changed by carlscabohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 12:14:39 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 7333851526d00cee593ca114d3394f77236fcaf8

    Comments

    Fix race in scheduler fuzzer
    
    ThreadManager instances are created on the new thread and thus their
    thread_manager_ member might not be initialized when GetThreadManagerFor
    is called.
    
    This patch addresses that issue by having two different containers. One
    to keep track of threads and the other for keeping track of all the
    ThreadManager instances.
    
    This code could use some nice refactoring, this patch just tries to do
    the minimum changes to get rid of the race.
    
    Bug: 906468
    Change-Id: Ie39f5a6a18111248c4f83264f6adcdaef4befa23
    Reviewed-on: https://chromium-review.googlesource.com/c/1365442
    Commit-Queue: Carlos Caballero <carlscab@google.com>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614321}

    Changed files

    • third_party/blink/renderer/platform/scheduler/test/fuzzer/sequence_manager_fuzzer_processor.cc
    • third_party/blink/renderer/platform/scheduler/test/fuzzer/sequence_manager_fuzzer_processor_unittest.cc
    • third_party/blink/renderer/platform/scheduler/test/fuzzer/simple_thread_impl.cc
    • third_party/blink/renderer/platform/scheduler/test/fuzzer/simple_thread_impl.h
    • third_party/blink/renderer/platform/scheduler/test/fuzzer/thread_pool_manager.cc
    • third_party/blink/renderer/platform/scheduler/test/fuzzer/thread_pool_manager.h
  9. Deflake AddFirstWallpaperAnimationEndCallback test

    Changed by alexclarkeohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 12:18:48 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 82b82a8b8c4115741888bb0dfe3fcd439cff51e5

    Comments

    Deflake AddFirstWallpaperAnimationEndCallback test
    
    This test is currently flaky because it relies upon the ordering
    of delayed and non delayed tasks to quit a run loop before the
    very short (0.01s) animation delay is up. This patch deflakes it by
    temporarily freezing time to prevent the animation from
    completing before the test expects it to.
    
    TBR=wzang@chromium.org
    
    Bug: 863341, 891670, 910493
    Change-Id: I34cf2824c387c380134eb38b3375e6ab79de4be8
    Reviewed-on: https://chromium-review.googlesource.com/c/1365244
    Commit-Queue: Alex Clarke <alexclarke@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614322}

    Changed files

    • ash/wallpaper/wallpaper_controller_unittest.cc
  10. [signin] Delete DiceFixAuthErrors

    Changed by drogerohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 12:22:30 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 153707e1531f4233168575401a73ad4568ab5caa

    Comments

    [signin] Delete DiceFixAuthErrors
    
    This configuration is no longer enabled on any platforms.
    The code can now be removed.
    
    TBR=sky
    
    Bug: 777774
    Change-Id: Id92ef784e3ae933b21d96f8fd39deba1a4fa67a6
    Reviewed-on: https://chromium-review.googlesource.com/c/1355189
    Commit-Queue: David Roger <droger@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614323}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/extensions/api/identity/identity_api.cc
    • chrome/browser/extensions/api/identity/identity_api_unittest.cc
    • chrome/browser/signin/account_consistency_mode_manager.cc
    • chrome/browser/signin/account_consistency_mode_manager.h
    • chrome/browser/signin/account_consistency_mode_manager_unittest.cc
    • chrome/browser/signin/account_reconcilor_factory.cc
    • chrome/browser/signin/chrome_signin_helper_unittest.cc
    • chrome/browser/signin/dice_browsertest.cc
    • chrome/browser/signin/dice_response_handler.cc
    • chrome/browser/signin/dice_response_handler_unittest.cc
    • chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc
    • chrome/browser/signin/process_dice_header_delegate_impl.cc
    • chrome/browser/signin/process_dice_header_delegate_impl_unittest.cc
    • chrome/browser/signin/scoped_account_consistency.cc
    • chrome/browser/signin/scoped_account_consistency.h
    • chrome/browser/ui/views/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc
    • chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
    • chrome/browser/ui/webui/settings/people_handler_unittest.cc
    • components/signin/core/browser/about_signin_internals.cc
    • components/signin/core/browser/account_consistency_method.h
    • components/signin/core/browser/account_reconcilor_unittest.cc
    • components/signin/core/browser/dice_account_reconcilor_delegate.cc
    • components/signin/core/browser/dice_account_reconcilor_delegate_unittest.cc
    • components/signin/core/browser/dice_header_helper.cc
    • components/signin/core/browser/signin_header_helper_unittest.cc
  11. Update description of BrowsingDataCounter's |pref_|

    Changed by huanzhongohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 12:27:49 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision d45ef23cc4d0ce5a4cba1b1433c55e319cb2222a

    Comments

    Update description of BrowsingDataCounter's |pref_|
    
    Remove part of the description of BrowsingDataCounter's |pref_| that's no longer true and irrelevant.
    
    Bug: none
    Change-Id: Ibfb47522b33b5ca92f9e29191c79b7070d425e38
    Reviewed-on: https://chromium-review.googlesource.com/c/1358459
    Reviewed-by: Christian Dullweber <dullweber@chromium.org>
    Commit-Queue: Huanzhong Huang <huanzhong@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614324}

    Changed files

    • components/browsing_data/core/counters/browsing_data_counter.h
  12. Roll src-internal ddbf9b06e56d..eb2f2ad6ffdf (1 commits)

    Changed by chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 12:49:13 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 6b7b1e666839441d358ae9d6278f1bb51dc6731b

    Comments

    Roll src-internal ddbf9b06e56d..eb2f2ad6ffdf (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ddbf9b06e56d..eb2f2ad6ffdf
    
    
    Created with:
      gclient setdep -r src-internal@eb2f2ad6ffdf
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I641322947d4d0b62fb0cf79fc9ae43742fb6b51e
    Reviewed-on: https://chromium-review.googlesource.com/c/1365413
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614325}

    Changed files

    • DEPS
  13. Roll src/third_party/webrtc 518add35a8f3..fafae11bfc4c (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 13:04:06 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 345809a783fb9cf763ca8e46c49ff17d9cc56bcf

    Comments

    Roll src/third_party/webrtc 518add35a8f3..fafae11bfc4c (1 commits)
    
    https://webrtc.googlesource.com/src.git/+log/518add35a8f3..fafae11bfc4c
    
    
    git log 518add35a8f3..fafae11bfc4c --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 terelius@webrtc.org Allow parsing RTC event logs without a transaction ID.
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@fafae11bfc4c
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller
    ...skip...
    ary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I2becf74e5f60f900df64e46c4e9a20b4e5603999
    Reviewed-on: https://chromium-review.googlesource.com/c/1365414
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614326}

    Changed files

    • DEPS
  14. [s13n] Convert account_reconcilor_unittest.cc to IdentityManager

    Changed by tonikitooohnoyoudont@igalia.com
    Changed at Thursday, 06-Dec-18 13:09:06 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 0d46e46ee383877ad62974bf266d5bbc96c2f056

    Comments

    [s13n] Convert account_reconcilor_unittest.cc to IdentityManager
    
    This CL migrates (most of) account_reconcilor_unittest.cc code
    away from SigninManager and PO2TS.
    Production code was migrated and unit tests were minimally updated
    to keep running in [1].
    
    Remarks:
    - The CL can completely remove SigninManager direct API calls.
    - The CL could not completely remove direct PO2TS API calls, due to two
    missing API: set_all_credentials_loaded_for_testing and LoadCredentials.
    - Given how the test uses gaia_id
    ...skip...
    nce, the following methods were added/
    used:
    
    * GaiaIdForAccountKey: Added.
    * identity::GetTestGaiaIdForEmail: Referenced.
    
    [1] https://chromium-review.googlesource.com/c/1330223
    
    BUG=910581
    
    Change-Id: I58db6044caa22b6072cb6d22dd7c97c668c46cd3
    Reviewed-on: https://chromium-review.googlesource.com/c/1357059
    Reviewed-by: David Roger <droger@chromium.org>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#614327}

    Changed files

    • components/signin/core/browser/account_reconcilor_unittest.cc
  15. use SkFont for measure and break text

    Changed by reedohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 13:09:16 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 15ec682801537617ba819e09336399a51e45bf82

    Comments

    use SkFont for measure and break text
    
    TBR=
    
    Bug: skia:2664
    Change-Id: Idf2e2d1c4eefd295d4262a0b49542c83119f639f
    Reviewed-on: https://chromium-review.googlesource.com/c/1363212
    Commit-Queue: Mike Reed <reed@google.com>
    Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614328}

    Changed files

    • cc/layers/heads_up_display_layer_impl.cc
    • media/blink/webmediaplayer_cast_android.cc
  16. Change interleaving of delayed and immediate tasks to match MessageLoop

    Changed by alexclarkeohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 13:20:50 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision dda57a2c6aa319675172f8558ce8c24d9333f894

    Comments

    Change interleaving of delayed and immediate tasks to match MessageLoop
    
    Previously the TaskQueueSelector would allow up to 3 delayed tasks to
    run for every immediate task if both where ready to run.  This patch
    changes it to a 1:1 ratio like the MessageLoop.  NB neither the
    SequenceManager nor the MessageLoop allow delayed tasks to skip ahead
    of immediate tasks.
    
    In addition I've removed the PrioritizingSelector inner class which makes
    the code a bit more readable.  In addition based on review comments I
    changed the style of functions to return a pointer to the WorkQueue or
    null rather than a bool. This in general improves readability.
    
    Bug: 863341, 891670
    Change-Id: I61d4f118880f109c01ad4a2d5301acc9103b0b35
    Reviewed-on: https://chromium-review.googlesource.com/c/1361103
    Commit-Queue: Alex Clarke <alexclarke@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614329}

    Changed files

    • base/task/sequence_manager/sequence_manager_impl.cc
    • base/task/sequence_manager/sequence_manager_impl.h
    • base/task/sequence_manager/sequence_manager_impl_unittest.cc
    • base/task/sequence_manager/task_queue_selector.cc
    • base/task/sequence_manager/task_queue_selector.h
    • base/task/sequence_manager/task_queue_selector_unittest.cc
    • base/task/sequence_manager/work_queue_sets.cc
    • base/task/sequence_manager/work_queue_sets.h
    • base/task/sequence_manager/work_queue_sets_unittest.cc
    • base/task/sequence_manager/work_queue_unittest.cc
    • third_party/blink/web_tests/http/tests/devtools/sources/debugger/debugger-scope-resolve-this-expected.txt
  17. SequenceManagerImpl::IsIdleForTesting to match MessageLoop behavior

    Changed by alexclarkeohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 13:22:23 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 1dc884dc9ff9b74841192d420479197f80c3ac9c

    Comments

    SequenceManagerImpl::IsIdleForTesting to match MessageLoop behavior
    
    The MessageLoop version of IsIdleForTesting does not take Now() into
    account, but the SequenceManager version was.  This is a mistake
    because its flaky when there are delayed tasks that are just about
    to run.
    
    TBR=fdoray@chromium.org
    
    Bug: 910645, 863341, 891670
    Change-Id: Ieaf5e534df0f553046b76fa844f61e4a268082f9
    Reviewed-on: https://chromium-review.googlesource.com/c/1365233
    Reviewed-by: Alex Clarke <alexclarke@chromium.org>
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Commit-Queue: Alex Clarke <alexclarke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614330}

    Changed files

    • base/message_loop/message_loop_unittest.cc
    • base/task/sequence_manager/sequence_manager.h
    • base/task/sequence_manager/sequence_manager_impl.cc
  18. Require that .pak files are successfully loaded.

    Changed by erikchenohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 13:26:55 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision a706d62ed54b601a3527b61a7f89b17564c262e0

    Comments

    Require that .pak files are successfully loaded.
    
    Several test suites relied on the common resources .pak being unsuccessfully
    loaded in order to function correctly. On Android, .pak files can leak between
    successive runs of different test suites, which would cause flaky test failures.
    This CL makes it so that failing to load the common resources .pak file will hit
    a DCHECK. This CL fixes several instances where test suites were incorrectly
    trying to load [and failing to load] the common resources .pak file.
    
    Change-Id: I5294f921e42524b699c7019b7a56c0a30106c89c
    Bug: 906587
    Reviewed-on: https://chromium-review.googlesource.com/c/1363447
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614331}

    Changed files

    • components/ntp_tiles/icon_cacher_impl_unittest.cc
    • ui/base/resource/resource_bundle_android.cc
    • ui/base/test/run_all_unittests.cc
  19. Roll src-internal eb2f2ad6ffdf..8807e6de3a17 (1 commits)

    Changed by chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 13:53:50 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 37a6700f01fadc319384c011beb86db7515ade14

    Comments

    Roll src-internal eb2f2ad6ffdf..8807e6de3a17 (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eb2f2ad6ffdf..8807e6de3a17
    
    
    Created with:
      gclient setdep -r src-internal@8807e6de3a17
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ia5bde08c98963dcef9b75753e08be31595dac2af
    Reviewed-on: https://chromium-review.googlesource.com/c/1365416
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614332}

    Changed files

    • DEPS
  20. Roll src/third_party/perfetto c30ed73dd52a..659c1b009ec3 (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 14:08:40 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision b51a676e5e3d26f8d48ca9e6fb906f6dd88756ce

    Comments

    Roll src/third_party/perfetto c30ed73dd52a..659c1b009ec3 (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/c30ed73dd52a..659c1b009ec3
    
    
    git log c30ed73dd52a..659c1b009ec3 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 fmayer@google.com Merge "Bump libunwindstack version."
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@659c1b009ec3
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the 
    ...skip...
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I630fd97193f894a0e0cbe60330730e616ab39f65
    Reviewed-on: https://chromium-review.googlesource.com/c/1365415
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614333}

    Changed files

    • DEPS
  21. Form-associated custom elements: Fix missing validation bubble

    Changed by tkentohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 14:18:41 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 2e6eb70fa0fe55992e61f7b0dc3179f9cd844193

    Comments

    Form-associated custom elements: Fix missing validation bubble
    
    - Override validationMessage() and ValidationSubMessage() to return
      correct strings
    
    - ValidationMessaeClientImpl doesn't reject display:inline anchor
      elements.
    
    Bug: 905922
    Bug: https://github.com/w3c/webcomponents/issues/187
    Change-Id: Ie743d6018bb38f30db0b8624a6313519dd5737f4
    Reviewed-on: https://chromium-review.googlesource.com/c/1365108
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Reviewed-by: Keishi Hattori <keishi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614334}

    Changed files

    • third_party/blink/renderer/core/html/custom/element_internals.cc
    • third_party/blink/renderer/core/html/custom/element_internals.h
    • third_party/blink/renderer/core/page/validation_message_client_impl.cc
    • third_party/blink/web_tests/custom-elements/form-validation-bubble-appearance-expected.txt
    • third_party/blink/web_tests/custom-elements/form-validation-bubble-appearance.html
    • third_party/blink/web_tests/platform/linux/custom-elements/form-validation-bubble-appearance-expected.png
    • third_party/blink/web_tests/platform/mac-mac10.10/custom-elements/form-validation-bubble-appearance-expected.png
    • third_party/blink/web_tests/platform/mac-mac10.11/custom-elements/form-validation-bubble-appearance-expected.png
    • third_party/blink/web_tests/platform/mac-mac10.12/custom-elements/form-validation-bubble-appearance-expected.png
    • third_party/blink/web_tests/platform/mac/custom-elements/form-validation-bubble-appearance-expected.png
    • third_party/blink/web_tests/platform/win/custom-elements/form-validation-bubble-appearance-expected.png
    • third_party/blink/web_tests/platform/win7/custom-elements/form-validation-bubble-appearance-expected.png
  22. Deflake RenderWidgetHostViewMacTest.TimerBasedPhaseInfo

    Changed by alexclarkeohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 14:20:22 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 7b9d64e613231dffb7a26caf88dcaa909d0a4407

    Comments

    Deflake RenderWidgetHostViewMacTest.TimerBasedPhaseInfo
    
    This test relies on the ordering of delayed and non-delayed tasks
    which is a mistake. Changeing it to quit after all tasks have
    run makes it reliable.
    
    TBR=asvitkine@chromium.org
    
    Bug: 863341, 891670
    Change-Id: Id8dcbda9359a3adcf9688973457edf146d1d070f
    Reviewed-on: https://chromium-review.googlesource.com/c/1365447
    Commit-Queue: Alex Clarke <alexclarke@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614335}

    Changed files

    • content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
  23. Roll src/third_party/skia 7c4a9b7c7e0e..7b7ab595d908 (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 14:22:05 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 39e5800574050534d2b70aa6e7da7b010f57dfac

    Comments

    Roll src/third_party/skia 7c4a9b7c7e0e..7b7ab595d908 (1 commits)
    
    https://skia.googlesource.com/skia.git/+log/7c4a9b7c7e0e..7b7ab595d908
    
    
    git log 7c4a9b7c7e0e..7b7ab595d908 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 reed@google.com SkRunFont is gone, there is only SkFont
    
    
    Created with:
      gclient setdep -r src/third_party/skia@7b7ab595d908
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource
    ...skip...
    ;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jcgregorio@chromium.org
    
    Change-Id: Id40b7d9fe6a9513d6352c50b6624fa0e436fa3b5
    Reviewed-on: https://chromium-review.googlesource.com/c/1365417
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614336}

    Changed files

    • DEPS
  24. Android: Set strip_absolute_paths_from_debug_symbols=true by default

    Changed by agrieveohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 14:32:39 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 028bb8405dfce446318d32755e9649b127359091

    Comments

    Android: Set strip_absolute_paths_from_debug_symbols=true by default
    
    Supposed to improve goma cache hit rate. I found gdb debugging still
    works with it enabled.
    
    Bug: 439949
    Change-Id: Ia78ae57e5eb84fa8fb8bbb3c6bb15ea7814932bd
    Reviewed-on: https://chromium-review.googlesource.com/c/1364692
    Commit-Queue: agrieve <agrieve@chromium.org>
    Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614337}

    Changed files

    • build/config/compiler/BUILD.gn
  25. [Mfill Android] Wrap AccessorySheetTab data by type

    Changed by fhorschigohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 14:36:16 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision fb8587a0131ab38c4c17164c60edc2860e5ff063

    Comments

    [Mfill Android] Wrap AccessorySheetTab data by type
    
    This CL adds the new representation for tab data next to the existing
    one. This ensures that the old UI still works and the new UI is
    completely guarded by #autofill-keyboard-accessory-view.
    
    The actual drawing of the elements follows in crrev.com/c/1356547.
    
    Bug: 853772, 911084
    Change-Id: Ia38706aefb687fbe704b62307fa7d793a9b45c36
    Reviewed-on: https://chromium-review.googlesource.com/c/1350875
    Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
    Reviewed-by: Ioana Pandele <ioanap@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614338}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetMediator.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetProperties.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryViewTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryIntegrationTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingControllerTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetControllerTest.java
  26. Remove FetchContext::recordDataUriWithOctothorpe

    Changed by yhiranoohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 14:40:55 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision c7969a55cf2c0369dbcc3f409ee2cc5e84139d31

    Comments

    Remove FetchContext::recordDataUriWithOctothorpe
    
    Use FetchCountext::CountUsage instead.
    
    Bug: 123004
    Change-Id: I0809339a59bb6b3e29bf364923502af5c83a5f07
    Reviewed-on: https://chromium-review.googlesource.com/c/1364997
    Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
    Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614339}

    Changed files

    • third_party/blink/renderer/core/loader/frame_fetch_context.cc
    • third_party/blink/renderer/core/loader/frame_fetch_context.h
    • third_party/blink/renderer/platform/loader/fetch/fetch_context.h
    • third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
  27. Refactor the "is incremental marking" counter into an "entry flag" class.

    Changed by jbromanohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 14:43:24 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 12ea27e64fc74784c517bc88488503d064204143

    Comments

    Refactor the "is incremental marking" counter into an "entry flag" class.
    
    1. Switch to <atomic>, which is the future of atomics in Blink.
    
    2. Since this logic is subtle, it is factored out into a separate class
       with a verbose comment, explaining why its semantics are correct.
    
    3. Since the load didn't previously synchronize with the store, and the
       only requirement a thread has is that it sees its own writes (and the
       data doesn't become corrupt), std::memory_order_relaxed is used for
       all accesses.
    
    Bug: 736037
    Change-Id: I017da1ebfba3e95e5d0393014dc57fb4958bd6b1
    Reviewed-on: https://chromium-review.googlesource.com/c/1364151
    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Jeremy Roman <jbroman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614340}

    Changed files

    • third_party/blink/renderer/platform/heap/BUILD.gn
    • third_party/blink/renderer/platform/heap/atomic_entry_flag.h
    • third_party/blink/renderer/platform/heap/thread_state.cc
    • third_party/blink/renderer/platform/heap/thread_state.h
  28. Snav: Search inside focused scroll containers

    Changed by junho0924.seoohnoyoudont@lge.com
    Changed at Thursday, 06-Dec-18 14:43:43 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 0d17b741996e047d7aaf439dcb22ef7359e8f52b

    Comments

    Snav: Search inside focused scroll containers
    
    Previously, spatial navigation could not navigate inside a focused
    container. This change makes spatnav first search (or scroll) a
    focused scroll container, before searching outside of it:
    
    (1) Search for focusable elements inside any focused container.
    (2) If step (1) couldn't find a candidate, try to scroll the container.
    (3) If step (2) couldn't scroll, search for focusable elements outside
        the container.
    
    This follows the design document: https://bit.ly/snav2.
    
    Bug: 821297
    Change-Id: I81ab360dac5ee865e34c0f840378c9a637a8fe89
    Reviewed-on: https://chromium-review.googlesource.com/c/960185
    Commit-Queue: JunHo Seo <junho0924.seo@lge.com>
    Reviewed-by: Fredrik Söderquist <fs@opera.com>
    Reviewed-by: Hugo Holgersson <hugoh@vewd.com>
    Cr-Commit-Position: refs/heads/master@{#614341}

    Changed files

    • third_party/blink/renderer/core/page/focus_controller.cc
    • third_party/blink/web_tests/fast/spatial-navigation/resources/snav-testharness.js
    • third_party/blink/web_tests/fast/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html
    • third_party/blink/web_tests/fast/spatial-navigation/snav-dont-search-focused-offscreen-scroller.html
    • third_party/blink/web_tests/fast/spatial-navigation/snav-search-focused-scroller-first.html
  29. MockClock for ScopedTaskEnvironment

    Changed by carlscabohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 14:45:06 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision a6f990329d1059f1ae594ffbe6c70c46c10257a2

    Comments

    MockClock for ScopedTaskEnvironment
    
    Add the option to get a MockClock that is in sync with the underlying
    MockTickClock that ScopedTaskEnvironment uses. Some test need access to
    a base::Clock and ScopedTaskEnvironment currently just provides a
    MockTickClock.
    
    Need for this araised while refactoring
    components/ntp_snippets/breaking_news/breaking_news_gcm_app_handler_unittest.cc
    to use ScopedTaskEnvironment instead of MessageLoop.
    
    Bug: 891670
    Change-Id: I0716dbe2b46e268dfe57bed7c667d275f62519af
    Reviewed-on: https://chromium-review.googlesource.com/c/1356553
    Commit-Queue: Carlos Caballero <carlscab@google.com>
    Reviewed-by: François Doray <fdoray@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614342}

    Changed files

    • base/test/scoped_task_environment.cc
    • base/test/scoped_task_environment.h
    • base/test/scoped_task_environment_unittest.cc
  30. Roll src/third_party/webrtc fafae11bfc4c..628f37a6fe24 (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 14:46:39 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 7c100291e910c399ebd733edf3b23ba1483c6843

    Comments

    Roll src/third_party/webrtc fafae11bfc4c..628f37a6fe24 (1 commits)
    
    https://webrtc.googlesource.com/src.git/+log/fafae11bfc4c..628f37a6fe24
    
    
    git log fafae11bfc4c..628f37a6fe24 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 hta@webrtc.org Delete a cricket::DtlsTransport when PC is closed
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@628f37a6fe24
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    
    ...skip...
    OTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:907849
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: Ie1e59d6a33a293fd29401a6f788a14412896c3cb
    Reviewed-on: https://chromium-review.googlesource.com/c/1365418
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614343}

    Changed files

    • DEPS
  31. Add host checking on module-managed URLs again a static host list.

    Changed by chuanlohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 14:50:25 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision ac56ab76f720b0ed9361f4976e6db1d13fb52853

    Comments

    Add host checking on module-managed URLs again a static host list.
    
    Besides checking hosts and paths against intent extras, this CL
    specifically checks for HTTPS scheme on module-managed URLs.
    CustomTabActivityTest is also updated to use HTTPS test server
    for all tests that are dynamic module related.
    
    This is guarded by the CCTModuleCustomHeader Finch feature.
    
    Bug: 882404
    Change-Id: I24d3e5b16762818ba330ad8f9c0f030eaf9d82e9
    Reviewed-on: https://chromium-review.googlesource.com/c/1361065
    Commit-Queue: John Lin <chuanl@google.com>
    Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
    Reviewed-by: Robert Sesek <rsesek@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614344}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsDynamicModuleTestUtils.java
  32. Automated Commit: LKGM 11355.0.0 for chromeos.

    Changed by 3su6n15k.defaultohnoyoudont@developer.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 14:52:47 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 043caffb8b4e36858d3f4da8762f092cec06b3a6

    Comments

    Automated Commit: LKGM 11355.0.0 for chromeos.
    
    BUG=762641
    TBR=stevenjb@chromium.org
    
    Change-Id: I2d05b9f382d1b86bf0aebf1b8418417f062d759e
    Reviewed-on: https://chromium-review.googlesource.com/c/1365550
    Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
    Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614345}

    Changed files

    • chromeos/CHROMEOS_LKGM
  33. Roll src-internal 8807e6de3a17..44685896babc (2 commits)

    Changed by chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 14:53:16 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 5c97bac91ae2029a5ad29114325f796b7888fdc0

    Comments

    Roll src-internal 8807e6de3a17..44685896babc (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8807e6de3a17..44685896babc
    
    
    Created with:
      gclient setdep -r src-internal@44685896babc
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: If1245f560fc46b4b68ad7243540bdeaaf2b309ad
    Reviewed-on: https://chromium-review.googlesource.com/c/1365420
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614346}

    Changed files

    • DEPS
  34. Worker: Move shared_worker_connector.mojom from content/ to blink/ (Onion Soup)

    Changed by nhirokiohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 14:55:38 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 0e677766dedb2399fee8e8f3676eb1b2fc8b8953

    Comments

    Worker: Move shared_worker_connector.mojom from content/ to blink/ (Onion Soup)
    
    Bug: 911415
    Change-Id: Ifab02f8eccba1f2501400150d9aa563e88f44ac8
    Reviewed-on: https://chromium-review.googlesource.com/c/1365105
    Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614347}

    Changed files

    • content/browser/worker_host/shared_worker_connector_impl.cc
    • content/browser/worker_host/shared_worker_connector_impl.h
    • content/browser/worker_host/shared_worker_service_impl.h
    • content/browser/worker_host/shared_worker_service_impl_unittest.cc
    • content/common/BUILD.gn
    • content/public/app/mojo/content_browser_manifest.json
    • content/renderer/shared_worker/shared_worker_repository.h
    • third_party/blink/public/mojom/BUILD.gn
    • third_party/blink/public/mojom/worker/shared_worker_connector.mojom
    • tools/metrics/histograms/enums.xml
  35. Roll src/third_party/chromite d138913917ce..71928dd258ca (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 14:57:57 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 9b3c027024066455b2eac2cff1e5d970d2bb2fea

    Comments

    Roll src/third_party/chromite d138913917ce..71928dd258ca (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/d138913917ce..71928dd258ca
    
    
    git log d138913917ce..71928dd258ca --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 dhanyaganesh@chromium.org lib/cidb.py: Delete functions used in bad_cl_detector
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@71928dd258ca
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Doc
    ...skip...
    oll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: Ice83d4eef69c02fcd84486fabe2d28c58eed7cd7
    Reviewed-on: https://chromium-review.googlesource.com/c/1365419
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614348}

    Changed files

    • DEPS
  36. [swarming] use var for luci-go CIPD package version

    Changed by tikutaohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 14:58:11 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 409e0ff6a1064ec2a2784407d6439396729d9ff1

    Comments

    [swarming] use var for luci-go CIPD package version
    
    This is to simplify DEPS and enforce to use the same revision for each luci-go
    client.
    
    Change-Id: Ibb642840e09fe83f8736dbf86ab73f00154b0843
    Reviewed-on: https://chromium-review.googlesource.com/c/1364998
    Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
    Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614349}

    Changed files

    • DEPS
  37. Add a debug flag for the WebApkValidator to cut down logcat spam.

    Changed by dominicknohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 15:05:17 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 39c9b8c6af3aaa4aeb398959f263193b0263f8bf

    Comments

    Add a debug flag for the WebApkValidator to cut down logcat spam.
    
    BUG=None
    
    Change-Id: Ie6bcdd0b88fd32f8416871f58381cd88f2b6e234
    Reviewed-on: https://chromium-review.googlesource.com/c/1364650
    Commit-Queue: Xi Han <hanxi@chromium.org>
    Reviewed-by: Xi Han <hanxi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614350}

    Changed files

    • chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java
  38. Deflake WebMediaPlayerMSTest.RotationChange

    Changed by alexclarkeohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 15:05:38 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision dbb7308e7bcc0053dca3104f3306ce64a34085a3

    Comments

    Deflake WebMediaPlayerMSTest.RotationChange
    
    This test currently relies upon the exact ordering of RenderFrame,
    InjectFrame and CheckForFrameChanges, which is a mix of delayed and
    immediate tasks. The scheduler doesn't guarantee the exact ordering
    of these which causes this test to flake.  We add some extra
    RunLoop().RunUntilIdle() calls to ensure CheckForFrameChanges has
    a chance to run.
    
    TBR=miu@chromium.org
    
    Bug: 863341, 891670
    Change-Id: I526d6b77f6ce46f04d84584f5daba096ef1a98e5
    Reviewed-on: https://chromium-review.googlesource.com/c/1365248
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Reviewed-by: Alex Clarke <alexclarke@chromium.org>
    Commit-Queue: Alex Clarke <alexclarke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614351}

    Changed files

    • content/renderer/media/stream/webmediaplayer_ms_unittest.cc
  39. Android: Don't bother creating .srcjar for generated chrome version file

    Changed by agrieveohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 15:07:05 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision a52806d08dd7e18975257e131b8a1528c5a116ba

    Comments

    Android: Don't bother creating .srcjar for generated chrome version file
    
    Bug: 908479
    Change-Id: I6b6d50319143a5b4135c446d7723d6a70fc3fecc
    Reviewed-on: https://chromium-review.googlesource.com/c/1364610
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Commit-Queue: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614352}

    Changed files

    • chrome/android/BUILD.gn
  40. Remove highlight delay for FindInPage results out of screen.

    Changed by mrsuyiohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 15:10:19 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 40735d1fe4a48f42b6ec7b71dcaa92c3f04a095f

    Comments

    Remove highlight delay for FindInPage results out of screen.
    
    In current implementation of find_in_page.js, when user navigates to a
    match result out of the screen, the orange highlight will be added to it
    with a 250ms delay. In previous version, the callback invoked after
    250ms will always add orange highlight to the current selected match
    result, and the CL(http://crrev/c/1347363) accidently changed the logic
    and created a bug. If user clicks "goNext" fast enough, selected match
    result may get highl
    ...skip...
    ee the comments in old version code). Then the
    scrolling work moved from Js into OC, so there are two lines about
    scrolling that are commented out.
    
    Since UX has also confirmed that delay on highlight is not necessary, it
    should be removed now.
    
    Bug: 911611
    Change-Id: If0fef219b33954e243e527f3b50dbe836f753ede
    Reviewed-on: https://chromium-review.googlesource.com/c/1365610
    Reviewed-by: Peter Lee <pkl@chromium.org>
    Commit-Queue: Yi Su <mrsuyi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614353}

    Changed files

    • ios/chrome/browser/find_in_page/resources/find_in_page.js
  41. Run tests when policy_test_cases.json changes

    Changed by acostinasohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 15:12:46 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 0c940428a52570c147124aed3eb41f080e9a5be6

    Comments

    Run tests when policy_test_cases.json changes
    
    BUG=498579
    
    Change-Id: I0ef207bbcf210de686902b2248f4e0c96453b707
    Reviewed-on: https://chromium-review.googlesource.com/c/1365236
    Commit-Queue: Andreea-Elena Costinas <acostinas@google.com>
    Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614354}

    Changed files

    • chrome/test/data/policy/PRESUBMIT.py
    • components/policy/resources/PRESUBMIT.py
  42. Roll src/third_party/perfetto 659c1b009ec3..f6a1cb2d8968 (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 15:12:50 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision dc4e8d2d0fefe947d4dd4456a96c76d6dfc0a8ad

    Comments

    Roll src/third_party/perfetto 659c1b009ec3..f6a1cb2d8968 (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/659c1b009ec3..f6a1cb2d8968
    
    
    git log 659c1b009ec3..f6a1cb2d8968 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 lalitm@google.com Merge "trace_processor: speed up args table even more"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@f6a1cb2d8968
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Docu
    ...skip...
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: Iefd01cf34bed9c2c688570386aa10a75fdaa45f4
    Reviewed-on: https://chromium-review.googlesource.com/c/1365421
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614355}

    Changed files

    • DEPS
  43. Roll src/third_party/SPIRV-Tools/src 03afee3b9081..2e4563d94f9d (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 15:14:00 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision c5413cf5e311b79d1ba90bb3f69ab0ec5bd52d14

    Comments

    Roll src/third_party/SPIRV-Tools/src 03afee3b9081..2e4563d94f9d (1 commits)
    
    https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/03afee3b9081..2e4563d94f9d
    
    
    git log 03afee3b9081..2e4563d94f9d --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 stevenperron@google.com Document in the context what happens with id overflow. (#2159)
    
    
    Created with:
      gclient setdep -r src/third_party/SPIRV-Tools/src@2e4563d94f9d
    
    The AutoRoll server is located here: https://autor
    ...skip...
    
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I3d9b965d9a72ca7f3180c5a14e4ed28a7ce905db
    Reviewed-on: https://chromium-review.googlesource.com/c/1365422
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614356}

    Changed files

    • DEPS
  44. Cleanup ContentClient and ContentBrowserClient.

    Changed by kuznetsovsohnoyoudont@yandex-team.ru
    Changed at Thursday, 06-Dec-18 15:14:18 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision d6f9ac554c7ac46b1401183b8925ca96327e2cf3

    Comments

    Cleanup ContentClient and ContentBrowserClient.
    
    Otherwise dangling pointers are leave - this can affect other
    tests. For example, if some test uses content::TestBrowserThreadBundle
    and runs after AndroidWebViewStateSerializerTest, this test will fail.
    
    Change-Id: Ic39f5e10a68a232ca2b3d58dcd21dc61bab29e43
    Reviewed-on: https://chromium-review.googlesource.com/c/1354445
    Commit-Queue: Bo <boliu@chromium.org>
    Reviewed-by: Bo <boliu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614357}

    Changed files

    • android_webview/browser/state_serializer_unittest.cc
  45. gpu_init: Stop inlining GpuInit::TakeDefaultOffscreenSurface()

    Changed by raphael.kubo.da.costaohnoyoudont@intel.com
    Changed at Thursday, 06-Dec-18 15:22:28 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 763b79a9142f3f063eca4504dc9a45b7e75e252f

    Comments

    gpu_init: Stop inlining GpuInit::TakeDefaultOffscreenSurface()
    
    This fixes the GCC build after commit b6ef3ba2a3 ("Pass GpuPreferences to
    in-process GPU in Mash"):
    
        In file included from ../../content/utility/utility_service_factory.h:12,
                         from ../../content/utility/utility_service_factory.cc:5:
        ../../base/memory/scoped_refptr.h: In instantiation of ‘static void scoped_refptr<T>::Release(T*) [with T = gl::GLSurface]’:
        ../../base/memory/scoped_refptr.h:208:14:   required
    ...skip...
    claration of ‘class gl::GLSurface’
         class GLSurface;
               ^~~~~~~~~
    
    gpu_init.h forward-declares gl::GLSurface but using std::move() with GCC
    seems to require a full declaration for things to work.
    
    Bug: 819294
    Change-Id: Ib22ca2f8af6977869571292acf780042507a8afd
    Reviewed-on: https://chromium-review.googlesource.com/c/1365249
    Reviewed-by: Jonathan Backer <backer@chromium.org>
    Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
    Cr-Commit-Position: refs/heads/master@{#614358}

    Changed files

    • gpu/ipc/service/gpu_init.cc
    • gpu/ipc/service/gpu_init.h
  46. [swarming] Remove non CIPD managed luci-go package

    Changed by tikutaohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 15:29:28 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision d5c1c0b4189d3e625d7e5a1c0568f255d911d5b6

    Comments

    [swarming] Remove non CIPD managed luci-go package
    
    Bug: 851596
    Change-Id: I834ccae440b5590525644e4ad9e9d3c952038547
    Reviewed-on: https://chromium-review.googlesource.com/c/1364976
    Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
    Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614359}

    Changed files

    • DEPS
    • tools/luci-go/.gitignore
    • tools/luci-go/linux64/isolate.sha1
    • tools/luci-go/mac64/isolate.sha1
    • tools/luci-go/win64/isolate.exe.sha1
  47. [EventTiming] Make PerformanceEventTiming Exposed=Window

    Changed by npmohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 15:33:01 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision fa0f7396931a4b55b3f8aba9de6345817a4fa081

    Comments

    [EventTiming] Make PerformanceEventTiming Exposed=Window
    
    This CL makes PerformanceEventTiming IDL consistent with the spec, after
    https://github.com/WICG/event-timing/pull/16. Note that EventCount is
    not yet implemented.
    
    Bug: 823744
    Change-Id: I01779ed82cba0cfea0542ab74cc95b4e7adc8aac
    Reviewed-on: https://chromium-review.googlesource.com/c/1363961
    Reviewed-by: Timothy Dresser <tdresser@chromium.org>
    Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614360}

    Changed files

    • third_party/blink/renderer/core/timing/performance_event_timing.idl
  48. Mark upcoming WPT media-source test as WontFix

    Changed by raphael.kubo.da.costaohnoyoudont@intel.com
    Changed at Thursday, 06-Dec-18 15:35:33 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 15bf688046abf6202ae6151e2459409060b9def6

    Comments

    Mark upcoming WPT media-source test as WontFix
    
    This test requires MP4 support in content_shell; that's not enabled by
    default and breaks WPT imports.
    
    TBR=chcunningham@chromium.org, wolenetz@chromium.org
    
    No-Try: true
    Change-Id: I3f176312cec46c8ef03dad5d40106c721b0f9723
    Reviewed-on: https://chromium-review.googlesource.com/c/1365613
    Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
    Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
    Cr-Commit-Position: refs/heads/master@{#614361}

    Changed files

    • third_party/blink/web_tests/NeverFixTests
  49. Closure compile list_thumbnail_loader_unittest

    Changed by noelohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 15:36:11 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 454a4f0cb9c837740bbb0bb1f07809728f98f4a6

    Comments

    Closure compile list_thumbnail_loader_unittest
    
     - remove list_thumbnail_loader_unittest.html
     - add BUILD rules to auto-generate and compile this unittest
     - add @types to the unittest vars
     - inline the canvas dataURL image creation step in Setup()
     - fix all Closure compiler errors
    
    No change in test behavior, no new tests.
    
    Bug: 912557
    Change-Id: I157b0c1ef56704901e760e6f5125e4e05ea76377
    Reviewed-on: https://chromium-review.googlesource.com/c/1364999
    Commit-Queue: Stuart Langley <slangley@chromium.org>
    Reviewed-by: Stuart Langley <slangley@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614362}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_jstest.cc
    • ui/file_manager/file_manager/foreground/js/BUILD.gn
    • ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.html
    • ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.js
  50. Roll src/third_party/skia 7b7ab595d908..b45d5124816e (2 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 15:46:47 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 57fc861db699982ad4c3aa3e0a509a1626cc6146

    Comments

    Roll src/third_party/skia 7b7ab595d908..b45d5124816e (2 commits)
    
    https://skia.googlesource.com/skia.git/+log/7b7ab595d908..b45d5124816e
    
    
    git log 7b7ab595d908..b45d5124816e --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 halcanary@google.com bin/sysopen: script moved to bin
    2018-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 8f1b7a66a5e3..d300548fcc28 (1 commits)
    
    
    Created with:
      gclient setdep -r src/third_party/skia@b45d5124816e
    
    The AutoRoll se
    ...skip...
    ;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jcgregorio@chromium.org
    
    Change-Id: I3d2ffa675f1a4bc1a9509ab85ecb6c7b974dc5f9
    Reviewed-on: https://chromium-review.googlesource.com/c/1365423
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614363}

    Changed files

    • DEPS
  51. cros: Fix startup page focus

    Changed by xiyuanohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 15:52:16 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 2a66b11ee57844b24718b518f170706bc9242eab

    Comments

    cros: Fix startup page focus
    
    - Move RestoreFocus from BrowserView::Show to OnWidgetActivationChanged
      to do it when the browser window is activated;
    - Remove SetInitialFocus in SessionRestoreImpl::ShowBrowser since
      BrowserView change should do that as part of RestoreFocus;
    - Also remove the debugging code for SetInitialFocus crash
      under SessionRestoreImpl::RestoreTab since ShowBrowser no longer
      calls SetInitialFocus;
    
    Bug: 859257, 850626, 908524
    Change-Id: Ia24e4d68e1386de84765f914bb75319c9887dfd1
    Reviewed-on: https://chromium-review.googlesource.com/c/1313728
    Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
    Reviewed-by: Charlie Reis <creis@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614364}

    Changed files

    • chrome/browser/sessions/session_restore.cc
    • chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc
    • chrome/browser/ui/views/frame/browser_view.cc
    • chrome/browser/ui/views/frame/browser_view.h
    • chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc
    • chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
    • chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc
    • content/browser/web_contents/web_contents_impl.cc
    • content/browser/web_contents/web_contents_impl.h
  52. Fix SnapshotBrowserTest.AsyncMultiWindowTest for SkiaRenderer + DDL

    Changed by penghuangohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 15:52:45 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision b80c413d66b8cbc37db662ee9b141691b79c0eae

    Comments

    Fix SnapshotBrowserTest.AsyncMultiWindowTest for SkiaRenderer + DDL
    
    Bug: 911793
    Change-Id: I937e902d7e9ff7e046710558e48e4765b3ec06ee
    Reviewed-on: https://chromium-review.googlesource.com/c/1363864
    Reviewed-by: weiliangc <weiliangc@chromium.org>
    Commit-Queue: Peng Huang <penghuang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614365}

    Changed files

    • components/viz/service/display/direct_renderer.cc
    • components/viz/service/display/gl_renderer.cc
    • components/viz/service/display/skia_renderer.cc
  53. [cc] Fix incorrect KeyframeModel::InEffect() calculation on the cc side

    Changed by yiguohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:01:23 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision f22e0fbd1e6b06ff4d59faf95b2338f750fc0dac

    Comments

    [cc] Fix incorrect KeyframeModel::InEffect() calculation on the cc side
    
    By spec [1], an animation effect is "in effect" if its active time is
    not unresolved. However, if the effect is in the "after phase" and its
    fill mode is neither "forwards" nor "both", its active time should be
    unresolved which makes the effect not "in effect". Our cc logic doesn't
    handle this case correctly.
    
    This bug was not exposed because for regular animations we cancel the
    animation on compositor in such scenario. But for w
    ...skip...
    ulating phases and the corresponding
    active time based on the spec [2].
    
    [1] https://drafts.csswg.org/web-animations/#in-effect
    [2] https://drafts.csswg.org/web-animations/#active-time
    
    Bug: 906675
    Change-Id: I8872719432ede1eeeb1e7bdcf3b5f0312787c0d7
    Reviewed-on: https://chromium-review.googlesource.com/c/1342598
    Commit-Queue: Yi Gu <yigu@chromium.org>
    Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
    Reviewed-by: Majid Valipour <majidvp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614366}

    Changed files

    • cc/animation/keyframe_model.cc
    • cc/animation/keyframe_model.h
    • cc/animation/keyframe_model_unittest.cc
    • third_party/blink/web_tests/TestExpectations
    • third_party/blink/web_tests/animations/animationworklet/worklet-animation-local-time-after-duration.html
  54. [Autofill Assistant] Added terms&conditions link to the onboarding.

    Changed by arbesserohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 16:01:58 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision cd919f3f010e5b6de66e39935e9799217778cd5a

    Comments

    [Autofill Assistant] Added terms&conditions link to the onboarding.
    
    Note that this URL is currently under construction, the corresponding issue is here: b/120547988
    
    Bug: 806868
    Change-Id: Ic7ecf90682c392cbe7762ec451570e651e4f5f79
    Reviewed-on: https://chromium-review.googlesource.com/c/1365446
    Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
    Commit-Queue: Clemens Arbesser <arbesser@google.com>
    Cr-Commit-Position: refs/heads/master@{#614367}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/FirstRunScreen.java
    • chrome/android/java/strings/android_chrome_strings.grd
  55. [scheduling] Use ScopedTaskEnvironment instead of MessageLoop in reading_list

    Changed by carlscabohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 16:09:34 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 38b88b324987071d63453326c3eff948c64ac80c

    Comments

    [scheduling] Use ScopedTaskEnvironment instead of MessageLoop in reading_list
    
    MessageLoop will go away, eventually.
    
    BUG=891670
    
    Change-Id: I4525159fc6e326db0f77bd38a1a8cca63ae9ab28
    Reviewed-on: https://chromium-review.googlesource.com/c/1352764
    Commit-Queue: Carlos Caballero <carlscab@google.com>
    Reviewed-by: Eric Noyau <noyau@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614368}

    Changed files

    • components/reading_list/core/reading_list_store_unittest.cc
  56. [scheduling] Use ScopedTaskEnvironment instead of MessageLoop in subresource_filter

    Changed by carlscabohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 16:10:05 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision ad0f7767c18d3300fe7becde35058c50bf48ffd4

    Comments

    [scheduling] Use ScopedTaskEnvironment instead of MessageLoop in subresource_filter
    
    MessageLoop will go away, eventually.
    
    BUG=891670
    
    Change-Id: I3fcddf556b24d65f93a7d575093d89ab45e5e22e
    Reviewed-on: https://chromium-review.googlesource.com/c/1352783
    Reviewed-by: Dominic Battré <battre@chromium.org>
    Commit-Queue: Carlos Caballero <carlscab@google.com>
    Cr-Commit-Position: refs/heads/master@{#614369}

    Changed files

    • components/subresource_filter/content/browser/async_document_subresource_filter_unittest.cc
  57. Roll src-internal 44685896babc..3803956c4af7 (2 commits)

    Changed by chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 16:10:38 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision fcc9d76b468f3dae15a524e8b049732dde465850

    Comments

    Roll src-internal 44685896babc..3803956c4af7 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/44685896babc..3803956c4af7
    
    
    Created with:
      gclient setdep -r src-internal@3803956c4af7
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I62764da8eaf39f1e4804b1100243cd8038fa6046
    Reviewed-on: https://chromium-review.googlesource.com/c/1365426
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614370}

    Changed files

    • DEPS
  58. Move blink::InstanceCounters to use relaxed std::atomic, and add a warning comment.

    Changed by jbromanohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:12:39 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 63ff3ddea380122470a6633bb72be00c1b153e63

    Comments

    Move blink::InstanceCounters to use relaxed std::atomic, and add a warning comment.
    
    The comment is added because it is clearly tempting to rely on these counters
    to provide an accurate count of the number of instances that exist across threads,
    but that is not something that can be computed with atomics (which do not provide
    mutual exclusion).
    
    It doesn't appear that these atomics intend to synchronize any other memory access
    (and in fact in many cases are used only from a single thread).
    
    Bug: 736037
    Change-Id: I2372ae73878361024779aadb39a72983f4faa3bb
    Reviewed-on: https://chromium-review.googlesource.com/c/1355885
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Jeremy Roman <jbroman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614371}

    Changed files

    • third_party/blink/renderer/platform/instance_counters.cc
    • third_party/blink/renderer/platform/instance_counters.h
  59. Roll src/third_party/dawn bdd887fce76c..5aacd29d5e7e (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 16:14:54 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision df691e06ba773e8f2bd42f8020a96e303da324d1

    Comments

    Roll src/third_party/dawn bdd887fce76c..5aacd29d5e7e (1 commits)
    
    https://dawn.googlesource.com/dawn.git/+log/bdd887fce76c..5aacd29d5e7e
    
    
    git log bdd887fce76c..5aacd29d5e7e --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 cwallez@chromium.org ProcTable: only cast the return value if needed.
    
    
    Created with:
      gclient setdep -r src/third_party/dawn@5aacd29d5e7e
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    ht
    ...skip...
    OTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=cwallez@chromium.org
    
    Change-Id: I629fa6a92ef21293c055a467c0becb4c16cc13bb
    Reviewed-on: https://chromium-review.googlesource.com/c/1365424
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614372}

    Changed files

    • DEPS
  60. [DL] Don't immediately update the locked element frame rect.

    Changed by vmpstrohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:15:58 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 43a377d1697ac74ec5e45f739ee90becbcf253df

    Comments

    [DL] Don't immediately update the locked element frame rect.
    
    This patch ensures that we do layout in a pending frame rect, which is
    only put in place for children of the locked element during layout.
    
    After the promise is resolved, we put the pending frame rect as the
    active one and ensure that we relayout the previously locked box itself.
    
    This means that if the promise resolution, for example, removed the
    element as is the case in
    https://docs.google.com/document/d/1VrcVA5JyBmYn0Yi4wjPt1l9ce5Mhf-zu6o63p_mt98w/edit
    
    Then we never commit what was a pending layout and never see a flash
    of laid out content.
    
    R=chrishtr@chromium.org, mstensho@chromium.org
    
    Bug: 907613, 882663
    Change-Id: I7d03ae73ea4cb96c17ce8bb4162718155c2072be
    Reviewed-on: https://chromium-review.googlesource.com/c/1358969
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Commit-Queue: vmpstr <vmpstr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614373}

    Changed files

    • third_party/blink/renderer/core/display_lock/display_lock_context.cc
    • third_party/blink/renderer/core/display_lock/display_lock_context.h
    • third_party/blink/renderer/core/layout/layout_block.cc
    • third_party/blink/renderer/core/layout/layout_box.h
    • third_party/blink/renderer/core/layout/layout_object.h
    • third_party/blink/web_tests/display-lock/lock-before-append/measure-and-remove-expected.html
    • third_party/blink/web_tests/display-lock/lock-before-append/measure-and-remove.html
  61. [scheduling] Use ScopedTaskEnvironment instead of MessageLoop in unified_consent

    Changed by carlscabohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 16:16:56 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision b3860213db9788a157bb1ed7db2b13842aadb3e8

    Comments

    [scheduling] Use ScopedTaskEnvironment instead of MessageLoop in unified_consent
    
    MessageLoop will go away, eventually.
    
    BUG=891670
    
    Change-Id: Icbd30eb1886bb00105cd8ae5a8b158ffa9a397ea
    Reviewed-on: https://chromium-review.googlesource.com/c/1352427
    Reviewed-by: Thomas Tangl <tangltom@chromium.org>
    Commit-Queue: Carlos Caballero <carlscab@google.com>
    Cr-Commit-Position: refs/heads/master@{#614374}

    Changed files

    • components/unified_consent/unified_consent_service_unittest.cc
  62. Roll src/third_party/perfetto f6a1cb2d8968..06b4f7386a8c (4 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 16:19:28 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision d5132268fd2c639e018c94a217f8a1b858d45fac

    Comments

    Roll src/third_party/perfetto f6a1cb2d8968..06b4f7386a8c (4 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/f6a1cb2d8968..06b4f7386a8c
    
    
    git log f6a1cb2d8968..06b4f7386a8c --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 primiano@google.com Merge "Implement ftrace flushing"
    2018-12-06 eseckler@google.com Merge "tracing service: Verify target buffers specified in commit requests"
    2018-12-06 eseckler@google.com Merge "trace writer: Register/unregister on writer cr
    ...skip...
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: Idda6e5efcff897194b1a51547934631761a92561
    Reviewed-on: https://chromium-review.googlesource.com/c/1365427
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614375}

    Changed files

    • DEPS
  63. Trivial fix in PasswordDetailsTableViewController.

    Changed by mrsuyiohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:22:57 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 8f89c208303009df6334d2f961e7e5e5a4e6fcc7

    Comments

    Trivial fix in PasswordDetailsTableViewController.
    
    This CL changes the _weakDelegate of PasswordDetailsTableViewController
    from an instance var to a property, and replaces the mock class in
    PasswordDetailsTableViewControllerUnittest with OCMock.
    
    Bug: 894791
    Change-Id: I1cbb95e2f8aa3fb6befd3010040b0fe1ff4463d9
    Reviewed-on: https://chromium-review.googlesource.com/c/1361245
    Commit-Queue: Yi Su <mrsuyi@chromium.org>
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614376}

    Changed files

    • ios/chrome/browser/ui/settings/password_details_table_view_controller.mm
    • ios/chrome/browser/ui/settings/password_details_table_view_controller_unittest.mm
  64. [clang-tidy] Apply modernize-loop-convert in /base/i18n

    Changed by jdoerrieohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:32:02 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 812de1576d58185d036dc7483646b6b109d87e54

    Comments

    [clang-tidy] Apply modernize-loop-convert in /base/i18n
    
    This change applies clang-tidy's modernize-loop-convert [1] in /base/i18n.
    
    Reproduction steps:
    - run clang-tidy's modernize-loop-convert
    - run git cl format
    - manually remove unused constants due to -Wunused-const-variable
    
    [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-loop-convert.html
    
    This CL was uploaded by git cl split.
    
    R=jshin@chromium.org
    
    Bug: 895746
    Change-Id: I9b9790b60aaca3f6afb2b4bd1109d800aec5b26a
    Reviewed-on: https://chromium-review.googlesource.com/c/1282404
    Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Reviewed-by: Jungshik Shin <jshin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614377}

    Changed files

    • base/i18n/break_iterator_unittest.cc
    • base/i18n/build_utf8_validator_tables.cc
    • base/i18n/file_util_icu_unittest.cc
    • base/i18n/number_formatting_unittest.cc
    • base/i18n/rtl_unittest.cc
    • base/i18n/streaming_utf8_validator_perftest.cc
    • base/i18n/streaming_utf8_validator_unittest.cc
  65. [ribbon] Use CSSPropertyName when reifying in StyleValueFactory.

    Changed by andruudohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:34:38 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision bbede4251138524fef777d5b155fe9ae1b1e2915

    Comments

    [ribbon] Use CSSPropertyName when reifying in StyleValueFactory.
    
    Now that we have an object that can represent both native property names
    and custom property names, let's use it.
    
    Sidenote: the reification functions in StyleValueFactory can not take
    CSSProperty instances. This is because reification needs to happen on
    worklets, where we don't have the context of a Document (which again is
    needed to access the property registry).
    
    There should be no behavior change in this CL.
    
    Change-Id: I0d39a8e83628389699003bb7998548267635dffd
    Reviewed-on: https://chromium-review.googlesource.com/c/1361041
    Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
    Reviewed-by: Xida Chen <xidachen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614378}

    Changed files

    • third_party/blink/renderer/core/css/css_property_name.h
    • third_party/blink/renderer/core/css/css_property_name_test.cc
    • third_party/blink/renderer/core/css/cssom/style_property_map.cc
    • third_party/blink/renderer/core/css/cssom/style_property_map_read_only_main_thread.cc
    • third_party/blink/renderer/core/css/cssom/style_value_factory.cc
    • third_party/blink/renderer/core/css/cssom/style_value_factory.h
  66. Roll src/third_party/webrtc 628f37a6fe24..18f0c3c038fc (4 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 16:35:07 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision ebf220173e186b0fcc4798a1f4f089bffd440451

    Comments

    Roll src/third_party/webrtc 628f37a6fe24..18f0c3c038fc (4 commits)
    
    https://webrtc.googlesource.com/src.git/+log/628f37a6fe24..18f0c3c038fc
    
    
    git log 628f37a6fe24..18f0c3c038fc --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 solenberg@webrtc.org Add RegisterAudioSendPayload() method
    2018-12-06 nisse@webrtc.org Use opaque int as payload_type in MediaTransportInterface
    2018-12-06 artit@webrtc.org Fix iOS version for internal.client.webrtc perf test
    2018-12-06 terelius@webrtc.org Fix performanc
    ...skip...
    ary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: Ifbb867efd8a5e86d9623621b8f48610c342a9aa9
    Reviewed-on: https://chromium-review.googlesource.com/c/1365425
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614379}

    Changed files

    • DEPS
  67. [android pylib] support go swarming client in gtest merge script

    Changed by tikutaohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:42:23 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 7383bfa895ea1e7288ed021e5618a5f674f0eff7

    Comments

    [android pylib] support go swarming client in gtest merge script
    
    go swarming client have different directory structure of task outputs from python.
    In go client, directory name of task output become task_id, not shard index like in python.
    let me support both directory structure during migration.
    
    This is cherry-pick of
    https://chromium-review.googlesource.com/c/chromium/tools/build/+/1360817
    
    This is to prevent infra failure like
    https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel/145571
    
    Bug: 894045
    Change-Id: I91da3b0b99ea7a984852ee76f20a09f23e9f490e
    Reviewed-on: https://chromium-review.googlesource.com/c/1364995
    Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
    Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614380}

    Changed files

    • build/android/pylib/results/presentation/standard_gtest_merge.py
  68. flags: remove enable-fullscreen-tab-detaching

    Changed by ellyjonesohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:43:45 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision e9957f7b592e93bba2519525e143fd3e8a7d37e2

    Comments

    flags: remove enable-fullscreen-tab-detaching
    
    This flag is not used anywhere in the code.
    
    Bug: 912155
    Change-Id: I38343c739a2fc2580aa04f9bf120ab0b74ba6929
    Reviewed-on: https://chromium-review.googlesource.com/c/1363436
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Reviewed-by: Robert Sesek <rsesek@chromium.org>
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614381}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/flag-metadata.json
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • chrome/common/chrome_switches.cc
    • chrome/common/chrome_switches.h
  69. simplify DEPS using !=

    Changed by tikutaohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:43:55 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision e306cbad4a10443729a396127a1a6d28db536afd

    Comments

    simplify DEPS using !=
    
    Change-Id: I801fad16f64b1cce56ea5ecb1aced0e93bf992cd
    Reviewed-on: https://chromium-review.googlesource.com/c/1364935
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614382}

    Changed files

    • DEPS
  70. Implement correct opacity and filter handling within backdrop-filter

    Changed by masonfreedohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:49:45 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 7e7e4790f28e6339dd2de044e851b43de5028cbc

    Comments

    Implement correct opacity and filter handling within backdrop-filter
    
    Prior to this CL, opacity and filters applied to the backdrop-filtered
    element did not get applied to the backdrop-filtered backdrop. Now, the
    opacity and filters get applied directly to the backdrop-filtered
    image directly, which is an approximation but should be very close.
    
    Also fixed up a few of the backdrop-filter tests to account for this,
    and removed a few lines from TestExpectations that now work.
    
    Bug: 497522, 524689
    Change-Id: If671bdf65ac0ae04cf175143eb8949ff4be0837b
    Reviewed-on: https://chromium-review.googlesource.com/c/1357626
    Reviewed-by: vmpstr <vmpstr@chromium.org>
    Commit-Queue: Mason Freed <masonfreed@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614383}

    Changed files

    • cc/trees/layer_tree_host_pixeltest_filters.cc
    • components/viz/service/display/gl_renderer.cc
    • components/viz/service/display/gl_renderer.h
    • components/viz/service/display/skia_renderer.cc
    • components/viz/service/display/software_renderer.cc
    • components/viz/test/data/backdrop_filter_rotated_sw.png
    • third_party/blink/web_tests/TestExpectations
    • third_party/blink/web_tests/css3/filters/backdrop-filter-basic-blur-expected.png
    • third_party/blink/web_tests/css3/filters/backdrop-filter-basic-blur.html
    • third_party/blink/web_tests/css3/filters/backdrop-filter-plus-filter-expected.html
    • third_party/blink/web_tests/css3/filters/backdrop-filter-plus-filter.html
    • third_party/blink/web_tests/css3/filters/backdrop-filter-rendering-expected.html
    • third_party/blink/web_tests/css3/filters/backdrop-filter-rendering.html
    • third_party/blink/web_tests/external/wpt/css/filter-effects/backdrop-filter-basic-background-color-ref.html
    • third_party/blink/web_tests/external/wpt/css/filter-effects/backdrop-filter-basic-background-color.html
    • third_party/blink/web_tests/external/wpt/css/filter-effects/backdrop-filter-basic-opacity-2-ref.html
    • third_party/blink/web_tests/external/wpt/css/filter-effects/backdrop-filter-basic-opacity-2.html
    • third_party/blink/web_tests/external/wpt/css/filter-effects/backdrop-filter-clip-rect.html
    • third_party/blink/web_tests/external/wpt/css/filter-effects/backdrop-filter-edge-pixels-ref.html
    • third_party/blink/web_tests/external/wpt/css/filter-effects/backdrop-filter-edge-pixels.html
    • third_party/blink/web_tests/external/wpt/css/filter-effects/backdrop-filter-isolation-fixed.html
    • third_party/blink/web_tests/external/wpt/css/filter-effects/backdrop-filter-isolation-isolate.html
    • third_party/blink/web_tests/external/wpt/css/filter-effects/backdrop-filter-isolation-ref.html
    • third_party/blink/web_tests/external/wpt/css/filter-effects/backdrop-filter-isolation.html
  71. [Autofill Assistant] Onboarding buttons are now aligned with the Terms&Conditions box.

    Changed by arbesserohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 16:53:12 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision c8e849191083c16cb2b18e3d219fbe008741c26d

    Comments

    [Autofill Assistant] Onboarding buttons are now aligned with the Terms&Conditions box.
    
    Before: https://screenshot.googleplex.com/ESkLNquDXJd.png
    After: https://screenshot.googleplex.com/tEssthOhzV9.png
    
    Bug: 806868
    Change-Id: I628e6aaa3bf11f453096c80dfc05266393db6ede
    Reviewed-on: https://chromium-review.googlesource.com/c/1365435
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Clemens Arbesser <arbesser@google.com>
    Cr-Commit-Position: refs/heads/master@{#614384}

    Changed files

    • chrome/android/java/res_autofill_assistant/layout/init_screen.xml
  72. Remove iOS Translate Event Logging in Sync

    Changed by anthonyvdohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:54:37 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 375260f7da26d6910344c5904c849b916ff217c8

    Comments

    Remove iOS Translate Event Logging in Sync
    
    The feature is disabled by default, no config currently applies, and it
    was decided to stop collecting these events. This removes the iOS
    portion of the code because it allows removing a translate -> sync
    dependency that was preventing another change from landing.
    
    Bug: 896719,911781
    Change-Id: I54c40dc1154bb6619d876dbd3fc86e3d22078e99
    Reviewed-on: https://chromium-review.googlesource.com/c/1361927
    Reviewed-by: Roger McFarlane <rogerm@chromium.org>
    Reviewed-by: David Roger <droger@chromium.org>
    Commit-Queue: anthonyvd <anthonyvd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614385}

    Changed files

    • ios/chrome/browser/translate/BUILD.gn
    • ios/chrome/browser/translate/chrome_ios_translate_client.mm
  73. passwords: don't eat space KeyPressed on Mac

    Changed by ellyjonesohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:54:59 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 848e9aed3705fe5ca9392b26f90caf4221c96850

    Comments

    passwords: don't eat space KeyPressed on Mac
    
    On Mac, KeyPressed is what activates buttons, not KeyReleased, so eating
    KeyPressed breaks this button.
    
    Bug: 910070
    Change-Id: I4776bc3b14ac52879ad96c20d55f93126ba349d7
    Reviewed-on: https://chromium-review.googlesource.com/c/1361627
    Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614386}

    Changed files

    • chrome/browser/ui/views/passwords/manage_passwords_icon_views.cc
    • chrome/browser/ui/views/passwords/manage_passwords_icon_views.h
  74. remove static destructable variables from add_unique_urls_task_unittest.cc

    Changed by harringtondohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:55:41 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision e45074e7d2cef61213347c47fa6657c2b5904fa4

    Comments

    remove static destructable variables from add_unique_urls_task_unittest.cc
    
    Also updated a comment as suggested in a previous code review.
    
    Change-Id: If59276e9261ac2ba82ece5086798f34933df5040
    Reviewed-on: https://chromium-review.googlesource.com/c/1362473
    Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
    Commit-Queue: Dan H <harringtond@google.com>
    Cr-Commit-Position: refs/heads/master@{#614387}

    Changed files

    • components/offline_pages/core/prefetch/prefetch_item.h
    • components/offline_pages/core/prefetch/tasks/add_unique_urls_task_unittest.cc
  75. [scheduling] Use ScopedTaskEnvironment instead of MessageLoop in ssl_errors

    Changed by carlscabohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 17:08:20 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 6e29ed936c19b696b115972f7016aefc417edb55

    Comments

    [scheduling] Use ScopedTaskEnvironment instead of MessageLoop in ssl_errors
    
    MessageLoop will go away, eventually.
    
    BUG=891670
    
    Change-Id: I297de47c1dd4d2a58276c136d8b48216ed4fd769
    Reviewed-on: https://chromium-review.googlesource.com/c/1353889
    Reviewed-by: Carlos IL <carlosil@chromium.org>
    Commit-Queue: Carlos Caballero <carlscab@google.com>
    Cr-Commit-Position: refs/heads/master@{#614388}

    Changed files

    • components/ssl_errors/error_classification_unittest.cc
  76. Roll src/third_party/depot_tools 2e00228777c0..f94f910e9a1f (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 17:09:47 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 6c8d5c3b4617238d24caa5e87093bc9e80148b6e

    Comments

    Roll src/third_party/depot_tools 2e00228777c0..f94f910e9a1f (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2e00228777c0..f94f910e9a1f
    
    
    git log 2e00228777c0..f94f910e9a1f --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 tikuta@chromium.org [ninjalog] disable log upload
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@f94f910e9a1f
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
    
    Documentation for
    ...skip...
    ausing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:900161
    TBR=agable@chromium.org
    
    Change-Id: Id3ec9912b3cfeaff57a05c560c43f6945ba75dda
    Reviewed-on: https://chromium-review.googlesource.com/c/1365429
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614389}

    Changed files

    • DEPS
  77. [sheriff] Update TestExpectations for flaky layout test

    Changed by rogermohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:10:19 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision f668bb5e368b109bd420c2525055ffbd6de3f064

    Comments

    [sheriff] Update TestExpectations for flaky layout test
    
    compositing/visibility/overlays-persist-on-navigation.html
    
    TBR: jyasskin@chromium.org
    Bug: 912570
    Change-Id: Iab922b37a9081c3b0a83490e738bda1d03cf24d3
    Reviewed-on: https://chromium-review.googlesource.com/c/1365715
    Commit-Queue: Roger McFarlane <rogerm@chromium.org>
    Reviewed-by: Roger McFarlane <rogerm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614390}

    Changed files

    • third_party/blink/web_tests/TestExpectations
  78. Address race between device notifications and enumerations in AudioDeviceListenerMac

    Changed by guidouohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:12:31 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 01694e809e567530443ffb8687fd5f3956f79c0f

    Comments

    Address race between device notifications and enumerations in AudioDeviceListenerMac
    
    Originally AudioDeviceListenerMac assumed that once CoreAudio reports that a device does not exist,
    it was no longer possible to get notifications related to that device, so it was safe to remove
    the listener for that device.
    However, since notifications can come from multiple threads and the corresponding callbacks make
    a thread jump, we have observed that it is indeed possible to get notifications about removed dev
    ...skip...
    d and posts a task to remove listeners that have been marked as deleted
    for several seconds, at a time when we can confidently no longer expect notifications from the removed device.
    
    Bug: 911311
    Change-Id: I07cc9c8e24a0cfdfadcc04d0e8bd33e14ab61422
    Reviewed-on: https://chromium-review.googlesource.com/c/1363187
    Commit-Queue: Guido Urdaneta <guidou@chromium.org>
    Reviewed-by: Oskar Sundbom <ossu@chromium.org>
    Reviewed-by: Olga Sharonova <olka@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614391}

    Changed files

    • media/audio/mac/audio_device_listener_mac.cc
    • media/audio/mac/audio_device_listener_mac.h
  79. [BrowserTest] Deflake TouchActionBrowserTest

    Changed by xidachenohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:12:43 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision cc4b7196ecbd35a92870ed88bb47b4cd658aff4f

    Comments

    [BrowserTest] Deflake TouchActionBrowserTest
    
    In these browser tests, we inject a synthetic gesture scroll, and jank
    the main thread sometimes, and then check the scroll offset by
    executing:
    "document.scrollingElement.scrollTop" and ".scrollLeft"
    
    From the resut when it is flaky, it seems that even though the
    compositor frame's metadata shows that the scroll offset is >=
    half of the expected scroll offset, the main thread's scroll offset
    might still smaller than half of the expected scroll offset.
    
    This CL makes change to just check that it actually scrolled on the
    expected axis (from the main thread), instead of checking the scroll
    offset.
    
    Bug: 876323
    Change-Id: Ieee6f44304c67e8db89bc4e899ae8e69e8416f33
    Reviewed-on: https://chromium-review.googlesource.com/c/1363863
    Commit-Queue: Xida Chen <xidachen@chromium.org>
    Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614392}

    Changed files

    • content/browser/renderer_host/input/touch_action_browsertest.cc
  80. Network Service: Migrate drive::JobScheduler to NetworkConnectionTracker

    Changed by juncaiohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:15:52 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision e2d41b1393eb57790a1634640b1aa149a7c5fc24

    Comments

    Network Service: Migrate drive::JobScheduler to NetworkConnectionTracker
    
    This CL migrates drive::JobScheduler from NetworkChangeNotifier to
    NetworkConnectionTracker, which works with the network service enabled.
    
    The "Initial upload" patch of this CL is the same as:
    https://chromium-review.googlesource.com/c/chromium/src/+/1236558
    
    Bug: 887038
    Change-Id: Ib19f501f6a85a0c32dc81d47ea4b161b5a726efe
    Reviewed-on: https://chromium-review.googlesource.com/c/1287040
    Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
    Reviewed-by: Naoki Fukino <fukino@chromium.org>
    Commit-Queue: Jun Cai <juncai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614393}

    Changed files

    • chrome/browser/chromeos/drive/drive_integration_service.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
    • components/drive/about_resource_loader_unittest.cc
    • components/drive/change_list_loader_unittest.cc
    • components/drive/directory_loader_unittest.cc
    • components/drive/file_system/operation_test_base.cc
    • components/drive/file_system_unittest.cc
    • components/drive/job_scheduler.cc
    • components/drive/job_scheduler.h
    • components/drive/job_scheduler_unittest.cc
    • components/drive/start_page_token_loader_unittest.cc
    • components/drive/sync_client_unittest.cc
    • components/drive/team_drive_change_list_loader_unittest.cc
    • components/drive/team_drive_list_loader_unittest.cc
  81. Roll src/third_party/skia b45d5124816e..69e5785d9f00 (5 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 17:17:14 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 6d53fe10d0ecc6897202868f2fbc8fe8b8c1f29c

    Comments

    Roll src/third_party/skia b45d5124816e..69e5785d9f00 (5 commits)
    
    https://skia.googlesource.com/skia.git/+log/b45d5124816e..69e5785d9f00
    
    
    git log b45d5124816e..69e5785d9f00 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 jvanverth@google.com Add RG_88 texture format
    2018-12-06 bsalomon@google.com Revert "Revert "Mark wrapped textures imported into SkImages as "read only".""
    2018-12-06 brianosman@google.com Add glenarrow to GPU BonusConfigs bots
    2018-12-06 jvanverth@google.com Reland "Fallba
    ...skip...
    ;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jcgregorio@chromium.org
    
    Change-Id: Ibd613da5fd186bba27bfe363e347e45335b28086
    Reviewed-on: https://chromium-review.googlesource.com/c/1365428
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614394}

    Changed files

    • DEPS
  82. [ios] Add credit card logo to manual fallback cells

    Changed by djeanohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 17:21:52 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 7b27d290eab4ed6d50a84f1ddf959e82039afeff

    Comments

    [ios] Add credit card logo to manual fallback cells
    
    Bug: 912516
    Change-Id: Ibb72af9f02dfe63a206e7039bb388009b1ecd670
    Reviewed-on: https://chromium-review.googlesource.com/c/1365448
    Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
    Commit-Queue: David Jean <djean@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614395}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/action_cell.mm
    • ios/chrome/browser/ui/autofill/manual_fill/credit_card.h
    • ios/chrome/browser/ui/autofill/manual_fill/credit_card.mm
    • ios/chrome/browser/ui/autofill/manual_fill/credit_card_form.mm
    • ios/chrome/browser/ui/autofill/manual_fill/credit_card_unittest.mm
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_address_cell.mm
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_card_cell.mm
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_cell_utils.h
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_cell_utils.mm
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_password_cell.mm
  83. Improve error messaging of perf_data_generator when benchmarks scheduled state is incorrect

    Changed by nednguyenohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 17:24:03 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 7226f9435afe250b14abe22d33dcc2ba72bb4116

    Comments

    Improve error messaging of perf_data_generator when benchmarks scheduled state is incorrect
    
    For Telemetry or non Telemetry benchmarks, these two states generally need to match:
    1) The states of all benchmarks that are tracked BenchmarkMetadata objects. This
    will results in benchmarks being generated in https://bit.ly/chrome-benchmarks
    list.
    2) The states of all benchmarks that are scheduled, either directly (for
    non Telemetry benchmarks) as a 'script' in src-side json, or indirectly through
    benchmark
    ...skip...
    mark class and
    deschedule the benchmark on the perf waterfall. After that, you can
    safely remove the benchmark's dependency code, e.g: stories, WPR
    archives, metrics,..
    
    
    Bug: 911828
    Change-Id: Ia9e9746391eb1e9932c8e0619a25e3273a77e9c5
    Reviewed-on: https://chromium-review.googlesource.com/c/1363681
    Commit-Queue: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
    Reviewed-by: Emily Hanley <eyaich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614396}

    Changed files

    • tools/perf/core/perf_data_generator.py
    • tools/perf/core/perf_data_generator_unittest.py
  84. Feature to enable system AEC.

    Changed by grunellohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:25:20 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 63f2d772b2664b4572190bcd497280afdc6d559f

    Comments

    Feature to enable system AEC.
    
    This lets users enable the system AEC for testing purposes.
    
    If there is no system echo canceller available, getUserMedia with echo cancellation enabled will fail.
    
    Bug: 776327
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Ie041bc1d205762875f9ad4817d8d3441d967256e
    Reviewed-on: https://chromium-review.googlesource.com/c/1113440
    Commit-Queue: Henrik Grunell <grunell@chromium.org>
    Reviewed-by: Olga Sharonova <olka@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Guido Urdaneta <guidou@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614397}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/flag-metadata.json
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • content/renderer/media/stream/media_stream_constraints_util_audio.cc
    • media/audio/audio_features.cc
    • media/audio/audio_features.h
    • tools/metrics/histograms/enums.xml
  85. [AF] Update ShouldSuggestServerCards to check opt in in sync-transport.

    Changed by sebsgohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:25:39 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 3e93500b9d63f42bfac14872be6bec7560b8479a

    Comments

    [AF] Update ShouldSuggestServerCards to check  opt in in sync-transport.
    
    For users that are in sync transport mode, server cards should only be
    suggested if the user has opted-in to seeing them.
    
    Bug: 907929
    Change-Id: I45d855fa6072a1ecb85a4c35244280b0ec8cb4fb
    Reviewed-on: https://chromium-review.googlesource.com/c/1365086
    Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
    Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614398}

    Changed files

    • components/autofill/core/browser/personal_data_manager.cc
    • components/autofill/core/browser/personal_data_manager_unittest.cc
  86. Remove Crash Expectation for fullscreen/full-screen-inline-split-crash.html

    Changed by jonrossohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:26:27 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision b270bbd6b31a08acc546d943f7d615ae58a36943

    Comments

    Remove Crash Expectation for fullscreen/full-screen-inline-split-crash.html
    
    fullscreen/full-screen-inline-split-crash.html was crashing on Android, do to a
    check which is only valid on Mac. This Check has since been restricted to Mac
    only.
    
    We no longer expect this to crash. And new crashes should be logged as they
    would be different bugs. The most recent run on flaky dashboard shows a pass,
    though there is only one recent run found.
    
    I'm removing the crash expectation.
    
    TEST=fullscreen/full-screen-inline-split-crash.html
    
    Bug: 883591
    Change-Id: I3863ac01cba653af98ac4bdb95d326d170ac70d1
    Reviewed-on: https://chromium-review.googlesource.com/c/1364211
    Reviewed-by: kylechar <kylechar@chromium.org>
    Commit-Queue: Jonathan Ross <jonross@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614399}

    Changed files

    • third_party/blink/web_tests/TestExpectations
  87. Roll src/third_party/perfetto 06b4f7386a8c..6ae9526278fc (3 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 17:26:46 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 6d7e45d18cb08da70c65d1583787364a7e948f78

    Comments

    Roll src/third_party/perfetto 06b4f7386a8c..6ae9526278fc (3 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/06b4f7386a8c..6ae9526278fc
    
    
    git log 06b4f7386a8c..6ae9526278fc --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 fmayer@google.com profiling: Do not disable SELinux by default in script.
    2018-12-06 fmayer@google.com Merge "profiling: Improve bookeeping."
    2018-12-06 fmayer@google.com Merge "profiler: Use sequence number for interner ID."
    
    
    Created with:
      g
    ...skip...
    ailures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:117762471
    TBR=perfetto-bugs@google.com
    
    Change-Id: Ie435d664e7d91a309a0b66937bb75144cf94dc58
    Reviewed-on: https://chromium-review.googlesource.com/c/1365756
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614400}

    Changed files

    • DEPS
  88. Update Mash FYI browser_tests filter

    Changed by stevenjbohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:27:34 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 5036b8ef6edb94c35cd5c5d8b6ab4d2b0f3e94b4

    Comments

    Update Mash FYI browser_tests filter
    
    Bug: 646565
    
    For keyboard specific change to policy_browsertest.cc:
    TBR=emaxx@chromium.org
    
    Change-Id: I214a6563614e83c912de7eb8b880a995fda2f89d
    Reviewed-on: https://chromium-review.googlesource.com/c/1363898
    Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614401}

    Changed files

    • chrome/browser/policy/policy_browsertest.cc
    • chrome/browser/ui/ash/keyboard/keyboard_controller_browsertest.cc
    • testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter
  89. [Signin][Android] Reset SigninHelper shared prefs in SigninTestUtil

    Changed by bsazonovohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:27:51 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision b0262e8f0abfde39fcf63e6047510b41bade79bd

    Comments

    [Signin][Android] Reset SigninHelper shared prefs in SigninTestUtil
    
    This CL replaces SigninHelper.resetAccountRenameEventIndex with
    resetSharedPrefs that clears all shared preferences saved by
    SigninHelper. resetSharedPrefs is invoked from SigninTestUtil to make
    sure the state doesn't leak between tests.
    
    Bug: 906712
    Change-Id: I439783e0c0977621f4492fb882c3825f91cb6b3a
    Reviewed-on: https://chromium-review.googlesource.com/c/1365242
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614402}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/signin/SigninHelper.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java
    • chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/signin/SigninTestUtil.java
  90. [Autofill Assistant] Fix gestures in partial overlay mode.

    Changed by szermattohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:30:25 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 188b097f0df3ade4cdc73a68ff51ad8035972b39

    Comments

    [Autofill Assistant] Fix gestures in partial overlay mode.
    
    With this patch, scroll, fling and pinch gestures in partial overlay
    mode work and feel the same way as in normal mode, even outside of the
    touchable area.
    
    Before this patch, when in partial overlay mode, scroll was simulated -
    badly, fling and pinch did not work at all.
    
    The way this now works, when touching outside of the touchable area in
    partial overlay mode, events are buffered just long enough to make sure
    that the gesture is not a tap
    ...skip...
     margin is turned off unless
    in accessibility mode - and we don't intercept gestures in accessibility
    mode anyways.
    
    This change also removes the now unnecessary support for calling
    javascript scrollBy from Android Java.
    
    Bug: 806868
    Change-Id: I605a8659543bd2140c124e9b79e9b9b9de606c55
    Reviewed-on: https://chromium-review.googlesource.com/c/1362935
    Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
    Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614403}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/TouchEventFilter.java
    • chrome/browser/android/autofill_assistant/ui_controller_android.cc
    • chrome/browser/android/autofill_assistant/ui_controller_android.h
    • components/autofill_assistant/browser/controller.cc
    • components/autofill_assistant/browser/controller.h
    • components/autofill_assistant/browser/ui_delegate.h
    • components/autofill_assistant/browser/web_controller.cc
    • components/autofill_assistant/browser/web_controller.h
  91. Rolling buildtools 04161ec8..7d88270d

    Changed by smaierohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:35:46 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 9b5c0a7e5bf7a73942ba783b6180f83a4d63b1e4

    Comments

    Rolling buildtools 04161ec8..7d88270d
    
    Also updates docs on how to build clang-format.
    
    Bug: 911708, 907181
    Change-Id: I55b3d9833b030fece1eb52c3b6b53492959582b2
    Reviewed-on: https://chromium-review.googlesource.com/c/1365081
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614404}

    Changed files

    • DEPS
    • docs/updating_clang_format_binaries.md
  92. [iOS] Update OpenInToolbar bottom margin constraint for new windows.

    Changed by kkhorimotoohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:44:16 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision c8bcca4e25ae2b9046f8cf4c31d94b179d45e4a7

    Comments

    [iOS] Update OpenInToolbar bottom margin constraint for new windows.
    
    Previously OpenInToolbar updated its bottom constraint when moved to
    a new superview.  This occurs when the toolbar is added to the tab's
    view (CRWWebControllerContainerView) when a tab is navigated to an
    exportable URL.  If the foreground tab is changed after this occurs, the
    tab's view is removed from the hierarchy, which deactivates the
    bottom margin height constraint since the open in toolbar is removed
    from the BVC's hierarchy.
    ...skip...
     updated while the tab's view is not visible due to delayed
    JavaScript execution that is used to apply the PageDisplayState.
    
    Bug: 907485
    Change-Id: Iedd05d5cf6657e26372235d026fd2c34e87f9c95
    Reviewed-on: https://chromium-review.googlesource.com/c/1364162
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614405}

    Changed files

    • ios/chrome/browser/ui/open_in_toolbar.mm
  93. [MDC roll] Roll Material Motion Interchange to 6c385396ae7d3ee6752c3d625e322138eb8e25fc

    Changed by ios-autorollerohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:46:43 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 0ae3d0c44adc34d53f2a6a29a16971553b1ff8f5

    Comments

    [MDC roll] Roll Material Motion Interchange to 6c385396ae7d3ee6752c3d625e322138eb8e25fc
    
    TBR=smut
    
    Change-Id: I3d7d55c3e0301c6db509d674e1f42b33392ee933
    Reviewed-on: https://chromium-review.googlesource.com/c/1365795
    Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org>
    Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614406}

    Changed files

    • DEPS
    • ios/third_party/motion_interchange_objc/README.chromium
  94. Verify correctness of WebState::GetTitle during session restore.

    Changed by eugenebutohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 17:51:40 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 1b8b0c79967271555e0d197b0ac874d2c61bd641

    Comments

    Verify correctness of WebState::GetTitle during session restore.
    
    Cached title is returned during restoration and URL hostname is returned
    right after restoration is complete, but before the page finishes load.
    
    Bug: 877671
    Change-Id: Ie7375a3c0c47a77417f1d10bb4bb0d48d6127da1
    Reviewed-on: https://chromium-review.googlesource.com/c/1363968
    Reviewed-by: Danyao Wang <danyao@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614407}

    Changed files

    • ios/web/web_state/web_state_unittest.mm
  95. Autoplay: remove cross-origin autoplay policy from //chrome and //content.

    Changed by mlamouriohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:55:34 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 04c8595b3d4c10d8ce02c057084a8e46df0d8c1e

    Comments

    Autoplay: remove cross-origin autoplay policy from //chrome and //content.
    
    This isn't removing the code in Blink but prevents users from setting this
    autoplay policy.
    
    Bug: 911795
    Change-Id: I8803813a1971d2c0082af164ed8d73a48e3a1cf7
    Reviewed-on: https://chromium-review.googlesource.com/c/1362225
    Reviewed-by: Becca Hughes <beccahughes@chromium.org>
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614408}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/ui/webui/media/media_engagement_ui.cc
    • content/browser/renderer_host/render_view_host_impl.cc
    • content/public/common/web_preferences.h
    • content/renderer/render_view_impl.cc
    • media/base/media_switches.cc
    • media/base/media_switches.h
  96. [Sync] Fix initialization in sync_file_system_browsertest

    Changed by mamirohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:55:58 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 7ba8f46fbafda0457b26c1d714f55bcc7b7555ae

    Comments

    [Sync] Fix initialization in sync_file_system_browsertest
    
    In sync_file_system_browsertest.cc
    
    The following code snippet
    
    info.account_id = kGaiaId;
    info.account_id = kEmail;
    
    Assigns info.account_id and directly overrides it with another value
    which renders the first assignment useless.
    
    Change-Id: Ia27e36e6d9f54fba7c5e179492408c327ff2bb67
    Reviewed-on: https://chromium-review.googlesource.com/c/1363283
    Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614409}

    Changed files

    • chrome/browser/apps/platform_apps/api/sync_file_system/sync_file_system_browsertest.cc
  97. Fix rounding error in coordinate conversion

    Changed by andrewxuohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:56:38 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision a6cdb0f015d98d56b2eddcd20624875762ddb6ba

    Comments

    Fix rounding error in coordinate conversion
    
    Fix the rounding error in code for coordinate conversion from
    native host coordinate to screen DIP coordinate.
    
    In the original code, when mouse cursor is in the warp region of
    secondary display, its screen DIP coordinate which is computed by
    ConvertHostPointToRelativeToRootWindow may be out of secondary display
    due to rounding error. It is also found that this rounding error only
    happens with specific display zoom factors and display rotation
    degrees.
    
    Test: ash_unittests
    
    Bug: 905035
    Change-Id: I4570dee911777ad820ede6677f7a3382f5b9a5fc
    Reviewed-on: https://chromium-review.googlesource.com/c/1364392
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Commit-Queue: Andrew Xu <andrewxu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614410}

    Changed files

    • ash/display/extended_mouse_warp_controller.cc
    • ash/display/extended_mouse_warp_controller.h
    • ash/display/extended_mouse_warp_controller_unittest.cc
    • ash/display/screen_position_controller.cc
    • ash/display/screen_position_controller_unittest.cc
    • ash/host/ash_window_tree_host_platform.h
  98. [TaskScheduler]: Migrate off of ScopedAllowWait in /base

    Changed by etiennepohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:59:27 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 030ca0ae838b897e824961a4b15e86d3ad2719ce

    Comments

    [TaskScheduler]: Migrate off of ScopedAllowWait in /base
    
    base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more
    explicit counterpart.
    
    It should have been replaced by :
     * base::ScopedAllowBaseSyncPrimitivesForTesting in test files.
     * base::ScopedAllowBaseSyncPrimitives in non-test files
     * base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope when it's used on threads
       that don't allow blocking
    The last one is strongly frowned upon but this CL aims to document existing
    beh
    ...skip...
     top-level CL if necessary :
    https://chromium-review.googlesource.com/c/chromium/src/+/1288533
    
    Please CQ if LGTY!
    
    This CL was uploaded by git cl split.
    
    R=danakj@chromium.org
    
    Bug: 766678
    Change-Id: Ibe3a0f37c044cc58d5d25eacc2bb2aba6441de3a
    Reviewed-on: https://chromium-review.googlesource.com/c/1325218
    Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
    Reviewed-by: Chris Hamilton <chrisha@chromium.org>
    Reviewed-by: danakj <danakj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614411}

    Changed files

    • base/test/thread_test_helper.cc
    • base/threading/simple_thread.cc
    • base/threading/thread.cc
    • cc/raster/single_thread_task_graph_runner.cc
    • chrome/browser/memory/memory_kills_monitor.cc
  99. Import wpt@6185fc083a08ea74f0ddfffff917321fb6ffa42d

    Changed by wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 18:00:44 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 82be89cec654871a1ba8277151b966b7ec4a4be4

    Comments

    Import wpt@6185fc083a08ea74f0ddfffff917321fb6ffa42d
    
    Using wpt-import in Chromium 454a4f0cb9c837740bbb0bb1f07809728f98f4a6.
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    chcunningham@chromium.org, wolenetz@chromium.org:
      external/wpt/media-source
    jsbell@chromium.org:
      external/wpt/resources
    
    NOAUTOREVERT=true
    TBR=raphael.kubo.da.costa
    
    No-Export: true
    Change-Id: Ia09e3aaf2750bf36e54d5e1fbc6bb85fa85476c9
    Reviewed-on: https://chromium-review.googlesource.com/c/1365716
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614412}

    Changed files

    • third_party/blink/web_tests/NeverFixTests
    • third_party/blink/web_tests/SlowTests
    • third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
    • third_party/blink/web_tests/external/wpt/css/css-overscroll-behavior/overscrollBehavior-manual.html
    • third_party/blink/web_tests/external/wpt/interfaces/web-nfc.idl
    • third_party/blink/web_tests/external/wpt/media-source/mediasource-invalid-codec.html
    • third_party/blink/web_tests/external/wpt/media-source/mp4/invalid-codec.mp4
    • third_party/blink/web_tests/external/wpt/media-source/webm/invalid-codec.webm
    • third_party/blink/web_tests/external/wpt/resources/testharness.js
    • third_party/blink/web_tests/external/wpt/svg/interact/scripted/composed.window.svg
    • third_party/blink/web_tests/external/wpt/svg/interact/scripted/focus-events.svg
    • third_party/blink/web_tests/external/wpt/svg/interact/scripted/focus-tabindex-default-value.svg
    • third_party/blink/web_tests/external/wpt/svg/interact/scripted/resources/blank.htm
    • third_party/blink/web_tests/external/wpt/svg/interact/scripted/tabindex-focus-flag-expected.txt
    • third_party/blink/web_tests/external/wpt/svg/interact/scripted/tabindex-focus-flag.svg
    • third_party/blink/web_tests/external/wpt/web-nfc/idlharness.https.window-expected.txt
  100. Roll src-internal 3803956c4af7..a7fc8655690d (2 commits)

    Changed by chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 18:01:25 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 84d7fb2bf2f79989653e257c1a8f9395f060c2a6

    Comments

    Roll src-internal 3803956c4af7..a7fc8655690d (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3803956c4af7..a7fc8655690d
    
    
    Created with:
      gclient setdep -r src-internal@a7fc8655690d
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Id0c5837a852e741ceb14c762676aff02d0ef6ce0
    Reviewed-on: https://chromium-review.googlesource.com/c/1365755
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614413}

    Changed files

    • DEPS
  101. android_webview: Remove extracted pak file cleanup logic

    Changed by agrieveohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:01:50 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 7f85b75a6d0ca2431e811c9d245765ea60773263

    Comments

    android_webview: Remove extracted pak file cleanup logic
    
    This removes some cleanup that now has very low odds of being
    necessary. It was to clean up accidentally extracted files
    for users of M60 and M61 Monochrome (15 months ago).
    
    Bug: 756580
    Change-Id: I502d7080ec26d0301a9e17e07ae9f5b7266ac088
    Reviewed-on: https://chromium-review.googlesource.com/c/1364019
    Reviewed-by: Richard Coles <torne@chromium.org>
    Commit-Queue: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614414}

    Changed files

    • android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
  102. ARC: Ignore account updates for which a refresh token is not present

    Changed by sinhakohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:02:34 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 37a377ec76e2c3fafe0d86ffecc765b23b4633ba

    Comments

    ARC: Ignore account updates for which a refresh token is not present
    
    As accounts are being migrated to Chrome OS Account Manager, we may have
    some accounts for which we do not have a valid refresh token yet.
    
    Do not attempt to push these accounts to ARC. When these accounts do get
    a valid refresh token, ArcAuthService will be notified again.
    
    Bug: 871690
    Test: browser_tests --gtest_filter="*ArcAuthService*Test*"
    Change-Id: Id69d8b2deed80adf455a42f4393de33b3f099022
    Reviewed-on: https://chromium-review.googlesource.com/c/1350175
    Reviewed-by: Yury Khmel <khmel@chromium.org>
    Commit-Queue: Kush Sinha <sinhak@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614415}

    Changed files

    • chrome/browser/chromeos/arc/auth/arc_auth_service.cc
    • chrome/browser/chromeos/arc/auth/arc_auth_service_browsertest.cc
  103. Add setTopBarHeight in ActivityHostImpl.

    Changed by chuanlohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 18:06:41 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision c01a2a44506aafbb2ff2d7a8c610260b74982138

    Comments

    Add setTopBarHeight in ActivityHostImpl.
    
    This is guarded by the CCTModuleCustomHeader Finch feature.
    
    Bug: 882404
    Change-Id: I118b6d859596e321cb2f058ee3f370c8c26eb41e
    Reviewed-on: https://chromium-review.googlesource.com/c/1333653
    Reviewed-by: Ted Choc <tedchoc@chromium.org>
    Reviewed-by: Matthew Jones <mdjones@chromium.org>
    Reviewed-by: Chris Palmer <palmer@chromium.org>
    Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
    Commit-Queue: John Lin <chuanl@google.com>
    Cr-Commit-Position: refs/heads/master@{#614416}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabTopBarDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/dynamicmodule/ActivityHostImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
  104. Modify aar.py to enumerate .so files

    Changed by bialpioohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:07:42 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 6065e789cb75b094748d6a55f74a7508039e8bd3

    Comments

    Modify aar.py to enumerate .so files
    
    Modify android_aar_prebuilt template in android/rules.gni to
    leverage information about native libraries in aar archive
    and unpack them.
    
    The above changes are needed to allow us to cleanly
    take a dependency on ARCore.
    
    Bug: 887669
    Change-Id: I32f9d4fd284c9357bcc115f3ee14ca72cfdd684d
    Reviewed-on: https://chromium-review.googlesource.com/c/1362288
    Reviewed-by: Bill Orr <billorr@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614417}

    Changed files

    • build/android/gyp/aar.py
    • build/config/android/rules.gni
  105. [Signin][Android] Remove password field from AccountHolder

    Changed by bsazonovohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:08:50 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 94fa8ee397d7527c33e9be475fce4ca18bfd6e12

    Comments

    [Signin][Android] Remove password field from AccountHolder
    
    This CL removes password field from
    org.chromium.components.signin.test.util.AccountHolder and related test
    classes. This field is never used and doesn't make much sense in current
    account management model.
    
    Bug: None
    Change-Id: I207476bdad1f0059fcab4893d326b7463f4f85f2
    Reviewed-on: https://chromium-review.googlesource.com/c/1365591
    Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614418}

    Changed files

    • chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PasswordViewingTypeTest.java
    • chrome/android/javatests/src/org/chromium/chrome/test/util/ChromeSigninUtilsTest.java
    • chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeSigninUtils.java
    • components/signin/core/browser/android/javatests/src/org/chromium/components/signin/test/util/AccountHolder.java
  106. Revert "Replace blink::ToIsolate(ExecutionContext) with blink::ExecutionContext->GetIsolate()"

    Changed by hinokaohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:13:34 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision e908ae1d722150daddb6a3074842d564e29b6694

    Comments

    Revert "Replace blink::ToIsolate(ExecutionContext) with blink::ExecutionContext->GetIsolate()"
    
    This reverts commit e206e5c21ee57618fc3c7fa9d59a60360d39f711.
    
    Reason for revert: Crashing
    Crash report: crbug.com/912480
    Fuzzer report: crbug.com/912451
    
    Likely due to nullptr contexts passed in blink::probe::AsyncTaskCanceled() and blink::probe::AsyncTaskCanceledBreakable()
    
    Original change's description:
    > Replace blink::ToIsolate(ExecutionContext) with blink::ExecutionContext->GetIsolate()
    > 
    > And remo
    ...skip...
    chromium.org>
    > Commit-Queue: Ryan Tseng <hinoka@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614197}
    
    TBR=hinoka@chromium.org,yukishiino@chromium.org,haraken@chromium.org
    
    Change-Id: Icea742f3e380e87491d1a8606cf7c10e5c2a7c4c
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 889542
    Reviewed-on: https://chromium-review.googlesource.com/c/1365881
    Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    Commit-Queue: Ryan Tseng <hinoka@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614419}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/script_event_listener.cc
    • third_party/blink/renderer/bindings/core/v8/script_promise_property_base.cc
    • third_party/blink/renderer/bindings/core/v8/script_promise_property_test.cc
    • third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.cc
    • third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.h
    • third_party/blink/renderer/core/frame/csp/content_security_policy.cc
    • third_party/blink/renderer/core/html/html_frame_element_base.cc
    • third_party/blink/renderer/core/messaging/message_port.cc
    • third_party/blink/renderer/core/probe/core_probes.cc
    • third_party/blink/renderer/core/trustedtypes/trusted_types_util.cc
    • third_party/blink/renderer/core/workers/dedicated_worker.cc
    • third_party/blink/renderer/core/workers/dedicated_worker_messaging_proxy.cc
    • third_party/blink/renderer/core/workers/experimental/task.cc
    • third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc
    • third_party/blink/renderer/modules/indexeddb/idb_key_range.cc
    • third_party/blink/renderer/modules/payments/abort_payment_respond_with_observer.cc
    • third_party/blink/renderer/modules/payments/can_make_payment_respond_with_observer.cc
    • third_party/blink/renderer/modules/payments/payment_request_respond_with_observer.cc
    • third_party/blink/renderer/modules/service_worker/fetch_respond_with_observer.cc
    • third_party/blink/renderer/modules/time_zone_monitor/time_zone_monitor_client.cc
  107. chromeos: refactor LockWindow

    Changed by skyohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:22:31 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision b1e4803dd916d499f16209589ff06a0745a8e474

    Comments

    chromeos: refactor LockWindow
    
    LockWindow is used from both chrome and ash. LockWindow reaches directly into
    ash and parents a widget to ash's hierarchy. This won't work from the chrome
    side. The code has been refactored in two ways:
    
    . ash specific functionality has been moved into LockLayoutManager.
    . a factory function for creating the widget is added to ash/public/cpp. The
      function takes an argument that dictates how it works. Specifically in
      ash code the parent is supplied, outside of ash the container id is used.
    
    BUG=899862
    TEST=covered by tests
    
    Change-Id: I4c0ca9c91948df9f653f5cb97bb6bc1c48c09301
    Reviewed-on: https://chromium-review.googlesource.com/c/1364076
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Commit-Queue: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614420}

    Changed files

    • ash/BUILD.gn
    • ash/login/login_screen_controller.cc
    • ash/login/login_screen_test_api.cc
    • ash/login/ui/lock_screen.cc
    • ash/login/ui/lock_screen.h
    • ash/login/ui/lock_window.cc
    • ash/login/ui/lock_window.h
    • ash/login/ui/lock_window_unittest.cc
    • ash/login/ui/login_bubble.cc
    • ash/public/cpp/BUILD.gn
    • ash/public/cpp/lock_screen_widget_factory.cc
    • ash/public/cpp/lock_screen_widget_factory.h
    • ash/shelf/login_shelf_view.cc
    • ash/system/message_center/ash_message_center_lock_screen_controller.cc
    • ash/system/tray/tray_background_view.cc
    • ash/wm/lock_layout_manager.cc
    • chrome/browser/chromeos/login/lock/DEPS
    • chrome/browser/chromeos/login/lock/webui_screen_locker.cc
    • chrome/browser/chromeos/login/lock/webui_screen_locker.h
    • testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
  108. Mark expired Bluetooth Socket histograms obsolete

    Changed by reillygohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:23:47 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision ef14b6505703c04034ac99d6b4231b40ed6cac6d

    Comments

    Mark expired Bluetooth Socket histograms obsolete
    
    Code to generate these histograms was removed in r614051.
    
    Bug: 899953,899957,899960
    Change-Id: Ie667a64fffe45f0ae8bcf436eb6be991262cdec0
    Reviewed-on: https://chromium-review.googlesource.com/c/1363953
    Reviewed-by: Jesse Doherty <jwd@chromium.org>
    Commit-Queue: Reilly Grant <reillyg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614421}

    Changed files

    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml
  109. Fix watchlist and owners for chrome/services/isolated_xr_device

    Changed by billorrohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:27:12 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 165281bde1ac0911644f1bc947c9a1e4e37af0f7

    Comments

    Fix watchlist and owners for chrome/services/isolated_xr_device
    
    Fix watchlist and owners for chrome/services/isolated_xr_device.
    
    Change-Id: I26bcb8301a1d0e79850a8218fc1b8bb961efaca0
    Reviewed-on: https://chromium-review.googlesource.com/c/1364337
    Reviewed-by: David Dorwin <ddorwin@chromium.org>
    Commit-Queue: Bill Orr <billorr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614422}

    Changed files

    • WATCHLISTS
    • chrome/services/isolated_xr_device/OWNERS
  110. Prepare Switch Access event handler for mash.

    Changed by anastasiohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 18:35:12 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 74fe33533bbf0873b3944bffe8c9ec0f4f3f5ce0

    Comments

    Prepare Switch Access event handler for mash.
    
    Create a Switch Access event handler in ash/, and convert the current
    handler in chrome/ to a delegate.
    
    Bug: 905439
    Change-Id: I7cca3cf8883f1e1fd0bfa6f5c02797ce020b46b5
    Reviewed-on: https://chromium-review.googlesource.com/c/1354037
    Reviewed-by: James Cook <jamescook@chromium.org>
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Reviewed-by: David Tseng <dtseng@chromium.org>
    Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
    Cr-Commit-Position: refs/heads/master@{#614423}

    Changed files

    • ash/BUILD.gn
    • ash/accessibility/accessibility_controller.cc
    • ash/accessibility/accessibility_controller.h
    • ash/events/OWNERS
    • ash/events/switch_access_event_handler.cc
    • ash/events/switch_access_event_handler.h
    • ash/events/switch_access_event_handler_unittest.cc
    • ash/public/interfaces/accessibility_controller.mojom
    • chrome/browser/accessibility/accessibility_extension_api.cc
    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/accessibility/accessibility_manager.cc
    • chrome/browser/chromeos/accessibility/accessibility_manager.h
    • chrome/browser/chromeos/accessibility/switch_access_browsertest.cc
    • chrome/browser/chromeos/accessibility/switch_access_event_handler.cc
    • chrome/browser/chromeos/accessibility/switch_access_event_handler.h
    • chrome/browser/chromeos/accessibility/switch_access_event_handler_delegate.cc
    • chrome/browser/chromeos/accessibility/switch_access_event_handler_delegate.h
    • chrome/browser/chromeos/preferences.cc
    • chrome/browser/ui/ash/accessibility/accessibility_controller_client_unittest.cc
  111. DevTools: enable Console keyboard navigation by default

    Changed by luoeohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:37:44 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 48789ec6e4da515fdeda4ec1c3d569a06466790c

    Comments

    DevTools: enable Console keyboard navigation by default
    
    Bug: 865674
    Change-Id: I6f1bf84a2113f64cc0c00839067f4e41ca72f483
    Reviewed-on: https://chromium-review.googlesource.com/c/1330295
    Commit-Queue: Erik Luo <luoe@chromium.org>
    Reviewed-by: Joel Einbinder <einbinder@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614424}

    Changed files

    • third_party/blink/renderer/devtools/front_end/main/Main.js
  112. Remove LOG(ERROR)s for debugging purpose

    Changed by hongchanohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:38:47 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision e9735f4354b21bdb795cb75ce70b7d51178ebaab

    Comments

    Remove LOG(ERROR)s for debugging purpose
    
    Multiple LOG(ERROR)s were introduced by the CL
    (https://chromium-review.googlesource.com/c/1355333) but it looks like
    a mistake.
    
    Change-Id: Id3ab8dc6ab999ef37f4d6c0d05985be0e48a5c64
    Reviewed-on: https://chromium-review.googlesource.com/c/1365551
    Commit-Queue: Hongchan Choi <hongchan@chromium.org>
    Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614425}

    Changed files

    • third_party/blink/renderer/modules/webaudio/audio_context.cc
  113. [LayoutNG] Simplify & correct static position for OOF positioned.

    Changed by ikilpatrickohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:41:54 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision f77f8ad37d9fe5ad966d482e601671a588e68207

    Comments

    [LayoutNG] Simplify & correct static position for OOF positioned.
    
    This patch is primarily simplifies how we determine the static position
    for an OOF positioned node, within the inline context.
    
    There are many fixes, (see test cases).
    
    Additionally, fixed positioned nodes, now work when they have an inline
    level containing block.
    
    Bug: 636993
    Change-Id: I36b573578fc85d9ba9b757f258ec7391eec73c0a
    Reviewed-on: https://chromium-review.googlesource.com/c/1356999
    Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
    Reviewed-by: Aleks Totic <atotic@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614426}

    Changed files

    • third_party/blink/renderer/core/layout/ng/geometry/ng_logical_offset.cc
    • third_party/blink/renderer/core/layout/ng/geometry/ng_logical_offset.h
    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_box_state.cc
    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_box_state.h
    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_layout_algorithm.cc
    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_layout_algorithm.h
    • third_party/blink/renderer/core/layout/ng/inline/ng_line_box_fragment_builder.cc
    • third_party/blink/renderer/core/layout/ng/inline/ng_line_box_fragment_builder.h
    • third_party/blink/renderer/core/layout/ng/ng_box_fragment_builder.cc
    • third_party/blink/renderer/core/layout/ng/ng_box_fragment_builder.h
    • third_party/blink/renderer/core/layout/ng/ng_container_fragment_builder.cc
    • third_party/blink/renderer/core/layout/ng/ng_container_fragment_builder.h
    • third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.cc
    • third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.h
    • third_party/blink/renderer/core/layout/ng/ng_out_of_flow_positioned_descendant.h
    • third_party/blink/web_tests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/blink/web_tests/TestExpectations
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/htb-ltr-ltr.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/htb-ltr-rtl.tentative.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/htb-ref.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/htb-rtl-ltr.tentative.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/htb-rtl-rtl.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/vlr-ltr-ltr.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/vlr-ltr-rtl.tentative.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/vlr-ref.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/vlr-rtl-ltr.tentative.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/vlr-rtl-rtl.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/vrl-ltr-ltr.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/vrl-ltr-rtl.tentative.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/vrl-ref.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/vrl-rtl-ltr.tentative.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/vrl-rtl-rtl.html
  114. android: Implement DumpWithoutCrashing() from child processes

    Changed by jperazaohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:45:00 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 6b424b920a9170a35eb79ffb283078f4598f6716

    Comments

    android: Implement DumpWithoutCrashing() from child processes
    
    Bug: 911834
    Change-Id: I1901745a79f40748791d5c9a0dee1f45fb7ca88a
    Reviewed-on: https://chromium-review.googlesource.com/c/1362189
    Reviewed-by: Mark Mentovai <mark@chromium.org>
    Commit-Queue: Joshua Peraza <jperaza@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614427}

    Changed files

    • components/crash/content/app/crashpad.cc
    • components/crash/content/app/crashpad_linux.cc
    • components/crash/content/browser/crash_handler_host_linux.cc
  115. [EoC] Fix and re-enable in-product help test and add a new one

    Changed by twellingtonohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:47:49 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision e0b574a4d998f620204f784c8e7cb02b9aa941d8

    Comments

    [EoC] Fix and re-enable in-product help test and add a new one
    
    The FakeTracker used to stub out the feature engagement system never
    triggered the onInitializedCallback, so the test was failing because
    ContextualSuggestionsMediator#mCanShowIph never got set to true.
    
    Trigger the callback as soon as FakeTracker#addOnInitializedCallback is
    called, re-enable the EoC test and add a new test for the IPH variant
    that requires a reverse scroll.
    
    BUG=890947
    
    Change-Id: Idcaf4435a585b738b7421e7510f24b146d536403
    Reviewed-on: https://chromium-review.googlesource.com/c/1362434
    Commit-Queue: Theresa <twellington@chromium.org>
    Reviewed-by: Becky Zhou <huayinz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614428}

    Changed files

    • chrome/android/javatests/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/contextual_suggestions/FakeTracker.java
  116. cros: Update AppsGridView bottom drag buffer

    Changed by newcomerohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:49:10 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 9504f17bdd7940d0d8064259f57291baa895002e

    Comments

    cros: Update AppsGridView bottom drag buffer
    
    The AppsGridView is transformed to fit on screens that use display zoom.
    
    Use the current transform to calculate the bottom of the AppsGridView,
    then consider all drags below AppsGridView "in the buffer". The old
    buffer values do not make sense with the redesign, and with a scaled
    display.
    
    Bug: 907914
    Change-Id: I40e15fc8ba4f1022a9def18ac97fd0bab0d2d031
    Reviewed-on: https://chromium-review.googlesource.com/c/1354479
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Commit-Queue: Alex Newcomer <newcomer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614429}

    Changed files

    • ash/app_list/views/apps_grid_view.cc
    • ash/app_list/views/apps_grid_view_unittest.cc
  117. Roll src/third_party/SPIRV-Tools/src 2e4563d94f9d..aa270e568a3f (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 18:50:42 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision a21025682fd1c24239ed4808f1c1870f74f5bb19

    Comments

    Roll src/third_party/SPIRV-Tools/src 2e4563d94f9d..aa270e568a3f (1 commits)
    
    https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2e4563d94f9d..aa270e568a3f
    
    
    git log 2e4563d94f9d..aa270e568a3f --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 stevenperron@google.com Be more explicit about SPIRV_WERROR option. (#2141)
    
    
    Created with:
      gclient setdep -r src/third_party/SPIRV-Tools/src@aa270e568a3f
    
    The AutoRoll server is located here: https://autoroll.skia.or
    ...skip...
    
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: Ifb3e0f98bcb32754e848a5a9822efd67723b982f
    Reviewed-on: https://chromium-review.googlesource.com/c/1365757
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614430}

    Changed files

    • DEPS
  118. chromeos: add LOG to figure out crash

    Changed by skyohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:59:49 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision bd76e5f452c349df7a9febf422932f67e50dc50a

    Comments

    chromeos: add LOG to figure out crash
    
    CHECK() in an official build eats its parameters. Add a LOG statement to help
    figure out why CHECK() is being hit.
    
    BUG=912228
    TEST=none
    
    Change-Id: I6fd0ffc04eb1db128f10acee7a1ed5131980e486
    Reviewed-on: https://chromium-review.googlesource.com/c/1365835
    Reviewed-by: James Cook <jamescook@chromium.org>
    Commit-Queue: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614431}

    Changed files

    • ui/aura/mus/in_flight_change.cc
  119. [NTP] Remove UI MD flag

    Changed by kmilkaohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:00:38 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 0896159f33c40980e46c43ff7c56c84dcf7b4aa1

    Comments

    [NTP] Remove UI MD flag
    
    Remove flag for ntp md ui. Change the new styling to be the
    default and remove the md class, this mainly affects the fakebox
    as the icons are styled via md-icons.
    
    Mostly a reland of https://crrev.com/c/1265024.
    
    Bug: 905386
    Change-Id: I62db12fe3cea1e85ed615f1ad2fbb9ea211f585e
    Reviewed-on: https://chromium-review.googlesource.com/c/1361720
    Reviewed-by: Kristi Park <kristipark@chromium.org>
    Reviewed-by: Brian White <bcwhite@chromium.org>
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Commit-Queue: Kyle Milka <kmilka@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614432}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/flag-metadata.json
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • chrome/browser/resources/local_ntp/local_ntp.css
    • chrome/browser/resources/local_ntp/local_ntp.js
    • chrome/browser/search/local_ntp_source.cc
    • chrome/browser/search/ntp_features.cc
    • chrome/browser/search/ntp_features.h
    • chrome/browser/ui/search/local_ntp_browsertest.cc
    • chrome/test/data/local_ntp/local_ntp_browsertest.js
    • testing/variations/fieldtrial_testing_config.json
  120. [TaskScheduler]: Migrate off of AssertBlockingAllowedDeprecated in /chrome/browser/app_controller_mac.mm

    Changed by etiennepohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:02:10 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision a620e5ec9ccbf30be37fd4004d95ed3c2032334d

    Comments

    [TaskScheduler]: Migrate off of AssertBlockingAllowedDeprecated in /chrome/browser/app_controller_mac.mm
    
    base::AssertBlockingAllowedDeprecated is deprecated in favor of
    ScopedBlockingCall, which serves as a precise annotation of
    the scope that may/will block.
    
    Please make sure of the following:
      - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
        If this is not the case, ScopedBlockingCall should be instantiated
        closer to the blocking call. See scoped_blocking_call.h for 
    ...skip...
    heir
        own internal annotations.
    
    Refer to the top-level CL if necessary :
    https://chromium-review.googlesource.com/c/chromium/src/+/1338391
    
    Please CQ if LGTY!
    
    This CL was uploaded by git cl split.
    
    R=mark@chromium.org
    
    Bug: 903957
    Change-Id: I6b8a4fa67bfabb263bf80d78fb3ca8a295b3fcab
    Reviewed-on: https://chromium-review.googlesource.com/c/1366075
    Reviewed-by: Mark Mentovai <mark@chromium.org>
    Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614433}

    Changed files

    • chrome/browser/app_controller_mac.mm
  121. AXNodeData: Adds the ability to remove attributes and doesn't allow duplicate attributes to be added

    Changed by nektarohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:05:13 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 95fc875c1a7130a6f6e319bacb6c5bc1ea9e1f09

    Comments

    AXNodeData: Adds the ability to remove attributes and doesn't allow duplicate attributes to be added
    
    When trying to work with AXVirtualViews in order to make TableView and TreeView accessible, one quickly realizes that it is not efficient to destroy and re-create all the accessibility nodes that are affected by a selection change.
    While this is inevitable if crossing a process boundary, e.g. serializing and sending modifications to the accessibility tree from the renderer to the browser, it is unnece
    ...skip...
    butes because this has been a source of bugs in the past.
    Instead of a DCHECK I prefer to remove the old attribute and add the new one, because this will not break any existing code.
    R=aleventhal@chromium.org, dmazzoni@chromium.org
    
    Change-Id: I34e566b0d5c9c6b8e2e33187996236913ec6a5b3
    Reviewed-on: https://chromium-review.googlesource.com/c/1365802
    Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614434}

    Changed files

    • ui/accessibility/ax_node_data.cc
    • ui/accessibility/ax_node_data.h
  122. Remove dependency on WindowTreeHost from UIControlsOzone in Mus

    Changed by mukaiohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:06:21 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 8dbf8cb7525f089bfb08506c2ac7e40dccf49ac0

    Comments

    Remove dependency on WindowTreeHost from UIControlsOzone in Mus
    
    The WindowTreeHost is tied with a toplevel window in Mus; removal
    of WindowTreeHost can happen very easily.
    
    Note that this CL only allows two of the three reported failures
    DetachToBrowserTabDragControllerTest.DragAllToSeparateWindow
    DetachToBrowserTabDragControllerTest.DragAllToSeparateWindowAndCancel
    
    DetachToBrowserTabDragControllerTest.DragSingleTabToSeparateWindow
    is confirmed not crashing, but failing anyways.
    
    Bug: 910791
    Test: single_process_mash_interactive_ui_tests
    Change-Id: If2edb91951e01df13c510a1cd71d1d0ed6d45244
    Reviewed-on: https://chromium-review.googlesource.com/c/1363854
    Commit-Queue: Jun Mukai <mukai@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614435}

    Changed files

    • chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
    • ui/aura/test/ui_controls_factory_ozone.cc
  123. Revert "Network Service: Migrate drive::JobScheduler to NetworkConnectionTracker"

    Changed by juncaiohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:06:24 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision bee8665911f1e87abbd90b9aa4e0ccb141ee2575

    Comments

    Revert "Network Service: Migrate drive::JobScheduler to NetworkConnectionTracker"
    
    This reverts commit e2d41b1393eb57790a1634640b1aa149a7c5fc24.
    
    Reason for revert:
    linux-chromeos-rel bot failed at:
    https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/16932
    
    Original change's description:
    > Network Service: Migrate drive::JobScheduler to NetworkConnectionTracker
    > 
    > This CL migrates drive::JobScheduler from NetworkChangeNotifier to
    > NetworkConnectionTracker, which wo
    ...skip...
    no <fukino@chromium.org>
    > Commit-Queue: Jun Cai <juncai@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614393}
    
    TBR=hashimoto@chromium.org,fukino@chromium.org,juncai@chromium.org
    
    Change-Id: I72e70bae035cab91ec3d325d7aec66d9f90b5499
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 887038
    Reviewed-on: https://chromium-review.googlesource.com/c/1366260
    Reviewed-by: Jun Cai <juncai@chromium.org>
    Commit-Queue: Jun Cai <juncai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614436}

    Changed files

    • chrome/browser/chromeos/drive/drive_integration_service.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
    • components/drive/about_resource_loader_unittest.cc
    • components/drive/change_list_loader_unittest.cc
    • components/drive/directory_loader_unittest.cc
    • components/drive/file_system/operation_test_base.cc
    • components/drive/file_system_unittest.cc
    • components/drive/job_scheduler.cc
    • components/drive/job_scheduler.h
    • components/drive/job_scheduler_unittest.cc
    • components/drive/start_page_token_loader_unittest.cc
    • components/drive/sync_client_unittest.cc
    • components/drive/team_drive_change_list_loader_unittest.cc
    • components/drive/team_drive_list_loader_unittest.cc
  124. [bluetooth][win] Force uncached characteristic value reads

    Changed by reillygohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:07:29 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision d810f68079066a4a8f9e9a3c3730fc1bcdf72f7a

    Comments

    [bluetooth][win] Force uncached characteristic value reads
    
    The ReadValueAsync() method will return the characteristic value
    cached by Windows. It appears that when a value is written to a
    characteristic Windows assumes that the device will respond with the
    value written and will update its cache to that value. This is a
    problem for devices which do not follow this behavior and instead
    respond with an unrelated value.
    
    This change switches to using the ReadValueWithCacheModeAsync() method
    and passes the BluetoothCacheMode_Uncached flag in order to force
    Windows to always read the value directly from the device.
    
    Bug: 904114
    Change-Id: I76b214abd0004fc311e1f32a9457273df60a6f54
    Reviewed-on: https://chromium-review.googlesource.com/c/1364393
    Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Commit-Queue: Reilly Grant <reillyg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614437}

    Changed files

    • device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.cc
    • device/bluetooth/test/fake_gatt_characteristic_winrt.cc
  125. IndexedDB: Map mojom key to blink IDBKey

    Changed by cmpohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:11:10 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision f56c0db093f876ac4dc8326b4ef396f458053ce4

    Comments

    IndexedDB: Map mojom key to blink IDBKey
    
    Bug: 717812
    Change-Id: I59d74bd808e2a7e30264ec3a8dafd30964552f0a
    Reviewed-on: https://chromium-review.googlesource.com/c/1354334
    Commit-Queue: Chase Phillips <cmp@chromium.org>
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Reviewed-by: Daniel Murphy <dmurph@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614438}

    Changed files

    • third_party/blink/renderer/bindings/modules/v8/v8_binding_for_modules_test.cc
    • third_party/blink/renderer/modules/indexeddb/BUILD.gn
    • third_party/blink/renderer/modules/indexeddb/idb_cursor.cc
    • third_party/blink/renderer/modules/indexeddb/idb_factory.cc
    • third_party/blink/renderer/modules/indexeddb/idb_key.cc
    • third_party/blink/renderer/modules/indexeddb/idb_key.h
    • third_party/blink/renderer/modules/indexeddb/idb_object_store.cc
    • third_party/blink/renderer/modules/indexeddb/idb_value.cc
    • third_party/blink/renderer/modules/indexeddb/idb_value.h
    • third_party/blink/renderer/modules/indexeddb/indexed_db_blink.typemap
    • third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.cc
    • third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.h
    • third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.cc
    • third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.h
    • third_party/blink/renderer/modules/indexeddb/indexed_db_key_builder.cc
    • third_party/blink/renderer/modules/indexeddb/indexed_db_key_builder.h
    • third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.cc
    • third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.h
    • third_party/blink/renderer/modules/indexeddb/mock_web_idb_database.cc
    • third_party/blink/renderer/modules/indexeddb/mock_web_idb_database.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_callbacks.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_cursor.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl_unittest.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_database.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_database_impl_unittest.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_key.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_key.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_key_range.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_key_range.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_value.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_value.h
  126. Reland "Switch all libFuzzer and AFL builds (except Windows) to is_component_build=true."

    Changed by mmorozohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:11:43 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision b9f77956c8f6e93ff67ad7ef5ae6d1528ae367c1

    Comments

    Reland "Switch all libFuzzer and AFL builds (except Windows) to is_component_build=true."
    
    This is a reland of 446c61f501b4b971c63ba40e1667e5b0d8ca76c8
    
    The reason for the previous revert should be fixed now by https://crrev.com/c/1362457
    
    Original change's description:
    > Switch all libFuzzer and AFL builds (except Windows) to is_component_build=true.
    >
    > Bug: 701825
    > Change-Id: I4b361daa1eae576f402818b467684efa5380df88
    > Reviewed-on: https://chromium-review.googlesource.com/c/1361297
    > Commit-Queue:
    ...skip...
    zman <metzman@chromium.org>
    > Reviewed-by: Ben Pastene <bpastene@chromium.org>
    > Reviewed-by: Abhishek Arya <inferno@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#613700}
    
    Bug: 701825
    Change-Id: I6f6336f7203600a62f760866a54ad03281dd6c13
    Reviewed-on: https://chromium-review.googlesource.com/c/1365084
    Reviewed-by: Abhishek Arya <inferno@chromium.org>
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Commit-Queue: Max Moroz <mmoroz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614439}

    Changed files

    • tools/mb/mb_config.pyl
  127. Revert "Disable the new tab-loading animation"

    Changed by jyasskinohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:13:17 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 742b8857c4dd0ab4550f7b2c1f200ce5be406b9c

    Comments

    Revert "Disable the new tab-loading animation"
    
    This reverts commit 355b8185716292a8f145c77168ee89148ecabf31.
    
    Reason for revert: Made several tests flaky: https://crbug.com/912543
    
    Original change's description:
    > Disable the new tab-loading animation
    > 
    > Makes sure that a lot of animation-related code is bypassed when the
    > new-tab-animation flag is off. This should hopefully fix a couple of
    > performance regressions that have not yet been root caused so that they
    > don't go out with M72.
    > 
    > Bug:
    ...skip...
    pbos@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614199}
    
    TBR=pbos@chromium.org,sdy@chromium.org
    
    Change-Id: Ib4c022a255ad085c1716d3559a7f84dcb61c2785
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:912328, chromium:905745, chromium:905918, chromium:910265
    Reviewed-on: https://chromium-review.googlesource.com/c/1366359
    Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org>
    Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614440}

    Changed files

    • chrome/browser/ui/views/tabs/tab_icon.cc
    • chrome/browser/ui/views/tabs/tab_unittest.cc
    • chrome/common/chrome_features.cc
  128. Roll src/third_party/perfetto 6ae9526278fc..2d82f1496ad6 (5 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 19:16:31 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 6f57571795c09e55baf346db98141204a3a62f65

    Comments

    Roll src/third_party/perfetto 6ae9526278fc..2d82f1496ad6 (5 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/6ae9526278fc..2d82f1496ad6
    
    
    git log 6ae9526278fc..2d82f1496ad6 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 fmayer@google.com Add script to continuously pull and run fuzzers.
    2018-12-06 fmayer@google.com Merge "Add script to run all fuzzers."
    2018-12-06 hjd@google.com Merge "trace_processor: Add regression test for span join two views"
    2018-12-06 hjd@
    ...skip...
    failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:69150303
    TBR=perfetto-bugs@google.com
    
    Change-Id: I7acb4631e389a069d1114f01135ac8354d3950cc
    Reviewed-on: https://chromium-review.googlesource.com/c/1365759
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614441}

    Changed files

    • DEPS
  129. Allow third party cookies for requests from chrome-extension schemes

    Changed by cduvallohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:17:42 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 042756580e2aa3917d3215744f8428d3a4b672b4

    Comments

    Allow third party cookies for requests from chrome-extension schemes
    
    This fixes a regression where requests from extension background pages
    were not getting third party cookies. XHR requests from extensions
    should be allowed to see cookies from URLs that are listed in the
    permissions of the manifest, even if third party cookies are blocked.
    
    A previous change (http://crrev.com/c/1195147) missed this bit of
    functionality from here:
    https://cs.chromium.org/chromium/src/components/content_settings/core/browser/cookie_settings.cc?l=126&rcl=43732e6d56e5b5556590891fcbdb3c53a44fad5f
    
    Bug: 788738
    Change-Id: Ie239f7077772513f54c9d2a9c811774986d24506
    Reviewed-on: https://chromium-review.googlesource.com/c/1364696
    Reviewed-by: Will Harris <wfh@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Commit-Queue: Clark DuVall <cduvall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614442}

    Changed files

    • chrome/browser/net/network_context_configuration_browsertest.cc
    • chrome/browser/net/profile_network_context_service.cc
    • services/network/cookie_manager.cc
    • services/network/cookie_settings.cc
    • services/network/cookie_settings.h
    • services/network/cookie_settings_unittest.cc
    • services/network/public/mojom/cookie_manager.mojom
  130. Exposing ErrorEvent interface to workers.

    Changed by kdillonohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:24:16 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 9ef7e4c4dcae40ae9c40823847f748e80346ae71

    Comments

    Exposing ErrorEvent interface to workers.
    
    According to current specs (https://html.spec.whatwg.org/#the-errorevent-interface)
    the ErrorEvent interface should be exposed to the window and workers.
    
    Bug: 852769
    Change-Id: I38b057113fa6f56d473b75a7f328635f46f73af5
    Reviewed-on: https://chromium-review.googlesource.com/c/1362003
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Katie Dillon <kdillon@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614443}

    Changed files

    • third_party/blink/renderer/core/events/error_event.idl
    • third_party/blink/web_tests/TestExpectations
    • third_party/blink/web_tests/external/wpt/WebIDL/ecmascript-binding/no-regexp-special-casing.any.worker-expected.txt
    • third_party/blink/web_tests/external/wpt/workers/semantics/interface-objects/001.worker-expected.txt
    • third_party/blink/web_tests/external/wpt/workers/semantics/interface-objects/003-expected.txt
    • third_party/blink/web_tests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
    • third_party/blink/web_tests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
    • third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
    • third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
    • third_party/blink/web_tests/webexposed/global-interface-listing-dedicated-worker-expected.txt
    • third_party/blink/web_tests/webexposed/global-interface-listing-shared-worker-expected.txt
  131. Roll src/third_party/skia 69e5785d9f00..ae9dfc0e5845 (6 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 19:28:13 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision a218cc31ad1906bf93bf9d39c00b9a196bded00e

    Comments

    Roll src/third_party/skia 69e5785d9f00..ae9dfc0e5845 (6 commits)
    
    https://skia.googlesource.com/skia.git/+log/69e5785d9f00..ae9dfc0e5845
    
    
    git log 69e5785d9f00..ae9dfc0e5845 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 kjlubick@google.com [canvaskit] In Canvas2d, move matrix to internal canvas
    2018-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader bd49ad09c5ca..c730c3846064 (1 commits)
    2018-12-06 recipe-roller@chromium.org Roll recipe dependenc
    ...skip...
    ;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jcgregorio@chromium.org
    
    Change-Id: Ie5bd98d000c45bc295618bbb85e0b6b816624d3b
    Reviewed-on: https://chromium-review.googlesource.com/c/1365758
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614444}

    Changed files

    • DEPS
  132. Add ErrorProne check to assert use of android.support.annotation.Nullable

    Changed by abennerohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 19:29:41 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision f6f6371df0c9151ab37afb7ec65f15300a764edd

    Comments

    Add ErrorProne check to assert use of android.support.annotation.Nullable
    
    Adds an android ErrorProne check to give a compiler error
    when using javax Nullable instead of android Nullable.
    See bug for motivation.
    
    Bug: 771683
    Change-Id: I6384fa515405159e3fa894303022cad8bfc389b9
    Reviewed-on: https://chromium-review.googlesource.com/c/1363677
    Commit-Queue: Aiden Benner <abenner@google.com>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614445}

    Changed files

    • tools/android/errorprone_plugin/BUILD.gn
    • tools/android/errorprone_plugin/src/org/chromium/tools/errorprone/plugin/AndroidNullableCheck.java
  133. Convert relaxed atomics in AudioHandler derived classes to use std::atomic.

    Changed by jbromanohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:31:22 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 3fa81b306229acf0f78dd41f8d3c89b6d5042596

    Comments

    Convert relaxed atomics in AudioHandler derived classes to use std::atomic.
    
    Bug: 736037
    Change-Id: I47b75930aceca3ec76f9816e0d76418b24e378bf
    Reviewed-on: https://chromium-review.googlesource.com/c/1363907
    Reviewed-by: Hongchan Choi <hongchan@chromium.org>
    Commit-Queue: Jeremy Roman <jbroman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614446}

    Changed files

    • third_party/blink/renderer/modules/webaudio/audio_param.cc
    • third_party/blink/renderer/modules/webaudio/audio_param.h
    • third_party/blink/renderer/modules/webaudio/dynamics_compressor_node.cc
    • third_party/blink/renderer/modules/webaudio/dynamics_compressor_node.h
  134. [Chromecast] Only enable CastAudioMixer where needed

    Changed by kmackayohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:31:25 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 79b4157706b6b2d702d4a431efe3e16a4d72bfc2

    Comments

    [Chromecast] Only enable CastAudioMixer where needed
    
    We only need the mixer in CastAudioManager when the CMA backend does not
    support mixing.
    
    Bug: internal b/79728288
    Change-Id: Ib2950350fd1b72bfd61d8cf42bbec47105e93927
    Reviewed-on: https://chromium-review.googlesource.com/c/1366259
    Reviewed-by: Sergey Volk <servolk@chromium.org>
    Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614447}

    Changed files

    • chromecast/browser/BUILD.gn
    • chromecast/browser/cast_content_browser_client.cc
    • chromecast/chromecast.gni