Home | Search
Login

Builder ToTLinux (dbg) Build #5518

Results:

build successful

Trigger Info:

Got Revision3429b21df57fb03c658e5b63ae81a42f4316a978

Execution:

Steps and Logfiles:

Show:
  1. ( 3 hrs 40 mins ) steps
    running steps via annotated script
  2. ( 5 secs ) update_scripts
    update_scripts
  3. ( 1 ms ) LUCI Migration
    LUCI Migration
  4. ( 1 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 1 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 1 ms ) report builders
    report builders
     
    running builder/tester 'ToTLinux (dbg)' on master 'chromium.clang'
  7. ( 1 ms ) makedirs checkout path
    makedirs checkout path
  8. ( 1 mins 25 secs ) bot_update
    bot_update
    [141GB/492GB used (28%)]
  9. ( 1 ms ) swarming.py --version
    swarming.py --version
    0.14
  10. ( 23 mins 14 secs ) gclient runhooks
    gclient runhooks
  11. ( 1 ms ) get compile targets for scripts
    get compile targets for scripts
  12. ( 1 ms ) read test spec (chromium.clang.json)
    read test spec (chromium.clang.json)
    path: /b/c/b/ToTLinux__dbg_/src/testing/buildbot/chromium.clang.json
  13. ( 1 ms ) lookup GN args
    lookup GN args
     
    clang_use_chrome_plugins = false
    is_clang = true
    is_component_build = true
    is_debug = true
    llvm_force_head_revision = true
  14. ( 13 secs ) generate_build_files
    generate_build_files
  15. ( 8 ms ) clang_revision
    clang_revision
  16. ( 3 hrs 14 mins ) compile
    compile
  17. ( 5 secs ) compile confirm no-op
    compile confirm no-op
  18. ( 1 ms ) upload_ninja_log
    upload_ninja_log
  19. ( 1 ms ) test_pre_run
    test_pre_run
  20. ( 1 secs ) sizes
    sizes
    sizes
    <div class="BuildResultInfo">
    </div>
  21. ( 2 ms ) recipe result
    recipe result

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromium/bb/chromium.clang/ToTLinux__dbg_/5518/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.clang/ToTLinux__dbg_/5518" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "132d15c217e0363626a5d789861b75122f718b5d" Annotation(bot_update)
got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" Annotation(bot_update)
got_dawn_revision "5aacd29d5e7ed44d3cb0d1c690fbd0fc5152978f" Annotation(bot_update)
got_nacl_revision "17af1e818981ebf2c492a678d4d31c9e1ee37fc7" Annotation(bot_update)
got_revision "3429b21df57fb03c658e5b63ae81a42f4316a978" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#614556}" Annotation(bot_update)
got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" Annotation(bot_update)
got_v8_revision "c5bfa5d3b1a5b015ac01228595f8a3e5643f4868" Annotation(bot_update)
got_v8_revision_cp "refs/heads/7.3.52@{#1}" Annotation(bot_update)
got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#25919}" Annotation(bot_update)
got_clang_revision "348559" Annotation(clang_revision)
build_data_dir "/b/rr/tmprdc6Gd" Annotation(steps)
build_id "buildbot/chromium.clang/ToTLinux (dbg)/5518" Annotation(steps)
builder_id "master.chromium.clang:ToTLinux (dbg)" Annotation(steps)
blamelist ["aee@chromium.org","agawronska@chromium.org","agrieve@chromium.org","bsheedy@chromium.org","cduvall@chromium.org","chcunningham@chromium.org","chromium-autoroll@skia-public.iam.gserviceaccount.com","chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com","danakj@chromium.org","davidluphd@google.com","dbeam@chromium.org","dmblack@google.com","dmurph@chromium.org","fdegans@chromium.org","hanxi@google.com","hiroshige@chromium.org","jam@chromium.org","jamescook@chromium.org","jazzhsu@chromium.org","jiahuiguo@chromium.org","jinsukkim@chromium.org","jkarlin@chromium.org","jyasskin@chromium.org","lethalantidote@chromium.org","lukasza@chromium.org","mgiuca@chromium.org","mmoroz@chromium.org","mtlieuu@chromium.org","nednguyen@google.com","newcomer@chromium.org","noel@chromium.org","oysteine@google.com","pdr@chromium.org","qnnguyen@chromium.org","reillyg@chromium.org","rkjnsn@chromium.org","rsesek@chromium.org","sammc@chromium.org","scottchen@chromium.org","sebsg@chromium.org","sergeyu@chromium.org","siyua@chromium.org","smaier@chromium.org","smcgruer@chromium.org","thakis@chromium.org","thomasanderson@chromium.org","vikassoni@chromium.org","yileili@google.com","yusukes@chromium.org","zqzhang@google.com"] Build
branch "master" Build
buildnumber 5518 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src.git" Build
requestedAt 1544134308 Build
revision "3429b21df57fb03c658e5b63ae81a42f4316a978" Build
slavename "slave164-c1" BuildSlave
buildername "ToTLinux (dbg)" Builder
git_revision "3429b21df57fb03c658e5b63ae81a42f4316a978" Change
scheduler "chromium_src_commits" Scheduler
buildbotURL "https://build.chromium.org/p/chromium.clang/" master.cfg
mastername "chromium.clang" master.cfg
workdir "/b/build/slave/ToTLinux__dbg_" slave

Blamelist:

  1. (jinsukkimohnoyoudont@chromium.org)
  2. (thakisohnoyoudont@chromium.org)
  3. (scottchenohnoyoudont@chromium.org)
  4. (newcomerohnoyoudont@chromium.org)
  5. (davidluphdohnoyoudont@google.com)
  6. (lukaszaohnoyoudont@chromium.org)
  7. (jiahuiguoohnoyoudont@chromium.org)
  8. (smaierohnoyoudont@chromium.org)
  9. (cduvallohnoyoudont@chromium.org)
  10. (smcgruerohnoyoudont@chromium.org)
  11. (agrieveohnoyoudont@chromium.org)
  12. (dmurphohnoyoudont@chromium.org)
  13. (lethalantidoteohnoyoudont@chromium.org)
  14. (fdegansohnoyoudont@chromium.org)
  15. (jamescookohnoyoudont@chromium.org)
  16. (sergeyuohnoyoudont@chromium.org)
  17. (sebsgohnoyoudont@chromium.org)
  18. (vikassoniohnoyoudont@chromium.org)
  19. (rkjnsnohnoyoudont@chromium.org)
  20. (jkarlinohnoyoudont@chromium.org)
  21. (bsheedyohnoyoudont@chromium.org)
  22. (pdrohnoyoudont@chromium.org)
  23. (danakjohnoyoudont@chromium.org)
  24. (chcunninghamohnoyoudont@chromium.org)
  25. (hiroshigeohnoyoudont@chromium.org)
  26. (nednguyenohnoyoudont@google.com)
  27. (zqzhangohnoyoudont@google.com)
  28. (jyasskinohnoyoudont@chromium.org)
  29. (reillygohnoyoudont@chromium.org)
  30. (aeeohnoyoudont@chromium.org)
  31. (dbeamohnoyoudont@chromium.org)
  32. (rsesekohnoyoudont@chromium.org)
  33. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  34. (mmorozohnoyoudont@chromium.org)
  35. (lukaszaohnoyoudont@chromium.org)
  36. (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  37. (hanxiohnoyoudont@google.com)
  38. (reillygohnoyoudont@chromium.org)
  39. (agawronskaohnoyoudont@chromium.org)
  40. (oysteineohnoyoudont@google.com)
  41. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  42. (yusukesohnoyoudont@chromium.org)
  43. (mgiucaohnoyoudont@chromium.org)
  44. (qnnguyenohnoyoudont@chromium.org)
  45. (jyasskinohnoyoudont@chromium.org)
  46. (noelohnoyoudont@chromium.org)
  47. (jamohnoyoudont@chromium.org)
  48. (dmblackohnoyoudont@google.com)
  49. (mtlieuuohnoyoudont@chromium.org)
  50. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  51. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  52. (thomasandersonohnoyoudont@chromium.org)
  53. (yileiliohnoyoudont@google.com)
  54. (siyuaohnoyoudont@chromium.org)
  55. (jazzhsuohnoyoudont@chromium.org)
  56. (sammcohnoyoudont@chromium.org)

Timing:

Create N/A
Start Friday, 07-Dec-18 01:28:07 UTC
End Friday, 07-Dec-18 05:08:31 UTC
Pending N/A
Execution 3 hrs 40 mins

All Changes:

  1. Revert "Reland "Android: Factor InProductHelp UI out of Tab""

    Changed by jinsukkimohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 22:10:37 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision fbe75ef510a9d9123f6c7f8cbd54d5f5b5680277

    Comments

    Revert "Reland "Android: Factor InProductHelp UI out of Tab""
    
    This reverts commit 76d39b3a8d8fbd0e990f92a992d80213724de9bd.
    
    Reason for revert:  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Oreo%20Phone%20Tester/2097 
    
    https://crbug.com/907602 doesn't seem to be addressed.
    
    Original change's description:
    > Reland "Android: Factor InProductHelp UI out of Tab"
    > 
    > 
    > https://chromium-review.googlesource.com/c/chromium/src/+/1272779 had a couple
    > of bugs in |ToolbarButtonInProductHelpC
    ...skip...
    nsuk Kim <jinsukkim@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614161}
    
    TBR=twellington@chromium.org,jinsukkim@chromium.org
    
    Change-Id: Id92d47e6ac65a0b1a50f4ad4cb1c0b9a11189993
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 889682, 907502, 907503, 907770, 907505, 907602
    Reviewed-on: https://chromium-review.googlesource.com/c/1366456
    Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
    Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614501}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarButtonInProductHelpController.java
  2. Explicitly list all $root_out_dir/resources/inspector files in the isolate.

    Changed by thakisohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:20:39 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision f213164d219da210c4c0383d4878c02633599965

    Comments

    Explicitly list all $root_out_dir/resources/inspector files in the isolate.
    
    Listing a generated directory in the isolate means that incremental
    builders (and devs doing incremental builds) can have stale files in
    their generated isolated files.
    
    Bug: 911761
    Change-Id: I8652b272b44b031771e4458d43d5091abb093428
    Reviewed-on: https://chromium-review.googlesource.com/c/1366443
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614502}

    Changed files

    • BUILD.gn
    • third_party/blink/renderer/devtools/BUILD.gn
  3. Navi Onboarding: fix double-recording Welcome.SigninPrompt

    Changed by scottchenohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:56:04 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 9dfaf94c590c701314cb691deb74eb194468930c

    Comments

    Navi Onboarding: fix double-recording Welcome.SigninPrompt
    
    Welcome.SigninPrompt was doubly recorded because during onboarding we
    sometimes redirect users back to the welcome page. This CL fixes the issue
    by detecting if the welcome page instance is a redirected impression, and
    skip recording SigninPrompt if so.
    
    Bug: 905785
    Change-Id: Iff60b8813ee8a1f6c1f2eb3887b32356a5e3e00e
    Reviewed-on: https://chromium-review.googlesource.com/c/1362199
    Reviewed-by: Hector Carmona <hcarmona@chromium.org>
    Commit-Queue: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614503}

    Changed files

    • chrome/browser/ui/webui/welcome/welcome_handler.cc
    • chrome/browser/ui/webui/welcome/welcome_handler.h
  4. cros: Remove the touchable app context menu flag.

    Changed by newcomerohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:56:08 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision b0cb7753a7379fe8910ea1dda4d70915f45f4e5e

    Comments

    cros: Remove the touchable app context menu flag.
    
    The feature has been enabled by default, so remove the flag.
    
    Bug: 906684
    Change-Id: I0ea6f282ef1054c1098fbb8b9fd4b537088db74b
    Reviewed-on: https://chromium-review.googlesource.com/c/1351752
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Alex Newcomer <newcomer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614504}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • ui/base/ui_base_features.cc
    • ui/base/ui_base_features.h
  5. Add doodle sharing to local NTP. Sharing consists of a sharing button and a sharing dialog box. Also includes browser tests.

    Changed by davidluphdohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 00:57:11 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision c81cefa5985be68912e54cfbd5a3d8467b25f2ce

    Comments

    Add doodle sharing to local NTP. Sharing consists of a sharing button and a sharing dialog box. Also includes browser tests.
    
    Bug:896461
    
    -Enable using the Google local NTP -> Enabled
    -Enable doodles on the local NTP -> Enabled
    -?force-doodle=0 (for simple) or ?force-doodle=1 (for animated)
    
    Test: Set the following flags in chrome://flags:
    Change-Id: If900a18e2cada746132d894aa104f273f914bd90
    Reviewed-on: https://chromium-review.googlesource.com/c/1330356
    Reviewed-by: Kyle Milka <kmilka@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Commit-Queue: David Lu <davidluphd@google.com>
    Cr-Commit-Position: refs/heads/master@{#614505}

    Changed files

    • chrome/browser/resources/local_ntp/icons/close.svg
    • chrome/browser/resources/local_ntp/icons/copy.svg
    • chrome/browser/resources/local_ntp/icons/facebook.svg
    • chrome/browser/resources/local_ntp/icons/mail.svg
    • chrome/browser/resources/local_ntp/icons/twitter.svg
    • chrome/browser/resources/local_ntp/local_ntp.css
    • chrome/browser/resources/local_ntp/local_ntp.html
    • chrome/browser/resources/local_ntp/local_ntp.js
    • chrome/browser/search/local_ntp_source.cc
    • chrome/browser/ui/search/local_ntp_doodle_browsertest.cc
    • components/search_provider_logos/google_logo_api.cc
    • components/search_provider_logos/logo_cache.cc
    • components/search_provider_logos/logo_common.h
  6. Also considering about:srcdoc in url::Origin::Resolve.

    Changed by lukaszaohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:57:16 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision b309508508f232e7a91aa34891f652313afa7840

    Comments

    Also considering about:srcdoc in url::Origin::Resolve.
    
    about:srcdoc inherits the origin of its parent frame (similarly to
    about:blank).  Therefore url::Origin::Resolve should also consider
    about:srcdoc.
    
    Bug: 911683
    Change-Id: I114cdd21ff5b317c38cd50e648a16fb0879ceed9
    Reviewed-on: https://chromium-review.googlesource.com/c/1361284
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614506}

    Changed files

    • url/origin.cc
    • url/origin_unittest.cc
  7. [M72] Add tooltip on Save card prompt to explain saving the card to

    Changed by jiahuiguoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:58:17 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 6a4e41ee265aa46f1c650cd1c8bdaf84b166c32b

    Comments

    [M72] Add tooltip on Save card prompt to explain saving the card to
    Google Account in Butter mode.
    
    
    BUG: 905393
    Change-Id: I71eca987c5e2d865efbd6bc00b6212b160f5ea3a
    Reviewed-on: https://chromium-review.googlesource.com/c/1357634
    Reviewed-by: Evan Stade <estade@chromium.org>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Commit-Queue: Jason Guo <jiahuiguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614507}

    Changed files

    • chrome/browser/ui/views/autofill/save_card_offer_bubble_views.cc
    • chrome/browser/ui/views/autofill/save_card_offer_bubble_views.h
    • components/autofill_strings.grdp
  8. Android: cleaning up some Proguard flags

    Changed by smaierohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:58:21 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision a48fa4727e3291b992bd9e7f30e69f6112392493

    Comments

    Android: cleaning up some Proguard flags
    
    Making these keep rules more explicit.
    
    Bug: 887942
    Change-Id: I70038c8c58025892a7003fad5bb3ff83384f13f5
    Reviewed-on: https://chromium-review.googlesource.com/c/1366262
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Sam Maier <smaier@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614508}

    Changed files

    • chrome/android/java/proguard.flags
  9. Support using gtest_filter and test-launcher-filter-file together on Android

    Changed by cduvallohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:59:23 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 10692b98cca291e29f79fe8df9aae71b1ac452ff

    Comments

    Support using gtest_filter and test-launcher-filter-file together on Android
    
    These args used to be mutually exclusive, which would cause errors when
    retrying the Android network service tests (which use
    --test-launcher-filter-file). This combines the filters specified in the
    filter file with the gtest_filter argument.
    
    See here for an example of a failure:
    https://chromium-swarm.appspot.com/task?id=41984d0ac388e010
    
    Bug: 880915
    Change-Id: I2fee107d13c44bd90cd9532bcabda4bb12f7e111
    Reviewed-on: https://chromium-review.googlesource.com/c/1364071
    Commit-Queue: Clark DuVall <cduvall@chromium.org>
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614509}

    Changed files

    • build/android/pylib/utils/test_filter.py
    • build/android/pylib/utils/test_filter_test.py
  10. [ScrollTimeline] Upstream based currentTime tests to WPT

    Changed by smcgruerohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:59:26 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 42baeb7ae71e916dc19433ce698de5c02d5fa169

    Comments

    [ScrollTimeline] Upstream based currentTime tests to WPT
    
    This CL starts to upstream the currentTime tests to WPT. To split this
    up, we start with just the 'basic' tests - basic functionality,
    adjusting for time range, and start/end scroll offsets. The writing mode
    and NaN tests will follow in later patches.
    
    There are a few mostly non-behavioral changes to the tests in this CL:
    
      * Some comments were edited for clarity.
      * For tests with more than one assert_equals(), descriptions were
        added to
    ...skip...
    es not print out the line number of a failure.
      * In a few places we had more than one assert_equals for the same
        scenario (e.g. multiple cases where scroll was after the
        startScrollOffset point). These have been deduplicated.
    
    Bug: 911254
    Change-Id: I783fcf7f43cda876defa9c36db9a0e7dff4e82c7
    Reviewed-on: https://chromium-review.googlesource.com/c/1366297
    Reviewed-by: Yi Gu <yigu@chromium.org>
    Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614510}

    Changed files

    • third_party/blink/web_tests/external/wpt/scroll-animations/current-time.html
    • third_party/blink/web_tests/external/wpt/scroll-animations/resources/scrolltimeline-utils.js
    • third_party/blink/web_tests/fast/animation/scroll-animations/scrolltimeline-currenttime.html
  11. Android: Don't create .srcjar for generated version_info file

    Changed by agrieveohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:00:28 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 09e78caaf8a95c230efdd010b1c11a828d7a421d

    Comments

    Android: Don't create .srcjar for generated version_info file
    
    Bug: 908479
    Change-Id: Ibb6192e9c77342b67e0342e724de18c87a021b1f
    Reviewed-on: https://chromium-review.googlesource.com/c/1364611
    Reviewed-by: Paul Miller <paulmiller@chromium.org>
    Commit-Queue: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614511}

    Changed files

    • components/version_info/android/BUILD.gn
  12. [IndexedDB] Testing ordering and error handling for transaction.commit

    Changed by dmurphohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:00:31 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision b0bd6d5bc0487315bdc89ba96df55b318cadc7b6

    Comments

    [IndexedDB] Testing ordering and error handling for transaction.commit
    
    * Tests that transaction ordering is consistent, even if a transaction
      calls commit().
    * Tests that request errors cause a commit()-ed transaction to abort.
    
    The second case seems to be broken in our implementation.
    
    R=andreasbutler@google.com, cmp@chromium.org
    
    Bug: 911877
    Change-Id: I47da6ce9d350f6c47afcd02cf808d4fefb5f013f
    Reviewed-on: https://chromium-review.googlesource.com/c/1362477
    Commit-Queue: Daniel Murphy <dmurph@chromium.org>
    Reviewed-by: Chase Phillips <cmp@chromium.org>
    Reviewed-by: Victor Costan <pwnall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614512}

    Changed files

    • third_party/blink/web_tests/external/wpt/IndexedDB/idb-explicit-commit.any-expected.txt
    • third_party/blink/web_tests/external/wpt/IndexedDB/idb-explicit-commit.any.js
    • third_party/blink/web_tests/external/wpt/IndexedDB/idb-explicit-commit.any.worker-expected.txt
  13. Gives Media Element focus upon mouse iteration.

    Changed by lethalantidoteohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:01:34 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 4c0284d5fa813c6b993da4ac57a54db665c2b523

    Comments

    Gives Media Element focus upon mouse iteration.
    
    This change makes it such that when a user interacts with the media element
    or its controls,the media element will be given focus. This allows one to use
    the keyboard controls to control the video.
    
    Bug: 827565
    Change-Id: I21a6d5ab2b75aeb3bf646c694eeac62f787c89aa
    Reviewed-on: https://chromium-review.googlesource.com/c/1292814
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614513}

    Changed files

    • third_party/blink/renderer/core/html/media/html_media_element.cc
    • third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
    • third_party/blink/web_tests/fullscreen/full-screen-test.js
    • third_party/blink/web_tests/fullscreen/video-controls-timeline.html
    • third_party/blink/web_tests/media/controls/video-enter-exit-fullscreen-without-hovering-doesnt-show-controls.html
    • third_party/blink/web_tests/media/video-controls-mouse-events-captured.html
    • third_party/blink/web_tests/media/video-mouse-focus.html
  14. [Fuchsia] Remove the batch limit for net_unittests

    Changed by fdegansohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:01:59 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 9de2c414af3dcffebb07593f33da6d4a0815301a

    Comments

    [Fuchsia] Remove the batch limit for net_unittests
    
    Bug: 844416, 847915
    Change-Id: Id9b4d2a330978e81863557665ba0aa66889cc4bf
    Reviewed-on: https://chromium-review.googlesource.com/c/1364079
    Reviewed-by: Wez <wez@chromium.org>
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614514}

    Changed files

    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/test_suites.pyl
  15. Fix double-parenting in AXWindowObjWrapper under mash

    Changed by jamescookohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:02:42 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision a15d7535017f58556cb996cb75328512d91efe5d

    Comments

    Fix double-parenting in AXWindowObjWrapper under mash
    
    Under mus/mash both the WindowTreeHost's root aura::Window and the content
    aura::Window will return the same Widget for GetWidgetForNativeView(). Only
    return the Widget for the content window, not the root, since otherwise
    we'll end up with two children in the AX node tree that have the same
    parent.
    
    This allows AXAuraWindowUtilsTest to run under views_mus_unittests and
    unblocks some future tests.
    
    Bug: 911945, 911776
    Test: views_unittests, views_mus_unittests
    Change-Id: I554c77e0dca90f1901a42d3331bca0a05e7bbd88
    Reviewed-on: https://chromium-review.googlesource.com/c/1365986
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614515}

    Changed files

    • ui/views/BUILD.gn
    • ui/views/accessibility/ax_window_obj_wrapper.cc
  16. Fuchsia: Use SandboxPolicyFuchsia for context process.

    Changed by sergeyuohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:03:04 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision df0d5a5590ab54ffcc074b8dcc0ca2ed92a06a60

    Comments

    Fuchsia: Use SandboxPolicyFuchsia for context process.
    
    1. Updated SandboxPolicyFuchsia to support sandbox policy for context
       process.
    2. Updated ContextProviderImpl to use SandboxPolicyFuchsia.
    3. SandboxPolicyFuchsia now provides Vulkan access to Context process.
    
    Bug: 861853
    Change-Id: If0e72e424bbadc0199a1c06e7c27e5df4245c7c7
    Reviewed-on: https://chromium-review.googlesource.com/c/1354563
    Reviewed-by: Wez <wez@chromium.org>
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614516}

    Changed files

    • services/service_manager/sandbox/fuchsia/sandbox_policy_fuchsia.cc
    • services/service_manager/sandbox/fuchsia/sandbox_policy_fuchsia.h
    • services/service_manager/sandbox/sandbox_type.h
    • webrunner/BUILD.gn
    • webrunner/service/context_provider_impl.cc
  17. [AF] Add SyncState suffix to some key autofill metrics.

    Changed by sebsgohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:03:47 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 119a2fe85a3ae98d60d9e5a5b0837c20cb21bfb3

    Comments

    [AF] Add SyncState suffix to some key autofill metrics.
    
    The suffixes describing the sync state are:
    SignedOut
    SignedIn
    kSignedInAndWalletSyncTransportEnabled
    SignedInAndSyncFeature
    
    The metrics that will have those suffixes are
    Autofill.FormEvents
    Autofill.IsEnabled.PageLoad
    Autofill.SaveCreditCardPrompt
    
    The previous histograms will continue to be logged. This is only
    additional logging.
    
    Bug: 903290
    Change-Id: Ibc96a1db12408f13d40fe75ed9aec96af80eac96
    Reviewed-on: https://chromium-review.googlesource.com/c/1326602
    Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Reviewed-by: Jesse Doherty <jwd@chromium.org>
    Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614517}

    Changed files

    • chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
    • chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
    • chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
    • components/autofill/core/browser/BUILD.gn
    • components/autofill/core/browser/autofill_external_delegate_unittest.cc
    • components/autofill/core/browser/autofill_manager.cc
    • components/autofill/core/browser/autofill_manager.h
    • components/autofill/core/browser/autofill_manager_unittest.cc
    • components/autofill/core/browser/autofill_metrics.cc
    • components/autofill/core/browser/autofill_metrics.h
    • components/autofill/core/browser/autofill_metrics_unittest.cc
    • components/autofill/core/browser/personal_data_manager.cc
    • components/autofill/core/browser/personal_data_manager.h
    • components/autofill/core/browser/personal_data_manager_unittest.cc
    • components/autofill/core/browser/sync_utils.h
    • components/autofill/core/browser/test_autofill_client.cc
    • components/autofill/core/browser/test_autofill_client.h
    • tools/metrics/histograms/histograms.xml
  18. Import AHardwareBuffer into a Vulkan Image.

    Changed by vikassoniohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:04:09 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision c8e53d0f70e2e8bc9736e55cacd1bf939efc18da

    Comments

    Import AHardwareBuffer into a Vulkan Image.
    
    Added a utility function to create a vulkan image and import AHardwareBuffer
    created outside of vulkan device into a vulkan image.
    
    Bug: 891060
    Change-Id: Id6a81c0b21e53bac4c439c3a7d8f787cbc32b68b
    Reviewed-on: https://chromium-review.googlesource.com/c/1357658
    Commit-Queue: vikas soni <vikassoni@chromium.org>
    Reviewed-by: Eric Karl <ericrk@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614518}

    Changed files

    • components/viz/common/BUILD.gn
    • gpu/vulkan/BUILD.gn
    • gpu/vulkan/android/vulkan_android_unittests.cc
    • gpu/vulkan/android/vulkan_implementation_android.cc
    • gpu/vulkan/android/vulkan_implementation_android.h
    • gpu/vulkan/generate_bindings.py
    • gpu/vulkan/vulkan_function_pointers.cc
    • gpu/vulkan/vulkan_function_pointers.h
    • gpu/vulkan/vulkan_implementation.h
  19. Add BufferedFileWriter class.

    Changed by rkjnsnohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:04:52 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision ad6a38199aa947ed053a75a19b89172f4a4ee0ba

    Comments

    Add BufferedFileWriter class.
    
    FileOperations::Writer only allows one operation to be pending at a
    time, while chunks from the network will be delivered to
    FileTransferMessageHandler as soon as they arrive. BufferedFileWriter
    will sit between the two and maintain a queue of chunks to be written,
    passing them to the Writer in sequence.
    
    Bug: 679313
    Change-Id: Id10c8d3f34c4811feb373e6cb60f470d2a2a59d5
    Reviewed-on: https://chromium-review.googlesource.com/c/1362455
    Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
    Reviewed-by: Joe Downing <joedow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614519}

    Changed files

    • remoting/host/file_transfer/BUILD.gn
    • remoting/host/file_transfer/buffered_file_writer.cc
    • remoting/host/file_transfer/buffered_file_writer.h
    • remoting/host/file_transfer/buffered_file_writer_unittest.cc
    • remoting/host/file_transfer/fake_file_operations.cc
    • remoting/host/file_transfer/fake_file_operations.h
  20. Plumb the top frame origin of resource requests to the net stack

    Changed by jkarlinohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:05:14 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision be37f9105bb8760e009c71e61770b514449fe398

    Comments

    Plumb the top frame origin of resource requests to the net stack
    
    In order to experiment with splitting the disk cache by top frame
    origin, we'll need to plumb the top frame origin up to the network stack
    for each resource request.
    
    We're focused on just document subresource requests and navigation
    requests for now because that's the majority of request types and this
    is meant to support an early experiment. We will need to include other
    types of requests (e.g., from workers, or signed exchange redire
    ...skip...
    redirect. Top frame navigations do however.
    
    Bug: 898855
    Change-Id: I86a1c5a61986d15c445991c4e50482209f051cca
    Reviewed-on: https://chromium-review.googlesource.com/c/1335869
    Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Camille Lamy <clamy@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Reviewed-by: Mike West <mkwst@chromium.org>
    Commit-Queue: Josh Karlin <jkarlin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614520}

    Changed files

    • content/browser/devtools/devtools_url_loader_interceptor.cc
    • content/browser/frame_host/navigation_request.cc
    • content/browser/frame_host/navigation_request_info.cc
    • content/browser/frame_host/navigation_request_info.h
    • content/browser/frame_host/navigator_impl_unittest.cc
    • content/browser/loader/navigation_url_loader_impl.cc
    • content/browser/loader/navigation_url_loader_impl_unittest.cc
    • content/browser/loader/navigation_url_loader_unittest.cc
    • content/browser/loader/resource_dispatcher_host_impl.cc
    • content/browser/loader/resource_dispatcher_host_unittest.cc
    • content/browser/navigation_browsertest.cc
    • content/common/service_worker/service_worker_loader_helpers.cc
    • content/common/throttling_url_loader.cc
    • content/renderer/loader/web_url_loader_impl.cc
    • content/renderer/loader/web_url_loader_impl_unittest.cc
    • content/test/data/page_with_iframe_and_image.html
    • headless/test/test_network_interceptor.cc
    • net/url_request/redirect_info.cc
    • net/url_request/redirect_info.h
    • net/url_request/redirect_info_unittest.cc
    • net/url_request/url_request.cc
    • net/url_request/url_request.h
    • net/url_request/url_request_job.cc
    • net/url_request/url_request_unittest.cc
    • services/network/public/cpp/net_ipc_param_traits.h
    • services/network/public/cpp/network_ipc_param_traits.h
    • services/network/public/cpp/resource_request.h
    • services/network/url_loader.cc
    • third_party/blink/public/platform/web_url_loader_client.h
    • third_party/blink/public/platform/web_url_request.h
    • third_party/blink/renderer/core/dom/document.cc
    • third_party/blink/renderer/core/dom/document.h
    • third_party/blink/renderer/core/exported/web_document_test.cc
    • third_party/blink/renderer/core/loader/frame_fetch_context.cc
    • third_party/blink/renderer/core/loader/frame_fetch_context.h
    • third_party/blink/renderer/platform/exported/web_url_request.cc
    • third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
    • third_party/blink/renderer/platform/loader/fetch/resource_loader.h
    • third_party/blink/renderer/platform/loader/fetch/resource_request.cc
    • third_party/blink/renderer/platform/loader/fetch/resource_request.h
    • third_party/blink/renderer/platform/loader/fetch/resource_request_test.cc
    • third_party/blink/renderer/platform/testing/weburl_loader_mock.cc
  21. Disable standard instrumentation tests on O

    Changed by bsheedyohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:05:57 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 0183346307f959af42efec29b8ee773c15a8b00c

    Comments

    Disable standard instrumentation tests on O
    
    chrome_public_test_apk and webview_instrumentation_test_apk have always
    failed on O and end up burning a lot of device time with no one actively
    monitoring them or trying to fix them. This combined with the few number
    of devices that have Oreo means that the other tests that run on Oreo
    that are monitored can end up not running due to capacity issues. So,
    disable these tests on Oreo until they're either fixed or more capacity
    is added.
    
    Bug: 884413
    Change-Id: Ica3a501ed078075dfb462f9cbcd7b3f26cb8dcad
    Reviewed-on: https://chromium-review.googlesource.com/c/1366255
    Reviewed-by: Ben Pastene <bpastene@chromium.org>
    Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614521}

    Changed files

    • testing/buildbot/chromium.android.json
    • testing/buildbot/test_suite_exceptions.pyl
  22. Rename the last vestiges of "SlimmingPaintV2" to "CompositeAfterPaint"

    Changed by pdrohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:06:19 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 10022953931784acabd9033bba08839e8aaa46c6

    Comments

    Rename the last vestiges of "SlimmingPaintV2" to "CompositeAfterPaint"
    
    This patch cleans up a few remaining instances of Slimming Paint V2
    since it has been renamed Composite After Paint.
    
    Bug: 909899
    Change-Id: Ibb09cb7c603b10359ce6e5e954f2c67bd395a906
    Reviewed-on: https://chromium-review.googlesource.com/c/1366257
    Reviewed-by: vmpstr <vmpstr@chromium.org>
    Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
    Commit-Queue: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614522}

    Changed files

    • cc/layers/layer.h
    • cc/trees/layer_tree_host.cc
    • cc/trees/layer_tree_host_impl.cc
    • cc/trees/property_tree.h
    • third_party/blink/web_tests/virtual/composite-after-paint/compositing/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/fast/block/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/fast/borders/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/fast/clip/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/fast/css/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/fast/overflow/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/fast/repaint/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/paint/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/paint/subpixel/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/svg/README.txt
    • tools/metrics/histograms/histograms.xml
  23. Update TODO about hiding the main frame RenderWidget when swapping out

    Changed by danakjohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:07:02 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision cc8b1e563f106abfcd3e153bcaf03f3c6a272d81

    Comments

    Update TODO about hiding the main frame RenderWidget when swapping out
    
    Combine 2 TODOs into one explanation about why this is done for main
    frames only (subframes don't need it since we drop the RenderWidget
    when the frame is detached during SwapOut).
    
    R=creis@chromium.org
    
    Change-Id: Ib10c51401994f9a3a6d8270b45eb1006297ecb50
    Bug: 908582
    Reviewed-on: https://chromium-review.googlesource.com/c/1362104
    Reviewed-by: Charlie Reis <creis@chromium.org>
    Commit-Queue: danakj <danakj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614523}

    Changed files

    • content/browser/frame_host/render_frame_host_manager.cc
  24. Refactor decoder support query utils

    Changed by chcunninghamohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:07:27 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 78534522cdb0c3881263661a2aba2606f246bf76

    Comments

    Refactor decoder support query utils
    
    Until now, media/ decoder capabilities were described by
    media/base/decode_capabilities.*. Embedders could override those
    abilities via MediaClient. This meant 2 steps to query for
    what configs were supported
    1) if MediaClient exists, ask it
    2) fallback to functions in decode_capabilites
    
    We have two places where these steps should be followed:
    MimeUtilInternal and WebMediaCapabilitiesClientImpl. Until now,
    only MimeUtilInternal did both.
    
    We anticipate a third ca
    ...skip...
     *DecoderConfig and
    *Type is a closer match to the web APIs we're trying to serve
    (IsTypeSupported and CanPlayType).
    
    Change-Id: I5c49d28f3d7ad9e824388cb346369795c3a621f9
    Bug: 911823
    Reviewed-on: https://chromium-review.googlesource.com/c/1361938
    Reviewed-by: Sergey Volk <servolk@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
    Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614524}

    Changed files

    • chromecast/renderer/cast_content_renderer_client.cc
    • chromecast/renderer/cast_content_renderer_client.h
    • content/public/renderer/content_renderer_client.cc
    • content/public/renderer/content_renderer_client.h
    • content/renderer/media/render_media_client.cc
    • content/renderer/media/render_media_client.h
    • media/base/BUILD.gn
    • media/base/decode_capabilities.h
    • media/base/key_systems_unittest.cc
    • media/base/media_client.h
    • media/base/media_types.h
    • media/base/mime_util_internal.cc
    • media/base/supported_types.cc
    • media/base/supported_types.h
    • media/base/supported_types_unittest.cc
    • media/blink/webmediacapabilitiesclient_impl.cc
    • media/renderers/audio_renderer_impl_unittest.cc
  25. Remove IsNestedWorker()

    Changed by hiroshigeohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:08:08 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 8b47801ae2af0092ff6f701c8b21de5cc744ad93

    Comments

    Remove IsNestedWorker()
    
    No longer used after
    https://chromium-review.googlesource.com/1351929.
    
    Bug: 880027
    Change-Id: Ic8e633dca12f60431530f803730286b02927cd3f
    Reviewed-on: https://chromium-review.googlesource.com/c/1350902
    Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Reviewed-by: Nate Chapin <japhet@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614525}

    Changed files

    • third_party/blink/renderer/core/workers/dedicated_worker_global_scope.cc
    • third_party/blink/renderer/core/workers/dedicated_worker_global_scope.h
    • third_party/blink/renderer/core/workers/dedicated_worker_thread.cc
    • third_party/blink/renderer/core/workers/dedicated_worker_thread.h
    • third_party/blink/renderer/core/workers/worker_global_scope.h
  26. Simplify json source side of performance_test_suite of linux-perf-fyi bot

    Changed by nednguyenohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 01:08:52 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision f5dfc4fc873896dc668f7060914800c4e48a0b0f

    Comments

    Simplify json source side of performance_test_suite of linux-perf-fyi bot
    
    The *_layout_ng tests are currently not running (see https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/linux-perf-fyi/417), so cleaning them up to prepare
    for further refactoring
    
    Bug: 902089
    Change-Id: Iadd871b8975793fdfcd848be06de690f40cf2058
    Reviewed-on: https://chromium-review.googlesource.com/c/1361929
    Commit-Queue: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614526}

    Changed files

    • testing/buildbot/chromium.perf.fyi.json
  27. [Clank MR] Fix several issues in FlingingControllerAdapter

    Changed by zqzhangohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 01:09:55 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 118df4e7ec6d5ce91fd45bddde32c384b6f59c6c

    Comments

    [Clank MR] Fix several issues in FlingingControllerAdapter
    
    RemoteMediaClient.getApproximateStreamPosition() is expensive for
    polling as it has an internal lock. This CL will calculate the
    approximate stream position in Clank, so we only read from
    RemoteMediaClient upon status update. A new class
    (StreamPositionExtrapolator) is migrated from the non-CAF code,
    which is used as a helper class for position calculation.
    
    Also the loaded state is cleared if the player state is idle and
    finished, which solves the "seek after finished" issue.
    
    Bug: 711860
    Change-Id: I95b1fe67f3ae12ef7012c6ce1f5e7fe7af2d13be
    Reviewed-on: https://chromium-review.googlesource.com/c/1364065
    Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
    Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614527}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/media/router/caf/remoting/FlingingControllerAdapter.java
    • chrome/android/java/src/org/chromium/chrome/browser/media/router/caf/remoting/StreamPositionExtrapolator.java
    • chrome/android/java_sources.gni
  28. Revert "[AF] Test that removing wallet data results in removing wallet metadata"

    Changed by jyasskinohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:09:58 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 7810b8be795d32099d6589963c0ed8949106bbab

    Comments

    Revert "[AF] Test that removing wallet data results in removing wallet metadata"
    
    This reverts commit f16eb38ad60352dbdf7241ebb0f40b546d1197a1.
    
    Reason for revert: FindIt says its tests are flaky: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZjE2ZWIzOGFkNjAzNTJkYmRmNzI0MWViYjBmNDBiNTQ2ZDExOTdhMQw
    
    Original change's description:
    > [AF] Test that removing wallet data results in removing wallet metadata
    > 
    > This CL adds t
    ...skip...
    ewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#613261}
    
    TBR=sebsg@chromium.org,jkrcal@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 894001, 911953
    Change-Id: I20bb26bbd973d8ee7411c3269dc4ab6f98e0e272
    Reviewed-on: https://chromium-review.googlesource.com/c/1366876
    Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org>
    Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614528}

    Changed files

    • chrome/browser/sync/test/integration/two_client_wallet_sync_test.cc
    • chrome/browser/sync/test/integration/wallet_helper.cc
    • chrome/browser/sync/test/integration/wallet_helper.h
  29. [bluetooth][win] Force uncached descriptor value reads

    Changed by reillygohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:11:01 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision dc08cacbde1ee26cbe43bbf576097dd9528467f2

    Comments

    [bluetooth][win] Force uncached descriptor value reads
    
    This is a follow-up to r614437 which updates ReadRemoteDescriptor() to also use
    the uncached variant of the ReadValueAsync() function so as not to return a
    stale value.
    
    Bug: 904114
    Change-Id: Ifb7e0be25f799eadc4f1e65aea6c6c5850649019
    Reviewed-on: https://chromium-review.googlesource.com/c/1366321
    Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Commit-Queue: Reilly Grant <reillyg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614529}

    Changed files

    • device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.cc
    • device/bluetooth/test/fake_gatt_descriptor_winrt.cc
  30. WebUI: cr-slider, simplify slider logic by removing |updateValueInstantly| property

    Changed by aeeohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:11:05 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 52964c260bee1e96f746517215ac398ccd2c67ba

    Comments

    WebUI: cr-slider, simplify slider logic by removing |updateValueInstantly| property
    
    |updateValueInstantly| is only used by the display size slider. The property
    was passed through settings-slider. This CL moves the |updateValueInstantly|
    logic to settings-slider.
    
    The reasoning is that cr-slider had a property |value| that represents the
    slider value unless the slider was in a dragging state and
    |updateValueInstantly| was false. A new value called |immediateValue_|
    was added to always have the correc
    ...skip...
     |pref.value|. Instead of having two properties in
    cr-slider and one property in settings-slider to store the slider value,
    moving the |updateValueInstantly| logic to settings-slider significantly
    simplifies the code.
    
    Bug: 902873
    Change-Id: I5d5d8771aa8246850bfd9b4926d820180e43c211
    Reviewed-on: https://chromium-review.googlesource.com/c/1363642
    Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614530}

    Changed files

    • chrome/browser/resources/settings/controls/settings_slider.html
    • chrome/browser/resources/settings/controls/settings_slider.js
    • chrome/test/data/webui/cr_elements/cr_slider_test.js
    • chrome/test/data/webui/settings/settings_slider_tests.js
    • ui/webui/resources/cr_elements/cr_slider/cr_slider.html
    • ui/webui/resources/cr_elements/cr_slider/cr_slider.js
  31. Dark Mode: give user-facing WebUI pages data on whether dark mode is on

    Changed by dbeamohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:12:05 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 1793df0e4ba009b98744de629534a7f000716341

    Comments

    Dark Mode: give user-facing WebUI pages data on whether dark mode is on
    
    R=dpapad@chromium.org
    BUG=883049
    
    Change-Id: Ia0657f1333ee3c3e556b36515f97c66a666309d9
    Reviewed-on: https://chromium-review.googlesource.com/c/1354685
    Commit-Queue: Dan Beam <dbeam@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614531}

    Changed files

    • chrome/browser/resources/md_bookmarks/bookmarks.html
    • chrome/browser/resources/md_downloads/downloads.html
    • chrome/browser/resources/md_extensions/extensions.html
    • chrome/browser/resources/md_history/history.html
    • chrome/browser/resources/md_user_manager/user_manager.html
    • chrome/browser/resources/print_preview/print_preview_new.html
    • chrome/browser/resources/settings/settings.html
    • chrome/browser/ui/webui/dark_mode_handler.cc
    • chrome/browser/ui/webui/dark_mode_handler.h
    • chrome/browser/ui/webui/dark_mode_handler_unittest.cc
    • chrome/browser/ui/webui/extensions/extensions_ui.cc
    • chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
    • chrome/browser/ui/webui/md_downloads/md_downloads_ui.cc
    • chrome/browser/ui/webui/md_history_ui.cc
    • chrome/browser/ui/webui/print_preview/print_preview_ui.cc
    • chrome/browser/ui/webui/settings/md_settings_ui.cc
    • chrome/browser/ui/webui/signin/md_user_manager_ui.cc
    • third_party/closure_compiler/externs/pending.js
    • ui/webui/resources/PRESUBMIT.py
    • ui/webui/resources/html/dark_mode.html
    • ui/webui/resources/js/BUILD.gn
    • ui/webui/resources/js/dark_mode.js
    • ui/webui/resources/webui_resources.grd
  32. [Mac] Sign bundled dylibs in the Framework's Libraries directory.

    Changed by rsesekohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:12:08 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 9670dd54c8b6b8d22ccd21c35e692a02173901d7

    Comments

    [Mac] Sign bundled dylibs in the Framework's Libraries directory.
    
    Bug: 912686
    Change-Id: I3725ed02fca95eec846819aa22f33ef072a116db
    Reviewed-on: https://chromium-review.googlesource.com/c/1366857
    Reviewed-by: Mark Mentovai <mark@chromium.org>
    Commit-Queue: Robert Sesek <rsesek@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614532}

    Changed files

    • chrome/installer/mac/sign_app.sh.in
    • chrome/installer/mac/sign_versioned_dir.sh.in
  33. Roll src/third_party/perfetto 82c3965be4fb..f4a214430436 (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 01:13:12 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision e171d8b83984479dc365214912e21c34421fd20d

    Comments

    Roll src/third_party/perfetto 82c3965be4fb..f4a214430436 (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/82c3965be4fb..f4a214430436
    
    
    git log 82c3965be4fb..f4a214430436 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 primiano@google.com Merge "Add shmempages to mm_counters + deal with future unknowns"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@f4a214430436
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-a
    ...skip...
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I1256def975b7a9590aefaae9c38b379783bebeaf
    Reviewed-on: https://chromium-review.googlesource.com/c/1366775
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614533}

    Changed files

    • DEPS
  34. Revert "Make //third_party/fontconfig explicitly depend on //third_party:freetype_harfbuzz."

    Changed by mmorozohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:13:15 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 9ef757a81180101de6b2e09c57509077d8588376

    Comments

    Revert "Make //third_party/fontconfig explicitly depend on //third_party:freetype_harfbuzz."
    
    This reverts commit 0baa5bdf0ed91499211384b636161ae9749f5ade.
    
    Reason for revert: is not needed after https://chromium-review.googlesource.com/c/chromium/src/+/1362457
    
    Original change's description:
    > Make //third_party/fontconfig explicitly depend on //third_party:freetype_harfbuzz.
    > 
    > Bug: 911836
    > Change-Id: Ia76687b3cb8d329792e5ef0310faee93d05344f2
    > Reviewed-on: https://chromium-review.googlesource.co
    ...skip...
    /heads/master@{#613792}
    
    TBR=bungeman@chromium.org,mmoroz@chromium.org,thomasanderson@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 911836
    Change-Id: Ibc4c88faadd5c1e603fc0f26ce956c282909798e
    Reviewed-on: https://chromium-review.googlesource.com/c/1365083
    Reviewed-by: Max Moroz <mmoroz@chromium.org>
    Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614534}

    Changed files

    • third_party/fontconfig/BUILD.gn
  35. Introducing URLLoaderFactoryParams::request_initiator_origin_lock.

    Changed by lukaszaohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:14:19 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 1e686969e6098169e9306ae8cbc245e80c416dad

    Comments

    Introducing URLLoaderFactoryParams::request_initiator_origin_lock.
    
    This CL is a step toward the world where we don't trust the origin
    reported by the renderer in network::ResourceRequest::request_initiator
    and instead know the request initiator a priori (e.g. it gets computed
    by the browser process).
    
    This CL only logs UMA that says whether the newly introduced lock is
    compatible with the request initiator requested by the user of the
    NetworkService (e.g. by the renderer process).  This CL doesn't ye
    ...skip...
    lled |request_initiator_site_lock| rather
    than |request_initiator_origin_lock|.
    
    Bug: 871827
    Change-Id: I97cc8285ace65e072bd7780da45522b10cb5ba57
    Reviewed-on: https://chromium-review.googlesource.com/c/1351574
    Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
    Reviewed-by: Brian White <bcwhite@chromium.org>
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Nasko Oskov <nasko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614535}

    Changed files

    • content/browser/DEPS
    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/frame_host/render_frame_host_impl.h
    • content/browser/loader/cross_site_document_blocking_browsertest.cc
    • content/browser/renderer_host/render_process_host_impl.cc
    • content/browser/renderer_host/render_process_host_impl.h
    • content/public/browser/render_process_host.h
    • content/public/test/mock_render_process_host.cc
    • content/public/test/mock_render_process_host.h
    • extensions/browser/url_loader_factory_manager.cc
    • services/network/public/mojom/network_context.mojom
    • services/network/url_loader.cc
    • services/network/url_loader.h
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml
  36. Roll src-internal c67e56ecd9f7..fb4f6083a23a (3 commits)

    Changed by chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 01:14:24 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 8e1e2d94aa4b3a81993943ac762d6ae0ef585e7c

    Comments

    Roll src-internal c67e56ecd9f7..fb4f6083a23a (3 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c67e56ecd9f7..fb4f6083a23a
    
    
    Created with:
      gclient setdep -r src-internal@fb4f6083a23a
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I32f9955376d2494ce2bdd5a7f352257f01e7694d
    Reviewed-on: https://chromium-review.googlesource.com/c/1366365
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614536}

    Changed files

    • DEPS
  37. Fix org.chromium.content.browser.BrowserStartupControllerTest failures on Android.

    Changed by hanxiohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 01:15:25 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 03089e2445101e1a2dce3b89262abfdb107def6f

    Comments

    Fix org.chromium.content.browser.BrowserStartupControllerTest failures on Android.
    
    The crash is caused due to junit test BrowserStartupControllerTest doesn't
    initialize the native but call serviceManagerStartupComplete. In that function,
    we record startup metrics and failed due to native doesn't initialized. Therefore,
    we add a protect function for the metrics record and override it in the
    TestBrowserStartupController.
    
    Bug: 912619
    Change-Id: Ifa6ba36bc926f0f033f7df0f4e6a67fce0ca340f
    Reviewed-on: https://chromium-review.googlesource.com/c/1366717
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Commit-Queue: Xi Han <hanxi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614537}

    Changed files

    • content/public/android/java/src/org/chromium/content/browser/BrowserStartupControllerImpl.java
    • content/public/android/javatests/src/org/chromium/content/browser/BrowserStartupControllerTest.java
  38. Remove support for calling UsbDeviceHandle methods from any thread

    Changed by reillygohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:15:35 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 99cbf6105655ac0c6818ec08bacf7fe27c46439c

    Comments

    Remove support for calling UsbDeviceHandle methods from any thread
    
    As of r613802 the last remaining user of this quirk in the
    UsbDeviceHandle API has been migrated to the USB Mojo interface and so
    the ability to call methods on UsbDeviceHandle from any thread and have
    the callback posted back to the caller's thread can be removed.
    
    Bug: 699790
    Change-Id: Ieb3adecc2e971909aa69f612036d9bc0f5d69f31
    Reviewed-on: https://chromium-review.googlesource.com/c/1364224
    Commit-Queue: Reilly Grant <reillyg@chromium.org>
    Reviewed-by: Ovidio Henriquez <odejesush@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614538}

    Changed files

    • device/usb/usb_device_handle.h
    • device/usb/usb_device_handle_impl.cc
    • device/usb/usb_device_handle_impl.h
    • device/usb/usb_device_handle_usbfs.cc
    • device/usb/usb_device_handle_usbfs.h
    • device/usb/usb_device_handle_win.cc
    • device/usb/usb_device_handle_win.h
  39. child user: Add ParentAccessCodeConfig user policy

    Changed by agawronskaohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:16:32 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 24fde26e7643d0bb161d27cc1a1b79432e5752e5

    Comments

    child user: Add ParentAccessCodeConfig user policy
    
    This policy specifies configuration that is used to generate/verify
    Parent Access Code on child user's device.
    This policy applies only to child user.
    The value of this policy should not be displayed in the UI and
    it is marked as 'sensitiveValue' therefore.
    
    Bug: 911326
    Test: policy_test_cases.json
    Change-Id: Iee3dafce712b67f038cea52d5fc8810a6532e809
    Reviewed-on: https://chromium-review.googlesource.com/c/1359893
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Commit-Queue: Aga Wronska <agawronska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614539}

    Changed files

    • chrome/browser/chromeos/child_accounts/screen_time_controller.cc
    • chrome/browser/policy/configuration_policy_handler_list_factory.cc
    • chrome/common/pref_names.cc
    • chrome/common/pref_names.h
    • chrome/test/data/policy/policy_test_cases.json
    • components/policy/resources/policy_templates.json
    • tools/metrics/histograms/enums.xml
  40. Reland "Perfetto: Stop splitting _COMPLETE events"

    Changed by oysteineohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 01:16:41 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 9d830c214cd1c59958ee19403b446fa5b796e794

    Comments

    Reland "Perfetto: Stop splitting _COMPLETE events"
    
    This is a reland of 53e8b2a294d66219b5c4daf00dda1cb9f822a54f
    
    Relanding after https://chromium-review.googlesource.com/c/catapult/+/1364251
    which is what caused the failures triggering the revert last time.
    
    Original change's description:
    > Perfetto: Stop splitting _COMPLETE events
    >
    > The current Perfetto backend splits _COMPLETE trace events into
    > separate _BEGIN and _END pairs, as it's not very feasible to modify
    > existing events after they're w
    ...skip...
    glesource.com/c/1354503
    > Commit-Queue: oysteine <oysteine@chromium.org>
    > Reviewed-by: Eric Seckler <eseckler@chromium.org>
    > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#612360}
    
    Bug: 909728, 888558
    Change-Id: I5e3d6e0f170066011e2a5b452969d9c8cd18ac4f
    Reviewed-on: https://chromium-review.googlesource.com/c/1359304
    Reviewed-by: oysteine <oysteine@chromium.org>
    Commit-Queue: oysteine <oysteine@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614540}

    Changed files

    • base/trace_event/trace_log.cc
    • base/trace_event/trace_log.h
    • base/trace_event/traced_value.cc
    • services/tracing/public/cpp/perfetto/trace_event_data_source.cc
    • services/tracing/public/cpp/perfetto/trace_event_data_source.h
    • services/tracing/public/cpp/perfetto/trace_event_data_source_unittest.cc
  41. Roll src/third_party/chromite aee33ef79380..0979b51ccfc5 (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 01:17:36 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision a37a6778df3a131eaf11267d6a4326fb224d84db

    Comments

    Roll src/third_party/chromite aee33ef79380..0979b51ccfc5 (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/aee33ef79380..0979b51ccfc5
    
    
    git log aee33ef79380..0979b51ccfc5 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 dgarrett@google.com chromeos_config: No vm/hwtests on postsubmit builders.
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@0979b51ccfc5
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Document
    ...skip...
    oll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I4e3e4301aa9906f500ad68cf36b931128256259e
    Reviewed-on: https://chromium-review.googlesource.com/c/1366362
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614541}

    Changed files

    • DEPS
  42. arc: Start/stop arc-vm job

    Changed by yusukesohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:17:48 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 4c29cfc31d659799b277676557231dd600c3f6a3

    Comments

    arc: Start/stop arc-vm job
    
    BUG=b:118408409
    TEST=sign in, tap Play Store icon, check arc-vm job is running, sign out,
     check arc-vm job is stopped
    TEST=check that the socket is chronos:chronos and 0600 on eve-arcvm
    
    Change-Id: Ibfa140a4aaee58f562ae898a0f308067388c6f22
    Reviewed-on: https://chromium-review.googlesource.com/c/1363964
    Commit-Queue: Yusuke Sato <yusukes@chromium.org>
    Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614542}

    Changed files

    • components/arc/arc_session_impl.cc
    • components/arc/arc_vm_client_adapter.cc
  43. Fixed UKM API docs to match the current API.

    Changed by mgiucaohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:18:40 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 5c1e47620c5653fbf40e7df3eea08869cff4dcd7

    Comments

    Fixed UKM API docs to match the current API.
    
    Change-Id: If0cb49393d3c04414687d16427a50d591cf216d1
    Reviewed-on: https://chromium-review.googlesource.com/c/1349152
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Reviewed-by: Jesse Doherty <jwd@chromium.org>
    Commit-Queue: Matt Giuca <mgiuca@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614543}

    Changed files

    • services/metrics/ukm_api.md
  44. cros: Move most event/widget handling logic out of LoginBubble

    Changed by qnnguyenohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:18:53 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision a61287973e8f4522ed673ac1a77de0dc56eb1bc8

    Comments

    cros: Move most event/widget handling logic out of LoginBubble
    
    Changes made:
    - Move the (keyboard/click/tap) event handling logic into a
      LoginBubbleHandler class.
    - Move the widget handling into LoginBaseBubbleView itself
    
    Bug: 912658
    Change-Id: Ia1a9bf4b8d847ef74ef1716e73dfe1b16b8d19b2
    Reviewed-on: https://chromium-review.googlesource.com/c/1366516
    Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614544}

    Changed files

    • ash/login/ui/login_base_bubble_view.cc
    • ash/login/ui/login_base_bubble_view.h
    • ash/login/ui/login_bubble.cc
    • ash/login/ui/login_bubble.h
  45. Revert "Change interleaving of delayed and immediate tasks to match MessageLoop"

    Changed by jyasskinohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:19:44 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 957b034333640c832f432f6d9cdb2f3ef260fd5b

    Comments

    Revert "Change interleaving of delayed and immediate tasks to match MessageLoop"
    
    This reverts commit dda57a2c6aa319675172f8558ce8c24d9333f894.
    
    Reason for revert: Made http/tests/devtools/sources/debugger-breakpoints/restore-locations-for-breakpoint-with-broken-source-map.js flaky, according to https://crbug.com/912614.
    
    Original change's description:
    > Change interleaving of delayed and immediate tasks to match MessageLoop
    > 
    > Previously the TaskQueueSelector would allow up to 3 delayed tasks to
    > 
    ...skip...
    omium.org>
    > Reviewed-by: Alexander Timin <altimin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614329}
    
    TBR=skyostil@chromium.org,alexclarke@chromium.org,altimin@chromium.org
    
    Change-Id: I2b92bee12bfdd05fac12955655106253cab0d1e6
    No-Presubmit: true
    Bug: 863341, 891670, 912614
    Reviewed-on: https://chromium-review.googlesource.com/c/1366223
    Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org>
    Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614545}

    Changed files

    • base/task/sequence_manager/sequence_manager_impl.cc
    • base/task/sequence_manager/sequence_manager_impl.h
    • base/task/sequence_manager/sequence_manager_impl_unittest.cc
    • base/task/sequence_manager/task_queue_selector.cc
    • base/task/sequence_manager/task_queue_selector.h
    • base/task/sequence_manager/task_queue_selector_unittest.cc
    • base/task/sequence_manager/work_queue_sets.cc
    • base/task/sequence_manager/work_queue_sets.h
    • base/task/sequence_manager/work_queue_sets_unittest.cc
    • base/task/sequence_manager/work_queue_unittest.cc
    • third_party/blink/web_tests/http/tests/devtools/sources/debugger/debugger-scope-resolve-this-expected.txt
  46. task_contoller_unittest: move setupFileManagerPrivate() to Setup()

    Changed by noelohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:19:58 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 96e0fd8bd99e572dca38519ae68140414636a21f

    Comments

    task_contoller_unittest: move setupFileManagerPrivate() to Setup()
    
    After CL:1364270 all test cases begin with a setupFileManagerPrivate()
    call: move that into Setup().
    
    No change in test behavior, no new tests.
    
    Bug: 912410
    Change-Id: I36e2180012918ec00d552397395c8bb61048382c
    Reviewed-on: https://chromium-review.googlesource.com/c/1364996
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Commit-Queue: Noel Gordon <noel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614546}

    Changed files

    • ui/file_manager/file_manager/foreground/js/task_controller_unittest.js
  47. Remove usage of URLRequestContextGetter in Cast code.

    Changed by jamohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:20:49 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision b79dd6ba6c392016444abfc5b26d42ed8774bb57

    Comments

    Remove usage of URLRequestContextGetter in Cast code.
    
    It just needed the NetLog code. Eventually this dependency will go away as well (https://crbug.com/806817).
    
    Bug: 837753
    Change-Id: Ic17ada4a10492986f052453ab49111f8732bc7b5
    Reviewed-on: https://chromium-review.googlesource.com/c/1363976
    Reviewed-by: Yuri Wiitala <miu@chromium.org>
    Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614547}

    Changed files

    • chrome/browser/chrome_content_browser_client.cc
    • chrome/browser/media/cast_transport_host_filter.cc
    • chrome/browser/media/cast_transport_host_filter.h
    • chrome/browser/media/cast_transport_host_filter_unittest.cc
    • content/browser/storage_partition_impl.cc
    • content/public/browser/storage_partition.h
  48. Don't sync speaker id enrollment status when flag is disabled.

    Changed by dmblackohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 01:21:05 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 0c33e07c15885a19bea8dfccaf773209165b992a

    Comments

    Don't sync speaker id enrollment status when flag is disabled.
    
    This sync was causing a bit to be set that caused personal queries to
    fail due to lack of voice match. Unfortunately, this will not fix users
    who already went down this code path so we'll have to do a follow up
    to clear the culprit bit.
    
    Removing user and re-adding with the fix CL will fix functionality for
    a user who got into the bad state, and the fix CL will prevent others
    from getting into this state.
    
    Bug: b:120625879
    Change-Id: Id002bf47f49409cf2d08ec1f7d4ee7061369339b
    Reviewed-on: https://chromium-review.googlesource.com/c/1366491
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Commit-Queue: David Black <dmblack@google.com>
    Cr-Commit-Position: refs/heads/master@{#614548}

    Changed files

    • chromeos/services/assistant/assistant_manager_service_impl.cc
  49. Consolidate calls to clock sources to OfflineClock #3

    Changed by mtlieuuohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:21:54 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 297ccb8018a6c2da5df6cd4e860e6cfc4b395e40

    Comments

    Consolidate calls to clock sources to OfflineClock #3
    
    This change further changes direct calls to Time::Now or the default
    base::Clock instance to an OfflineClock module within classes which
    need a Clock pointer to be passed into the class. This eliminates the
    need for testing-only functions and further allows ease of testing.
    This change is specific to production files and their related tests in:
    
    components/offline_pages/core/
    
    Bug: 906903
    Change-Id: I579d9b8e9c785e0c004ecc3d25e05f7aa031fe4c
    Reviewed-on: https://chromium-review.googlesource.com/c/1359487
    Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
    Commit-Queue: Mark Lieu <mtlieuu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614549}

    Changed files

    • components/offline_pages/core/offline_event_logger.cc
    • components/offline_pages/core/offline_page_metadata_store.cc
    • components/offline_pages/core/offline_page_metadata_store_unittest.cc
    • components/offline_pages/core/prefetch/prefetch_downloader_impl.cc
    • components/offline_pages/core/prefetch/prefetch_downloader_impl.h
    • components/offline_pages/core/prefetch/prefetch_downloader_impl_unittest.cc
  50. Roll src/third_party/catapult d18d6c7c7183..5d7bcad36ff4 (2 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 01:22:12 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision ac8ebb246231cdea5872c01e6d596a00462678a3

    Comments

    Roll src/third_party/catapult d18d6c7c7183..5d7bcad36ff4 (2 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/d18d6c7c7183..5d7bcad36ff4
    
    
    git log d18d6c7c7183..5d7bcad36ff4 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 sky@chromium.org chromeos: close all tabs before running the next test
    2018-12-06 benjhayden@chromium.org Fetch list of sheriffs in v2spa
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@5d7bcad36ff4
    
    The AutoRoll server is located here: https://auto
    ...skip...
    linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:911777
    TBR=sullivan@chromium.org
    
    Change-Id: If23adcbc8ff79755fd29de43bbc2f838fc7f6da2
    Reviewed-on: https://chromium-review.googlesource.com/c/1366783
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614550}

    Changed files

    • DEPS
  51. Roll src/third_party/angle 9092bdc7a76f..132d15c217e0 (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 01:22:58 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 72f167fc8b19da36c14852436d8723204806f878

    Comments

    Roll src/third_party/angle 9092bdc7a76f..132d15c217e0 (1 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/9092bdc7a76f..132d15c217e0
    
    
    git log 9092bdc7a76f..132d15c217e0 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 jmadill@chromium.org Clear uncleared textures as a dirty object.
    
    
    Created with:
      gclient setdep -r src/third_party/angle@132d15c217e0
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is
    ...skip...
    el;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=ynovikov@chromium.org
    
    Change-Id: I9029c6290fcfb525efa9e7706c45f24048d1edf4
    Reviewed-on: https://chromium-review.googlesource.com/c/1366479
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614551}

    Changed files

    • DEPS
  52. Add thomasanderson as an OWNER of build

    Changed by thomasandersonohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:23:17 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 6948a3c3a89b032ff74eb3a5c9fe78c94e85e670

    Comments

    Add thomasanderson as an OWNER of build
    
    R=dpranke
    
    Change-Id: Ia66eac1ecb07e462699d1d6c9e6b39f60c2bbd05
    Reviewed-on: https://chromium-review.googlesource.com/c/1366493
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614552}

    Changed files

    • build/OWNERS
  53. Enable warmer welcome during Assistant launch.

    Changed by yileiliohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 01:24:04 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 29dca9fe6ae866266c976809adc33c09a2ca1088

    Comments

    Enable warmer welcome during Assistant launch.
    
    1. It is guarded by a finch flag AssistantWarmerWelcome.
    2. WW only shows 3 times.
    
    Bug: b:112495005
    Test: Manual
    
    Change-Id: I80cbcfd4104c17172939d36b986be65077bf0bb3
    Reviewed-on: https://chromium-review.googlesource.com/c/1355174
    Reviewed-by: Will Harris <wfh@chromium.org>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Commit-Queue: Yilei Li <yileili@google.com>
    Cr-Commit-Position: refs/heads/master@{#614553}

    Changed files

    • ash/BUILD.gn
    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_controller.h
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/public/cpp/ash_pref_names.cc
    • ash/public/cpp/ash_pref_names.h
    • ash/shell.cc
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/fake_assistant_manager_service_impl.cc
    • chromeos/services/assistant/fake_assistant_manager_service_impl.h
    • chromeos/services/assistant/public/features.cc
    • chromeos/services/assistant/public/features.h
    • chromeos/services/assistant/public/mojom/assistant.mojom
    • chromeos/services/assistant/test_support/mock_assistant.h
  54. [AF Paradise] Change the timing of showing credit card icon in the omnibox

    Changed by siyuaohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:24:21 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 1519a34eff922497f280e53a035e019e8f10b436

    Comments

    [AF Paradise] Change the timing of showing credit card icon in the omnibox
    
    Previously when migration dialog was shown, the credit card icon was not
    visible. In this change, we change it to: Credit card icon will always
    be visible when migration dialog is shown.
    
    1) Add more step in LocalCardMigrationFlowStep. The
    MIGRATION_RESULT_PENDING will be used for the animation in the next CL.
    
    2) Use the observer pattern for dialog controller to pass correct state
    to manage_migration_ui_controller when user clicks okay/cancel button.
    
    3) Change the new link navigation to pop-ups since the dialog is
    blocking the browser now.
    
    Bug: 897998
    Change-Id: I32acf9136d1d0298f23cc79ede99f223a01566c1
    Reviewed-on: https://chromium-review.googlesource.com/c/1356260
    Commit-Queue: Siyu An <siyua@chromium.org>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Reviewed-by: Evan Stade <estade@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614554}

    Changed files

    • chrome/browser/ui/autofill/chrome_autofill_client.cc
    • chrome/browser/ui/autofill/local_card_migration_controller_observer.h
    • chrome/browser/ui/autofill/local_card_migration_dialog_controller_impl.cc
    • chrome/browser/ui/autofill/local_card_migration_dialog_controller_impl.h
    • chrome/browser/ui/autofill/manage_migration_ui_controller.cc
    • chrome/browser/ui/autofill/manage_migration_ui_controller.h
    • chrome/browser/ui/views/autofill/local_card_migration_dialog_view.cc
    • chrome/browser/ui/views/autofill/local_card_migration_error_dialog_view.cc
    • chrome/browser/ui/views/autofill/local_card_migration_error_dialog_view.h
    • chrome/browser/ui/views/autofill/local_card_migration_icon_view.cc
    • components/autofill/core/browser/ui/local_card_migration_dialog_controller.h
  55. [Media Controls] Fix controls flicker in small size

    Changed by jazzhsuohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:25:11 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 3fd190dee907661320a5bfc5963d615406fffd35

    Comments

    [Media Controls] Fix controls flicker in small size
    
    This CL fixed control layout in small video size by
    adding an estimated width of time display element which
    was default to 0 when its hidden.
    
    Bug: 911062
    Change-Id: I747e465e87fd27eec1ac5ad4720fa79525443f04
    Reviewed-on: https://chromium-review.googlesource.com/c/1358647
    Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
    Reviewed-by: Tommy Steimel <steimel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614555}

    Changed files

    • third_party/blink/renderer/modules/media_controls/elements/media_control_input_element.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_remaining_time_display_element.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_remaining_time_display_element.h
    • third_party/blink/renderer/modules/media_controls/elements/media_control_time_display_element.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_time_display_element.h
    • third_party/blink/web_tests/media/controls/controls-layout-in-different-size.html
  56. Add ui::SelectFileDialog::FileTypeInfo::ANY_PATH_OR_URL.

    Changed by sammcohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:25:24 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 3429b21df57fb03c658e5b63ae81a42f4316a978

    Comments

    Add ui::SelectFileDialog::FileTypeInfo::ANY_PATH_OR_URL.
    
    For most file select dialogs, hosted docs that can only be accessed via
    their URLs are not useful to select. Only browser file-open dialogs can
    meaningfully interact with these virtual files, translating their paths
    into URLs. Other dialogs return unusable file paths that cannot be
    opened as regular files, causing unnecessary and confusing failures.
    
    Add a FileTypeInfo enumerator, ANY_PATH_OR_URL, for clients to opt into
    accepting such virtual files, used by Browser. In dialogs not opting
    into this mode, disallow selecting hosted docs.
    
    Bug: 843881
    Change-Id: I8abc6408e94d60d6e8b3889b0899038c90789119
    Reviewed-on: https://chromium-review.googlesource.com/c/1360451
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Sam McNally <sammc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614556}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/file_manager/url_util.cc
    • chrome/browser/ui/browser.cc
    • ui/file_manager/base/js/filtered_volume_manager.js
    • ui/file_manager/base/js/volume_manager_types.js
    • ui/file_manager/file_manager/foreground/css/file_manager.css
    • ui/file_manager/file_manager/foreground/js/constants.js
    • ui/file_manager/file_manager/foreground/js/file_manager.js
    • ui/file_manager/file_manager/foreground/js/file_selection.js
    • ui/file_manager/file_manager/foreground/js/launch_param.js
    • ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js
    • ui/file_manager/file_manager/foreground/js/ui/file_table.js
    • ui/file_manager/file_manager/foreground/js/ui/file_table_list.js
    • ui/file_manager/integration_tests/file_manager/file_dialog.js
    • ui/shell_dialogs/select_file_dialog.h