Home | Search
Login

Builder ToTAndroid64 Build #1478

Results:

build successful

Trigger Info:

Got Revisiona9e0cd51f3d7bc6927d332966ab734d8045b2d2d

Execution:

Steps and Logfiles:

Show:
  1. ( 14 hrs 7 mins ) steps
    running steps via annotated script
  2. ( 5 secs ) update_scripts
    update_scripts
  3. ( 1 ms ) LUCI Migration
    LUCI Migration
  4. ( 1 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 1 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 1 ms ) report builders
    report builders
     
    running builder/tester 'ToTAndroid64' on master 'chromium.clang'
  7. ( 1 ms ) makedirs checkout path
    makedirs checkout path
  8. ( 4 mins 36 secs ) bot_update
    bot_update
    [145GB/492GB used (29%)]
  9. ( 1 ms ) swarming.py --version
    swarming.py --version
    0.14
  10. ( 1 hrs 8 mins ) gclient runhooks
    gclient runhooks
  11. ( 3 ms ) get compile targets for scripts
    get compile targets for scripts
  12. ( 1 ms ) read test spec (chromium.clang.json)
    read test spec (chromium.clang.json)
    path: /b/c/b/ToTAndroid64/src/testing/buildbot/chromium.clang.json
  13. ( 2 mins 37 secs ) clean local files
    clean local files
  14. ( 16 secs ) tree truth steps
    tree truth steps
  15. ( 1 ms ) lookup GN args
    lookup GN args
     
    clang_use_chrome_plugins = false
    is_clang = true
    is_debug = false
    llvm_force_head_revision = true
    target_cpu = "arm64"
    target_os = "android"
  16. ( 1 mins 1 secs ) generate_build_files
    generate_build_files
  17. ( 1 ms ) clang_revision
    clang_revision
  18. ( 12 hrs 46 mins ) compile
    compile
  19. ( 2 mins 40 secs ) compile confirm no-op
    compile confirm no-op
    This should have been a no-op, but it wasn't.
  20. ( 22 secs ) upload_ninja_log
    upload_ninja_log
  21. ( 1 ms ) test_pre_run
    test_pre_run
  22. ( 1 ms ) sizes
    sizes
    sizes
    <div class="BuildResultInfo">
    </div>
  23. ( 1 ms ) test_report
    test_report
  24. ( 1 ms ) recipe result
    recipe result

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromium/bb/chromium.clang/ToTAndroid64/1478/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.clang/ToTAndroid64/1478" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "8f1b7a66a5e3182e44635f18c5740b77fa7c057f" Annotation(bot_update)
got_buildtools_revision "04161ec8d7c781e4498c699254c69ba0dd959fde" Annotation(bot_update)
got_dawn_revision "0a7ddd43d77ca2d7de3a1d08feb62cf5e8a578a6" Annotation(bot_update)
got_nacl_revision "17af1e818981ebf2c492a678d4d31c9e1ee37fc7" Annotation(bot_update)
got_revision "a9e0cd51f3d7bc6927d332966ab734d8045b2d2d" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#614263}" Annotation(bot_update)
got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" Annotation(bot_update)
got_v8_revision "f5137533bdfac762e980b17eb7b4a2433dd07d1d" Annotation(bot_update)
got_v8_revision_cp "refs/heads/7.3.39@{#1}" Annotation(bot_update)
got_webrtc_revision "c60a77731d68c8648135372dbe54c92dfba731bd" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#25911}" Annotation(bot_update)
got_clang_revision "348456" Annotation(clang_revision)
build_data_dir "/b/rr/tmp_E4nBv" Annotation(steps)
build_id "buildbot/chromium.clang/ToTAndroid64/1478" Annotation(steps)
builder_id "master.chromium.clang:ToTAndroid64" Annotation(steps)
blamelist ["agrieve@chromium.org","bsheedy@chromium.org","carlosk@chromium.org","chrishall@chromium.org","chromium-autoroll@skia-public.iam.gserviceaccount.com","jdarpinian@chromium.org","ksakamoto@chromium.org","luoe@chromium.org","nasko@chromium.org","rockot@chromium.org","thomasanderson@chromium.org","wanderview@chromium.org","zhuoyu.qian@samsung.com"] Build
branch "master" Build
buildnumber 1478 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src.git" Build
requestedAt 1544064918 Build
revision "a9e0cd51f3d7bc6927d332966ab734d8045b2d2d" Build
slavename "slave172-c1" BuildSlave
buildername "ToTAndroid64" Builder
git_revision "a9e0cd51f3d7bc6927d332966ab734d8045b2d2d" Change
scheduler "chromium_src_commits" Scheduler
buildbotURL "https://build.chromium.org/p/chromium.clang/" master.cfg
mastername "chromium.clang" master.cfg
workdir "/b/build/slave/ToTAndroid64" slave

Blamelist:

  1. (naskoohnoyoudont@chromium.org)
  2. (rockotohnoyoudont@chromium.org)
  3. (carloskohnoyoudont@chromium.org)
  4. (bsheedyohnoyoudont@chromium.org)
  5. (wanderviewohnoyoudont@chromium.org)
  6. (chrishallohnoyoudont@chromium.org)
  7. (ksakamotoohnoyoudont@chromium.org)
  8. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  9. (thomasandersonohnoyoudont@chromium.org)
  10. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  11. (zhuoyu.qianohnoyoudont@samsung.com)
  12. (jdarpinianohnoyoudont@chromium.org)
  13. (luoeohnoyoudont@chromium.org)
  14. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  15. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  16. (agrieveohnoyoudont@chromium.org)
  17. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)

Timing:

Create N/A
Start Thursday, 06-Dec-18 04:07:28 UTC
End Thursday, 06-Dec-18 18:15:11 UTC
Pending N/A
Execution 14 hrs 7 mins

All Changes:

  1. Store the committed origin for navigation in FrameNavigationEntry.

    Changed by naskoohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 02:53:58 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 18006bc7a59e2db7fe94d2511d0a0fe66b678f72

    Comments

    Store the committed origin for navigation in FrameNavigationEntry.
    
    Bug: 882053
    Change-Id: I36960aa5fbab5ef8d3ba89158f31d408950da34b
    Reviewed-on: https://chromium-review.googlesource.com/c/1344876
    Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
    Commit-Queue: Nasko Oskov <nasko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614247}

    Changed files

    • content/browser/frame_host/frame_navigation_entry.cc
    • content/browser/frame_host/frame_navigation_entry.h
    • content/browser/frame_host/navigation_controller_impl.cc
    • content/browser/frame_host/navigation_controller_impl_browsertest.cc
    • content/browser/frame_host/navigation_entry_impl.cc
    • content/browser/frame_host/navigation_entry_impl.h
    • content/test/test_render_frame_host.cc
    • content/test/test_web_contents.cc
  2. [mojo] Fix JS lite bindings compilation

    Changed by rockotohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 03:01:51 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 59b68d8136b3526cf41a42228344bcb52cd73275

    Comments

    [mojo] Fix JS lite bindings compilation
    
    Adds the default compilation options to the js_binary target which
    builds the bindings_lite binary. Fixes all of the miscellaneous resulting
    compilation errors. Some major resulting changes:
    
     - Interface support (stuff which has to depend on generated control
       message bindings) is moved into a separate module to avoid a circular
       dependency between it and the rest of mojo.internal.
     - Enums, Structs, and Unions have had their type specs lifted into a
       $ 
    ...skip...
    he
       global namespace.
    
    It is still not feasible to use fully compiled (i.e. with
    ADVANCED_OPTIMIZATION) generated bindings from non-complied JS due to
    unavoidable symbol munging, but for fully compiled JS binaries, they
    work just fine.
    
    Bug: 905533
    Change-Id: I0d915188f34dd94b7380a20a80b3d450c367640b
    Reviewed-on: https://chromium-review.googlesource.com/c/1340914
    Commit-Queue: Ken Rockot <rockot@google.com>
    Reviewed-by: calamity <calamity@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614248}

    Changed files

    • mojo/public/js/BUILD.gn
    • mojo/public/js/bindings_lite.js
    • mojo/public/js/compile_preamble.js
    • mojo/public/js/interface_support.js
    • mojo/public/tools/bindings/concatenate_and_replace_closure_exports.py
    • mojo/public/tools/bindings/generators/js_templates/lite/enum_definition.tmpl
    • mojo/public/tools/bindings/generators/js_templates/lite/interface_definition.tmpl
    • mojo/public/tools/bindings/generators/js_templates/lite/module_definition.tmpl
    • mojo/public/tools/bindings/generators/js_templates/lite/mojom-lite.js.tmpl
    • mojo/public/tools/bindings/generators/js_templates/lite/struct_definition.tmpl
    • mojo/public/tools/bindings/generators/js_templates/lite/union_definition.tmpl
    • mojo/public/tools/bindings/generators/mojom_js_generator.py
    • mojo/public/tools/bindings/mojom.gni
    • third_party/closure_compiler/closure_args.gni
    • third_party/closure_compiler/compile_js.gni
    • third_party/closure_compiler/externs/mojo_core.js
  3. Fix border colors for offline content preview on dino page

    Changed by carloskohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 03:06:28 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 6fa34733adbc1a5ee43f18902a7683bfe03e8764

    Comments

    Fix border colors for offline content preview on dino page
    
    TBR: chili@chromium.org
    Bug: 852872
    Change-Id: Iab8527b01c03ea9abb3c7542fe56f88be39bb620
    Reviewed-on: https://chromium-review.googlesource.com/c/1364297
    Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
    Reviewed-by: Cathy Li <chili@chromium.org>
    Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614249}

    Changed files

    • components/neterror/resources/neterror.css
  4. Add XR instrumentation web content workaround

    Changed by bsheedyohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 03:06:39 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 8b38b5d3ba2bc4e343b756f932ac7b807ffa94da

    Comments

    Add XR instrumentation web content workaround
    
    Adds a workaround for https://crbug.com/908917 into the XR
    instrumentation test setup since attempts to work around the issue in
    the test runner haven't been completely successful. This workaround
    performs a swipe which should be a no-op when running a RenderTest,
    which seems to prevent the flakiness when doing pixel diffs.
    
    Bug: 908917
    Change-Id: I38bf8fb5abe1c0a2bf19e044dd9237919ec2b019
    Reviewed-on: https://chromium-review.googlesource.com/c/1362293
    Reviewed-by: Bill Orr <billorr@chromium.org>
    Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614250}

    Changed files

    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/ChromeTabbedActivityXrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/CustomTabActivityXrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/WebappActivityXrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrTestRuleUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/XrTestRuleUtils.java
  5. CacheStorage: Hold DOM binding objects alive during operations.

    Changed by wanderviewohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 03:09:11 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 20b1274003890d6d42807a41daf846948410f355

    Comments

    CacheStorage: Hold DOM binding objects alive during operations.
    
    We are seeing some DCHECKs trigger that suggest the owning Cache object
    is destroyed while an outstanding operation is in progress.  This can
    in theory happen in code that operates on the cache, but then discards
    its reference while waiting for the promise to settle.
    
    Bug: 912141
    Change-Id: Ic82e8b86bb427808df4d7f16326b50998cf6b031
    Reviewed-on: https://chromium-review.googlesource.com/c/1364130
    Commit-Queue: Ben Kelly <wanderview@chromium.org>
    Reviewed-by: Victor Costan <pwnall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614251}

    Changed files

    • third_party/blink/renderer/modules/cache_storage/cache.cc
    • third_party/blink/renderer/modules/cache_storage/cache_storage.cc
  6. Add language detection content browser test including nested nodes.

    Changed by chrishallohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 03:09:33 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 198763278fb66b3a7135b29c3817f2dc5df7d6f4

    Comments

    Add language detection content browser test including nested nodes.
    
    R=dmazzoni,aboxhall
    
    Bug: 889370
    Change-Id: I56bd50586a13d754d9dd1547e277d7daab216ec3
    Reviewed-on: https://chromium-review.googlesource.com/c/1362698
    Commit-Queue: Chris Hall <chrishall@chromium.org>
    Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614252}

    Changed files

    • content/browser/accessibility/dump_accessibility_tree_browsertest.cc
    • content/test/data/accessibility/language-detection/lang-attribute-expected-blink.txt
    • content/test/data/accessibility/language-detection/lang-attribute-nested-expected-blink.txt
    • content/test/data/accessibility/language-detection/lang-attribute-nested-expected-mac.txt
    • content/test/data/accessibility/language-detection/lang-attribute-nested-expected-win.txt
    • content/test/data/accessibility/language-detection/lang-attribute-nested.html
  7. Defer preloads with imagesrcset/imagesizes until the first chunk is parsed

    Changed by ksakamotoohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 03:10:20 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 10bb83df93723eeecec3590fdf14904adf835795

    Comments

    Defer preloads with imagesrcset/imagesizes until the first chunk is parsed
    
    Preloads from link headers with the media attribute are deferred until
    the first chunk of the document is parsed, so that ViewportDescription
    from the preload scanner can be taken into account. Preloads with
    imagesrcset or imagesizes depend on the viewport, so such preloads
    should be deferred as well.
    
    Note: This applies to only preloads dispatched by DocumentLoader. Link
    rel=preload headers from subresources (e.g. prefetch) are not deferred
    even if they have media/imagesrcset/imagesizes attributes.
    
    Bug: 813452
    Change-Id: Iccc6ec12cf5bd53b71824463378c854cbd23a5ba
    Reviewed-on: https://chromium-review.googlesource.com/c/1360193
    Reviewed-by: Dominic Farolino <domfarolino@gmail.com>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614253}

    Changed files

    • third_party/blink/renderer/core/loader/link_loader.cc
    • third_party/blink/renderer/platform/loader/link_header.h
    • third_party/blink/web_tests/http/tests/preload/meta-viewport-link-headers-imagesrcset.html
    • third_party/blink/web_tests/http/tests/preload/resources/media-link-headers-imagesrcset.php
  8. Roll src/third_party/chromite 474edce4406d..bbdb8efacb83 (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 03:12:40 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 3cd318393407a2a41d64257adf43328ca0be06b0

    Comments

    Roll src/third_party/chromite 474edce4406d..bbdb8efacb83 (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/474edce4406d..bbdb8efacb83
    
    
    git log 474edce4406d..bbdb8efacb83 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 zhuohao@chromium.org kalista: mark paladin as important (not experiment)
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@bbdb8efacb83
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentat
    ...skip...
    oll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I6fb66328feffe89fc681fe5c58f480966ce48b73
    Reviewed-on: https://chromium-review.googlesource.com/c/1364175
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614254}

    Changed files

    • DEPS
  9. Add RPATH to shared libraries

    Changed by thomasandersonohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 03:23:02 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 3b3db14346589ff4069d004883b52d0a01690fe5

    Comments

    Add RPATH to shared libraries
    
    Fixes libfontconfig.so not being able to find libfreetype_harfbuzz.so:
    
    $ ldd libfontconfig.so | grep freetype_harfbuzz
    	libfreetype_harfbuzz.so => not found
    $ ls libfreetype_harfbuzz.so
    libfreetype_harfbuzz.so
    
    R=thakis
    
    Bug: 911836,912366
    Change-Id: Ia0aaed8fc2c745b02cecf9ee3ce9888c1d8ccf77
    Reviewed-on: https://chromium-review.googlesource.com/c/1362457
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614255}

    Changed files

    • build/config/BUILD.gn
    • build/config/gcc/BUILD.gn
  10. Roll src/third_party/pdfium 10a8fea122ad..3d29bcfeed81 (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 03:23:31 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision a2fbd70f366e6b6d8f73bf80d3a0c74125054462

    Comments

    Roll src/third_party/pdfium 10a8fea122ad..3d29bcfeed81 (1 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/10a8fea122ad..3d29bcfeed81
    
    
    git log 10a8fea122ad..3d29bcfeed81 --date=short --no-merges --format='%ad %ae %s'
    2018-12-05 thestig@chromium.org Change an if-statement into an ASSERT().
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@3d29bcfeed81
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
    
    Documentation for the AutoRoller is here:
    https://s
    ...skip...
    
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I8b24638e181c01201a33d852b1f81623c83b758a
    Reviewed-on: https://chromium-review.googlesource.com/c/1364176
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614256}

    Changed files

    • DEPS
  11. Replace IndexedDBContext::CopyOriginData to use url::Origin instead of GURL.

    Changed by zhuoyu.qianohnoyoudont@samsung.com
    Changed at Thursday, 06-Dec-18 03:24:09 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision ef13decd92d62733ffa17cf1fb8c700d35615443

    Comments

    Replace IndexedDBContext::CopyOriginData to use url::Origin instead of GURL.
    
    As the comment left by jsbell@, replace IndexedDBContext::CopyOriginData
    to use url::Origin instead of GURL.
    
    Change-Id: I0cf75ad39b1081b32cb4ac060cfa0294d987e767
    Reviewed-on: https://chromium-review.googlesource.com/c/1360211
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Joshua Bell <jsbell@chromium.org>
    Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
    Cr-Commit-Position: refs/heads/master@{#614257}

    Changed files

    • chrome/browser/extensions/app_data_migrator.cc
    • content/browser/indexed_db/indexed_db_context_impl.cc
    • content/browser/indexed_db/indexed_db_context_impl.h
    • content/public/browser/indexed_db_context.h
  12. Fix --disable-gl-error-limit flag

    Changed by jdarpinianohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 03:24:55 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 104af6fb98cba827d7eab8783b5bc1ecfdbe4397

    Comments

    Fix --disable-gl-error-limit flag
    
    Respect GpuPreferences rather than checking the command line
    in the logger.
    
    Bug: 910812
    Change-Id: I79e044d9a0e791a2603c36712755c759f1d04f1c
    Reviewed-on: https://chromium-review.googlesource.com/c/1364154
    Commit-Queue: James Darpinian <jdarpinian@chromium.org>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614258}

    Changed files

    • gpu/command_buffer/service/gles2_cmd_decoder.cc
    • gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
    • gpu/command_buffer/service/logger.cc
    • gpu/command_buffer/service/logger.h
    • gpu/command_buffer/service/raster_decoder.cc
  13. DevTools: fix Console scroll preservation with keyboard experiment

    Changed by luoeohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 03:28:42 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 0835ba4d696ebe20992dee8b5c2ccbe2a4e658c8

    Comments

    DevTools: fix Console scroll preservation with keyboard experiment
    
    To ensure Console preserves scroll position when switching panels,
    - ConsoleView's focus() now focuses the viewport instead of the
      prompt, when needed.
    - ConsoleView manually restores scroll positions, since viewport's
      focus() may scroll items into view.
    
    Bug: 865674
    Change-Id: I8f338a98557c94dddc7f0ba5177b635a72aee503
    Reviewed-on: https://chromium-review.googlesource.com/c/1361793
    Reviewed-by: Joel Einbinder <einbinder@chromium.org>
    Commit-Queue: Erik Luo <luoe@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614259}

    Changed files

    • third_party/blink/renderer/devtools/front_end/console/ConsoleView.js
    • third_party/blink/renderer/devtools/front_end/console/ConsoleViewport.js
    • third_party/blink/web_tests/http/tests/devtools/console/console-focus-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/console/console-focus.js
  14. Roll src/third_party/dawn e2f948469c66..0a7ddd43d77c (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 03:30:25 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 46b10ea6760666cd5eb4f50e8523a5c1b3bdda0d

    Comments

    Roll src/third_party/dawn e2f948469c66..0a7ddd43d77c (1 commits)
    
    https://dawn.googlesource.com/dawn.git/+log/e2f948469c66..0a7ddd43d77c
    
    
    git log e2f948469c66..0a7ddd43d77c --date=short --no-merges --format='%ad %ae %s'
    2018-12-05 senorblanco@chromium.org Create new src/tests BUILD.gn file.
    
    
    Created with:
      gclient setdep -r src/third_party/dawn@0a7ddd43d77c
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://ski
    ...skip...
    OTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=cwallez@chromium.org
    
    Change-Id: I247d5fe52886ea7f75eb3ad9302f80e9ec371677
    Reviewed-on: https://chromium-review.googlesource.com/c/1364177
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614260}

    Changed files

    • DEPS
  15. Roll src/third_party/catapult a8f4725aa003..41fdb78fbbd8 (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 03:30:29 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 7c2c6d0b62ba27d74d76d889cac156032508ada2

    Comments

    Roll src/third_party/catapult a8f4725aa003..41fdb78fbbd8 (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/a8f4725aa003..41fdb78fbbd8
    
    
    git log a8f4725aa003..41fdb78fbbd8 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 rmhasan@google.com Adds new verification to expectation_parser.py
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@41fdb78fbbd8
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
    
    Documentation for the AutoRoller is h
    ...skip...
    linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:905426
    TBR=sullivan@chromium.org
    
    Change-Id: Iadc0d06b2a4c70581e69076309c1b0be42ad0aec
    Reviewed-on: https://chromium-review.googlesource.com/c/1364178
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614261}

    Changed files

    • DEPS
  16. Android: Rename __build_config targets to __build_config_crbug_908819

    Changed by agrieveohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 03:31:30 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision cec62592a29d5d33fe9049a470dab57a247f9fb1

    Comments

    Android: Rename __build_config targets to __build_config_crbug_908819
    
    Goal is to surface give a pointer in "missing dependency" error messages
    about why the non-existent dependency was added.
    
    TBR=agrieve  # Trivial rename
    
    Bug: 908819
    Change-Id: I42a7b791658101985ec90afe85cbfe54de86b8df
    Reviewed-on: https://chromium-review.googlesource.com/c/1361933
    Commit-Queue: agrieve <agrieve@chromium.org>
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614262}

    Changed files

    • android_webview/glue/generate_resource_rewriter.gni
    • build/android/docs/build_config.md
    • build/android/gradle/generate_gradle.py
    • build/config/android/internal_rules.gni
    • build/config/android/rules.gni
  17. Roll src/third_party/depot_tools 9875e180e5fd..2e00228777c0 (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 03:31:33 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision a9e0cd51f3d7bc6927d332966ab734d8045b2d2d

    Comments

    Roll src/third_party/depot_tools 9875e180e5fd..2e00228777c0 (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9875e180e5fd..2e00228777c0
    
    
    git log 9875e180e5fd..2e00228777c0 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 vadimsh@chromium.org [cipd] Update CIPD client to v2.2.13.
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@2e00228777c0
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
    
    Document
    ...skip...
    ausing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:911229
    TBR=agable@chromium.org
    
    Change-Id: Ibce76fcee0243f3df875ac171c9b84663e2e4bf4
    Reviewed-on: https://chromium-review.googlesource.com/c/1364018
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614263}

    Changed files

    • DEPS