Home | Search
Login

Builder ToTAndroid Build #4550

Results:

failed compile

Trigger Info:

Got Revisionf0a2cb028ac1783367699e8328a39951440671b3

Execution:

Steps and Logfiles:

Show:
  1. ( 29 mins 9 secs ) steps
    running steps via annotated script
  2. ( 5 secs ) update_scripts
    update_scripts
  3. ( 9 ms ) LUCI Migration
    LUCI Migration
  4. ( 16 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 1 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 1 ms ) report builders
    report builders
     
    running builder/tester 'ToTAndroid' on master 'chromium.clang'
  7. ( 1 ms ) makedirs checkout path
    makedirs checkout path
  8. ( 1 mins 55 secs ) bot_update
    bot_update
    [96GB/492GB used (19%)]
  9. ( 1 ms ) swarming.py --version
    swarming.py --version
    0.13
  10. ( 23 mins 1 secs ) gclient runhooks
    gclient runhooks
  11. ( 1 ms ) get compile targets for scripts
    get compile targets for scripts
  12. ( 1 ms ) read test spec (chromium.clang.json)
    read test spec (chromium.clang.json)
    path: /b/c/b/ToTAndroid/src/testing/buildbot/chromium.clang.json
  13. ( 25 secs ) clean local files
    clean local files
  14. ( 1 ms ) tree truth steps
    tree truth steps
  15. ( 1 ms ) clean isolated files
    clean isolated files
  16. ( 14 secs ) generate_build_files
    generate_build_files
  17. ( 1 ms ) read GN args
    read GN args
     
    clang_use_chrome_plugins = false
    ffmpeg_branding = "Chrome"
    is_clang = true
    is_component_build = false
    is_debug = false
    llvm_force_head_revision = true
    proprietary_codecs = true
    strip_debug_info = true
    symbol_level = 1
    target_os = "android"
  18. ( 1 ms ) clang_revision
    clang_revision
  19. ( 2 mins 13 secs ) compile
    compile
  20. ( 2 secs ) upload_ninja_log
    upload_ninja_log
  21. ( 1 ms ) Failure reason
    Failure reason

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromium/bb/chromium.clang/ToTAndroid/4550/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.clang/ToTAndroid/4550" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "7f2329398fe8a8b57fa16ec222127a55a457968d" Annotation(bot_update)
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" Annotation(bot_update)
got_nacl_revision "32b6deb45d5fbc77c5f65d35db45c48cae3c06bc" Annotation(bot_update)
got_revision "f0a2cb028ac1783367699e8328a39951440671b3" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#591313}" Annotation(bot_update)
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" Annotation(bot_update)
got_v8_revision "9e11a283a395755900682bf19e307d4079de7d8c" Annotation(bot_update)
got_v8_revision_cp "refs/heads/7.1.98@{#1}" Annotation(bot_update)
got_webrtc_revision "e899629be4d8c86d3b26440b51d29db39c19b490" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#24737}" Annotation(bot_update)
got_clang_revision "342219" Annotation(clang_revision)
build_data_dir "/b/rr/tmpb3XQNG" Annotation(steps)
build_id "buildbot/chromium.clang/ToTAndroid/4550" Annotation(steps)
builder_id "master.chromium.clang:ToTAndroid" Annotation(steps)
blamelist ["afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","bratell@opera.com","chromium-autoroll@skia-public.iam.gserviceaccount.com","djean@google.com","futhark@chromium.org","ksakamoto@chromium.org","leon.han@intel.com","mkwst@chromium.org","momon@google.com","ossu@chromium.org","philipp.hancke@googlemail.com","thestig@chromium.org","tkent@chromium.org","toyoshim@chromium.org","v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com","vovoy@chromium.org"] Build
branch "master" Build
buildnumber 4550 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src.git" Build
requestedAt 1536908843 Build
revision "f0a2cb028ac1783367699e8328a39951440671b3" Build
slavename "slave144-c1" BuildSlave
buildername "ToTAndroid" Builder
git_revision "f0a2cb028ac1783367699e8328a39951440671b3" Change
scheduler "chromium_src_commits" Scheduler
buildbotURL "https://build.chromium.org/p/chromium.clang/" master.cfg
mastername "chromium.clang" master.cfg
workdir "/b/build/slave/ToTAndroid" slave

Blamelist:

  1. (leon.hanohnoyoudont@intel.com)
  2. (afdo-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  3. (toyoshimohnoyoudont@chromium.org)
  4. (bratellohnoyoudont@opera.com)
  5. (vovoyohnoyoudont@chromium.org)
  6. (mkwstohnoyoudont@chromium.org)
  7. (momonohnoyoudont@google.com)
  8. (futharkohnoyoudont@chromium.org)
  9. (ksakamotoohnoyoudont@chromium.org)
  10. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  11. (djeanohnoyoudont@google.com)
  12. (thestigohnoyoudont@chromium.org)
  13. (ossuohnoyoudont@chromium.org)
  14. (tkentohnoyoudont@chromium.org)
  15. (philipp.hanckeohnoyoudont@googlemail.com)
  16. (vovoyohnoyoudont@chromium.org)
  17. (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)

Timing:

Create N/A
Start Friday, 14-Sep-18 09:49:11 UTC
End Friday, 14-Sep-18 10:18:21 UTC
Pending N/A
Execution 29 mins 9 secs

All Changes:

  1. [OnionSoup] Remove WebServiceWorkerClientsClaimCallbacks

    Changed by leon.hanohnoyoudont@intel.com
    Changed at Friday, 14-Sep-18 07:05:58 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision a150f13b6358860cdd8b245576363de39413d743

    Comments

    [OnionSoup] Remove WebServiceWorkerClientsClaimCallbacks
    
    After https://chromium-review.googlesource.com/c/chromium/src/+/1214709,
    now we send ClaimClients Mojo message from within Blink, no longer need
    this WebServiceWorkerClientsClaimCallbacks to cross boundary of Content
    and Blink.
    
    BUG=879019
    
    Change-Id: I755958f10b9cc3d049f89dec59eb2491bef31c1e
    Reviewed-on: https://chromium-review.googlesource.com/1220328
    Commit-Queue: Leon Han <leon.han@intel.com>
    Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#591297}

    Changed files

    • third_party/blink/public/BUILD.gn
    • third_party/blink/public/platform/modules/service_worker/web_service_worker_clients_claim_callbacks.h
    • third_party/blink/renderer/modules/service_worker/service_worker_clients.cc
    • third_party/blink/renderer/modules/service_worker/service_worker_error.cc
    • third_party/blink/renderer/modules/service_worker/service_worker_error.h
    • third_party/blink/renderer/modules/service_worker/service_worker_global_scope_client.cc
    • third_party/blink/renderer/modules/service_worker/service_worker_global_scope_client.h
  2. Roll AFDO from 71.0.3551.2_rc-r1 to 71.0.3552.0_rc-r1

    Changed by afdo-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Friday, 14-Sep-18 07:39:24 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision f861aa1ac410de8a5fdf0d26786ad237142fb32a

    Comments

    Roll AFDO from 71.0.3551.2_rc-r1 to 71.0.3552.0_rc-r1
    
    This CL may cause a small binary size increase, roughly proportional
    to how long it's been since our last AFDO profile roll. For larger
    increases (around or exceeding 100KB), please file a bug against
    gbiv@chromium.org. Additional context: https://crbug.com/805539
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoro
    ...skip...
     contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=gbiv@chromium.org
    
    Change-Id: I86b7b1b4a6d52f080a16980860111423919ebfd9
    Reviewed-on: https://chromium-review.googlesource.com/1226013
    Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#591298}

    Changed files

    • chrome/android/profiles/newest.txt
  3. ResourceLoadScheduler: Omit console info until the next state change

    Changed by toyoshimohnoyoudont@chromium.org
    Changed at Friday, 14-Sep-18 08:07:01 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision e3e236b01c92a5a334c818454bbf6bdb7377e615

    Comments

    ResourceLoadScheduler: Omit console info until the next state change
    
    Currently, we show console info when a throttling happens. I expect
    console's feature to gather similar messages omits repeating messages.
    But it does not work well if users' JavaScript put own logs.
    
    This patch adds a boolean flag to omit repeating messages. The flag
    will be reset when SchedulingLifecycleState changes. This should not
    happen so frequently.
    
    Bug: 883294
    Change-Id: I3e7844a7d4456fde88e198f500e21cb74c2ada64
    Reviewed-on: https://chromium-review.googlesource.com/1226482
    Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#591299}

    Changed files

    • third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc
    • third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.h
  4. Add support for jumbo in services/network (-7 CPU minutes)

    Changed by bratellohnoyoudont@opera.com
    Changed at Friday, 14-Sep-18 08:08:06 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 0d1660e8fa117697df40ddf4d755e3000599e7a3

    Comments

    Add support for jumbo in services/network (-7 CPU minutes)
    
    This adds support for jumbo compilation of services/network. Jumbo
    is a unity build implementation where many files are compiled
    together in the same translation unit. That is usually much faster,
    and more efficient, than compiling one file at a time, but it requires
    the code to be compatible with such treatment.
    
    In services/network there were two problems, one duplicated function
    which this patch unduplicates, and the IPC/ParamTraits system which
    is sensitive to include header ordering.
    
    In total, on the build time reference test, this saves 7 CPU minutes
    (from 12 to 4), or roughly 1 minute on an 8 core machine.
    
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: I997cc61159ccf9f23eb22f3b954b888b498e3862
    Reviewed-on: https://chromium-review.googlesource.com/1221946
    Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    Commit-Queue: Daniel Bratell <bratell@opera.com>
    Cr-Commit-Position: refs/heads/master@{#591300}

    Changed files

    • services/network/BUILD.gn
    • services/network/cors/cors_url_loader.cc
    • services/network/cors/cors_url_loader.h
    • services/network/public/cpp/BUILD.gn
  5. Remove serving_dirs usage in speedometer2

    Changed by vovoyohnoyoudont@chromium.org
    Changed at Friday, 14-Sep-18 08:26:26 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 76ac6d9368131537b0b474819f440a3df3477e0d

    Comments

    Remove serving_dirs usage in speedometer2
    
    The serving dir is also included by the page.
    
    Bug: chromium:883798
    Change-Id: I1d1a512774b69312642b6226a80023ac88ff3293
    Reviewed-on: https://chromium-review.googlesource.com/1226752
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Commit-Queue: Vovo Yang <vovoy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#591301}

    Changed files

    • tools/perf/benchmarks/speedometer2.py
  6. Add `document.domain` use counters to UKM.

    Changed by mkwstohnoyoudont@chromium.org
    Changed at Friday, 14-Sep-18 08:28:59 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 0989a6747d94349942269f803e57d3db0b25e75d

    Comments

    Add `document.domain` use counters to UKM.
    
    Bug: 787905
    Change-Id: Icbf2459fbd8bd60f6fc016624f72ec704491897b
    Reviewed-on: https://chromium-review.googlesource.com/1223368
    Reviewed-by: Steven Holte <holte@chromium.org>
    Commit-Queue: Mike West <mkwst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#591302}

    Changed files

    • chrome/browser/page_load_metrics/observers/use_counter/ukm_features.cc
  7. Restrict the use of CSSStyleSheets to only one Document

    Changed by momonohnoyoudont@google.com
    Changed at Friday, 14-Sep-18 08:50:17 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision eb63b845febd59990afb4eda6062edde359f1871

    Comments

    Restrict the use of CSSStyleSheets to only one Document
    
    After discussions in
    https://github.com/WICG/construct-stylesheets/issues/23, we concluded
    that using the same constructable stylesheet in multiple Documents
    should not be allowed, as it can raise security risk.
    This CL bans the use of CSSStyleSheets in different Documents by
    introducing associated_document_ in CSSStyleSheet and checking if the
    style is applied to the same Document when it's added to
    AdoptedStyleSheets of any TreeScope.
    
    Link to
    ...skip...
    tylesheets/issues/23
    
    Link to related CLs:
    crrev.com/c/1197002
    ^ Bring back moreStyleSheets as adoptedStyleSheets
    crrev.com/c/1160422
    ^ Implement Document.createEmptyCSSStyleSheet
    
    Bug: 807560
    Change-Id: Ia0ff0af8f9baeca09b14bcbeb10897cc99b5a0bf
    Reviewed-on: https://chromium-review.googlesource.com/1220527
    Commit-Queue: Momoko Sumida <momon@google.com>
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#591303}

    Changed files

    • third_party/WebKit/LayoutTests/fast/css/CSSStyleSheet-constructable.html
    • third_party/blink/renderer/core/css/css_style_sheet.cc
    • third_party/blink/renderer/core/css/css_style_sheet.h
    • third_party/blink/renderer/core/dom/document.cc
    • third_party/blink/renderer/core/dom/document_or_shadow_root.h
    • third_party/blink/renderer/core/dom/document_or_shadow_root.idl
    • third_party/blink/renderer/core/dom/tree_scope.cc
    • third_party/blink/renderer/core/dom/tree_scope.h
  8. Introduce StyleTraversalRoot for invalidate/recalc/rebuild.

    Changed by futharkohnoyoudont@chromium.org
    Changed at Friday, 14-Sep-18 08:54:55 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision ed7a56654a501f4764b5df1fb06f984b0650050b

    Comments

    Introduce StyleTraversalRoot for invalidate/recalc/rebuild.
    
    Style invalidation, style recalc, and layout tree rebuild all starts
    from the document root looking for dirty nodes which needs updating.
    That means we have unnecessary overhead traversing down to the dirty
    nodes, in particular when the number of dirty nodes are few and they
    have ancestors with many siblings. The overhead is mlog(n), if the
    depth to the dirty node(s) is n and the number of siblings for each
    ancestor is m. In particular, this
    ...skip...
    ection
    headings and links in the single page HTML spec shows that the
    RecalcStyle time is reduced by ~90%. Although that's an extreme case,
    we hope to see reduction in UMA numbers for Style.* performance for the
    50th percentile.
    
    Bug: 868810
    
    Change-Id: I1e2cea742348f35a07f89d31e8938e857d7405d8
    Reviewed-on: https://chromium-review.googlesource.com/1149300
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Reviewed-by: Anders Ruud <andruud@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#591304}

    Changed files

    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/css/BUILD.gn
    • third_party/blink/renderer/core/css/invalidation/style_invalidator.cc
    • third_party/blink/renderer/core/css/invalidation/style_invalidator.h
    • third_party/blink/renderer/core/css/layout_tree_rebuild_root.cc
    • third_party/blink/renderer/core/css/layout_tree_rebuild_root.h
    • third_party/blink/renderer/core/css/style_engine.cc
    • third_party/blink/renderer/core/css/style_engine.h
    • third_party/blink/renderer/core/css/style_invalidation_root.cc
    • third_party/blink/renderer/core/css/style_invalidation_root.h
    • third_party/blink/renderer/core/css/style_recalc_root.cc
    • third_party/blink/renderer/core/css/style_recalc_root.h
    • third_party/blink/renderer/core/css/style_traversal_root.cc
    • third_party/blink/renderer/core/css/style_traversal_root.h
    • third_party/blink/renderer/core/css/style_traversal_root_test.cc
    • third_party/blink/renderer/core/dom/container_node.cc
    • third_party/blink/renderer/core/dom/document.cc
    • third_party/blink/renderer/core/dom/element.cc
    • third_party/blink/renderer/core/dom/element.h
    • third_party/blink/renderer/core/dom/node.cc
    • third_party/blink/renderer/core/dom/node.h
  9. SignedExchange: Fix "invalid cbor header" test data

    Changed by ksakamotoohnoyoudont@chromium.org
    Changed at Friday, 14-Sep-18 09:01:25 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision f5c341a593985cab6e646bca1ae5511d93efd4e5

    Comments

    SignedExchange: Fix "invalid cbor header" test data
    
    In b2 format, CBOR header no longer appears at the first line of the
    xxd output.
    
    Bug: 803774
    Change-Id: I57b8a3833cbc2ec7339346244fe23099680f6a86
    Reviewed-on: https://chromium-review.googlesource.com/1226754
    Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#591305}

    Changed files

    • content/test/data/sxg/generate-test-sxgs.sh
    • content/test/data/sxg/test.example.org_test_invalid_cbor_header.sxg
  10. Roll src/third_party/skia 64b0fb599517..66261f1ac2b7 (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 14-Sep-18 09:02:23 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision ff03af2a11df4caecadc2a163be9e7cda1aaf7ac

    Comments

    Roll src/third_party/skia 64b0fb599517..66261f1ac2b7 (1 commits)
    
    https://skia.googlesource.com/skia.git/+log/64b0fb599517..66261f1ac2b7
    
    
    git log 64b0fb599517..66261f1ac2b7 --date=short --no-merges --format='%ad %ae %s'
    2018-09-14 csmartdalton@google.com ccpr: Don't release the stashed atlas proxy inside CopyAtlasOp
    
    
    Created with:
      gclient setdep -r src/third_party/skia@66261f1ac2b7
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is 
    ...skip...
    rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=caryclark@chromium.org
    
    Change-Id: I81d568ed3c405536bd8a237635e39e55ff90b91d
    Reviewed-on: https://chromium-review.googlesource.com/1226376
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#591306}

    Changed files

    • DEPS
  11. [ios] Added edit mode to bookmark search

    Changed by djeanohnoyoudont@google.com
    Changed at Friday, 14-Sep-18 09:03:46 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 78ec22b9935e102b470727ec543451a3565bb21e

    Comments

    [ios] Added edit mode to bookmark search
    
    Added handling of multiple edits by showing navigation bar when results are
    visible and handling any operation that would use the original root_node.
    
    Bug: 879570
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I451006aa456bcc494583aed58820e405d04852c0
    Reviewed-on: https://chromium-review.googlesource.com/1213174
    Commit-Queue: David Jean <djean@chromium.org>
    Reviewed-by: Sergio Collazos <sczs@chromium.org>
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#591307}

    Changed files

    • ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
    • ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
  12. Improve showing the printer management UI on Linux with Cinnamon.

    Changed by thestigohnoyoudont@chromium.org
    Changed at Friday, 14-Sep-18 09:04:04 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 109b9f7c2f4c9a5db75ef07575e395fdbd72a1c0

    Comments

    Improve showing the printer management UI on Linux with Cinnamon.
    
    Some users with Cinnamon use gnome-control-center for native printer
    management. So try launching it for Cinnamon users.
    
    BUG=869845
    
    Change-Id: Icbb73dd4db72c5151175015ffd8e6d0aaae76cf4
    Reviewed-on: https://chromium-review.googlesource.com/1226529
    Reviewed-by: Christian Dullweber <dullweber@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#591308}

    Changed files

    • chrome/browser/printing/printer_manager_dialog_linux.cc
  13. AudioServiceAudioProcessorProxy: Register as Aec Dump delegate later

    Changed by ossuohnoyoudont@chromium.org
    Changed at Friday, 14-Sep-18 09:07:59 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision df36306dcbed91e2477ee5020ca8ae8024d58911

    Comments

    AudioServiceAudioProcessorProxy: Register as Aec Dump delegate later
    
    There's no point in registering before having gotten an
    AudioProcessorControls to proxy to. Registering too early means it'll
    discard the request to start an AEC dump.
    
    I also simplified SetControls, as it should only be called once. The
    current structure was left behind from when the plan was to call it
    with nullptr to detach from the controls.
    
    Bug: 851959
    Change-Id: I4470a127fb6e22aa1b6fe4dd8a0b9bd0866514a4
    Reviewed-on: https://chromium-review.googlesource.com/1224930
    Reviewed-by: Max Morin <maxmorin@chromium.org>
    Commit-Queue: Oskar Sundbom <ossu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#591309}

    Changed files

    • content/renderer/media/stream/audio_service_audio_processor_proxy.cc
    • content/renderer/media/stream/audio_service_audio_processor_proxy.h
  14. FileChooser: Mojoify FileChooser IPC, part 1

    Changed by tkentohnoyoudont@chromium.org
    Changed at Friday, 14-Sep-18 09:10:56 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision c260c9a88bad63450919aa5f953dcbe8f0b874d4

    Comments

    FileChooser: Mojoify FileChooser IPC, part 1
    
    This CL introduces mojo struct FileChooserParams, and replaces
    content::FileChooserParams with it.
    
    - We transfer the mojo struct over a legacy IPC message temporarily.
      Following CLs will remove the legacy IPC message.
    
    - Update blink::WebFileChooserParams so that it matches to the mojo
      struct.
    
    FYI: All-in-one CL: https://chromium-review.googlesource.com/1170454
    
    Bug: 869257
    Change-Id: If9ebd72bb1d69cb1a6d2b282d82ec940ae103748
    Reviewed-on: https://chromium-review.googlesource.com/1195242
    Reviewed-by: Richard Coles <torne@chromium.org>
    Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#591310}

    Changed files

    • android_webview/browser/aw_web_contents_delegate.cc
    • android_webview/browser/aw_web_contents_delegate.h
    • chrome/browser/android/tab_web_contents_delegate_android.cc
    • chrome/browser/android/tab_web_contents_delegate_android.h
    • chrome/browser/devtools/devtools_window.cc
    • chrome/browser/devtools/devtools_window.h
    • chrome/browser/extensions/extension_view_host.cc
    • chrome/browser/extensions/extension_view_host.h
    • chrome/browser/file_select_helper.cc
    • chrome/browser/file_select_helper.h
    • chrome/browser/file_select_helper_unittest.cc
    • chrome/browser/ssl/security_state_tab_helper_browsertest.cc
    • chrome/browser/ui/apps/chrome_app_delegate.cc
    • chrome/browser/ui/apps/chrome_app_delegate.h
    • chrome/browser/ui/browser.cc
    • chrome/browser/ui/browser.h
    • components/guest_view/browser/guest_view_base.cc
    • components/guest_view/browser/guest_view_base.h
    • content/browser/frame_host/render_frame_host_delegate.h
    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/frame_host/render_frame_host_impl.h
    • content/browser/renderer_host/render_view_host_impl.cc
    • content/browser/security_exploit_browsertest.cc
    • content/browser/web_contents/web_contents_impl.cc
    • content/browser/web_contents/web_contents_impl.h
    • content/browser/web_contents/web_contents_impl_browsertest.cc
    • content/common/frame_messages.h
    • content/public/browser/render_frame_host.h
    • content/public/browser/web_contents_delegate.h
    • content/public/common/BUILD.gn
    • content/public/common/file_chooser_params.cc
    • content/public/common/file_chooser_params.h
    • content/renderer/pepper/pepper_file_chooser_host.cc
    • content/renderer/pepper/pepper_file_chooser_host_unittest.cc
    • content/renderer/render_frame_impl.cc
    • content/renderer/render_frame_impl.h
    • content/renderer/render_view_impl.h
    • content/shell/test_runner/web_frame_test_client.cc
    • content/test/content_browser_test_utils_internal.cc
    • content/test/content_browser_test_utils_internal.h
    • extensions/browser/app_window/app_delegate.h
    • extensions/browser/app_window/app_window.cc
    • extensions/browser/app_window/app_window.h
    • extensions/shell/browser/shell_app_delegate.cc
    • extensions/shell/browser/shell_app_delegate.h
    • third_party/blink/public/mojom/BUILD.gn
    • third_party/blink/public/mojom/choosers/OWNERS
    • third_party/blink/public/mojom/choosers/file_chooser.mojom
    • third_party/blink/public/web/web_file_chooser_params.h
    • third_party/blink/renderer/core/html/forms/file_input_type.cc
  15. webrtc: whitelist relayProtocol in RTCIceCandidateStats

    Changed by philipp.hanckeohnoyoudont@googlemail.com
    Changed at Friday, 14-Sep-18 09:30:21 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision 1b49866770eba276f5f1a8eb5cfce4a105869fed

    Comments

    webrtc: whitelist relayProtocol in RTCIceCandidateStats
    
    BUG=webrtc:7063
    
    Change-Id: I6436a1f9ebcb34bbc770ee4f1792e6636aa8efa4
    Reviewed-on: https://chromium-review.googlesource.com/1204097
    Commit-Queue: Henrik Boström <hbos@chromium.org>
    Reviewed-by: Henrik Boström <hbos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#591311}

    Changed files

    • chrome/test/data/webrtc/peerconnection_getstats.js
  16. Remove serving_dirs usage in static_top_25_pages

    Changed by vovoyohnoyoudont@chromium.org
    Changed at Friday, 14-Sep-18 09:31:07 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision c04854f4ff7ec8ad30e5e98ca59dc1930ea6b817

    Comments

    Remove serving_dirs usage in static_top_25_pages
    
    The serving dir is also included by the pages.
    
    Bug: chromium:883798
    Change-Id: Ifb67e19b03303e4929a0e588f5450707adec4835
    Reviewed-on: https://chromium-review.googlesource.com/1226484
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Commit-Queue: Vovo Yang <vovoy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#591312}

    Changed files

    • tools/perf/page_sets/static_top_25_pages.py
  17. Update V8 to version 7.1.98.

    Changed by v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 14-Sep-18 09:33:30 UTC
    Repository https://chromium.googlesource.com/chromium/src.git
    Branch
    Revision f0a2cb028ac1783367699e8328a39951440671b3

    Comments

    Update V8 to version 7.1.98.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/c12805f8..9e11a283
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_test
    ...skip...
    tional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: Ieee24a047a868e919a019dbf6a66d60f4f013fc0
    Reviewed-on: https://chromium-review.googlesource.com/1226528
    Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#591313}

    Changed files

    • DEPS