Builder ChromiumOS daisy Compile Build #45881
Results:
build successful
Trigger Info:
Got Revision | 65b8e2b35173bd53b83b5b5bb693828c393b282a |
Execution:
Steps and Logfiles:
Show:-
( 4 ms ) read test spec (chromium.chromiumos.json)read test spec (chromium.chromiumos.json)path: /b/c/b/ChromiumOS_daisy_Compile/src/testing/buildbot/chromium.chromiumos.json
Build Properties:
Name | Value | Source |
---|---|---|
log_location | "logdog://logs.chromium.org/chromium/bb/chromium.chromiumos/ChromiumOS_daisy_Compile/45881/+/recipes/annotations" | Annotation(LogDog Bootstrap) |
logdog_prefix | "bb/chromium.chromiumos/ChromiumOS_daisy_Compile/45881" | Annotation(LogDog Bootstrap) |
logdog_project | "chromium" | Annotation(LogDog Bootstrap) |
got_angle_revision | "f4f293effbc6ccba0b6462743d3f5bd9c794d75d" | Annotation(bot_update) |
got_buildtools_revision | null | Annotation(bot_update) |
got_nacl_revision | "7f07816e463da403255f0ab4f6d88004450dd09d" | Annotation(bot_update) |
got_revision | "65b8e2b35173bd53b83b5b5bb693828c393b282a" | Annotation(bot_update) |
got_revision_cp | "refs/heads/master@{#516342}" | Annotation(bot_update) |
got_swarming_client_revision | null | Annotation(bot_update) |
got_v8_revision | "9b3020fa2b08182b36b1cda292e4f67a70c7bd31" | Annotation(bot_update) |
got_v8_revision_cp | "refs/heads/6.4.288@{#1}" | Annotation(bot_update) |
got_webrtc_revision | "cba3d274daaf57b3c6e8bc6cd10b959cf2ec73bf" | Annotation(bot_update) |
got_webrtc_revision_cp | "refs/heads/master@{#20630}" | Annotation(bot_update) |
build_archive_url | "gs://chromium-chromiumos-archive/chromium.chromiumos/ChromiumOS daisy Compile/full-build-linux_65b8e2b35173bd53b83b5b5bb693828c393b282a.zip" | Annotation(package build) |
blamelist | ["adithyas@chromium.org","dpranke@chromium.org","edchin@chromium.org","loonybear@chromium.org","npm@chromium.org","pavely@chromium.org","perezju@chromium.org","rdsmith@chromium.org","rtoy@chromium.org","zakerinasab@chromium.org"] | Build |
branch | "master" | Build |
buildnumber | 45881 | Build |
project | "src" | Build |
repository | "https://chromium.googlesource.com/chromium/src" | Build |
requestedAt | 1510679510 | Build |
revision | "65b8e2b35173bd53b83b5b5bb693828c393b282a" | Build |
slavename | "slave25-c1" | BuildSlave |
buildername | "ChromiumOS daisy Compile" | Builder |
git_revision | "65b8e2b35173bd53b83b5b5bb693828c393b282a" | Change |
scheduler | "chromium" | Scheduler |
buildbotURL | "https://build.chromium.org/p/chromium.chromiumos/" | master.cfg |
mastername | "chromium.chromiumos" | master.cfg |
workdir | "/b/build/slave/ChromiumOS_daisy_Compile" | slave |
Blamelist:
- (pavelyohnoyoudont@chromium.org)
- (adithyasohnoyoudont@chromium.org)
- (edchinohnoyoudont@chromium.org)
- (rtoyohnoyoudont@chromium.org)
- (rdsmithohnoyoudont@chromium.org)
- (zakerinasabohnoyoudont@chromium.org)
- (npmohnoyoudont@chromium.org)
- (perezjuohnoyoudont@chromium.org)
- (dprankeohnoyoudont@chromium.org)
- (loonybearohnoyoudont@chromium.org)
Timing:
Create | N/A |
Start | Tuesday, 14-Nov-17 17:49:30 UTC |
End | Tuesday, 14-Nov-17 18:08:51 UTC |
Pending | N/A |
Execution | 19 mins 20 secs |
All Changes:
-
Reland: [Sync] Switch processor/worker to pull model
Changed by pavelyohnoyoudont@chromium.org Changed at Tuesday, 14-Nov-17 17:10:43 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7e0a44b102cbc1c2da37196f3f83b19dd6c67bcf Comments
Reland: [Sync] Switch processor/worker to pull model This change makes worker use results of GetLocalChanges when preparing commit contribution. EnqueueForCommit is not used and therefore removed. With this change the expectation is that ModelTypeWorker::entities_ only accumulate entities in two scenarios: - Between calls to ProcessGetUpdatesResponse and ApplyUpdates remote updates are accumulated - Between calls to GetContribution and OnCommit response local changes are maintained Encryption i ...skip... at. This CL includes bunch of random small cleanups I stumbled upon while reviewing implementation. BUG=740757 R=skym@chromium.org Reviewed-on: https://chromium-review.googlesource.com/729520 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#511258} Change-Id: I753173b6638d802c2057472f7a612e1b8f876d4c Reviewed-on: https://chromium-review.googlesource.com/753983 Cr-Commit-Position: refs/heads/master@{#516333}
Changed files
- components/sync/engine/commit_queue.h
- components/sync/engine_impl/commit.cc
- components/sync/engine_impl/commit.h
- components/sync/engine_impl/model_type_registry.cc
- components/sync/engine_impl/model_type_worker.cc
- components/sync/engine_impl/model_type_worker.h
- components/sync/engine_impl/model_type_worker_unittest.cc
- components/sync/engine_impl/non_blocking_type_commit_contribution.cc
- components/sync/engine_impl/syncer_util.cc
- components/sync/engine_impl/syncer_util.h
- components/sync/engine_impl/worker_entity_tracker.cc
- components/sync/model/entity_data.cc
- components/sync/model/entity_data.h
- components/sync/model_impl/processor_entity_tracker.cc
- components/sync/model_impl/processor_entity_tracker.h
- components/sync/model_impl/processor_entity_tracker_unittest.cc
- components/sync/model_impl/shared_model_type_processor.cc
- components/sync/model_impl/shared_model_type_processor.h
- components/sync/model_impl/shared_model_type_processor_unittest.cc
- components/sync/test/engine/mock_model_type_processor.cc
- components/sync/test/engine/mock_model_type_processor.h
- components/sync/test/engine/mock_model_type_worker.cc
- components/sync/test/engine/mock_model_type_worker.h
- components/sync/test/engine/single_type_mock_server.cc
-
Skip ancestor check if no fieldset elements were previously found
Changed by adithyasohnoyoudont@chromium.org Changed at Tuesday, 14-Nov-17 17:15:38 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3b949e190e6cf1a339911743abff26acbabcec99 Comments
Skip ancestor check if no fieldset elements were previously found If no fieldset element is found the first time UpdateAncestorDisabledState is run, future traversals to search for fieldset elements are skipped. This reduces time spent in HTMLInputElement::InsertedInto and HTMLInputElement::RemovedFrom by about 3% each. Bug: Change-Id: Id70b60f4d815dd2fa2067ea2971e57f6d9bb2922 Reviewed-on: https://chromium-review.googlesource.com/739182 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#516334}
Changed files
- third_party/WebKit/Source/core/html/forms/HTMLFormControlElement.cpp
- third_party/WebKit/Source/core/html/forms/HTMLFormControlElement.h
-
[ios] Fix settings presentation from SignedInAccounts
Changed by edchinohnoyoudont@chromium.org Changed at Tuesday, 14-Nov-17 17:15:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ef157deb8f5bbfa45547f500935c3b00a5e64af2 Comments
[ios] Fix settings presentation from SignedInAccounts The SignedInAccounts modal has a button to show the Settings screen, in which case the modal should be dismissed before presenting the Settings screen. This CL makes presentation happen inside the completion block of the dismissal. Otherwise, the presentation will fail because |self.presentingViewController| is still busy presenting another screen. Also, |self.presentingViewController| must be set to another variable to be used for presentation, otherwise, it will be nil after dismissal. Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia67e19816a4010a630f9679bae709b4f7307a3be Reviewed-on: https://chromium-review.googlesource.com/767587 Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#516335}
Changed files
- ios/chrome/browser/ui/authentication/signed_in_accounts_view_controller.mm
-
Handle AudioParam start clamping more efficiently.
Changed by rtoyohnoyoudont@chromium.org Changed at Tuesday, 14-Nov-17 17:16:50 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision aa260864abeb2898f711578e864673a5ec7bc43a Comments
Handle AudioParam start clamping more efficiently. Add a new vector to keep track of all newly inserted events. This vector is processed once in the audio thread to clamp the start time of the event if needed. Once processed, this vector is cleared. Previously, the clamp check would process the entire event list to see if any event needed to be clamped. Most of the time, this is wasted because there are no events to be clamped because they're all in the future or because they've already been clamped. Also removed unneeded member functions and variables. Bug: 780125 Test: Change-Id: I73b871d8fa87a68e482cb98d48af33e05d1f0cfb Reviewed-on: https://chromium-review.googlesource.com/747071 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#516336}
Changed files
- third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp
- third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h
-
Switch SessionDataDeleter cookie access over to Mojo.
Changed by rdsmithohnoyoudont@chromium.org Changed at Tuesday, 14-Nov-17 17:16:56 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c2789e7e496c904eeb6a0fe6684357ccec39c4fe Comments
Switch SessionDataDeleter cookie access over to Mojo. Bug: 721395 Change-Id: I06b833910c11c345b0995c0ff3f7de5f64c56b82 Reviewed-on: https://chromium-review.googlesource.com/760037 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#516337}
Changed files
- chrome/browser/sessions/session_data_deleter.cc
-
Update canvas-imageSmoothingQuality.html layout test fail status
Changed by zakerinasabohnoyoudont@chromium.org Changed at Tuesday, 14-Nov-17 17:18:19 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 837057b3271bfd9244e2a38a513867ace41ad536 Comments
Update canvas-imageSmoothingQuality.html layout test fail status According to the flakiness dashboard, layout test virtual/gpu/fast/canvas/ canvas-imageSmoothingQuality.html is now passing on Linux and Win, but still failing on Mac trybots: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=virtual%2Fgpu%2Ffast%2Fcanvas%2Fcanvas-imageSmoothingQuality.html This CL updates the fail tag to reflect this behavior. Bug: 693568 Change-Id: Ibd2974c9c02706d0ad5d6b0c342e2dc1112ead34 TBR: junov@chromium.org Reviewed-on: https://chromium-review.googlesource.com/768948 Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#516338}
Changed files
- third_party/WebKit/LayoutTests/TestExpectations
-
Add paint-timing test when child iframe paints
Changed by npmohnoyoudont@chromium.org Changed at Tuesday, 14-Nov-17 17:18:53 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 32522b611fe1b8c5dfb2e8111baca350115dc19d Comments
Add paint-timing test when child iframe paints This CL adds a test with a frame having a child iframe that renders an image. the parent should only get a first-paint entry even after the child has rendered the image. An upstream spec issue had been filed to clarify: https://github.com/w3c/paint-timing/issues/22 Bug: 736114 Change-Id: Idc0910a7acc8f8af3bf9634a7e6827805fe8d370 Reviewed-on: https://chromium-review.googlesource.com/766393 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#516339}
Changed files
- third_party/WebKit/LayoutTests/external/wpt/lint.whitelist
- third_party/WebKit/LayoutTests/external/wpt/paint-timing/child-painting-first-image.html
- third_party/WebKit/LayoutTests/external/wpt/paint-timing/resources/subframe-painting.html
- third_party/WebKit/LayoutTests/external/wpt/paint-timing/resources/subframe-sending-paint.html
-
[tools/android] Remove purge_ashmem tool
Changed by perezjuohnoyoudont@chromium.org Changed at Tuesday, 14-Nov-17 17:20:17 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9b9a86df3a6c72200f61065de82c6b45ed20bbab Comments
[tools/android] Remove purge_ashmem tool Tool is no longer used. Bug: 632021 Change-Id: Ib3fc75c0fdfa0d60ae9187e3009572ba694a7f3c Reviewed-on: https://chromium-review.googlesource.com/768733 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#516340}
Changed files
- tools/android/BUILD.gn
- tools/android/purge_ashmem/BUILD.gn
- tools/android/purge_ashmem/purge_ashmem.c
-
Revert "Reuse kArcIntentHelperPackageName in c/b/"
Changed by dprankeohnoyoudont@chromium.org Changed at Tuesday, 14-Nov-17 17:43:46 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a4b140b2f9122886e02d923525a08c2c6c39d52d Comments
Revert "Reuse kArcIntentHelperPackageName in c/b/" This reverts commit bf228a619a3edcb3321e1aee0ba23536427e0721. Reason for revert: Didn't compile properly on CrOS (which we missed due to a bad CQ configuration). Original change's description: > Reuse kArcIntentHelperPackageName in c/b/ > > Reusing kArcIntentHelperPackageName where needed. Also adding a method > to reuse such package name + a custom string appended to it, this is > AppendStringToIntentHelperPackageName. > > Bug: None > Test: Buil ...skip... kes@chromium.org> > Commit-Queue: David Jacobo <djacobo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#516326} TBR=yusukes@chromium.org,sky@chromium.org,djacobo@chromium.org Change-Id: Idfef3e2b248c5a1339bb97c47be0f3a6cdf84ba3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/769187 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#516341}
Changed files
- chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.cc
- chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc
- chrome/browser/chromeos/arc/user_session/arc_user_session_service.cc
- chrome/browser/ui/app_list/arc/arc_app_utils.cc
- chrome/browser/ui/views/apps/app_info_dialog/arc_app_info_links_panel.cc
- components/arc/intent_helper/arc_intent_helper_bridge.cc
- components/arc/intent_helper/arc_intent_helper_bridge.h
- components/arc/intent_helper/arc_intent_helper_bridge_unittest.cc
-
Revert "Reuse kArcIntentHelperPackageName in c/b/"
Changed by loonybearohnoyoudont@chromium.org Changed at Tuesday, 14-Nov-17 17:45:12 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 65b8e2b35173bd53b83b5b5bb693828c393b282a Comments
Revert "Reuse kArcIntentHelperPackageName in c/b/" This reverts commit bf228a619a3edcb3321e1aee0ba23536427e0721. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reuse kArcIntentHelperPackageName in c/b/ > > Reusing kArcIntentHelperPackageName where needed. Also adding a method > to reuse such package name + a custom string appended to it, this is > AppendStringToIntentHelperPackageName. > > Bug: None > Test: Build. > Change-Id: I1b9115b808533e1e5ed3339b7f3747496ca2f0c3 ...skip... romium.org,sky@chromium.org,djacobo@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Revert because it is breaking the build https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/79362 Change-Id: I2cd3a0c2b526d542242e14eeb9ed363b784f7795 Reviewed-on: https://chromium-review.googlesource.com/769047 Reviewed-by: Luna Lu <loonybear@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#516342}