Home | Search
Login

Builder Google Chrome Win Build #40120 Microsoft Windows

Results:

build successful

Trigger Info:

Got Revisionf2fef5671fb6850a4cdc203534f90483c35e2564

Execution:

Steps and Logfiles:

Show:
  1. ( 17 mins 26 secs ) steps
    running steps via annotated script
  2. ( 33 secs ) update_scripts
    update_scripts
  3. ( 3 ms ) LUCI Migration
    LUCI Migration
  4. ( 4 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 5 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 3 ms ) report builders
    report builders
     
    running builder/tester 'Google Chrome Win' on master 'chromium.chrome'
  7. ( 3 ms ) taskkill
    taskkill
  8. ( 3 ms ) makedirs checkout path
    makedirs checkout path
  9. ( 2 mins 25 secs ) bot_update
    bot_update
    [254GB/2047GB used (12%)]
  10. ( 3 ms ) ensure_goma
    ensure_goma
  11. ( 4 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  12. ( 3 ms ) swarming.py --version
    swarming.py --version
    0.13
  13. ( 49 secs ) clobber
    clobber
  14. ( 30 secs ) gclient runhooks
    gclient runhooks
  15. ( 4 ms ) get compile targets for scripts
    get compile targets for scripts
  16. ( 4 ms ) read test spec (chromium.chrome.json)
    read test spec (chromium.chrome.json)
    path: C:\b\c\b\win_chrome\src\testing\buildbot\chromium.chrome.json
  17. ( 3 ms ) lookup GN args
    lookup GN args
     
    is_chrome_branded = true
    is_debug = false
    is_official_build = true
    strip_absolute_paths_from_debug_symbols = true
    target_cpu = "x86"
    use_goma = true
    goma_dir = "C:\\b\\c\\goma_cache\\client"
  18. ( 1 mins 10 secs ) generate_build_files
    generate_build_files
  19. ( 3 ms ) preprocess_for_goma
    preprocess_for_goma
  20. ( 3 ms ) preprocess_for_goma.goma cache directory
    preprocess_for_goma.goma cache directory
  21. ( 12 secs ) preprocess_for_goma.start_goma
    preprocess_for_goma.start_goma
  22. ( 3 ms ) preprocess_for_goma.start cloudtail
    preprocess_for_goma.start cloudtail
  23. ( 10 mins 5 secs ) compile
    compile
  24. ( 5 secs ) compile confirm no-op
    compile confirm no-op
  25. ( 3 ms ) postprocess_for_goma
    postprocess_for_goma
  26. ( 4 ms ) postprocess_for_goma.goma_jsonstatus
    postprocess_for_goma.goma_jsonstatus
  27. ( 3 ms ) postprocess_for_goma.goma_stat
    postprocess_for_goma.goma_stat
  28. ( 3 ms ) postprocess_for_goma.stop_goma
    postprocess_for_goma.stop_goma
  29. ( 14 secs ) postprocess_for_goma.upload_log
    postprocess_for_goma.upload_log
  30. ( 10 secs ) postprocess_for_goma.stop cloudtail
    postprocess_for_goma.stop cloudtail
  31. ( 3 ms ) test_pre_run
    test_pre_run
  32. ( 6 ms ) sizes
    sizes
    sizes
    <div class="BuildResultInfo">
    </div>
  33. ( 3 ms ) process_dumps
    process_dumps
  34. ( 4 ms ) recipe result
    recipe result

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromium/bb/chromium.chrome/Google_Chrome_Win/40120/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.chrome/Google_Chrome_Win/40120" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" Annotation(bot_update)
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" Annotation(bot_update)
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" Annotation(bot_update)
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" Annotation(bot_update)
got_revision "f2fef5671fb6850a4cdc203534f90483c35e2564" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#606892}" Annotation(bot_update)
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" Annotation(bot_update)
got_v8_revision "f6ed3c5d7eb73112326476d681f0f79d40fc1e0e" Annotation(bot_update)
got_v8_revision_cp "refs/heads/7.2.287@{#1}" Annotation(bot_update)
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#25544}" Annotation(bot_update)
build_data_dir "C:\\b\\rr\\tmpevk_2f" Annotation(steps)
build_id "buildbot/chromium.chrome/Google Chrome Win/40120" Annotation(steps)
builder_id "master.chromium.chrome:Google Chrome Win" Annotation(steps)
blamelist ["chromium-autoroll@skia-public.iam.gserviceaccount.com","chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com","fsamuel@chromium.org","hayato@chromium.org","huayinz@chromium.org","javierrobles@chromium.org","jdeblasio@chromium.org","lanwei@chromium.org","mcarlen@chromium.org","penghuang@chromium.org","skym@google.com","wub@chromium.org"] Build
branch "master" Build
buildnumber 40120 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1541784425 Build
revision "f2fef5671fb6850a4cdc203534f90483c35e2564" Build
slavename "build52-m1" BuildSlave
buildername "Google Chrome Win" Builder
git_revision "f2fef5671fb6850a4cdc203534f90483c35e2564" Change
scheduler "chromium" Scheduler
buildbotURL "http://build.chromium.org/p/chromium.chrome/" master.cfg
mastername "chromium.chrome" master.cfg
workdir "C:\\b\\build\\slave/google-chrome-rel-win" slave

Blamelist:

  1. (huayinzohnoyoudont@chromium.org)
  2. (lanweiohnoyoudont@chromium.org)
  3. (mcarlenohnoyoudont@chromium.org)
  4. (hayatoohnoyoudont@chromium.org)
  5. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  6. (skymohnoyoudont@google.com)
  7. (jdeblasioohnoyoudont@chromium.org)
  8. (fsamuelohnoyoudont@chromium.org)
  9. (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  10. (javierroblesohnoyoudont@chromium.org)
  11. (wubohnoyoudont@chromium.org)
  12. (penghuangohnoyoudont@chromium.org)

Timing:

Create N/A
Start Friday, 09-Nov-18 17:53:07 UTC
End Friday, 09-Nov-18 18:10:34 UTC
Pending N/A
Execution 17 mins 26 secs

All Changes:

  1. [Feed] Fix Feed NTP not clickable when hardware keyboard is connected

    Changed by huayinzohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:25:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision acb2df40a36d52ef4649dc82d779b8b024112358

    Comments

    [Feed] Fix Feed NTP not clickable when hardware keyboard is connected
    
    Bug: 891877
    Change-Id: I8c0cae6ad80f290580975983cb2d2f4f6286509b
    Reviewed-on: https://chromium-review.googlesource.com/c/1325082
    Commit-Queue: Becky Zhou <huayinz@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606881}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java
  2. Add action_sequence in testdriver

    Changed by lanweiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:28:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 687313c56366619151285b4d87847b61e6547cbc

    Comments

    Add action_sequence in testdriver
    
    After we expose test_driver.Actions API to web users, we add their
    implementation in our testdriver file, and fix the wpt tests of
    Actions API.
    
    Bug: 893480
    Change-Id: Ib02c0223208eeb2cc30c2ca35b98d5fc938baa2c
    Reviewed-on: https://chromium-review.googlesource.com/c/1289119
    Commit-Queue: Lan Wei <lanwei@chromium.org>
    Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606882}

    Changed files

    • content/common/input/actions_parser.cc
    • content/common/input/actions_parser.h
    • content/common/input/actions_parser_unittest.cc
    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/elementPosition.html
    • third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/eventOrder.html
    • third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_pointermove.html
    • third_party/WebKit/LayoutTests/external/wpt/resources/testdriver-actions.js
    • third_party/WebKit/LayoutTests/external/wpt/resources/testdriver.js
    • third_party/WebKit/LayoutTests/external/wpt_automation/pointerevents/pointerevent_pointermove-manual-automation.js
    • third_party/WebKit/LayoutTests/resources/testdriver-vendor.js
    • third_party/WebKit/LayoutTests/resources/testdriver.js
  3. [Autofill Assistant] Handle payment request dismiss.

    Changed by mcarlenohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:30:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f3fe32fc147390a01e54fbd7c54e62ca3a3b8ad4

    Comments

    [Autofill Assistant] Handle payment request dismiss.
    
    Before this patch the payment request UI did not properly handle cancel
    and back button.
    
    This patch notifies the Autofill Assistant controller to shut down
    gracefully with a 'give up' message whenever the payment request UI has
    been canceled.
    
    Bug: 806868
    Change-Id: Ie3d83bf48a2004f0a6a72763c4b509b3db023ff9
    Reviewed-on: https://chromium-review.googlesource.com/c/1326499
    Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606883}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantPaymentRequest.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/PaymentRequestUI.java
    • components/autofill_assistant_strings.grdp
  4. Fix a bug in https://crrev.com/c/1272937, where event.target can be still null

    Changed by hayatoohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:31:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2ed9605b4c99774d8865dbd190e13c9fe5c2d03a

    Comments

    Fix a bug in https://crrev.com/c/1272937, where event.target can be still null
    
    Fix a bug in the previous CL, https://crrev.com/c/1272937, where event.target
    can be null when GetElement() returns nullptr.
    
    Bug: 892970, 893449, 902287
    Change-Id: I7a08227d39117c2dc90fe720f0d6ffd62d9b2ea6
    Reviewed-on: https://chromium-review.googlesource.com/c/1322177
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606884}

    Changed files

    • third_party/blink/renderer/modules/accessibility/ax_object.cc
  5. Roll src/third_party/perfetto cf90797ef05a..5fc6c2c52e7b (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 17:32:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0475284ad58e36e9950059000bb7ec3556bb31bb

    Comments

    Roll src/third_party/perfetto cf90797ef05a..5fc6c2c52e7b (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/cf90797ef05a..5fc6c2c52e7b
    
    
    git log cf90797ef05a..5fc6c2c52e7b --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 lalitm@google.com Merge "trace_processor: allow integers to be compared against doubles"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@5fc6c2c52e7b
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromiu
    ...skip...
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: Ifd53d09565e264f09c1deffb23f8adfce3a34958
    Reviewed-on: https://chromium-review.googlesource.com/c/1329505
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606885}

    Changed files

    • DEPS
  6. [Feed] Check loadUrlParams for null, fallback to opening online.

    Changed by skymohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 17:33:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 60b47f98f87e0f3689826e4342fab09b7a35ed5e

    Comments

    [Feed] Check loadUrlParams for null, fallback to opening online.
    
    Bug: 901179
    Change-Id: Ieb3a421a7930ddc0014f7ef57b6a8f6d89dc3615
    Reviewed-on: https://chromium-review.googlesource.com/c/1315358
    Commit-Queue: Sky Malice <skym@chromium.org>
    Reviewed-by: Filip Gorski <fgorski@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606886}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedLoggingBridge.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/action/FeedActionHandler.java
    • chrome/android/junit/src/org/chromium/chrome/browser/feed/action/FeedActionHandlerTest.java
    • chrome/browser/android/feed/feed_logging_bridge.cc
    • chrome/browser/android/feed/feed_logging_bridge.h
  7. Record Android revokes in Permissions.Action.Notification.

    Changed by jdeblasioohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:35:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f8c0f174bb015976222531ead359ade19b488833

    Comments

    Record Android revokes in Permissions.Action.Notification.
    
    This CL modifies fixes a bug in which metrics were not being recorded on
    Android when notification permissions were revoked. It adds a missing
    ScopedRevocationReporter for Chrome-visible changes, and adds detection
    code for when notification permissions are revoked in Android O+
    system channel settings.
    
    Bug: 782126
    Change-Id: I609e909936d09e6dd948f0601bbf73ecdb6b8b75
    Reviewed-on: https://chromium-review.googlesource.com/c/1324394
    Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Reviewed-by: Dominick Ng <dominickn@chromium.org>
    Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
    Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
    Reviewed-by: Christopher Thompson <cthomp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606887}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferenceBridge.java
    • chrome/browser/android/preferences/website_preference_bridge.cc
    • chrome/browser/permissions/permission_uma_util.h
    • tools/metrics/ukm/ukm.xml
  8. viz: Plumb LocalSurfaceIdAllocation to more places [part 5]

    Changed by fsamuelohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:36:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7e806513b1b91da6e96a56bfd3ca5f464c4666b9

    Comments

    viz: Plumb LocalSurfaceIdAllocation to more places [part 5]
    
    viz::LocalSurfaceIdAllocation bundles a viz::LocalSurfaceId and an
    allocation time for that viz::LocalSurfaceId. The purpose of this allocation
    time is to determine how long it takes for a surface to get embedded once
    an ID has been allocated for it.
    
    There was some concern raised about drift between LocalSurfaceIds and allocation
    times and so a previous CL bundled the two together in a class. This CL plumbs
    LocalSurfaceIdAllocation to more 
    ...skip...
    rentLocalSurfaceIdAllocator that return an allocation time or LocalSurfaceId
    independent of the other. This is to encourage future plumbing of
    LocalSurfaceIdAllocation instead.
    
    Bug: 655231
    Change-Id: I3118cc06e0afa04914a0e2e7457ffdfd5ad5778d
    Reviewed-on: https://chromium-review.googlesource.com/c/1327573
    Reviewed-by: Jonathan Ross <jonross@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Commit-Queue: Fady Samuel <fsamuel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606888}

    Changed files

    • cc/test/layer_tree_test.cc
    • cc/test/layer_tree_test.h
    • cc/trees/layer_tree_host_impl.cc
    • cc/trees/layer_tree_host_impl.h
    • cc/trees/layer_tree_host_unittest.cc
    • components/viz/common/surfaces/child_local_surface_id_allocator.h
    • components/viz/common/surfaces/child_local_surface_id_allocator_unittest.cc
    • components/viz/common/surfaces/parent_local_surface_id_allocator.h
    • components/viz/common/surfaces/parent_local_surface_id_allocator_unittest.cc
    • content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
    • third_party/blink/renderer/platform/graphics/surface_layer_bridge.cc
    • third_party/blink/renderer/platform/graphics/video_frame_submitter.cc
    • third_party/blink/renderer/platform/graphics/video_frame_submitter_test.cc
  9. Roll src-internal 827de2c806ba..5fa11106b909 (2 commits)

    Changed by chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 17:40:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7e4f2a9f17b74405f73aca4ecee7dcd639477de6

    Comments

    Roll src-internal 827de2c806ba..5fa11106b909 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/827de2c806ba..5fa11106b909
    
    
    Created with:
      gclient setdep -r src-internal@5fa11106b909
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ie1b9b04d41e2a6dfe8e4fa45f0d25892052660e1
    Reviewed-on: https://chromium-review.googlesource.com/c/1329503
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606889}

    Changed files

    • DEPS
  10. [iOS][MF] Adds password related histograms

    Changed by javierroblesohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:41:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f350cfe2c23c02c23f852840ee9d5e08d9c61e96

    Comments

    [iOS][MF] Adds password related histograms
    
    Bug: 878388
    Change-Id: Ia0a6622596753d87888e480401e38f7ef61ae539
    Reviewed-on: https://chromium-review.googlesource.com/c/1326013
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606890}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/password_view_controller.mm
    • tools/metrics/histograms/histograms.xml
  11. Reland "Export the quic batch writer code to Chromium. Note it's not used anywhere in Chrome, we are just exporting the code so people outside of Google can take a look."

    Changed by wubohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:45:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 346d1aac0d7c49126b8a9943434ee88af85481af

    Comments

    Reland "Export the quic batch writer code to Chromium. Note it's not used anywhere in Chrome, we are just exporting the code so people outside of Google can take a look."
    
    This reverts commit 683a348730bbea7ccea7158eacc04b928b3d5256.
    
    
    In addition to the auto-revert, I also changed two bzero calls to memset calls. I don't know why, but net_unittest under msan fails with a use-of-uninitialized-value: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8930601665674446576/+/st
    ...skip...
    al(int cmsg_level,
    
       if (cmsg_ == nullptr) {
         DCHECK_EQ(nullptr, hdr_.msg_control);
    -    bzero(cbuf_, cbuf_size_);
    +    memset(cbuf_, 0, cbuf_size_);
         hdr_.msg_control = cbuf_;
         cmsg_ = CMSG_FIRSTHDR(&hdr_);
       } else {
    
    
    R=rch@chromium.org
    
    Change-Id: Ibe60068cb87c0f974088b8c1601cc516ee333106
    Reviewed-on: https://chromium-review.googlesource.com/c/1329348
    Commit-Queue: Bin Wu <wub@chromium.org>
    Reviewed-by: Ryan Hamilton <rch@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606891}

    Changed files

    • net/BUILD.gn
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_base.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_base.h
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_buffer.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_buffer.h
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_buffer_test.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_test.h
    • net/third_party/quic/platform/impl/batch_writer/quic_gso_batch_writer.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_gso_batch_writer.h
    • net/third_party/quic/platform/impl/batch_writer/quic_gso_batch_writer_test.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_sendmmsg_batch_writer.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_sendmmsg_batch_writer.h
    • net/third_party/quic/platform/impl/batch_writer/quic_sendmmsg_batch_writer_test.cc
    • net/third_party/quic/platform/impl/quic_linux_socket_utils.cc
    • net/third_party/quic/platform/impl/quic_linux_socket_utils.h
    • net/third_party/quic/platform/impl/quic_linux_socket_utils_test.cc
    • net/third_party/quic/platform/impl/quic_socket_utils.cc
    • net/third_party/quic/platform/impl/quic_socket_utils.h
  12. Fix SkiaRenderer WebGL content not show problem

    Changed by penghuangohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:47:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f2fef5671fb6850a4cdc203534f90483c35e2564

    Comments

    Fix SkiaRenderer WebGL content not show problem
    
    The WebGL content is a flipped TextureQuad. SkiaRenderer only flips the
    Y coordinate for drawImageRect(with canvas->scale(1, -1)). It will draw
    the image outside of the Window (y < 0). To fix this problem, we use
    canvas->translate(0, quad_rect.bottom()) to move it back into the
    window.
    
    Bug: 901822
    Change-Id: I6b98f82fba896021e1c2878632b26a3bd8029845
    Reviewed-on: https://chromium-review.googlesource.com/c/1324137
    Commit-Queue: Peng Huang <penghuang@chromium.org>
    Reviewed-by: danakj <danakj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606892}

    Changed files

    • components/viz/service/display/gl_renderer.cc
    • components/viz/service/display/renderer_pixeltest.cc
    • components/viz/service/display/skia_renderer.cc
    • components/viz/test/data/intersecting_flipped_blue_green_half_size_rectangles.png
    • components/viz/test/data/intersecting_non_flipped_blue_green_half_size_rectangles.png