Home | Search
Login

Builder Google Chrome Mac Build #38642 Apple OSX

Results:

build successful

Trigger Info:

Got Revision162f0b1678e9c6b559ee7931f910cff372d9e5e2

Execution:

Steps and Logfiles:

Show:
  1. ( 46 mins 11 secs ) steps
    running steps via annotated script
  2. ( 5 secs ) update_scripts
    update_scripts
  3. ( 4 ms ) LUCI Migration
    LUCI Migration
  4. ( 3 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 5 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 3 ms ) report builders
    report builders
     
    running builder/tester 'Google Chrome Mac' on master 'chromium.chrome'
  7. ( 3 ms ) makedirs checkout path
    makedirs checkout path
  8. ( 1 mins 54 secs ) bot_update
    bot_update
    [112GB/199GB used (56%)]
  9. ( 3 ms ) ensure_goma
    ensure_goma
  10. ( 4 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  11. ( 3 ms ) swarming.py --version
    swarming.py --version
    0.13
  12. ( 9 secs ) clobber
    clobber
  13. ( 5 ms ) ensure_installed
    ensure_installed
  14. ( 14 secs ) gclient runhooks
    gclient runhooks
  15. ( 4 ms ) get compile targets for scripts
    get compile targets for scripts
  16. ( 4 ms ) read test spec (chromium.chrome.json)
    read test spec (chromium.chrome.json)
    path: /b/c/b/Google_Chrome_Mac/src/testing/buildbot/chromium.chrome.json
  17. ( 3 ms ) lookup GN args
    lookup GN args
     
    is_chrome_branded = true
    is_debug = false
    is_official_build = true
    strip_absolute_paths_from_debug_symbols = true
    use_goma = true
    goma_dir = "/b/c/goma_cache/client"
  18. ( 17 secs ) generate_build_files
    generate_build_files
  19. ( 4 ms ) clang_revision
    clang_revision
  20. ( 3 ms ) preprocess_for_goma
    preprocess_for_goma
  21. ( 3 ms ) preprocess_for_goma.goma cache directory
    preprocess_for_goma.goma cache directory
  22. ( 10 secs ) preprocess_for_goma.start_goma
    preprocess_for_goma.start_goma
  23. ( 3 ms ) preprocess_for_goma.start cloudtail
    preprocess_for_goma.start cloudtail
  24. ( 42 mins 18 secs ) compile
    compile
  25. ( 11 secs ) compile confirm no-op
    compile confirm no-op
  26. ( 3 ms ) postprocess_for_goma
    postprocess_for_goma
  27. ( 4 ms ) postprocess_for_goma.goma_jsonstatus
    postprocess_for_goma.goma_jsonstatus
  28. ( 3 ms ) postprocess_for_goma.goma_stat
    postprocess_for_goma.goma_stat
  29. ( 3 ms ) postprocess_for_goma.stop_goma
    postprocess_for_goma.stop_goma
  30. ( 9 secs ) postprocess_for_goma.upload_log
    postprocess_for_goma.upload_log
  31. ( 3 ms ) postprocess_for_goma.stop cloudtail
    postprocess_for_goma.stop cloudtail
  32. ( 3 ms ) test_pre_run
    test_pre_run
  33. ( 6 ms ) sizes
    sizes
    sizes
    <div class="BuildResultInfo">
    </div>
  34. ( 4 ms ) recipe result
    recipe result

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromium/bb/chromium.chrome/Google_Chrome_Mac/38642/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.chrome/Google_Chrome_Mac/38642" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" Annotation(bot_update)
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" Annotation(bot_update)
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" Annotation(bot_update)
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" Annotation(bot_update)
got_revision "162f0b1678e9c6b559ee7931f910cff372d9e5e2" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#606877}" Annotation(bot_update)
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" Annotation(bot_update)
got_v8_revision "31b2546b348e864539ade15897eac971b3c0e402" Annotation(bot_update)
got_v8_revision_cp "refs/heads/7.2.286@{#1}" Annotation(bot_update)
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#25544}" Annotation(bot_update)
got_clang_revision "346388-1" Annotation(clang_revision)
build_data_dir "/b/rr/tmpyRPf8f" Annotation(steps)
build_id "buildbot/chromium.chrome/Google Chrome Mac/38642" Annotation(steps)
builder_id "master.chromium.chrome:Google Chrome Mac" Annotation(steps)
blamelist ["buldina@chromium.org","chlily@chromium.org","digit@google.com","djean@google.com","dtapuska@chromium.org","mcarlen@chromium.org","mrsuyi@chromium.org","pdr@chromium.org","scottmg@chromium.org","skobes@chromium.org","skym@google.com","thestig@chromium.org"] Build
branch "master" Build
buildnumber 38642 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1541781216 Build
revision "162f0b1678e9c6b559ee7931f910cff372d9e5e2" Build
slavename "vm669-m1" BuildSlave
buildername "Google Chrome Mac" Builder
git_revision "162f0b1678e9c6b559ee7931f910cff372d9e5e2" Change
scheduler "chromium" Scheduler
buildbotURL "http://build.chromium.org/p/chromium.chrome/" master.cfg
mastername "chromium.chrome" master.cfg
workdir "/b/build/slave/google-chrome-rel-mac" slave

Blamelist:

  1. (digitohnoyoudont@google.com)
  2. (mrsuyiohnoyoudont@chromium.org)
  3. (thestigohnoyoudont@chromium.org)
  4. (djeanohnoyoudont@google.com)
  5. (mcarlenohnoyoudont@chromium.org)
  6. (dtapuskaohnoyoudont@chromium.org)
  7. (scottmgohnoyoudont@chromium.org)
  8. (skymohnoyoudont@google.com)
  9. (pdrohnoyoudont@chromium.org)
  10. (buldinaohnoyoudont@chromium.org)
  11. (chlilyohnoyoudont@chromium.org)
  12. (skobesohnoyoudont@chromium.org)

Timing:

Create N/A
Start Friday, 09-Nov-18 17:20:27 UTC
End Friday, 09-Nov-18 18:06:39 UTC
Pending N/A
Execution 46 mins 11 secs

All Changes:

  1. Android: Fix resource extraction from splits for Hebrew and others.

    Changed by digitohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 16:32:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 77b7b35987d9420138ebc3fcb7d24d786bf5549c

    Comments

    Android: Fix resource extraction from splits for Hebrew and others.
    
    This CL fixes a bug in the logic used to locate locale .pak files
    inside bundle splits. The reason for the bug is that bundletool
    wants to use deprecated language names (i.e. 'iw' instead of 'he')
    to store asset files.
    
    As an example, for Hebrew, Chrome was looking at:
    
      assets/locales#lang_he/he.pak
    
    While the file was really stored under:
    
      assets/locales#lang_iw/he.pak
    
    The CL fixes the issue for Hebrew, Yiddish and Indonesian and
    Filipino.
    
    BUG=902915
    R=benmason@chromium.org, tiborg@chromium.org, yfriedman@chromium.org, twellington@chromium.org
    
    Change-Id: I420158c30ba33c6203495af9453877722271e104
    Reviewed-on: https://chromium-review.googlesource.com/c/1327203
    Commit-Queue: David Turner <digit@chromium.org>
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606866}

    Changed files

    • ui/android/java/src/org/chromium/ui/base/LocalizationUtils.java
    • ui/android/java/src/org/chromium/ui/resources/ResourceExtractor.java
    • ui/android/junit/src/org/chromium/ui/base/LocalizationUtilsTest.java
  2. Remove JavaScript const/let/lambda presubmit check for iOS9.

    Changed by mrsuyiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:44:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a81bed5026f4a47ed9a0b690b0a950260f6e3e06

    Comments

    Remove JavaScript const/let/lambda presubmit check for iOS9.
    
    iOS9 is not supported by Chrome iOS and iGSA anymore, the presubmit check
    for risky ES6 grammar(const/let/lambda) can be removed now.
    
    Change-Id: I5a35d54097dbd215393aaba78868107befdc93b6
    Reviewed-on: https://chromium-review.googlesource.com/c/1329249
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Yi Su <mrsuyi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606867}

    Changed files

    • PRESUBMIT.py
    • PRESUBMIT_test.py
  3. Fix a typo in bisect-builds.py.

    Changed by thestigohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:46:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1c8c6f7ecd6a1927225c2257544c6d370441854f

    Comments

    Fix a typo in bisect-builds.py.
    
    Windows archives extract out into a directory called chrome-win. There
    is no chrome-winp directory.
    
    TBR=robertocn@chromium.org
    
    Change-Id: Ia5ee2725e107f32c44105ca396e28a4c0a06844c
    Reviewed-on: https://chromium-review.googlesource.com/c/1313731
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Ben Pastene <bpastene@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606868}

    Changed files

    • tools/bisect-builds.py
  4. [ios] plug in manual fallback for credit card and address

    Changed by djeanohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 16:50:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ec464d0a7b2ab771c1c7642a3568de17f4904b29

    Comments

    [ios] plug in manual fallback for credit card and address
    
    Bug: 845472
    Change-Id: Ie26e9022b60612b5ef90c7e9b2bde4202e6e745c
    Reviewed-on: https://chromium-review.googlesource.com/c/1319594
    Commit-Queue: David Jean <djean@chromium.org>
    Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606869}

    Changed files

    • ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/fallback_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.h
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm
  5. [Autofill Assistant] Integrate Payment Request.

    Changed by mcarlenohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:54:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 56a06fd5e79c627d247ce9976c217ea14a17c9c5

    Comments

    [Autofill Assistant] Integrate Payment Request.
    
    This patch is the first step to integrate the payment request UI into
    the autofill assistant sheet.
    
    The patch has and leaves a few rough edges but we'll deal with that
    piece by piece. In particular, the dismiss logic needs to be handled
    differently, so does the error view logic.
    
    Note: The DimmingDialog is reverted to package default visibility since
    the dependency from autofill assistant is removed here.
    
    Bug: 806868
    Change-Id: I25b83b804e13bbdec5d2a1688dd01cd085615b38
    Reviewed-on: https://chromium-review.googlesource.com/c/1324451
    Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
    Reviewed-by: Ganggui Tang <gogerald@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606870}

    Changed files

    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_payment_request.xml
    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_payment_request_bottom_bar.xml
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantPaymentRequest.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/BottomBarAnimations.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/PaymentRequestUI.java
    • chrome/android/java/src/org/chromium/chrome/browser/payments/ui/DimmingDialog.java
  6. Retire PerformanceNavigationTiming2 runtime enabled flag.

    Changed by dtapuskaohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:56:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 48519d5c39fc3533942f8107cce3df766e1d45b2

    Comments

    Retire PerformanceNavigationTiming2 runtime enabled flag.
    
    Feature first shipped in M57.
    
    BUG=611276
    
    Change-Id: Ib4b514df4f72b29333b534e6978ea8fa3dea5128
    Reviewed-on: https://chromium-review.googlesource.com/c/1323628
    Reviewed-by: David Bokan <bokan@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606871}

    Changed files

    • third_party/blink/renderer/core/timing/performance_navigation_timing.idl
    • third_party/blink/renderer/core/timing/window_performance.cc
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  7. fuchsia: Update sdk build job link in docs

    Changed by scottmgohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:02:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4e05b6f1c53bf3cfa376b672b70ed83643274b56

    Comments

    fuchsia: Update sdk build job link in docs
    
    Change-Id: I203f142ee84ecefeb36adaf9da175404f75194eb
    Reviewed-on: https://chromium-review.googlesource.com/c/1329506
    Commit-Queue: Scott Graham <scottmg@chromium.org>
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606872}

    Changed files

    • docs/fuchsia_sdk_updates.md
  8. [Feed] When rescheduling, just set period to 1 day instead of going to

    Changed by skymohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 17:02:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1dc99fe0bd2792457e4cc526e945df228ec47234

    Comments

    [Feed] When rescheduling, just set period to 1 day instead of going to
    native.
    
    Bug: 901331
    Change-Id: I65b3d748cb96669fa78a712552f82a44873debf3
    Reviewed-on: https://chromium-review.googlesource.com/c/1315929
    Commit-Queue: Sky Malice <skym@chromium.org>
    Reviewed-by: Filip Gorski <fgorski@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606873}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedRefreshTask.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedScheduler.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedSchedulerBridge.java
  9. [BlinkGenPropertyTrees] Stop incorrect clearing of property tree changed

    Changed by pdrohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:08:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6f5a1bd0249536b05ba2d3b45f175e742d1a6a47

    Comments

    [BlinkGenPropertyTrees] Stop incorrect clearing of property tree changed
    
    PaintPropertyTreeNode::Changed is used for in-layer raster invalidation,
    and cc damage for both SPV2 and BGPT. https://crrev.com/606472 failed
    to account for the case when non-transient paint controllers in
    GraphicsLayers would clear property tree changed values before the
    values could be used for damage.
    
    As a reminder, with BlinkGenPropertyTrees, each GraphicsLayer keeps a
    non-transient paint controller, and at the end of pain
    ...skip...
    nto the transient paint controller.
    
    This patch changes BGPT to clear all property tree changed bits after
    damage has been calculated in PaintArtifactCompositor. It is implemented
    with a recursive walk of the GraphicsLayer tree.
    
    Bug: 899628
    Change-Id: Ibc7d65d6ab8875508b9c3dd18ab6db1230bf1308
    Reviewed-on: https://chromium-review.googlesource.com/c/1327804
    Commit-Queue: Philip Rogers <pdr@chromium.org>
    Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606874}

    Changed files

    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/paint/invalidation/clip/clip-path-constant-repaint-expected.txt
    • third_party/blink/renderer/core/exported/web_layer_test.cc
    • third_party/blink/renderer/core/frame/local_frame_view.cc
    • third_party/blink/renderer/platform/graphics/graphics_layer_test.cc
    • third_party/blink/renderer/platform/graphics/paint/paint_artifact.cc
    • third_party/blink/renderer/platform/graphics/paint/paint_controller.cc
    • third_party/blink/renderer/platform/graphics/paint/paint_controller.h
    • third_party/blink/renderer/platform/graphics/paint/paint_property_node.h
  10. [ChromeDriver] Add tests names where Chrome retried to start to logs

    Changed by buldinaohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:10:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e02c93aa236dd55c50eafd019f865e192192ac34

    Comments

    [ChromeDriver] Add tests names where Chrome retried to start to logs
    
    Change-Id: I6d2cf48b16562f60e35b2d499bfbbe25c12533c1
    Reviewed-on: https://chromium-review.googlesource.com/c/1327168
    Reviewed-by: John Chen <johnchen@chromium.org>
    Commit-Queue: Tatiana Buldina <buldina@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606875}

    Changed files

    • chrome/test/chromedriver/client/chromedriver.py
    • chrome/test/chromedriver/test/run_py_tests.py
  11. Add reprioritization to SSLConnectJobs

    Changed by chlilyohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:13:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8a9302e29c7625fd7cdc65f374fc7f00550c21aa

    Comments

    Add reprioritization to SSLConnectJobs
    
    This change allows the priority of an SSLConnectJob to be changed. If
    the reprioritization occurs while the job is establishing its underlying
    connection, the priority change is also passed down to the lower-level
    socket pool.
    
    Bug: 166689
    Change-Id: I87d1e536846443901cc628423f4615c3ffa7542a
    Reviewed-on: https://chromium-review.googlesource.com/c/1327423
    Commit-Queue: Lily Chen <chlily@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606876}

    Changed files

    • net/socket/socket_test_util.cc
    • net/socket/socket_test_util.h
    • net/socket/ssl_client_socket_pool.cc
    • net/socket/ssl_client_socket_pool.h
    • net/socket/ssl_client_socket_pool_unittest.cc
  12. Add and report LayoutStability.JankScore UKM.

    Changed by skobesohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:14:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 162f0b1678e9c6b559ee7931f910cff372d9e5e2

    Comments

    Add and report LayoutStability.JankScore UKM.
    
    We prolong the lifetime of UkmPageLoadMetricsObserver to permit jank
    score reporting at session end for tabs that start or become hidden,
    but avoid extra reporting of other metrics by checking was_hidden_.
    
    The OnFinalLayoutStabilityUpdate hook is removed in favor of passing
    PageRenderData to existing hooks through PageLoadExtraInfo.  This lets
    the observer decide when to report.
    
    UKM collection review doc: go/lsukmrev
    
    Bug: 581518
    Change-Id: I2983dff155872f3080474e09df784d20b3cb08d3
    Reviewed-on: https://chromium-review.googlesource.com/c/1299917
    Commit-Queue: Steve Kobes <skobes@chromium.org>
    Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606877}

    Changed files

    • chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
    • chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
    • chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
    • chrome/browser/page_load_metrics/page_load_metrics_observer.cc
    • chrome/browser/page_load_metrics/page_load_metrics_observer.h
    • chrome/browser/page_load_metrics/page_load_tracker.cc
    • tools/metrics/ukm/ukm.xml