Home | Search
Login

Builder Google Chrome ChromeOS Build #58535 Canonical Ubuntu

Results:

build successful

Trigger Info:

Got Revision60b47f98f87e0f3689826e4342fab09b7a35ed5e

Execution:

Steps and Logfiles:

Show:
  1. ( 36 mins 39 secs ) steps
    running steps via annotated script
  2. ( 5 secs ) update_scripts
    update_scripts
  3. ( 4 ms ) LUCI Migration
    LUCI Migration
  4. ( 4 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 5 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 3 ms ) report builders
    report builders
     
    running builder/tester 'Google Chrome ChromeOS' on master 'chromium.chrome'
  7. ( 3 ms ) makedirs checkout path
    makedirs checkout path
  8. ( 2 mins 48 secs ) bot_update
    bot_update
    [288GB/3281GB used (8%)]
  9. ( 3 ms ) ensure_goma
    ensure_goma
  10. ( 4 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  11. ( 3 ms ) swarming.py --version
    swarming.py --version
    0.13
  12. ( 3 ms ) clobber
    clobber
  13. ( 10 mins 17 secs ) gclient runhooks
    gclient runhooks
  14. ( 4 ms ) get compile targets for scripts
    get compile targets for scripts
  15. ( 4 ms ) read test spec (chromium.chrome.json)
    read test spec (chromium.chrome.json)
    path: /b/c/b/Google_Chrome_ChromeOS/src/testing/buildbot/chromium.chrome.json
  16. ( 3 ms ) lookup GN args
    lookup GN args
     
    is_chrome_branded = true
    is_debug = false
    is_official_build = true
    strip_absolute_paths_from_debug_symbols = true
    target_os = "chromeos"
    use_goma = true
    goma_dir = "/b/c/goma_cache/client"
  17. ( 16 secs ) generate_build_files
    generate_build_files
  18. ( 3 ms ) preprocess_for_goma
    preprocess_for_goma
  19. ( 3 ms ) preprocess_for_goma.goma cache directory
    preprocess_for_goma.goma cache directory
  20. ( 9 secs ) preprocess_for_goma.start_goma
    preprocess_for_goma.start_goma
  21. ( 3 ms ) preprocess_for_goma.start cloudtail
    preprocess_for_goma.start cloudtail
  22. ( 21 mins 41 secs ) compile
    compile
  23. ( 3 ms ) compile confirm no-op
    compile confirm no-op
    This should have been a no-op, but it wasn't.
  24. ( 3 ms ) postprocess_for_goma
    postprocess_for_goma
  25. ( 4 ms ) postprocess_for_goma.goma_jsonstatus
    postprocess_for_goma.goma_jsonstatus
  26. ( 3 ms ) postprocess_for_goma.goma_stat
    postprocess_for_goma.goma_stat
  27. ( 3 ms ) postprocess_for_goma.stop_goma
    postprocess_for_goma.stop_goma
  28. ( 9 secs ) postprocess_for_goma.upload_log
    postprocess_for_goma.upload_log
  29. ( 3 ms ) postprocess_for_goma.stop cloudtail
    postprocess_for_goma.stop cloudtail
  30. ( 4 ms ) recipe result
    recipe result

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromium/bb/chromium.chrome/Google_Chrome_ChromeOS/58535/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.chrome/Google_Chrome_ChromeOS/58535" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" Annotation(bot_update)
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" Annotation(bot_update)
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" Annotation(bot_update)
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" Annotation(bot_update)
got_revision "60b47f98f87e0f3689826e4342fab09b7a35ed5e" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#606886}" Annotation(bot_update)
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" Annotation(bot_update)
got_v8_revision "f6ed3c5d7eb73112326476d681f0f79d40fc1e0e" Annotation(bot_update)
got_v8_revision_cp "refs/heads/7.2.287@{#1}" Annotation(bot_update)
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#25544}" Annotation(bot_update)
build_data_dir "/b/rr/tmpA5kYSH" Annotation(steps)
build_id "buildbot/chromium.chrome/Google Chrome ChromeOS/58535" Annotation(steps)
builder_id "master.chromium.chrome:Google Chrome ChromeOS" Annotation(steps)
blamelist ["buldina@chromium.org","chlily@chromium.org","chromium-autoroll@skia-public.iam.gserviceaccount.com","dbessonov@yandex-team.ru","dtapuska@chromium.org","hayato@chromium.org","hiroh@chromium.org","huayinz@chromium.org","lanwei@chromium.org","mcarlen@chromium.org","pdr@chromium.org","scottmg@chromium.org","skobes@chromium.org","skym@google.com","v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com"] Build
branch "master" Build
buildnumber 58535 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1541782683 Build
revision "60b47f98f87e0f3689826e4342fab09b7a35ed5e" Build
slavename "build6-m1" BuildSlave
buildername "Google Chrome ChromeOS" Builder
git_revision "60b47f98f87e0f3689826e4342fab09b7a35ed5e" Change
scheduler "chromium" Scheduler
buildbotURL "http://build.chromium.org/p/chromium.chrome/" master.cfg
mastername "chromium.chrome" master.cfg
workdir "/b/build/slave/google-chrome-rel-chromeos" slave

Blamelist:

  1. (dtapuskaohnoyoudont@chromium.org)
  2. (scottmgohnoyoudont@chromium.org)
  3. (skymohnoyoudont@google.com)
  4. (pdrohnoyoudont@chromium.org)
  5. (buldinaohnoyoudont@chromium.org)
  6. (chlilyohnoyoudont@chromium.org)
  7. (skobesohnoyoudont@chromium.org)
  8. (dbessonovohnoyoudont@yandex-team.ru)
  9. (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  10. (hirohohnoyoudont@chromium.org)
  11. (huayinzohnoyoudont@chromium.org)
  12. (lanweiohnoyoudont@chromium.org)
  13. (mcarlenohnoyoudont@chromium.org)
  14. (hayatoohnoyoudont@chromium.org)
  15. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  16. (skymohnoyoudont@google.com)

Timing:

Create N/A
Start Friday, 09-Nov-18 17:37:04 UTC
End Friday, 09-Nov-18 18:13:44 UTC
Pending N/A
Execution 36 mins 39 secs

All Changes:

  1. Retire PerformanceNavigationTiming2 runtime enabled flag.

    Changed by dtapuskaohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:56:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 48519d5c39fc3533942f8107cce3df766e1d45b2

    Comments

    Retire PerformanceNavigationTiming2 runtime enabled flag.
    
    Feature first shipped in M57.
    
    BUG=611276
    
    Change-Id: Ib4b514df4f72b29333b534e6978ea8fa3dea5128
    Reviewed-on: https://chromium-review.googlesource.com/c/1323628
    Reviewed-by: David Bokan <bokan@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606871}

    Changed files

    • third_party/blink/renderer/core/timing/performance_navigation_timing.idl
    • third_party/blink/renderer/core/timing/window_performance.cc
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  2. fuchsia: Update sdk build job link in docs

    Changed by scottmgohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:02:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4e05b6f1c53bf3cfa376b672b70ed83643274b56

    Comments

    fuchsia: Update sdk build job link in docs
    
    Change-Id: I203f142ee84ecefeb36adaf9da175404f75194eb
    Reviewed-on: https://chromium-review.googlesource.com/c/1329506
    Commit-Queue: Scott Graham <scottmg@chromium.org>
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606872}

    Changed files

    • docs/fuchsia_sdk_updates.md
  3. [Feed] When rescheduling, just set period to 1 day instead of going to

    Changed by skymohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 17:02:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1dc99fe0bd2792457e4cc526e945df228ec47234

    Comments

    [Feed] When rescheduling, just set period to 1 day instead of going to
    native.
    
    Bug: 901331
    Change-Id: I65b3d748cb96669fa78a712552f82a44873debf3
    Reviewed-on: https://chromium-review.googlesource.com/c/1315929
    Commit-Queue: Sky Malice <skym@chromium.org>
    Reviewed-by: Filip Gorski <fgorski@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606873}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedRefreshTask.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedScheduler.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedSchedulerBridge.java
  4. [BlinkGenPropertyTrees] Stop incorrect clearing of property tree changed

    Changed by pdrohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:08:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6f5a1bd0249536b05ba2d3b45f175e742d1a6a47

    Comments

    [BlinkGenPropertyTrees] Stop incorrect clearing of property tree changed
    
    PaintPropertyTreeNode::Changed is used for in-layer raster invalidation,
    and cc damage for both SPV2 and BGPT. https://crrev.com/606472 failed
    to account for the case when non-transient paint controllers in
    GraphicsLayers would clear property tree changed values before the
    values could be used for damage.
    
    As a reminder, with BlinkGenPropertyTrees, each GraphicsLayer keeps a
    non-transient paint controller, and at the end of pain
    ...skip...
    nto the transient paint controller.
    
    This patch changes BGPT to clear all property tree changed bits after
    damage has been calculated in PaintArtifactCompositor. It is implemented
    with a recursive walk of the GraphicsLayer tree.
    
    Bug: 899628
    Change-Id: Ibc7d65d6ab8875508b9c3dd18ab6db1230bf1308
    Reviewed-on: https://chromium-review.googlesource.com/c/1327804
    Commit-Queue: Philip Rogers <pdr@chromium.org>
    Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606874}

    Changed files

    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/paint/invalidation/clip/clip-path-constant-repaint-expected.txt
    • third_party/blink/renderer/core/exported/web_layer_test.cc
    • third_party/blink/renderer/core/frame/local_frame_view.cc
    • third_party/blink/renderer/platform/graphics/graphics_layer_test.cc
    • third_party/blink/renderer/platform/graphics/paint/paint_artifact.cc
    • third_party/blink/renderer/platform/graphics/paint/paint_controller.cc
    • third_party/blink/renderer/platform/graphics/paint/paint_controller.h
    • third_party/blink/renderer/platform/graphics/paint/paint_property_node.h
  5. [ChromeDriver] Add tests names where Chrome retried to start to logs

    Changed by buldinaohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:10:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e02c93aa236dd55c50eafd019f865e192192ac34

    Comments

    [ChromeDriver] Add tests names where Chrome retried to start to logs
    
    Change-Id: I6d2cf48b16562f60e35b2d499bfbbe25c12533c1
    Reviewed-on: https://chromium-review.googlesource.com/c/1327168
    Reviewed-by: John Chen <johnchen@chromium.org>
    Commit-Queue: Tatiana Buldina <buldina@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606875}

    Changed files

    • chrome/test/chromedriver/client/chromedriver.py
    • chrome/test/chromedriver/test/run_py_tests.py
  6. Add reprioritization to SSLConnectJobs

    Changed by chlilyohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:13:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8a9302e29c7625fd7cdc65f374fc7f00550c21aa

    Comments

    Add reprioritization to SSLConnectJobs
    
    This change allows the priority of an SSLConnectJob to be changed. If
    the reprioritization occurs while the job is establishing its underlying
    connection, the priority change is also passed down to the lower-level
    socket pool.
    
    Bug: 166689
    Change-Id: I87d1e536846443901cc628423f4615c3ffa7542a
    Reviewed-on: https://chromium-review.googlesource.com/c/1327423
    Commit-Queue: Lily Chen <chlily@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606876}

    Changed files

    • net/socket/socket_test_util.cc
    • net/socket/socket_test_util.h
    • net/socket/ssl_client_socket_pool.cc
    • net/socket/ssl_client_socket_pool.h
    • net/socket/ssl_client_socket_pool_unittest.cc
  7. Add and report LayoutStability.JankScore UKM.

    Changed by skobesohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:14:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 162f0b1678e9c6b559ee7931f910cff372d9e5e2

    Comments

    Add and report LayoutStability.JankScore UKM.
    
    We prolong the lifetime of UkmPageLoadMetricsObserver to permit jank
    score reporting at session end for tabs that start or become hidden,
    but avoid extra reporting of other metrics by checking was_hidden_.
    
    The OnFinalLayoutStabilityUpdate hook is removed in favor of passing
    PageRenderData to existing hooks through PageLoadExtraInfo.  This lets
    the observer decide when to report.
    
    UKM collection review doc: go/lsukmrev
    
    Bug: 581518
    Change-Id: I2983dff155872f3080474e09df784d20b3cb08d3
    Reviewed-on: https://chromium-review.googlesource.com/c/1299917
    Commit-Queue: Steve Kobes <skobes@chromium.org>
    Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606877}

    Changed files

    • chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
    • chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
    • chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
    • chrome/browser/page_load_metrics/page_load_metrics_observer.cc
    • chrome/browser/page_load_metrics/page_load_metrics_observer.h
    • chrome/browser/page_load_metrics/page_load_tracker.cc
    • tools/metrics/ukm/ukm.xml
  8. Out-of-line default constructor of WebRange.

    Changed by dbessonovohnoyoudont@yandex-team.ru
    Changed at Friday, 09-Nov-18 17:19:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 92aa96594173109bc330bb2eab84d8e61bd7ee5e

    Comments

    Out-of-line default constructor of WebRange.
    
    WebRange default constructor is both inline and BLINK_EXPORT.
    Using WebRange() in different blink modules (for example,
    blink_core and blink_controller) results in duplicate symbols
    during linking.
    
    This CL out-of-lines this constructor to ensure that exported
    constructor has only one implementation.
    
    Bug: 903712
    Change-Id: Ifdc947c4d0001a4be7404950a6a1639bc9877372
    Reviewed-on: https://chromium-review.googlesource.com/c/1328964
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Commit-Queue: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606878}

    Changed files

    • third_party/blink/public/web/web_range.h
    • third_party/blink/renderer/core/exported/web_range.cc
  9. Update V8 to version 7.2.287.

    Changed by v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 17:21:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d7625aefbe45933a2dc896bd154fbfe3663b3480

    Comments

    Update V8 to version 7.2.287.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/31b2546b..f6ed3c5d
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tes
    ...skip...
    ;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: Ida402fad2dfa8556ea7ae1c22d42058bfb90fa6f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329301
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606879}

    Changed files

    • DEPS
  10. Reland "media/gpu/VEA unittest: Test DMABuf-backed input buffers"

    Changed by hirohohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:21:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 341861b66e4ad99689c9842cdb723cf7429d3157

    Comments

    Reland "media/gpu/VEA unittest: Test DMABuf-backed input buffers"
    
    This adds the command line option, --natvie_input, that VEA unittest passes
    DMABuf-backed video frame to VEA.
    DMABufs are obtained by gbm though NativePixmap. To create NativePixmap on
    Chrome OS, it needs to set up Ozone environment properly. Therefore, this change
    also makes VEA unittest dependent on Ozone.
    
    BUG=chromium:895230
    TEST=VEA unittest on eve w/wo --native_input
    TBR=posciak@chromium.org
    
    Change-Id: I2998f0695813e5e1b77ae2136140eebc385636bf
    Reviewed-on: https://chromium-review.googlesource.com/c/1329121
    Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
    Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606880}

    Changed files

    • media/gpu/BUILD.gn
    • media/gpu/test/generic_dmabuf_video_frame_mapper.cc
    • media/gpu/test/rendering_helper.cc
    • media/gpu/test/texture_ref.cc
    • media/gpu/test/texture_ref.h
    • media/gpu/test/video_encode_accelerator_unittest_helpers.cc
    • media/gpu/test/video_encode_accelerator_unittest_helpers.h
    • media/gpu/test/video_frame_mapper_factory.cc
    • media/gpu/test/video_frame_mapper_factory.h
    • media/gpu/test/video_frame_validator.cc
    • media/gpu/test/video_frame_validator.h
    • media/gpu/video_decode_accelerator_unittest.cc
    • media/gpu/video_encode_accelerator_unittest.cc
  11. [Feed] Fix Feed NTP not clickable when hardware keyboard is connected

    Changed by huayinzohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:25:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision acb2df40a36d52ef4649dc82d779b8b024112358

    Comments

    [Feed] Fix Feed NTP not clickable when hardware keyboard is connected
    
    Bug: 891877
    Change-Id: I8c0cae6ad80f290580975983cb2d2f4f6286509b
    Reviewed-on: https://chromium-review.googlesource.com/c/1325082
    Commit-Queue: Becky Zhou <huayinz@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606881}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java
  12. Add action_sequence in testdriver

    Changed by lanweiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:28:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 687313c56366619151285b4d87847b61e6547cbc

    Comments

    Add action_sequence in testdriver
    
    After we expose test_driver.Actions API to web users, we add their
    implementation in our testdriver file, and fix the wpt tests of
    Actions API.
    
    Bug: 893480
    Change-Id: Ib02c0223208eeb2cc30c2ca35b98d5fc938baa2c
    Reviewed-on: https://chromium-review.googlesource.com/c/1289119
    Commit-Queue: Lan Wei <lanwei@chromium.org>
    Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606882}

    Changed files

    • content/common/input/actions_parser.cc
    • content/common/input/actions_parser.h
    • content/common/input/actions_parser_unittest.cc
    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/elementPosition.html
    • third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/eventOrder.html
    • third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_pointermove.html
    • third_party/WebKit/LayoutTests/external/wpt/resources/testdriver-actions.js
    • third_party/WebKit/LayoutTests/external/wpt/resources/testdriver.js
    • third_party/WebKit/LayoutTests/external/wpt_automation/pointerevents/pointerevent_pointermove-manual-automation.js
    • third_party/WebKit/LayoutTests/resources/testdriver-vendor.js
    • third_party/WebKit/LayoutTests/resources/testdriver.js
  13. [Autofill Assistant] Handle payment request dismiss.

    Changed by mcarlenohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:30:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f3fe32fc147390a01e54fbd7c54e62ca3a3b8ad4

    Comments

    [Autofill Assistant] Handle payment request dismiss.
    
    Before this patch the payment request UI did not properly handle cancel
    and back button.
    
    This patch notifies the Autofill Assistant controller to shut down
    gracefully with a 'give up' message whenever the payment request UI has
    been canceled.
    
    Bug: 806868
    Change-Id: Ie3d83bf48a2004f0a6a72763c4b509b3db023ff9
    Reviewed-on: https://chromium-review.googlesource.com/c/1326499
    Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606883}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantPaymentRequest.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/PaymentRequestUI.java
    • components/autofill_assistant_strings.grdp
  14. Fix a bug in https://crrev.com/c/1272937, where event.target can be still null

    Changed by hayatoohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:31:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2ed9605b4c99774d8865dbd190e13c9fe5c2d03a

    Comments

    Fix a bug in https://crrev.com/c/1272937, where event.target can be still null
    
    Fix a bug in the previous CL, https://crrev.com/c/1272937, where event.target
    can be null when GetElement() returns nullptr.
    
    Bug: 892970, 893449, 902287
    Change-Id: I7a08227d39117c2dc90fe720f0d6ffd62d9b2ea6
    Reviewed-on: https://chromium-review.googlesource.com/c/1322177
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606884}

    Changed files

    • third_party/blink/renderer/modules/accessibility/ax_object.cc
  15. Roll src/third_party/perfetto cf90797ef05a..5fc6c2c52e7b (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 17:32:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0475284ad58e36e9950059000bb7ec3556bb31bb

    Comments

    Roll src/third_party/perfetto cf90797ef05a..5fc6c2c52e7b (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/cf90797ef05a..5fc6c2c52e7b
    
    
    git log cf90797ef05a..5fc6c2c52e7b --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 lalitm@google.com Merge "trace_processor: allow integers to be compared against doubles"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@5fc6c2c52e7b
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromiu
    ...skip...
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: Ifd53d09565e264f09c1deffb23f8adfce3a34958
    Reviewed-on: https://chromium-review.googlesource.com/c/1329505
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606885}

    Changed files

    • DEPS
  16. [Feed] Check loadUrlParams for null, fallback to opening online.

    Changed by skymohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 17:33:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 60b47f98f87e0f3689826e4342fab09b7a35ed5e

    Comments

    [Feed] Check loadUrlParams for null, fallback to opening online.
    
    Bug: 901179
    Change-Id: Ieb3a421a7930ddc0014f7ef57b6a8f6d89dc3615
    Reviewed-on: https://chromium-review.googlesource.com/c/1315358
    Commit-Queue: Sky Malice <skym@chromium.org>
    Reviewed-by: Filip Gorski <fgorski@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606886}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedLoggingBridge.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/action/FeedActionHandler.java
    • chrome/android/junit/src/org/chromium/chrome/browser/feed/action/FeedActionHandlerTest.java
    • chrome/browser/android/feed/feed_logging_bridge.cc
    • chrome/browser/android/feed/feed_logging_bridge.h