Home | Search
Login

Builder Google Chrome ChromeOS Build #53150 Canonical Ubuntu

Results:

build successful

Trigger Info:

Got Revision8f2c3cb6d4923e8d5bc5486d9848fc9520e70a1d

Execution:

Steps and Logfiles:

Show:
  1. ( 17 mins 9 secs ) steps
    running steps via annotated script
  2. ( 53 secs ) update_scripts
    update_scripts
  3. ( 3 ms ) LUCI Migration
    LUCI Migration
  4. ( 3 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 2 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 1 ms ) makedirs checkout path
    makedirs checkout path
  7. ( 1 ms ) makedirs checkout path (2)
    makedirs checkout path (2)
  8. ( 1 ms ) remove .cipd
    remove .cipd
  9. ( 1 mins 29 secs ) bot_update
    bot_update
    [271GB/3281GB used (8%)]
  10. ( 3 ms ) ensure_goma
    ensure_goma
  11. ( 4 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  12. ( 3 ms ) swarming.py --version
    swarming.py --version
    0.13
  13. ( 8 secs ) clobber
    clobber
  14. ( 12 secs ) gclient runhooks
    gclient runhooks
  15. ( 3 ms ) get compile targets for scripts
    get compile targets for scripts
  16. ( 1 ms ) read test spec (chromium.chrome.json)
    read test spec (chromium.chrome.json)
    path: /b/c/b/Google_Chrome_ChromeOS/src/testing/buildbot/chromium.chrome.json
  17. ( 18 secs ) generate_build_files
    generate_build_files
  18. ( 3 ms ) preprocess_for_goma
    preprocess_for_goma
  19. ( 3 ms ) preprocess_for_goma.goma cache directory
    preprocess_for_goma.goma cache directory
  20. ( 7 secs ) preprocess_for_goma.start_goma
    preprocess_for_goma.start_goma
  21. ( 3 ms ) preprocess_for_goma.start cloudtail
    preprocess_for_goma.start cloudtail
  22. ( 10 mins 23 secs ) compile
    compile
  23. ( 3 ms ) compile confirm no-op
    compile confirm no-op
  24. ( 3 ms ) postprocess_for_goma
    postprocess_for_goma
  25. ( 4 ms ) postprocess_for_goma.goma_jsonstatus
    postprocess_for_goma.goma_jsonstatus
  26. ( 3 ms ) postprocess_for_goma.goma_stat
    postprocess_for_goma.goma_stat
  27. ( 3 ms ) postprocess_for_goma.stop_goma
    postprocess_for_goma.stop_goma
  28. ( 7 secs ) postprocess_for_goma.upload_log
    postprocess_for_goma.upload_log
  29. ( 3 ms ) postprocess_for_goma.stop cloudtail
    postprocess_for_goma.stop cloudtail
  30. ( 4 ms ) recipe result
    recipe result

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromium/bb/chromium.chrome/Google_Chrome_ChromeOS/53150/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.chrome/Google_Chrome_ChromeOS/53150" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" Annotation(bot_update)
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" Annotation(bot_update)
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" Annotation(bot_update)
got_revision "8f2c3cb6d4923e8d5bc5486d9848fc9520e70a1d" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#574718}" Annotation(bot_update)
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" Annotation(bot_update)
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" Annotation(bot_update)
got_v8_revision_cp "refs/heads/6.9.352@{#1}" Annotation(bot_update)
got_webrtc_revision "895617fa9bc36c240b37d47402cdb341ecadf994" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#23955}" Annotation(bot_update)
build_data_dir "/b/rr/tmpWGNrIO" Annotation(steps)
build_id "buildbot/chromium.chrome/Google Chrome ChromeOS/53150" Annotation(steps)
builder_id "master.chromium.chrome:Google Chrome ChromeOS" Annotation(steps)
blamelist ["fdoray@chromium.org","hcarmona@chromium.org","hgrandinetti@chromium.org","iclelland@chromium.org","japhet@chromium.org","jsaul@google.com","karandeepb@chromium.org","kmackay@chromium.org","kvitekp@chromium.org","liberato@chromium.org","npm@chromium.org"] Build
branch "master" Build
buildnumber 53150 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1531427914 Build
revision "8f2c3cb6d4923e8d5bc5486d9848fc9520e70a1d" Build
slavename "build6-m1" BuildSlave
buildername "Google Chrome ChromeOS" Builder
git_revision "8f2c3cb6d4923e8d5bc5486d9848fc9520e70a1d" Change
scheduler "chromium" Scheduler
buildbotURL "http://build.chromium.org/p/chromium.chrome/" master.cfg
mastername "chromium.chrome" master.cfg
workdir "/b/build/slave/google-chrome-rel-chromeos" slave

Blamelist:

  1. (japhetohnoyoudont@chromium.org)
  2. (kvitekpohnoyoudont@chromium.org)
  3. (jsaulohnoyoudont@google.com)
  4. (karandeepbohnoyoudont@chromium.org)
  5. (npmohnoyoudont@chromium.org)
  6. (fdorayohnoyoudont@chromium.org)
  7. (hgrandinettiohnoyoudont@chromium.org)
  8. (kmackayohnoyoudont@chromium.org)
  9. (iclellandohnoyoudont@chromium.org)
  10. (hgrandinettiohnoyoudont@chromium.org)
  11. (liberatoohnoyoudont@chromium.org)
  12. (hcarmonaohnoyoudont@chromium.org)

Timing:

Create N/A
Start Thursday, 12-Jul-18 21:10:51 UTC
End Thursday, 12-Jul-18 21:28:00 UTC
Pending N/A
Execution 17 mins 9 secs

All Changes:

  1. Clone service worker objects to nested workers

    Changed by japhetohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:36:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 62cb57146b83dcd0b2b2add48c4cfe02b3d770b9

    Comments

    Clone service worker objects to nested workers
    
    Bug: 31666
    Change-Id: I8db30dee7c6b72430eb4083536fca73606de76e8
    Reviewed-on: https://chromium-review.googlesource.com/1130101
    Commit-Queue: Nate Chapin <japhet@chromium.org>
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574707}

    Changed files

    • content/renderer/loader/web_worker_fetch_context_impl.cc
    • content/renderer/loader/web_worker_fetch_context_impl.h
    • content/renderer/render_frame_impl.cc
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/claim-worker-fetch.https-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/claim-worker-fetch.https.html
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/claim-nested-worker-fetch-iframe.html
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/claim-nested-worker-fetch-parent-worker.js
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/nested_load_worker.js
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/worker-interception-iframe.https.html
  2. Implemented headless compositor protocol tests for basic rAF, GIF and CSS animations. (III)

    Changed by kvitekpohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:37:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dcd804265b610b002db7023e6c180bd12e1e29bb

    Comments

    Implemented headless compositor protocol tests for basic rAF, GIF and CSS animations. (III)
    
    Browser flags that are required for BeginFrameControl are now set only
    for compositor specific tests thus preventing virtual time flakyness.
    
    Reinstate VirtualTimeErrorLoop test since this change fixes its
    flakiness.
    
    Change-Id: I0b01a81df1b8be63da316b27f7404f929f1e0fd1
    Reviewed-on: https://chromium-review.googlesource.com/1133711
    Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
    Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574708}

    Changed files

    • headless/test/DEPS
    • headless/test/data/protocol/emulation/compositor-basic-raf-expected.txt
    • headless/test/data/protocol/emulation/compositor-basic-raf.js
    • headless/test/data/protocol/emulation/compositor-css-animation-test-expected.txt
    • headless/test/data/protocol/emulation/compositor-css-animation-test.js
    • headless/test/data/protocol/emulation/compositor-image-animation-test-expected.txt
    • headless/test/data/protocol/emulation/compositor-image-animation-test.js
    • headless/test/data/protocol/emulation/resources/animated_square.gif
    • headless/test/data/protocol/emulation/resources/compositor-basic-raf.html
    • headless/test/data/protocol/emulation/resources/compositor-css-animation.html
    • headless/test/data/protocol/emulation/resources/compositor-image-animation.html
    • headless/test/headless_protocol_browsertest.cc
  3. [Autofill] Log metric for whether card upload cardholder name was edited

    Changed by jsaulohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 20:40:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1447fae2e377e748f4ddb532a99f6c5ba7319c98

    Comments

    [Autofill] Log metric for whether card upload cardholder name was edited
    
    Bug: 848955
    Change-Id: I8febd9c3471b58b962d3706eede4be506b092044
    Reviewed-on: https://chromium-review.googlesource.com/1134089
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Commit-Queue: Jared Saul <jsaul@google.com>
    Cr-Commit-Position: refs/heads/master@{#574709}

    Changed files

    • chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
    • chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
    • components/autofill/core/browser/autofill_metrics.cc
    • components/autofill/core/browser/autofill_metrics.h
    • tools/metrics/histograms/histograms.xml
  4. Change RulesMonitorService::HasRegisteredRuleset to take an extension_id.

    Changed by karandeepbohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:47:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b96ae12ef5fa70c2389e5b23da5a924eb4dff359

    Comments

    Change RulesMonitorService::HasRegisteredRuleset to take an extension_id.
    
    This CL changes RulesMonitorService::HasRegisteredRuleset to take an
    extension_id instead of an extension pointer.
    
    BUG=None
    
    Change-Id: If6d220b7bcaf9be473ff819961f5ed9fe67f681f
    Reviewed-on: https://chromium-review.googlesource.com/1134519
    Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
    Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574710}

    Changed files

    • extensions/browser/api/declarative_net_request/declarative_net_request_api.cc
    • extensions/browser/api/declarative_net_request/rules_monitor_service.cc
    • extensions/browser/api/declarative_net_request/rules_monitor_service.h
  5. Use UMA_HISTOGRAM_TIMES or saturated_cast to report milliseconds

    Changed by npmohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:49:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3e44f3be427bb7222e8e20640e261d620478e8bc

    Comments

    Use UMA_HISTOGRAM_TIMES or saturated_cast to report milliseconds
    
    This CL changes Blink code from using Count(delta.InMilliseconds()) to:
    * UMA_HISTOGRAM_TIMES where possible.
    * Otherwise, UMA_HISTOGRAM_CUSTOM_COUNTS if possible.
    * Otherwise, saturated_cast.
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I4f6e2ae0fb318b906ec75c546bea519cd130b09e
    Reviewed-on: https://chromium-review.googlesource.com/1134083
    Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
    Reviewed-by: Jeremy Roman <jbroman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574711}

    Changed files

    • third_party/blink/renderer/core/editing/spellcheck/spell_check_requester.cc
    • third_party/blink/renderer/core/html/media/autoplay_uma_helper.cc
    • third_party/blink/renderer/core/html/parser/css_preload_scanner.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_timeline_metrics.cc
    • third_party/blink/renderer/modules/notifications/notification_image_loader.cc
    • third_party/blink/renderer/platform/heap/heap_stats_collector.cc
    • third_party/blink/renderer/platform/heap/heap_stats_collector.h
    • third_party/blink/renderer/platform/heap/heap_stats_collector_test.cc
    • third_party/blink/renderer/platform/heap/thread_state.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
  6. RC: Record Chrome usage time when a LifecycleUnit is hidden.

    Changed by fdorayohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:54:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 840dc0a7c0eacb82070efe833ef3aacc7b2e89cb

    Comments

    RC: Record Chrome usage time when a LifecycleUnit is hidden.
    
    With this CL, the total Chrome usage time measured by UsageClock is
    recorded in a LifecycleUnit when it is hidden. In an upcoming CL, this
    will be used to discard a LifecycleUnit after a given amount of Chrome
    usage time has elapsed since it was hidden.
    
    We also record the wall time when a LifecycleUnit is hidden, because
    freezing occurs when a LifeycleUnit has been hidden for a given amount
    of wall clock time, not Chrome usage time.
    
    Bug: 775644
    Change-Id: I76d504e9bbf3eb86ded1203e4e117086faf93277
    Reviewed-on: https://chromium-review.googlesource.com/1133593
    Commit-Queue: François Doray <fdoray@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574712}

    Changed files

    • chrome/browser/browser_process_impl.cc
    • chrome/browser/browser_process_impl.h
    • chrome/browser/resource_coordinator/lifecycle_unit.h
    • chrome/browser/resource_coordinator/lifecycle_unit_base.cc
    • chrome/browser/resource_coordinator/lifecycle_unit_base.h
    • chrome/browser/resource_coordinator/lifecycle_unit_base_unittest.cc
    • chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
    • chrome/browser/resource_coordinator/tab_lifecycle_unit.h
    • chrome/browser/resource_coordinator/tab_lifecycle_unit_source.cc
    • chrome/browser/resource_coordinator/tab_lifecycle_unit_source.h
    • chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc
    • chrome/browser/resource_coordinator/tab_manager.cc
    • chrome/browser/resource_coordinator/tab_manager.h
    • chrome/browser/resource_coordinator/tab_manager_stats_collector.cc
    • chrome/browser/resource_coordinator/test_lifecycle_unit.cc
    • chrome/browser/resource_coordinator/test_lifecycle_unit.h
    • chrome/test/base/testing_browser_process.cc
    • chrome/test/base/testing_browser_process.h
  7. Reset screen time when policy is set.

    Changed by hgrandinettiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:58:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 181e63453a3893703a891f072853e33be656a7bf

    Comments

    Reset screen time when policy is set.
    
    The used time should be reset once the time usage limit is set.
    
    Bug: 860676
    Change-Id: I1d9650d298041caf0b6c2f7321f8263727924b60
    Reviewed-on: https://chromium-review.googlesource.com/1134058
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com>
    Cr-Commit-Position: refs/heads/master@{#574713}

    Changed files

    • chrome/browser/chromeos/child_accounts/screen_time_controller.cc
  8. [Chromecast] Implement audio output redirection

    Changed by kmackayohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 21:01:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3ff1556fabbdc61aaab8ee42eee5ae7d0bd0591f

    Comments

    [Chromecast] Implement audio output redirection
    
    Allow matching audio streams to be redirected to a different output.
    
    Bug: b/73284499
    Change-Id: I9eae9d945728e87a6cef299e24632f19860bc8e7
    Reviewed-on: https://chromium-review.googlesource.com/1130998
    Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
    Reviewed-by: Luke Halliwell <halliwell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574714}

    Changed files

    • chromecast/media/cma/backend/BUILD.gn
    • chromecast/media/cma/backend/audio_fader.cc
    • chromecast/media/cma/backend/audio_fader.h
    • chromecast/media/cma/backend/audio_output_redirector.cc
    • chromecast/media/cma/backend/audio_output_redirector.h
    • chromecast/media/cma/backend/filter_group.cc
    • chromecast/media/cma/backend/filter_group_unittest.cc
    • chromecast/media/cma/backend/mixer_input.cc
    • chromecast/media/cma/backend/mixer_input.h
    • chromecast/media/cma/backend/mock_redirected_audio_output.cc
    • chromecast/media/cma/backend/mock_redirected_audio_output.h
    • chromecast/media/cma/backend/stream_mixer.cc
    • chromecast/media/cma/backend/stream_mixer.h
    • chromecast/media/cma/backend/stream_mixer_unittest.cc
    • chromecast/public/cast_media_shlib.h
    • chromecast/public/media/BUILD.gn
    • chromecast/public/media/redirected_audio_output.h
  9. Use standard uppercase names for OT test methods

    Changed by iclellandohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 21:04:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 67f3705fc7dc9cec4a8059936441b436f4a20a39

    Comments

    Use standard uppercase names for OT test methods
    
    This change brings the OriginTrials namespace in line with Blink coding
    standards, and gets the test methods to match the corresponding methods
    in RuntimeEnabledFeatures.
    
    Change-Id: I2b91fbed4b675d55680996b101a110a98047091c
    Reviewed-on: https://chromium-review.googlesource.com/1135442
    Reviewed-by: Jason Chase <chasej@chromium.org>
    Reviewed-by: Jeremy Roman <jbroman@chromium.org>
    Commit-Queue: Ian Clelland <iclelland@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574715}

    Changed files

    • third_party/blink/renderer/bindings/scripts/generate_origin_trial_features.py
    • third_party/blink/renderer/bindings/scripts/v8_utilities.py
    • third_party/blink/renderer/bindings/tests/results/core/origin_trial_features_for_core.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary.cc
    • third_party/blink/renderer/build/scripts/templates/origin_trials.cc.tmpl
    • third_party/blink/renderer/build/scripts/templates/origin_trials.h.tmpl
    • third_party/blink/renderer/build/scripts/templates/web_origin_trials.cc.tmpl
    • third_party/blink/renderer/core/dom/document.cc
    • third_party/blink/renderer/core/dom/events/event_dispatcher.cc
    • third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc
    • third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
    • third_party/blink/renderer/core/loader/document_loader.cc
    • third_party/blink/renderer/core/loader/subresource_integrity_helper.cc
    • third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
    • third_party/blink/renderer/core/testing/origin_trials_test.cc
    • third_party/blink/renderer/core/testing/v8/web_core_test_support.cc
    • third_party/blink/renderer/core/timing/window_performance.cc
    • third_party/blink/renderer/modules/gamepad/navigator_gamepad.cc
    • third_party/blink/renderer/modules/mediastream/media_stream_track.cc
    • third_party/blink/renderer/modules/mediastream/user_media_request.cc
    • third_party/blink/renderer/modules/modules_initializer.cc
    • third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc
    • third_party/blink/renderer/modules/xr/xr_presentation_context.cc
  10. Fix wrong calculation of time on UsageTimeLimitProcessor.

    Changed by hgrandinettiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 21:04:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4e070c6b548e584a4e7934e88bcfb98a045518b1

    Comments

    Fix wrong calculation of time on UsageTimeLimitProcessor.
    
    The function that calculates wheter the time window limit of the current day is
    active, had a wrong logic.
    
    Bug: 860679
    Change-Id: Iafaaa54e36424033adaf384cdbc9c15d7aa2328e
    Reviewed-on: https://chromium-review.googlesource.com/1133459
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com>
    Cr-Commit-Position: refs/heads/master@{#574716}

    Changed files

    • chrome/browser/chromeos/child_accounts/usage_time_limit_processor.cc
    • chrome/browser/chromeos/child_accounts/usage_time_limit_processor_unittest.cc
  11. Handle MCVD cleanup properly if texture has been destroyed.

    Changed by liberatoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 21:05:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dcf09c7b1347f35a690e11fc7f592b678d5532db

    Comments

    Handle MCVD cleanup properly if texture has been destroyed.
    
    If AbstractTexture drops its reference to the underlying texture,
    then that texture might have been freed.  This happens when the
    gl stub is lost.
    
    Previously, MCVD assumed that the CodecImage attached to the texture
    was valid.  However, if the AbstractTexture has dropped its ref
    to the texture, and there are no other refs, then this assumption
    isn't right.
    
    This CL checks if the AbstractTexture still has a TextureBase before
    referencing the
    ...skip...
    ndered
    codec buffer.
    
    Bug: 863012
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: If83a9eb0c27d6eb8e995424bdf71f7f7bc93590d
    Reviewed-on: https://chromium-review.googlesource.com/1135697
    Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
    Commit-Queue: Frank Liberato <liberato@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574717}

    Changed files

    • media/gpu/android/texture_pool.cc
    • media/gpu/android/video_frame_factory_impl.cc
  12. NUX Google Apps - Show page at startup.

    Changed by hcarmonaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 21:07:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8f2c3cb6d4923e8d5bc5486d9848fc9520e70a1d

    Comments

    NUX Google Apps - Show page at startup.
    
    Shows the page on start up if the NuxGoogleApps feature is enabled.
    
    Bug: 832938
    Change-Id: Ibec2d3cb15d8922d4b8d475dca71671a6a02878a
    Reviewed-on: https://chromium-review.googlesource.com/1115475
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Reviewed-by: Tommy Martino <tmartino@chromium.org>
    Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
    Reviewed-by: Lei Zhang <thestig@chromium.org>
    Commit-Queue: Hector Carmona <hcarmona@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574718}

    Changed files

    • BUILD.gn
    • chrome/browser/profiles/profile_manager.cc
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/startup/startup_browser_creator.cc
    • chrome/browser/ui/startup/startup_tab_provider.cc
    • chrome/browser/ui/startup/startup_tab_provider.h
    • chrome/browser/ui/startup/startup_tab_provider_unittest.cc
    • chrome/browser/ui/webui/welcome_ui.cc
    • chrome/browser/ui/webui/welcome_ui.h
    • chrome/common/DEPS
    • chrome/common/pref_names.cc
    • chrome/common/pref_names.h
    • components/nux_google_apps/BUILD.gn
    • components/nux_google_apps/constants.cc
    • components/nux_google_apps/constants.h