Home | Search
Login

Builder Android Cronet Marshmallow 64bit Perf Build #27778 Canonical Ubuntu

Results:

build successful

Trigger Info:

Execution:

Steps and Logfiles:

Show:
  1. ( 22 mins 13 secs ) steps
    running steps via annotated script
  2. ( 11 secs ) update_scripts
    update_scripts
  3. ( 4 ms ) LUCI Migration
    LUCI Migration
  4. ( 4 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 2 ms ) setup_build
    setup_build
    running recipe: "cronet"
  6. ( 1 ms ) cleanup index.lock
    cleanup index.lock
  7. ( 7 mins 53 secs ) bot_update
    bot_update
    [52GB/442GB used (11%)]
  8. ( 5 secs ) clean local files
    clean local files
  9. ( 3 ms ) ensure_goma
    ensure_goma
  10. ( 5 secs ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  11. ( 3 ms ) clobber
    clobber
  12. ( 1 mins 30 secs ) gclient runhooks
    gclient runhooks
  13. ( 5 ms ) lookup GN args
    lookup GN args
     
    Count of GN args (22) exceeds limit (15), presented in logs instead
  14. ( 24 secs ) generate_build_files
    generate_build_files
  15. ( 3 ms ) preprocess_for_goma
    preprocess_for_goma
  16. ( 1 ms ) preprocess_for_goma.goma cache directory
    preprocess_for_goma.goma cache directory
  17. ( 5 secs ) preprocess_for_goma.start_goma
    preprocess_for_goma.start_goma
  18. ( 3 ms ) preprocess_for_goma.start cloudtail
    preprocess_for_goma.start cloudtail
  19. ( 5 mins 51 secs ) compile
    compile
  20. ( 3 ms ) compile confirm no-op
    compile confirm no-op
  21. ( 3 ms ) postprocess_for_goma
    postprocess_for_goma
  22. ( 4 ms ) postprocess_for_goma.goma_jsonstatus
    postprocess_for_goma.goma_jsonstatus
  23. ( 3 ms ) postprocess_for_goma.goma_stat
    postprocess_for_goma.goma_stat
  24. ( 3 ms ) postprocess_for_goma.stop_goma
    postprocess_for_goma.stop_goma
  25. ( 8 secs ) postprocess_for_goma.upload_log
    postprocess_for_goma.upload_log
  26. ( 3 ms ) postprocess_for_goma.stop cloudtail
    postprocess_for_goma.stop cloudtail
  27. ( 4 ms ) clear landmines
    clear landmines
  28. ( 3 ms ) ensure_goma (2)
    ensure_goma (2)
  29. ( 4 ms ) ensure_goma.ensure_installed (2)
    ensure_goma.ensure_installed (2)
  30. ( 28 secs ) gclient runhooks (2)
    gclient runhooks (2)
  31. ( 4 ms ) lookup GN args (2)
    lookup GN args (2)
     
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    use_goma = true
    goma_dir = "/b/c/goma_cache/client"
  32. ( 12 secs ) generate_build_files (2)
    generate_build_files (2)
  33. ( 3 ms ) preprocess_for_goma (2)
    preprocess_for_goma (2)
  34. ( 4 ms ) preprocess_for_goma.goma cache directory (2)
    preprocess_for_goma.goma cache directory (2)
  35. ( 3 ms ) preprocess_for_goma.start_goma (2)
    preprocess_for_goma.start_goma (2)
  36. ( 5 secs ) preprocess_for_goma.start cloudtail (2)
    preprocess_for_goma.start cloudtail (2)
  37. ( 41 secs ) compile (2)
    compile (2)
  38. ( 4 ms ) compile confirm no-op (2)
    compile confirm no-op (2)
  39. ( 3 ms ) postprocess_for_goma (2)
    postprocess_for_goma (2)
  40. ( 5 ms ) postprocess_for_goma.goma_jsonstatus (2)
    postprocess_for_goma.goma_jsonstatus (2)
  41. ( 3 ms ) postprocess_for_goma.goma_stat (2)
    postprocess_for_goma.goma_stat (2)
  42. ( 4 ms ) postprocess_for_goma.stop_goma (2)
    postprocess_for_goma.stop_goma (2)
  43. ( 5 secs ) postprocess_for_goma.upload_log (2)
    postprocess_for_goma.upload_log (2)
  44. ( 3 ms ) postprocess_for_goma.stop cloudtail (2)
    postprocess_for_goma.stop cloudtail (2)
  45. ( 3 mins 5 secs ) performance test
    performance test
  46. ( 4 ms ) get access token for service-account-cronet-perf.json
    get access token for service-account-cronet-perf.json
  47. ( 6 secs ) Perf Dashboard Upload
    Perf Dashboard Upload
  48. ( 4 ms ) recipe result
    recipe result

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromium/bb/chromium.android/Android_Cronet_Marshmallow_64bit_Perf/27778/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.android/Android_Cronet_Marshmallow_64bit_Perf/27778" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" Annotation(bot_update)
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" Annotation(bot_update)
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" Annotation(bot_update)
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" Annotation(bot_update)
got_src_revision "f350cfe2c23c02c23f852840ee9d5e08d9c61e96" Annotation(bot_update)
got_src_revision_cp "refs/heads/master@{#606890}" Annotation(bot_update)
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" Annotation(bot_update)
got_v8_revision "f6ed3c5d7eb73112326476d681f0f79d40fc1e0e" Annotation(bot_update)
got_v8_revision_cp "refs/heads/7.2.287@{#1}" Annotation(bot_update)
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#25544}" Annotation(bot_update)
build_data_dir "/b/rr/tmpV2Ubfa" Annotation(steps)
build_id "buildbot/chromium.android/Android Cronet Marshmallow 64bit Perf/27778" Annotation(steps)
builder_id "master.chromium.android:Android Cronet Marshmallow 64bit Perf" Annotation(steps)
blamelist ["chromium-autoroll@skia-public.iam.gserviceaccount.com","chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com","dbessonov@yandex-team.ru","fsamuel@chromium.org","hayato@chromium.org","hiroh@chromium.org","huayinz@chromium.org","javierrobles@chromium.org","jdeblasio@chromium.org","lanwei@chromium.org","mcarlen@chromium.org","skym@google.com","v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com"] Build
branch "master" Build
buildnumber 27778 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1541784058 Build
revision "f350cfe2c23c02c23f852840ee9d5e08d9c61e96" Build
slavename "build88-b1" BuildSlave
buildername "Android Cronet Marshmallow 64bit Perf" Builder
git_revision "f350cfe2c23c02c23f852840ee9d5e08d9c61e96" Change
scheduler "chromium_commits" Scheduler
buildbotURL "https://build.chromium.org/p/chromium.android/" master.cfg
mastername "chromium.android" master.cfg
workdir "/b/build/slave/Android_Cronet_Marshmallow_64bit_Perf" slave

Blamelist:

  1. (dbessonovohnoyoudont@yandex-team.ru)
  2. (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  3. (hirohohnoyoudont@chromium.org)
  4. (huayinzohnoyoudont@chromium.org)
  5. (lanweiohnoyoudont@chromium.org)
  6. (mcarlenohnoyoudont@chromium.org)
  7. (hayatoohnoyoudont@chromium.org)
  8. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  9. (skymohnoyoudont@google.com)
  10. (jdeblasioohnoyoudont@chromium.org)
  11. (fsamuelohnoyoudont@chromium.org)
  12. (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  13. (javierroblesohnoyoudont@chromium.org)

Timing:

Create N/A
Start Friday, 09-Nov-18 17:44:33 UTC
End Friday, 09-Nov-18 18:06:46 UTC
Pending N/A
Execution 22 mins 13 secs

All Changes:

  1. Out-of-line default constructor of WebRange.

    Changed by dbessonovohnoyoudont@yandex-team.ru
    Changed at Friday, 09-Nov-18 17:19:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 92aa96594173109bc330bb2eab84d8e61bd7ee5e

    Comments

    Out-of-line default constructor of WebRange.
    
    WebRange default constructor is both inline and BLINK_EXPORT.
    Using WebRange() in different blink modules (for example,
    blink_core and blink_controller) results in duplicate symbols
    during linking.
    
    This CL out-of-lines this constructor to ensure that exported
    constructor has only one implementation.
    
    Bug: 903712
    Change-Id: Ifdc947c4d0001a4be7404950a6a1639bc9877372
    Reviewed-on: https://chromium-review.googlesource.com/c/1328964
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Commit-Queue: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606878}

    Changed files

    • third_party/blink/public/web/web_range.h
    • third_party/blink/renderer/core/exported/web_range.cc
  2. Update V8 to version 7.2.287.

    Changed by v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 17:21:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d7625aefbe45933a2dc896bd154fbfe3663b3480

    Comments

    Update V8 to version 7.2.287.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/31b2546b..f6ed3c5d
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tes
    ...skip...
    ;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: Ida402fad2dfa8556ea7ae1c22d42058bfb90fa6f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329301
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606879}

    Changed files

    • DEPS
  3. Reland "media/gpu/VEA unittest: Test DMABuf-backed input buffers"

    Changed by hirohohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:21:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 341861b66e4ad99689c9842cdb723cf7429d3157

    Comments

    Reland "media/gpu/VEA unittest: Test DMABuf-backed input buffers"
    
    This adds the command line option, --natvie_input, that VEA unittest passes
    DMABuf-backed video frame to VEA.
    DMABufs are obtained by gbm though NativePixmap. To create NativePixmap on
    Chrome OS, it needs to set up Ozone environment properly. Therefore, this change
    also makes VEA unittest dependent on Ozone.
    
    BUG=chromium:895230
    TEST=VEA unittest on eve w/wo --native_input
    TBR=posciak@chromium.org
    
    Change-Id: I2998f0695813e5e1b77ae2136140eebc385636bf
    Reviewed-on: https://chromium-review.googlesource.com/c/1329121
    Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
    Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606880}

    Changed files

    • media/gpu/BUILD.gn
    • media/gpu/test/generic_dmabuf_video_frame_mapper.cc
    • media/gpu/test/rendering_helper.cc
    • media/gpu/test/texture_ref.cc
    • media/gpu/test/texture_ref.h
    • media/gpu/test/video_encode_accelerator_unittest_helpers.cc
    • media/gpu/test/video_encode_accelerator_unittest_helpers.h
    • media/gpu/test/video_frame_mapper_factory.cc
    • media/gpu/test/video_frame_mapper_factory.h
    • media/gpu/test/video_frame_validator.cc
    • media/gpu/test/video_frame_validator.h
    • media/gpu/video_decode_accelerator_unittest.cc
    • media/gpu/video_encode_accelerator_unittest.cc
  4. [Feed] Fix Feed NTP not clickable when hardware keyboard is connected

    Changed by huayinzohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:25:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision acb2df40a36d52ef4649dc82d779b8b024112358

    Comments

    [Feed] Fix Feed NTP not clickable when hardware keyboard is connected
    
    Bug: 891877
    Change-Id: I8c0cae6ad80f290580975983cb2d2f4f6286509b
    Reviewed-on: https://chromium-review.googlesource.com/c/1325082
    Commit-Queue: Becky Zhou <huayinz@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606881}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java
  5. Add action_sequence in testdriver

    Changed by lanweiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:28:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 687313c56366619151285b4d87847b61e6547cbc

    Comments

    Add action_sequence in testdriver
    
    After we expose test_driver.Actions API to web users, we add their
    implementation in our testdriver file, and fix the wpt tests of
    Actions API.
    
    Bug: 893480
    Change-Id: Ib02c0223208eeb2cc30c2ca35b98d5fc938baa2c
    Reviewed-on: https://chromium-review.googlesource.com/c/1289119
    Commit-Queue: Lan Wei <lanwei@chromium.org>
    Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606882}

    Changed files

    • content/common/input/actions_parser.cc
    • content/common/input/actions_parser.h
    • content/common/input/actions_parser_unittest.cc
    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/elementPosition.html
    • third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/eventOrder.html
    • third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_pointermove.html
    • third_party/WebKit/LayoutTests/external/wpt/resources/testdriver-actions.js
    • third_party/WebKit/LayoutTests/external/wpt/resources/testdriver.js
    • third_party/WebKit/LayoutTests/external/wpt_automation/pointerevents/pointerevent_pointermove-manual-automation.js
    • third_party/WebKit/LayoutTests/resources/testdriver-vendor.js
    • third_party/WebKit/LayoutTests/resources/testdriver.js
  6. [Autofill Assistant] Handle payment request dismiss.

    Changed by mcarlenohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:30:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f3fe32fc147390a01e54fbd7c54e62ca3a3b8ad4

    Comments

    [Autofill Assistant] Handle payment request dismiss.
    
    Before this patch the payment request UI did not properly handle cancel
    and back button.
    
    This patch notifies the Autofill Assistant controller to shut down
    gracefully with a 'give up' message whenever the payment request UI has
    been canceled.
    
    Bug: 806868
    Change-Id: Ie3d83bf48a2004f0a6a72763c4b509b3db023ff9
    Reviewed-on: https://chromium-review.googlesource.com/c/1326499
    Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606883}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantPaymentRequest.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/PaymentRequestUI.java
    • components/autofill_assistant_strings.grdp
  7. Fix a bug in https://crrev.com/c/1272937, where event.target can be still null

    Changed by hayatoohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:31:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2ed9605b4c99774d8865dbd190e13c9fe5c2d03a

    Comments

    Fix a bug in https://crrev.com/c/1272937, where event.target can be still null
    
    Fix a bug in the previous CL, https://crrev.com/c/1272937, where event.target
    can be null when GetElement() returns nullptr.
    
    Bug: 892970, 893449, 902287
    Change-Id: I7a08227d39117c2dc90fe720f0d6ffd62d9b2ea6
    Reviewed-on: https://chromium-review.googlesource.com/c/1322177
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606884}

    Changed files

    • third_party/blink/renderer/modules/accessibility/ax_object.cc
  8. Roll src/third_party/perfetto cf90797ef05a..5fc6c2c52e7b (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 17:32:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0475284ad58e36e9950059000bb7ec3556bb31bb

    Comments

    Roll src/third_party/perfetto cf90797ef05a..5fc6c2c52e7b (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/cf90797ef05a..5fc6c2c52e7b
    
    
    git log cf90797ef05a..5fc6c2c52e7b --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 lalitm@google.com Merge "trace_processor: allow integers to be compared against doubles"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@5fc6c2c52e7b
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromiu
    ...skip...
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: Ifd53d09565e264f09c1deffb23f8adfce3a34958
    Reviewed-on: https://chromium-review.googlesource.com/c/1329505
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606885}

    Changed files

    • DEPS
  9. [Feed] Check loadUrlParams for null, fallback to opening online.

    Changed by skymohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 17:33:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 60b47f98f87e0f3689826e4342fab09b7a35ed5e

    Comments

    [Feed] Check loadUrlParams for null, fallback to opening online.
    
    Bug: 901179
    Change-Id: Ieb3a421a7930ddc0014f7ef57b6a8f6d89dc3615
    Reviewed-on: https://chromium-review.googlesource.com/c/1315358
    Commit-Queue: Sky Malice <skym@chromium.org>
    Reviewed-by: Filip Gorski <fgorski@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606886}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedLoggingBridge.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/action/FeedActionHandler.java
    • chrome/android/junit/src/org/chromium/chrome/browser/feed/action/FeedActionHandlerTest.java
    • chrome/browser/android/feed/feed_logging_bridge.cc
    • chrome/browser/android/feed/feed_logging_bridge.h
  10. Record Android revokes in Permissions.Action.Notification.

    Changed by jdeblasioohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:35:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f8c0f174bb015976222531ead359ade19b488833

    Comments

    Record Android revokes in Permissions.Action.Notification.
    
    This CL modifies fixes a bug in which metrics were not being recorded on
    Android when notification permissions were revoked. It adds a missing
    ScopedRevocationReporter for Chrome-visible changes, and adds detection
    code for when notification permissions are revoked in Android O+
    system channel settings.
    
    Bug: 782126
    Change-Id: I609e909936d09e6dd948f0601bbf73ecdb6b8b75
    Reviewed-on: https://chromium-review.googlesource.com/c/1324394
    Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Reviewed-by: Dominick Ng <dominickn@chromium.org>
    Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
    Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
    Reviewed-by: Christopher Thompson <cthomp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606887}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferenceBridge.java
    • chrome/browser/android/preferences/website_preference_bridge.cc
    • chrome/browser/permissions/permission_uma_util.h
    • tools/metrics/ukm/ukm.xml
  11. viz: Plumb LocalSurfaceIdAllocation to more places [part 5]

    Changed by fsamuelohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:36:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7e806513b1b91da6e96a56bfd3ca5f464c4666b9

    Comments

    viz: Plumb LocalSurfaceIdAllocation to more places [part 5]
    
    viz::LocalSurfaceIdAllocation bundles a viz::LocalSurfaceId and an
    allocation time for that viz::LocalSurfaceId. The purpose of this allocation
    time is to determine how long it takes for a surface to get embedded once
    an ID has been allocated for it.
    
    There was some concern raised about drift between LocalSurfaceIds and allocation
    times and so a previous CL bundled the two together in a class. This CL plumbs
    LocalSurfaceIdAllocation to more 
    ...skip...
    rentLocalSurfaceIdAllocator that return an allocation time or LocalSurfaceId
    independent of the other. This is to encourage future plumbing of
    LocalSurfaceIdAllocation instead.
    
    Bug: 655231
    Change-Id: I3118cc06e0afa04914a0e2e7457ffdfd5ad5778d
    Reviewed-on: https://chromium-review.googlesource.com/c/1327573
    Reviewed-by: Jonathan Ross <jonross@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Commit-Queue: Fady Samuel <fsamuel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606888}

    Changed files

    • cc/test/layer_tree_test.cc
    • cc/test/layer_tree_test.h
    • cc/trees/layer_tree_host_impl.cc
    • cc/trees/layer_tree_host_impl.h
    • cc/trees/layer_tree_host_unittest.cc
    • components/viz/common/surfaces/child_local_surface_id_allocator.h
    • components/viz/common/surfaces/child_local_surface_id_allocator_unittest.cc
    • components/viz/common/surfaces/parent_local_surface_id_allocator.h
    • components/viz/common/surfaces/parent_local_surface_id_allocator_unittest.cc
    • content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
    • third_party/blink/renderer/platform/graphics/surface_layer_bridge.cc
    • third_party/blink/renderer/platform/graphics/video_frame_submitter.cc
    • third_party/blink/renderer/platform/graphics/video_frame_submitter_test.cc
  12. Roll src-internal 827de2c806ba..5fa11106b909 (2 commits)

    Changed by chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 17:40:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7e4f2a9f17b74405f73aca4ecee7dcd639477de6

    Comments

    Roll src-internal 827de2c806ba..5fa11106b909 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/827de2c806ba..5fa11106b909
    
    
    Created with:
      gclient setdep -r src-internal@5fa11106b909
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ie1b9b04d41e2a6dfe8e4fa45f0d25892052660e1
    Reviewed-on: https://chromium-review.googlesource.com/c/1329503
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606889}

    Changed files

    • DEPS
  13. [iOS][MF] Adds password related histograms

    Changed by javierroblesohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:41:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f350cfe2c23c02c23f852840ee9d5e08d9c61e96

    Comments

    [iOS][MF] Adds password related histograms
    
    Bug: 878388
    Change-Id: Ia0a6622596753d87888e480401e38f7ef61ae539
    Reviewed-on: https://chromium-review.googlesource.com/c/1326013
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606890}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/password_view_controller.mm
    • tools/metrics/histograms/histograms.xml