Builder Android Cronet Marshmallow 64bit Builder
Build #25963
Results:
exception steps exception remote_run_result
Trigger Info:
Execution:
Steps and Logfiles:
Show:Build Properties:
| Name | Value | Source |
|---|---|---|
| $recipe_engine/runtime | {"is_experimental":false,"is_luci":false} | Annotation(LUCI Migration) |
| luci_migration | {"status":"ok"} | Annotation(LUCI Migration) |
| log_location | "logdog://logs.chromium.org/chromium/bb/chromium.android/Android_Cronet_Marshmallow_64bit_Builder/25963/+/recipes/annotations" | Annotation(LogDog Bootstrap) |
| logdog_prefix | "bb/chromium.android/Android_Cronet_Marshmallow_64bit_Builder/25963" | Annotation(LogDog Bootstrap) |
| logdog_project | "chromium" | Annotation(LogDog Bootstrap) |
| build_data_dir | "/b/rr/tmpioarc4" | Annotation(steps) |
| build_id | "buildbot/chromium.android/Android Cronet Marshmallow 64bit Builder/25963" | Annotation(steps) |
| builder_id | "master.chromium.android:Android Cronet Marshmallow 64bit Builder" | Annotation(steps) |
| blamelist | ["alancutter@chromium.org","avi@chromium.org","ccameron@chromium.org","charleszhao@chromium.org","chromium-autoroll@skia-public.iam.gserviceaccount.com","maxmorin@chromium.org","nhiroki@chromium.org","pkotwicz@chromium.org","shuchen@google.com","tbansal@chromium.org","wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com"] | Build |
| branch | "master" | Build |
| buildnumber | 25963 | Build |
| project | "src" | Build |
| repository | "https://chromium.googlesource.com/chromium/src" | Build |
| requestedAt | 1544163178 | Build |
| revision | "38d4c8616dd560586a6e29165b77eadd5a2ca1ed" | Build |
| slavename | "build87-b1" | BuildSlave |
| buildername | "Android Cronet Marshmallow 64bit Builder" | Builder |
| git_revision | "38d4c8616dd560586a6e29165b77eadd5a2ca1ed" | Change |
| scheduler | "chromium_commits" | Scheduler |
| buildbotURL | "https://build.chromium.org/p/chromium.android/" | master.cfg |
| mastername | "chromium.android" | master.cfg |
| workdir | "/b/build/slave/Android_Cronet_Marshmallow_64bit_Builder" | slave |
Blamelist:
- (tbansal@chromium.org)
- (alancutter@chromium.org)
- (charleszhao@chromium.org)
- (maxmorin@chromium.org)
- (chromium-autoroll@skia-public.iam.gserviceaccount.com)
- (nhiroki@chromium.org)
- (wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com)
- (shuchen@google.com)
- (chromium-autoroll@skia-public.iam.gserviceaccount.com)
- (pkotwicz@chromium.org)
- (ccameron@chromium.org)
- (alancutter@chromium.org)
- (avi@chromium.org)
Timing:
| Create | N/A |
| Start | Friday, 07-Dec-18 07:26:09 UTC |
| End | Friday, 07-Dec-18 07:26:54 UTC |
| Pending | N/A |
| Execution | 44 secs |
All Changes:
-
Report PreviewsEligibilityReason as offline when device is offline
Changed by tbansal@chromium.org Changed at Friday, 07-Dec-18 06:11:36 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 01c4f97005f6f162b3df6953b8f2a4efce338ec1 Comments
Report PreviewsEligibilityReason as offline when device is offline Currently, if the device is offline, PreviewsEligibilityReason records the reason for not showing previews as network quality unavailable. This CL changes it to record the reason as device offline. Network quality unavailable reason is now used for only the cases where NQE (network quality estimator) reports ECT as Unknown. Bug: 912725 Change-Id: I0af0977770e2123f6ccd0317f8ebbfaed1aac9b2 Reviewed-on: https://chromium-review.googlesource.com/c/1366835 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#614621}
Changed files
- components/previews/content/previews_decider_impl.cc
- components/previews/content/previews_decider_impl_unittest.cc
- components/previews/core/previews_black_list.h
- components/previews/core/previews_logger.cc
- tools/metrics/histograms/enums.xml
-
Revert "Timer notification UI improvement:"
Changed by alancutter@chromium.org Changed at Friday, 07-Dec-18 06:18:17 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 28d424ea311f180535b9a5aceb6facfc61c9b59e Comments
Revert "Timer notification UI improvement:" This reverts commit d710a7b3ef59302c00c2e3fe1b00c788310801c6. Reason for revert: Broke compile: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/59395 ../../chromeos/services/assistant/assistant_manager_service_impl.cc:33:10: fatal error: 'libassistant/shared/internal_api/alarm_timer_types.h' file not found #include "libassistant/shared/internal_api/alarm_timer_types.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 err ...skip... Commit-Position: refs/heads/master@{#614618} TBR=xiyuan@chromium.org,dcheng@chromium.org,xiaohuic@chromium.org,dmblack@google.com,wutao@chromium.org,llin@chromium.org Change-Id: I8ece5ad7361e379880921e2abc55085d1de6cd88 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:119116816 Reviewed-on: https://chromium-review.googlesource.com/c/1367081 Reviewed-by: Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#614622}
Changed files
- ash/assistant/assistant_controller.cc
- ash/assistant/assistant_interaction_controller.cc
- ash/assistant/assistant_interaction_controller.h
- ash/assistant/util/deep_link_util.cc
- ash/assistant/util/deep_link_util.h
- ash/assistant/util/deep_link_util_unittest.cc
- chromeos/chromeos_strings.grd
- chromeos/services/assistant/assistant_manager_service_impl.cc
- chromeos/services/assistant/assistant_manager_service_impl.h
- chromeos/services/assistant/fake_assistant_manager_service_impl.cc
- chromeos/services/assistant/fake_assistant_manager_service_impl.h
- chromeos/services/assistant/public/features.cc
- chromeos/services/assistant/public/features.h
- chromeos/services/assistant/public/mojom/assistant.mojom
- chromeos/services/assistant/test_support/mock_assistant.h
-
TabRanker: Fix Query time logging.
Changed by charleszhao@chromium.org Changed at Friday, 07-Dec-18 06:26:07 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6378752b810e6122744cefac544c8d84278dcc71 Comments
TabRanker: Fix Query time logging. TabRanker query time logging was landed in this cl: https://chromium-review.googlesource.com/c/chromium/src/+/1350445 TabManager::GetSortedLifecycleUnitsFromTabRanker() was created to bypass calls to TabManager::GetSortedLifecycleUnits() But this was wrong on two aspects: (1) TabManagerDelegate::LowMemoryKillImpl is still calling GetSortedLifecycleUnits(), so ChromeOS discards are all skipped. (2) TabManagerDelegate::Candidate is calling lifecycle_unit_ ...skip... d TabActivityWatcher::LogOldestNTabFeatures() and call this function in TabManager::DiscardTab for query time logging. Bug: 911474 Change-Id: I103e8237cd96ea87667536b7b44b27fe8772abb4 Reviewed-on: https://chromium-review.googlesource.com/c/1360471 Reviewed-by: Christopher Morin <cmtm@google.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#614623}
Changed files
- chrome/browser/resource_coordinator/tab_activity_watcher.cc
- chrome/browser/resource_coordinator/tab_activity_watcher.h
- chrome/browser/resource_coordinator/tab_activity_watcher_browsertest.cc
- chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
- chrome/browser/resource_coordinator/tab_manager.cc
- chrome/browser/resource_coordinator/tab_manager.h
-
Activate audio thread hang monitoring when OOP
Changed by maxmorin@chromium.org Changed at Friday, 07-Dec-18 06:26:36 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c67047dd2ff166e62aa72f9d461e3a00baf5e573 Comments
Activate audio thread hang monitoring when OOP Also includes cleaning up the hang monitor: * Actually a class! * Actually possible to stop the hang monitor! * Tests! * When OOP, uploads dumps (without crashing). A kill switch is added for this. * Switch the UMA enum to kCase, make it a class enum, and use the simpler UMA histogram. * Switch from "tail posting" the periodic task to using RepeatingTimer. * Runs on the task scheduler rather than on the browser IO thread. * Some suspend/resume code was simplified. The hang monitor is now owned by the AudioThread implementation. Extra functionality (such a nuking the audio process in case of a hang) is coming later. Bug: 866442, 905681 Change-Id: Icfe83cc3e7626b164648a8b502d13cf2cfc25518 Reviewed-on: https://chromium-review.googlesource.com/c/1340264 Reviewed-by: Olga Sharonova <olka@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#614624}
Changed files
- content/browser/renderer_host/media/audio_output_authorization_handler_unittest.cc
- content/browser/renderer_host/render_process_host_impl.cc
- media/audio/BUILD.gn
- media/audio/audio_features.cc
- media/audio/audio_features.h
- media/audio/audio_manager.cc
- media/audio/audio_manager.h
- media/audio/audio_thread.h
- media/audio/audio_thread_hang_monitor.cc
- media/audio/audio_thread_hang_monitor.h
- media/audio/audio_thread_hang_monitor_unittest.cc
- media/audio/audio_thread_impl.cc
- media/audio/audio_thread_impl.h
- media/audio/test_audio_thread.cc
- media/audio/test_audio_thread.h
- services/audio/owning_audio_manager_accessor.cc
-
Roll src/third_party/catapult 5d7bcad36ff4..62ba44ace70c (1 commits)
Changed by chromium-autoroll@skia-public.iam.gserviceaccount.com Changed at Friday, 07-Dec-18 06:29:16 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a61e410e3beb88a04880f973dbde7c0099dbdff6 Comments
Roll src/third_party/catapult 5d7bcad36ff4..62ba44ace70c (1 commits) https://chromium.googlesource.com/catapult.git/+log/5d7bcad36ff4..62ba44ace70c git log 5d7bcad36ff4..62ba44ace70c --date=short --no-merges --format='%ad %ae %s' 2018-12-06 rmhasan@google.com Adds another verification to the Test expectation parser Created with: gclient setdep -r src/third_party/catapult@62ba44ace70c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoR ...skip... linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:905426 TBR=sullivan@chromium.org Change-Id: Ibda0e80cd77c7ecd1434701f064e2f99db1b8307 Reviewed-on: https://chromium-review.googlesource.com/c/1367099 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614625}
Changed files
- DEPS
-
Worklet: Use <meta name="timeout"> instead of SlowTests annotations for slow WPTs
Changed by nhiroki@chromium.org Changed at Friday, 07-Dec-18 06:31:46 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 593b9acb3dea58c30c4a4cd8d251938f66a47c1e Comments
Worklet: Use <meta name="timeout"> instead of SlowTests annotations for slow WPTs <meta name="timeout"> is prefereable for WPTs: https://web-platform-tests.org/writing-tests/testharness-api.html#harness-timeout Bug: 912240 Change-Id: I3c4a9acb1fb070c34d10f59ff9d3fd3d2bd11afb Reviewed-on: https://chromium-review.googlesource.com/c/1366469 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#614626}
Changed files
- third_party/blink/web_tests/SlowTests
- third_party/blink/web_tests/external/wpt/worklets/animation-worklet-csp.https.html
- third_party/blink/web_tests/external/wpt/worklets/audio-worklet-csp.https.html
-
Import wpt@2d0f68b3c512b4ba268b09fac224830f866a5720
Changed by wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com Changed at Friday, 07-Dec-18 06:36:58 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b38c320095ae37996d50a735f7d2690c9e0eed10 Comments
Import wpt@2d0f68b3c512b4ba268b09fac224830f866a5720 Using wpt-import in Chromium c71812f1007dae45bce45b451c384bf9c0dbd356. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I379fefc2dcbcf7082675a8eced0893890f23b0ef Reviewed-on: https://chromium-review.googlesource.com/c/1367132 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614627}
Changed files
- third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
- third_party/blink/web_tests/external/wpt/webrtc/RTCPeerConnection-track-stats.https-expected.txt
- third_party/blink/web_tests/external/wpt/webrtc/RTCPeerConnection-track-stats.https.html
- third_party/blink/web_tests/external/wpt/webrtc/legacy/RTCPeerConnection-addStream.https.html
- third_party/blink/web_tests/external/wpt/webrtc/no-media-call.html
-
Updates the order of key mappings to match the same as layout rendering in VK.
Changed by shuchen@google.com Changed at Friday, 07-Dec-18 06:48:36 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 65054bfdd84984501e8054b2f96edacc1bab93a9 Comments
Updates the order of key mappings to match the same as layout rendering in VK. The modifier importance priority is: Altgr > Shift > Capslock. So if user presses a key with Shift + Altgr + Capslock and the key mapping is not defined for the input method. It will fallback to other key mappings in this order: - Shift + Altgr - Altgr + Capslock - Shift + Capslock - Altgr - Shift - Capslock - Normal Bug: 910049 Change-Id: I3a274ba02671977a075ee27441acf429cf4569cb Reviewed-on: https://chromium-review.googlesource.com/c/1356735 Reviewed-by: Leo Zhang <googleo@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#614628}
Changed files
- chromeos/services/ime/public/cpp/rulebased/def/fa.cc
- chromeos/services/ime/public/cpp/rulebased/def/lo.cc
- chromeos/services/ime/public/cpp/rulebased/def/ta_inscript.cc
- chromeos/services/ime/public/cpp/rulebased/def/ta_phone.cc
- chromeos/services/ime/public/cpp/rulebased/def/th.cc
-
Roll src/third_party/skia 309f1deddf8e..f3babcd0afb3 (2 commits)
Changed by chromium-autoroll@skia-public.iam.gserviceaccount.com Changed at Friday, 07-Dec-18 06:49:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8112997ce464e3fa4ae5ca8e166c7adc1de03e35 Comments
Roll src/third_party/skia 309f1deddf8e..f3babcd0afb3 (2 commits) https://skia.googlesource.com/skia.git/+log/309f1deddf8e..f3babcd0afb3 git log 309f1deddf8e..f3babcd0afb3 --date=short --no-merges --format='%ad %ae %s' 2018-12-07 sergeyu@chromium.org Reland "Add SkFontMgr implementation for Fuchsia" 2018-12-07 reed@google.com Revert "Add SkFontMgr implementation for Fuchsia" Created with: gclient setdep -r src/third_party/skia@f3babcd0afb3 The AutoRoll server is located here: https://autoroll.s ...skip... ;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: Ieefefb070c45ba63a5efa3872a75e1d4140b5e41 Reviewed-on: https://chromium-review.googlesource.com/c/1367116 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614629}
Changed files
- DEPS
-
[Android Tests] Fix several FirstRunIntegrationTests
Changed by pkotwicz@chromium.org Changed at Friday, 07-Dec-18 06:57:01 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1ca54644ff73878027d7903ab3bd6288561e68a8 Comments
[Android Tests] Fix several FirstRunIntegrationTests This CL converts several FirstRunIntegrationTests to JUnit tests and re-enables them. BUG=911316 Change-Id: I7aada68234fe9a5cb25ee3bef29538cec537d49a Reviewed-on: https://chromium-review.googlesource.com/c/1362812 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#614630}
Changed files
- chrome/android/java_sources.gni
- chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java
- chrome/android/junit/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationUnitTest.java
-
RemoteMacViews: Wire up menu items and shortcut keys
Changed by ccameron@chromium.org Changed at Friday, 07-Dec-18 07:00:51 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1c1992d02fa89792498f5e3533772bd65d93973d Comments
RemoteMacViews: Wire up menu items and shortcut keys For menu items and shortcut keys to work, PWA windows need to have the ChromeCommandDispatcherDelegate and BrowserWindowCommandHandler structures set on them. This cannot be done by a method on views_bridge_mac::mojom:: BridgedNativeWidget, because the structures to be created exist in Chrome, which would be a layering violation. Introduce a method to chrome::mojom::AppShim which takes a widget id, creates the ChromeCommandDispatcherDelegate and BrowserWindowCommandHandler, and assigns them to the corresponding BridgedNativeWidgetImpl. Bug: 895169 Change-Id: Ie1d333bec235d7b6101d5b19aa89a74136d54a7a Reviewed-on: https://chromium-review.googlesource.com/c/1364210 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#614631}
Changed files
- chrome/app_shim/app_shim_controller.h
- chrome/app_shim/app_shim_controller.mm
- chrome/browser/apps/app_shim/app_shim_host_mac.cc
- chrome/browser/apps/app_shim/app_shim_host_mac.h
- chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc
- chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm
- chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc
- chrome/browser/apps/app_shim/extension_app_shim_handler_mac.h
- chrome/browser/ui/views/frame/browser_frame_mac.mm
- chrome/common/mac/app_shim.mojom
- ui/views/cocoa/bridged_native_widget_unittest.mm
- ui/views/widget/native_widget_mac.h
-
Revert "Add chrome_proxy.exe target on Windows"
Changed by alancutter@chromium.org Changed at Friday, 07-Dec-18 07:03:46 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0edcdf14a29397ba43d8e303bcf01f04705ed95e Comments
Revert "Add chrome_proxy.exe target on Windows" This reverts commit 86e7ed69a96f03ffcbb6af63d632f7951bf34b28. Reason for revert: Broke Chrome Canary update while the browser is open. Bug: 912716 Original change's description: > Add chrome_proxy.exe target on Windows > > This change adds a new executable to Windows called chrome_proxy.exe which > opens chrome.exe with all arguments forwarded. > > In a future patch bookmark app shortcuts will be updated to point to > chrome_proxy.exe instead of chrom ...skip... stig@chromium.org,alancutter@chromium.org,mgiuca@chromium.org,grt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. NOPRESUBMIT=TRUE # TBR doesn't apply because this revert touches an OWNERS file. Bug: 732357 Change-Id: I73cddef3173e3abc22f8c8c4720d84f9a9069ab1 Reviewed-on: https://chromium-review.googlesource.com/c/1366471 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#614632}
Changed files
- chrome/BUILD.gn
- chrome/chrome_proxy/BUILD.gn
- chrome/chrome_proxy/OWNERS
- chrome/chrome_proxy/chrome_proxy.ver
- chrome/chrome_proxy/chrome_proxy_main_win.cc
- chrome/installer/mini_installer/BUILD.gn
- chrome/installer/mini_installer/chrome.release
- chrome/installer/setup/install_worker.cc
- chrome/installer/setup/install_worker.h
- chrome/installer/setup/setup_main.cc
- chrome/installer/util/util_constants.cc
- chrome/installer/util/util_constants.h
- chrome/test/mini_installer/config/chrome_beta_installed.prop
- chrome/test/mini_installer/config/chrome_canary_installed.prop
- chrome/test/mini_installer/config/chrome_dev_installed.prop
- chrome/test/mini_installer/config/chrome_multi_system_installed.prop
- chrome/test/mini_installer/config/chrome_multi_user_installed.prop
- chrome/test/mini_installer/config/chrome_system_installed.prop
- chrome/test/mini_installer/config/chrome_user_installed.prop
- chrome/test/mini_installer/config/previous_chrome_canary_installed.prop
- chrome/test/mini_installer/config/previous_chrome_system_installed.prop
- chrome/test/mini_installer/config/previous_chrome_user_installed.prop
- chrome/tools/build/win/FILES.cfg
-
Remove linked_ptr from the extensions trackers.
Changed by avi@chromium.org Changed at Friday, 07-Dec-18 07:21:09 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 38d4c8616dd560586a6e29165b77eadd5a2ca1ed Comments
Remove linked_ptr from the extensions trackers. BUG=582001 Change-Id: I4141f3fe268d34e5d078740b5ef12b4f02b5efb1 Reviewed-on: https://chromium-review.googlesource.com/c/1364550 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#614633}
Changed files
- chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker.cc
- chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker.h
- chrome/browser/extensions/api/declarative_content/declarative_content_is_bookmarked_condition_tracker.cc
- chrome/browser/extensions/api/declarative_content/declarative_content_is_bookmarked_condition_tracker.h
- chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.cc
- chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.h