Home | Search
Login

Builder Android Cronet Marshmallow 64bit Builder Build #22840 Canonical Ubuntu

Results:

build successful

Trigger Info:

Execution:

Steps and Logfiles:

Show:
  1. ( 37 mins 7 secs ) steps
    running steps via annotated script
  2. ( 10 secs ) update_scripts
    update_scripts
  3. ( 1 ms ) setup_properties
    setup_properties
  4. ( 1 ms ) LUCI Migration
    LUCI Migration
  5. ( 2 ms ) LogDog Bootstrap
    LogDog Bootstrap
  6. ( 5 ms ) setup_build
    setup_build
    running recipe: "cronet"
  7. ( 9 secs ) remove .cipd
    remove .cipd
  8. ( 1 mins 36 secs ) cleanup index.lock
    cleanup index.lock
  9. ( 4 mins 17 secs ) bot_update
    bot_update
    [67GB/442GB used (15%)]
  10. ( 4 ms ) clean local files
    clean local files
  11. ( 3 ms ) ensure_goma
    ensure_goma
  12. ( 4 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  13. ( 3 ms ) clobber
    clobber
  14. ( 52 secs ) gclient runhooks
    gclient runhooks
  15. ( 1 mins 6 secs ) generate_build_files
    generate_build_files
  16. ( 3 ms ) preprocess_for_goma
    preprocess_for_goma
  17. ( 3 ms ) preprocess_for_goma.goma cache directory
    preprocess_for_goma.goma cache directory
  18. ( 3 ms ) preprocess_for_goma.start_goma
    preprocess_for_goma.start_goma
  19. ( 3 ms ) preprocess_for_goma.start cloudtail
    preprocess_for_goma.start cloudtail
  20. ( 4 mins 17 secs ) compile
    compile
  21. ( 3 ms ) compile confirm no-op
    compile confirm no-op
  22. ( 3 ms ) postprocess_for_goma
    postprocess_for_goma
  23. ( 4 ms ) postprocess_for_goma.goma_jsonstatus
    postprocess_for_goma.goma_jsonstatus
  24. ( 3 ms ) postprocess_for_goma.goma_stat
    postprocess_for_goma.goma_stat
  25. ( 3 ms ) postprocess_for_goma.stop_goma
    postprocess_for_goma.stop_goma
  26. ( 9 secs ) postprocess_for_goma.upload_log
    postprocess_for_goma.upload_log
  27. ( 3 ms ) postprocess_for_goma.stop cloudtail
    postprocess_for_goma.stop cloudtail
  28. ( 4 ms ) sizes
    sizes
    sizes
    <div class="BuildResultInfo">
    </div>
  29. ( 4 ms ) resource_sizes (CronetSample.apk)
    resource_sizes (CronetSample.apk)
    resource_sizes (CronetSample.apk)
    <div class="BuildResultInfo">
    </div>
  30. ( 3 ms ) get version
    get version
  31. ( 3 ms ) create adb symlink
    create adb symlink
  32. ( 3 ms ) spawn_logcat_monitor
    spawn_logcat_monitor
  33. ( 3 ms ) spawn_device_monitor
    spawn_device_monitor
  34. ( 5 secs ) authorize_adb_devices
    authorize_adb_devices
  35. ( 5 secs ) device_recovery
    device_recovery
  36. ( 2 mins 15 secs ) provision_devices
    provision_devices
  37. ( 2 ms ) device_status
    device_status
    Online devices: 2
  38. ( 46 secs ) cronet_unittests_android
    cronet_unittests_android
  39. ( 12 mins 29 secs ) net_unittests
    net_unittests
  40. ( 15 secs ) cronet_sample_test_apk
    cronet_sample_test_apk
  41. ( 7 ms ) cronet_sample_test_apk: generate result details
    cronet_sample_test_apk: generate result details
  42. ( 21 secs ) cronet_smoketests_missing_native_library_instrumentation_apk
    cronet_smoketests_missing_native_library_instrumentation_apk
  43. ( 4 ms ) cronet_smoketests_missing_native_library_instrumentation_apk: generate result details
    cronet_smoketests_missing_native_library_instrumentation_apk: generate result details
  44. ( 19 secs ) cronet_smoketests_platform_only_instrumentation_apk
    cronet_smoketests_platform_only_instrumentation_apk
  45. ( 4 ms ) cronet_smoketests_platform_only_instrumentation_apk: generate result details
    cronet_smoketests_platform_only_instrumentation_apk: generate result details
  46. ( 7 mins 19 secs ) cronet_test_instrumentation_apk
    cronet_test_instrumentation_apk
  47. ( 2 ms ) cronet_test_instrumentation_apk: generate result details
    cronet_test_instrumentation_apk: generate result details
  48. ( 2 ms ) shutdown_device_monitor
    shutdown_device_monitor
  49. ( 2 ms ) logcat_dump
    logcat_dump
  50. ( 1 ms ) gsutil upload
    gsutil upload
  51. ( 10 secs ) stack_tool_with_logcat_dump
    stack_tool_with_logcat_dump
  52. ( 3 ms ) stack_tool_for_tombstones
    stack_tool_for_tombstones
  53. ( 4 ms ) test_report
    test_report
  54. ( 4 ms ) recipe result
    recipe result

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromium/bb/chromium.android/Android_Cronet_Marshmallow_64bit_Builder/22840/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.android/Android_Cronet_Marshmallow_64bit_Builder/22840" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" Annotation(bot_update)
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" Annotation(bot_update)
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" Annotation(bot_update)
got_src_revision "3e44f3be427bb7222e8e20640e261d620478e8bc" Annotation(bot_update)
got_src_revision_cp "refs/heads/master@{#574711}" Annotation(bot_update)
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" Annotation(bot_update)
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" Annotation(bot_update)
got_v8_revision_cp "refs/heads/6.9.352@{#1}" Annotation(bot_update)
got_webrtc_revision "895617fa9bc36c240b37d47402cdb341ecadf994" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#23955}" Annotation(bot_update)
recipe "cronet" Annotation(setup_properties)
blamelist ["blink-w3c-test-autoroller@chromium.org","ekaramad@chromium.org","erikchen@chromium.org","jam@chromium.org","japhet@chromium.org","jsaul@google.com","karandeepb@chromium.org","kvitekp@chromium.org","mahmadi@chromium.org","martinkr@google.com","nburris@google.com","npm@chromium.org","rmcelrath@chromium.org","tiborg@chromium.org","uwyiming@google.com","webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","wfh@chromium.org"] Build
branch "master" Build
buildnumber 22840 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1531426416 Build
revision "3e44f3be427bb7222e8e20640e261d620478e8bc" Build
slavename "build87-b1" BuildSlave
buildername "Android Cronet Marshmallow 64bit Builder" Builder
git_revision "3e44f3be427bb7222e8e20640e261d620478e8bc" Change
scheduler "chromium_commits" Scheduler
buildbotURL "https://build.chromium.org/p/chromium.android/" master.cfg
mastername "chromium.android" master.cfg
workdir "/b/build/slave/Android_Cronet_Marshmallow_64bit_Builder" slave

Blamelist:

  1. (nburrisohnoyoudont@google.com)
  2. (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  3. (martinkrohnoyoudont@google.com)
  4. (mahmadiohnoyoudont@chromium.org)
  5. (erikchenohnoyoudont@chromium.org)
  6. (rmcelrathohnoyoudont@chromium.org)
  7. (ekaramadohnoyoudont@chromium.org)
  8. (uwyimingohnoyoudont@google.com)
  9. (tiborgohnoyoudont@chromium.org)
  10. (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  11. (wfhohnoyoudont@chromium.org)
  12. (jamohnoyoudont@chromium.org)
  13. (japhetohnoyoudont@chromium.org)
  14. (kvitekpohnoyoudont@chromium.org)
  15. (jsaulohnoyoudont@google.com)
  16. (karandeepbohnoyoudont@chromium.org)
  17. (npmohnoyoudont@chromium.org)

Timing:

Create N/A
Start Thursday, 12-Jul-18 20:51:04 UTC
End Thursday, 12-Jul-18 21:28:12 UTC
Pending N/A
Execution 37 mins 7 secs

All Changes:

  1. Chrome Cleanup UI: Extract GetLastUsedProfile call from scanner results

    Changed by nburrisohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 20:11:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision feda02794921ad4eca0b4c5d15c21bc0461e73fa

    Comments

    Chrome Cleanup UI: Extract GetLastUsedProfile call from scanner results

Chrome runs into a fatal error when the cleaner detects unwanted
software. This is because ChromeCleanerScannerResults is created in the
IO thread, and ProfileManager::GetLastUsedProfile requires the UI
thread. The tests passed because they run a test browser process.

- Extract extension name fetching to a separate function.
- Call this function in tests so they're not affected.
- Follow-up CL: Call this function once the scanner results are on the
UI thread, before they're sent to the web UI.

Bug: 853339
Change-Id: I9cc2425f7b196e923a22b2afd1e8eee7fca61f5b
Reviewed-on: https://chromium-review.googlesource.com/1135194
Commit-Queue: Nick Burris <nburris@google.com>
Reviewed-by: proberge <proberge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574695}

    Changed files

    • chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win_unittest.cc
    • chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win_unittest.cc
    • chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_scanner_results.cc
    • chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_scanner_results.h

  2. Roll src/third_party/webrtc 798ee75d2365..895617fa9bc3 (3 commits)

    Changed by webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 20:12:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 460febcbc6e56f2355493a4f43188b08753c2dc6

    Comments

    Roll src/third_party/webrtc 798ee75d2365..895617fa9bc3 (3 commits)

https://webrtc.googlesource.com/src.git/+log/798ee75d2365..895617fa9bc3


git log 798ee75d2365..895617fa9bc3 --date=short --no-merges --format='%ad %ae %s'
2018-07-12 buildbot@webrtc.org Roll chromium_revision efbdada3f7..f7c234b027 (574489:574598)
2018-07-12 magjed@webrtc.org Android: Add helper functions for comparing H264 codecs
2018-07-12 saza@webrtc.org Remove useless import of arm.gni


Created with:
  gclient setdep -r src/thir
...skip...
mac:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I07750ee2f3c028532fb0dfbfa0386eeeb119c8f8
Reviewed-on: https://chromium-review.googlesource.com/1135612
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574696}

    Changed files

    • DEPS

  3. device/fido/mac: integrate with browsing data deletion

    Changed by martinkrohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 20:13:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d54b58e5b08b96664080795a01e0bd2373952e6e

    Comments

    device/fido/mac: integrate with browsing data deletion

This updates browsing data deletion for DATA_TYPE_PASSWORDS to call
device::fido::mac::DeleteWebAuthnCredentials, which deletes credentials
created by the macOS platform authenticator from the OS keychain.

Also combine the two Touch ID specific configuration methods in
{Chrome,}AuthenticatorRequestDelegate and introduce a static variant for
Chrome.

Bug: 678128
Change-Id: I0034e0815da068fb27c1ea60cad95f958956838e
Reviewed-on: https://chromium-review.googlesource.com/1125177
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574697}

    Changed files

    • chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
    • chrome/browser/webauthn/chrome_authenticator_request_delegate.cc
    • chrome/browser/webauthn/chrome_authenticator_request_delegate.h
    • chrome/browser/webauthn/chrome_authenticator_request_delegate_unittest.cc
    • content/browser/webauth/authenticator_impl.cc
    • content/public/browser/authenticator_request_client_delegate.cc
    • content/public/browser/authenticator_request_client_delegate.h
    • device/fido/mac/authenticator.h

  4. Revert "[AF][IOS] Scan page for form changes when a field is focused"

    Changed by mahmadiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:13:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4b937d53836386e51532fbe870938b33ce0455ed

    Comments

    Revert "[AF][IOS] Scan page for form changes when a field is focused"

This reverts commit 77318515062e22c6dbcb5b4ae8c6daa4ef70d5b9.

Reason for revert:
This change caused a regression (crbug.com/860225). The cause of the regression is that when user focuses a field in order to edit it, Autofill::OnFormsSeen is called which in turn updates the cached form with the new user entered values. Once submitted, form values are discarded as they're thought to be the initial form values on page load. In its cu
...skip...
>
> Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570713}

TBR=olivierrobin@chromium.org,mahmadi@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 855696, 860225
Change-Id: Icc39e67e6d502d75451dbec83d6271255639ee4c
Reviewed-on: https://chromium-review.googlesource.com/1135671
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574698}

    Changed files

    • components/autofill/ios/browser/autofill_agent.mm

  5. Remove assertion from DetachToOwnWindow on macOS 10.10.

    Changed by erikchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:16:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b20bb048913985eae71b480db2a2017173ef73a2

    Comments

    Remove assertion from DetachToOwnWindow on macOS 10.10.

On macOS 10.10, AppKit appears to use the test's generated events to
asynchronously reactivate the first window. There's no way to tell when this
asynchronous reactivation will happen, so just avoid checking the assertion in
the test. This problem appears constrained to how we generate test events, and
not to the actual behavior of Chrome.

Bug: 862859
Change-Id: Ibab56946bef3aea9aac3123d3d8aefdb7974d063
Reviewed-on: https://chromium-review.googlesource.com/1135305
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574699}

    Changed files

    • chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

  6. Migrate PrivetTrafficDetector to use NetworkConnectionTracker.

    Changed by rmcelrathohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:20:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9b78521765f33993e81dfba771127fe9d5eb4add

    Comments

    Migrate PrivetTrafficDetector to use NetworkConnectionTracker.

This migrates PrivetTrafficDetector from using
net::NetworkChangeNotifier to content::NetworkConnectionTracker, which
works with the network service enabled.

Bug: 859134
Change-Id: I06f2ecbe142bbed9a8772f69ab109b0c0dc32581
Reviewed-on: https://chromium-review.googlesource.com/1123681
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574700}

    Changed files

    • chrome/browser/printing/cloud_print/privet_traffic_detector.cc
    • chrome/browser/printing/cloud_print/privet_traffic_detector.h

  7. Reset listener properties after provisional load

    Changed by ekaramadohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:25:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8afd07cc1159e077da359175edefd419a090fb7d

    Comments

    Reset listener properties after provisional load

When provisional load is committed in FrameLoader and the corresponding
frame is a LocalRoot, the EventListenerProperties are reset to none for
touch and wheel listeners. This update is then propagate through render
widget and LayterTreeHost to the browser and the CC correspondingly.

However, if the local root is provisional the call is dropped in
ChromeClientImpl. This would include all cross-process navigations which
end up in a provisional frame.

This change will make sure the initial updates for
EventListenerProperties for a local root are sent after
WebLocalFrameClient is notified about committing provisional load.

Bug: 850994
Change-Id: I686ab51277bf675d93bd744d6d0208977ac06b5c
Reviewed-on: https://chromium-review.googlesource.com/1126329
Commit-Queue: Ehsan Karamad <ekaramad@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574701}

    Changed files

    • content/browser/renderer_host/input/input_router_impl.h
    • content/browser/renderer_host/render_widget_host_browsertest.cc
    • third_party/blink/renderer/core/exported/local_frame_client_impl.cc
    • third_party/blink/renderer/core/loader/frame_loader.cc

  8. Record when a user presses Enter on a web page.

    Changed by uwyimingohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 20:28:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fb5a18d97233f6a11c4606fa3b085d2b7ba0ff11

    Comments

    Record when a user presses Enter on a web page.

This change adds a feature that allows the Action Recorder Extension to
detect when a user presses the Enter key on a page, and records this
action. Pressing the Enter key is a common action that a user invokes to
submit a form.

Bug: 855284
Change-Id: Ia0ec4ab99683266f09a422a4f7ae24fe52eb0b0b
Reviewed-on: https://chromium-review.googlesource.com/1135523
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574702}

    Changed files

    • components/test/data/autofill/automated_integration/action_recorder_extension/content/action_handler.js
    • components/test/data/autofill/automated_integration/action_recorder_extension/content/panel.js

  9. Android: Do not generate R.java from android_apk AndroidManifest.xml

    Changed by tiborgohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:29:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 01020f3bca281b6de9bd9deacbe849cbc1255cfa

    Comments

    Android: Do not generate R.java from android_apk AndroidManifest.xml

In order to implement synchronized proguarding we cannot have multiple
R class with the same package. Thus, prevent creation of R files with
manifest's package when creating APKs.

Bug: 862696
Change-Id: I51253c0434f18e19ea627710beaa85b8690b175c
Reviewed-on: https://chromium-review.googlesource.com/1134414
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574703}

    Changed files

    • build/android/gyp/compile_resources.py
    • build/android/gyp/util/resource_utils.py

  10. Import wpt@df05bcb7c5c82e300805d7c11121453ec4036e32

    Changed by blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:29:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e40e820481f52c0cc29b1841542b4e24465909bd

    Comments

    Import wpt@df05bcb7c5c82e300805d7c11121453ec4036e32

Using wpt-import in Chromium a7edd65b959ed3edbb808bd0bd2c914e5a92cfff.
With Chromium commits locally applied on WPT:
a9045946af "Add a fail-fast for longtask layouttests"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21190

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectatio
...skip...
googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org, mek@chromium.org:
  external/wpt/FileAPI

TBR=foolip

No-Export: true
Change-Id: I99e9ecbe3e626ec461f4663c7d48a6896f6a9616
Reviewed-on: https://chromium-review.googlesource.com/1135585
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574704}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json
    • third_party/WebKit/LayoutTests/external/wpt/FileAPI/idlharness.html
    • third_party/WebKit/LayoutTests/external/wpt/FileAPI/idlharness.worker.js

  11. Update Flash plugin metadata versions to latest version.

    Changed by wfhohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:31:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e233c1d178562ac6171d190f1e4d9ec9a94ac11e

    Comments

    Update Flash plugin metadata versions to latest version.

https://helpx.adobe.com/security/products/flash-player/apsb18-24.html

BUG=412078
TBR=jschuh@chromium.org

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Iecc32fe539d6d16418086f9d8b4e44fde19bdd69
Reviewed-on: https://chromium-review.googlesource.com/1135713
Commit-Queue: Will Harris <wfh@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574705}

    Changed files

    • chrome/browser/resources/plugin_metadata/plugins_linux.json
    • chrome/browser/resources/plugin_metadata/plugins_mac.json
    • chrome/browser/resources/plugin_metadata/plugins_win.json

  12. Stop using ResourceContext::GetHostResolver().

    Changed by jamohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:32:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ed5e651e10cd158bf786b33c0dcd77d714244d2e

    Comments

    Stop using ResourceContext::GetHostResolver().

ResourceContext is deprecated, and after r567879 it returns nullptr when network service is enabled.

Instead get the HostResolver from the URLRequestContext. Also remove ResourceContext::GetHostResolver() as it's no longer used.

Bug: 853696
Change-Id: Ic09dac09f14e4aaf0e20dd990246cc51ae35e933
Reviewed-on: https://chromium-review.googlesource.com/1135366
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574706}

    Changed files

    • android_webview/browser/aw_resource_context.cc
    • android_webview/browser/aw_resource_context.h
    • chrome/browser/profiles/profile_io_data.cc
    • chrome/browser/profiles/profile_io_data.h
    • chromecast/browser/cast_browser_context.cc
    • content/browser/renderer_host/p2p/socket_dispatcher_host.cc
    • content/browser/renderer_host/p2p/socket_dispatcher_host.h
    • content/browser/renderer_host/pepper/pepper_host_resolver_message_filter.cc
    • content/browser/renderer_host/pepper/pepper_host_resolver_message_filter.h
    • content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc
    • content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.h
    • content/browser/renderer_host/render_process_host_impl.cc
    • content/public/browser/resource_context.h
    • content/public/test/mock_resource_context.cc
    • content/public/test/mock_resource_context.h
    • content/shell/browser/shell_browser_context.cc
    • content/shell/browser/shell_browser_context.h
    • content/shell/browser/shell_url_request_context_getter.cc
    • content/shell/browser/shell_url_request_context_getter.h
    • extensions/browser/api/dns/dns_api.cc
    • extensions/browser/api/dns/dns_api.h
    • extensions/browser/api/dns/host_resolver_wrapper.cc
    • extensions/browser/api/dns/host_resolver_wrapper.h
    • extensions/browser/api/socket/socket_api.cc
    • extensions/browser/api/socket/socket_api.h
    • headless/lib/browser/headless_browser_context_impl.cc
    • webrunner/browser/webrunner_browser_context.cc

  13. Clone service worker objects to nested workers

    Changed by japhetohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:36:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 62cb57146b83dcd0b2b2add48c4cfe02b3d770b9

    Comments

    Clone service worker objects to nested workers

Bug: 31666
Change-Id: I8db30dee7c6b72430eb4083536fca73606de76e8
Reviewed-on: https://chromium-review.googlesource.com/1130101
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574707}

    Changed files

    • content/renderer/loader/web_worker_fetch_context_impl.cc
    • content/renderer/loader/web_worker_fetch_context_impl.h
    • content/renderer/render_frame_impl.cc
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/claim-worker-fetch.https-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/claim-worker-fetch.https.html
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/claim-nested-worker-fetch-iframe.html
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/claim-nested-worker-fetch-parent-worker.js
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/nested_load_worker.js
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/worker-interception-iframe.https.html

  14. Implemented headless compositor protocol tests for basic rAF, GIF and CSS animations. (III)

    Changed by kvitekpohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:37:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dcd804265b610b002db7023e6c180bd12e1e29bb

    Comments

    Implemented headless compositor protocol tests for basic rAF, GIF and CSS animations. (III)

Browser flags that are required for BeginFrameControl are now set only
for compositor specific tests thus preventing virtual time flakyness.

Reinstate VirtualTimeErrorLoop test since this change fixes its
flakiness.

Change-Id: I0b01a81df1b8be63da316b27f7404f929f1e0fd1
Reviewed-on: https://chromium-review.googlesource.com/1133711
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574708}

    Changed files

    • headless/test/DEPS
    • headless/test/data/protocol/emulation/compositor-basic-raf-expected.txt
    • headless/test/data/protocol/emulation/compositor-basic-raf.js
    • headless/test/data/protocol/emulation/compositor-css-animation-test-expected.txt
    • headless/test/data/protocol/emulation/compositor-css-animation-test.js
    • headless/test/data/protocol/emulation/compositor-image-animation-test-expected.txt
    • headless/test/data/protocol/emulation/compositor-image-animation-test.js
    • headless/test/data/protocol/emulation/resources/animated_square.gif
    • headless/test/data/protocol/emulation/resources/compositor-basic-raf.html
    • headless/test/data/protocol/emulation/resources/compositor-css-animation.html
    • headless/test/data/protocol/emulation/resources/compositor-image-animation.html
    • headless/test/headless_protocol_browsertest.cc

  15. [Autofill] Log metric for whether card upload cardholder name was edited

    Changed by jsaulohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 20:40:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1447fae2e377e748f4ddb532a99f6c5ba7319c98

    Comments

    [Autofill] Log metric for whether card upload cardholder name was edited

Bug: 848955
Change-Id: I8febd9c3471b58b962d3706eede4be506b092044
Reviewed-on: https://chromium-review.googlesource.com/1134089
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#574709}

    Changed files

    • chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
    • chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
    • components/autofill/core/browser/autofill_metrics.cc
    • components/autofill/core/browser/autofill_metrics.h
    • tools/metrics/histograms/histograms.xml

  16. Change RulesMonitorService::HasRegisteredRuleset to take an extension_id.

    Changed by karandeepbohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:47:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b96ae12ef5fa70c2389e5b23da5a924eb4dff359

    Comments

    Change RulesMonitorService::HasRegisteredRuleset to take an extension_id.

This CL changes RulesMonitorService::HasRegisteredRuleset to take an
extension_id instead of an extension pointer.

BUG=None

Change-Id: If6d220b7bcaf9be473ff819961f5ed9fe67f681f
Reviewed-on: https://chromium-review.googlesource.com/1134519
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574710}

    Changed files

    • extensions/browser/api/declarative_net_request/declarative_net_request_api.cc
    • extensions/browser/api/declarative_net_request/rules_monitor_service.cc
    • extensions/browser/api/declarative_net_request/rules_monitor_service.h

  17. Use UMA_HISTOGRAM_TIMES or saturated_cast to report milliseconds

    Changed by npmohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:49:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3e44f3be427bb7222e8e20640e261d620478e8bc

    Comments

    Use UMA_HISTOGRAM_TIMES or saturated_cast to report milliseconds

This CL changes Blink code from using Count(delta.InMilliseconds()) to:
* UMA_HISTOGRAM_TIMES where possible.
* Otherwise, UMA_HISTOGRAM_CUSTOM_COUNTS if possible.
* Otherwise, saturated_cast.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I4f6e2ae0fb318b906ec75c546bea519cd130b09e
Reviewed-on: https://chromium-review.googlesource.com/1134083
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574711}

    Changed files

    • third_party/blink/renderer/core/editing/spellcheck/spell_check_requester.cc
    • third_party/blink/renderer/core/html/media/autoplay_uma_helper.cc
    • third_party/blink/renderer/core/html/parser/css_preload_scanner.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_timeline_metrics.cc
    • third_party/blink/renderer/modules/notifications/notification_image_loader.cc
    • third_party/blink/renderer/platform/heap/heap_stats_collector.cc
    • third_party/blink/renderer/platform/heap/heap_stats_collector.h
    • third_party/blink/renderer/platform/heap/heap_stats_collector_test.cc
    • third_party/blink/renderer/platform/heap/thread_state.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc