Home | Search
Login

Builder Android Cronet Builder Asan Build #8154 Canonical Ubuntu

Results:

build successful exception update_scripts

Trigger Info:

Execution:

Steps and Logfiles:

Show:
  1. ( 43 mins 25 secs ) steps
    running steps via annotated script
  2. ( 2 mins ) update_scripts
    update_scripts
    gclient sync failed!
  3. ( 6 ms ) LUCI Migration
    LUCI Migration
  4. ( 4 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 5 ms ) setup_build
    setup_build
    running recipe: "cronet"
  6. ( 4 ms ) cleanup index.lock
    cleanup index.lock
  7. ( 10 mins 42 secs ) bot_update
    bot_update
    [53GB/442GB used (11%)]
  8. ( 4 ms ) clean local files
    clean local files
  9. ( 3 ms ) ensure_goma
    ensure_goma
  10. ( 4 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  11. ( 3 ms ) clobber
    clobber
  12. ( 1 mins 29 secs ) gclient runhooks
    gclient runhooks
  13. ( 5 ms ) lookup GN args
    lookup GN args
     
    Count of GN args (24) exceeds limit (15), presented in logs instead
  14. ( 15 secs ) generate_build_files
    generate_build_files
  15. ( 5 ms ) clang_revision
    clang_revision
  16. ( 3 ms ) preprocess_for_goma
    preprocess_for_goma
  17. ( 3 ms ) preprocess_for_goma.goma cache directory
    preprocess_for_goma.goma cache directory
  18. ( 6 secs ) preprocess_for_goma.start_goma
    preprocess_for_goma.start_goma
  19. ( 4 ms ) preprocess_for_goma.start cloudtail
    preprocess_for_goma.start cloudtail
  20. ( 5 mins 2 secs ) compile
    compile
  21. ( 3 ms ) compile confirm no-op
    compile confirm no-op
  22. ( 1 ms ) postprocess_for_goma
    postprocess_for_goma
  23. ( 4 ms ) postprocess_for_goma.goma_jsonstatus
    postprocess_for_goma.goma_jsonstatus
  24. ( 3 ms ) postprocess_for_goma.goma_stat
    postprocess_for_goma.goma_stat
  25. ( 3 ms ) postprocess_for_goma.stop_goma
    postprocess_for_goma.stop_goma
  26. ( 6 secs ) postprocess_for_goma.upload_log
    postprocess_for_goma.upload_log
  27. ( 1 ms ) postprocess_for_goma.stop cloudtail
    postprocess_for_goma.stop cloudtail
  28. ( 1 ms ) get version
    get version
  29. ( 1 ms ) create adb symlink
    create adb symlink
  30. ( 1 ms ) spawn_logcat_monitor
    spawn_logcat_monitor
  31. ( 1 ms ) spawn_device_monitor
    spawn_device_monitor
  32. ( 1 ms ) authorize_adb_devices
    authorize_adb_devices
  33. ( 9 secs ) device_recovery
    device_recovery
  34. ( 2 mins 34 secs ) provision_devices
    provision_devices
  35. ( 9 ms ) device_status
    device_status
    Online devices: 4
  36. ( 3 ms ) get_clang_version
    get_clang_version
  37. ( 4 ms ) Set up ASAN on devices
    Set up ASAN on devices
  38. ( 4 ms ) Set up ASAN on devices.List adb devices
    Set up ASAN on devices.List adb devices
  39. ( 4 ms ) Set up ASAN on devices.Root devices
    Set up ASAN on devices.Root devices
  40. ( 3 ms ) Set up ASAN on devices.0aa6b19043e4b976
    Set up ASAN on devices.0aa6b19043e4b976
  41. ( 3 ms ) Set up ASAN on devices.06596466005cab1a
    Set up ASAN on devices.06596466005cab1a
  42. ( 3 ms ) Set up ASAN on devices.05c34aa83444c162
    Set up ASAN on devices.05c34aa83444c162
  43. ( 5 secs ) Set up ASAN on devices.0accc2af43e4affc
    Set up ASAN on devices.0accc2af43e4affc
  44. ( 12 secs ) Set up ASAN on devices.wait_for_devices
    Set up ASAN on devices.wait_for_devices
  45. ( 43 secs ) cronet_unittests_android
    cronet_unittests_android
  46. ( 10 mins 43 secs ) net_unittests
    net_unittests
  47. ( 16 secs ) cronet_sample_test_apk
    cronet_sample_test_apk
  48. ( 4 ms ) cronet_sample_test_apk: generate result details
    cronet_sample_test_apk: generate result details
  49. ( 18 secs ) cronet_smoketests_missing_native_library_instrumentation_apk
    cronet_smoketests_missing_native_library_instrumentation_apk
  50. ( 4 ms ) cronet_smoketests_missing_native_library_instrumentation_apk: generate result details
    cronet_smoketests_missing_native_library_instrumentation_apk: generate result details
  51. ( 15 secs ) cronet_smoketests_platform_only_instrumentation_apk
    cronet_smoketests_platform_only_instrumentation_apk
  52. ( 3 ms ) cronet_smoketests_platform_only_instrumentation_apk: generate result details
    cronet_smoketests_platform_only_instrumentation_apk: generate result details
  53. ( 5 mins 8 secs ) cronet_test_instrumentation_apk
    cronet_test_instrumentation_apk
  54. ( 4 ms ) cronet_test_instrumentation_apk: generate result details
    cronet_test_instrumentation_apk: generate result details
  55. ( 3 ms ) shutdown_device_monitor
    shutdown_device_monitor
  56. ( 3 ms ) logcat_dump
    logcat_dump
  57. ( 3 ms ) gsutil upload
    gsutil upload
  58. ( 26 secs ) stack_tool_with_logcat_dump
    stack_tool_with_logcat_dump
  59. ( 4 ms ) stack_tool_for_tombstones
    stack_tool_for_tombstones
  60. ( 1 mins 3 secs ) stack_tool_for_asan
    stack_tool_for_asan
  61. ( 4 ms ) Tear down ASAN on devices
    Tear down ASAN on devices
  62. ( 4 ms ) Tear down ASAN on devices.0aa6b19043e4b976
    Tear down ASAN on devices.0aa6b19043e4b976
  63. ( 3 ms ) Tear down ASAN on devices.06596466005cab1a
    Tear down ASAN on devices.06596466005cab1a
  64. ( 3 ms ) Tear down ASAN on devices.05c34aa83444c162
    Tear down ASAN on devices.05c34aa83444c162
  65. ( 3 ms ) Tear down ASAN on devices.0accc2af43e4affc
    Tear down ASAN on devices.0accc2af43e4affc
  66. ( 13 secs ) Tear down ASAN on devices.wait_for_devices
    Tear down ASAN on devices.wait_for_devices
  67. ( 5 ms ) test_report
    test_report
  68. ( 4 ms ) recipe result
    recipe result

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromium/bb/chromium.android/Android_Cronet_Builder_Asan/8154/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.android/Android_Cronet_Builder_Asan/8154" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" Annotation(bot_update)
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" Annotation(bot_update)
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" Annotation(bot_update)
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" Annotation(bot_update)
got_src_revision "f513b7c0c1803fe4688b8eee2dab06f48dabf081" Annotation(bot_update)
got_src_revision_cp "refs/heads/master@{#606864}" Annotation(bot_update)
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" Annotation(bot_update)
got_v8_revision "31b2546b348e864539ade15897eac971b3c0e402" Annotation(bot_update)
got_v8_revision_cp "refs/heads/7.2.286@{#1}" Annotation(bot_update)
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#25544}" Annotation(bot_update)
got_clang_revision "346388-1" Annotation(clang_revision)
build_data_dir "/b/rr/tmpswtfkA" Annotation(steps)
build_id "buildbot/chromium.android/Android Cronet Builder Asan/8154" Annotation(steps)
builder_id "master.chromium.android:Android Cronet Builder Asan" Annotation(steps)
blamelist ["aaronhk@google.com","andruud@chromium.org","chromium-autoroll@skia-public.iam.gserviceaccount.com","chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com","cwallez@chromium.org","djean@google.com","dtapuska@chromium.org","eugenebut@google.com","fserb@chromium.org","grt@chromium.org","guidou@chromium.org","hiroshige@chromium.org","ioanap@chromium.org","lsuder@google.com","nektar@chromium.org","pshmakov@google.com","rayankans@google.com","reed@google.com","rohitrao@chromium.org","siggi@chromium.org","smaier@chromium.org","thakis@chromium.org","timvolodine@chromium.org","tonikitoo@igalia.com","treib@chromium.org","vasilii@chromium.org","wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com"] Build
branch "master" Build
buildnumber 8154 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1541774007 Build
revision "f513b7c0c1803fe4688b8eee2dab06f48dabf081" Build
slavename "build69-b1" BuildSlave
buildername "Android Cronet Builder Asan" Builder
git_revision "f513b7c0c1803fe4688b8eee2dab06f48dabf081" Change
scheduler "chromium_commits" Scheduler
buildbotURL "https://build.chromium.org/p/chromium.android/" master.cfg
mastername "chromium.android" master.cfg
workdir "/b/build/slave/Android_Cronet_Builder_Asan" slave

Blamelist:

  1. (treibohnoyoudont@chromium.org)
  2. (reedohnoyoudont@google.com)
  3. (siggiohnoyoudont@chromium.org)
  4. (rohitraoohnoyoudont@chromium.org)
  5. (hiroshigeohnoyoudont@chromium.org)
  6. (smaierohnoyoudont@chromium.org)
  7. (ioanapohnoyoudont@chromium.org)
  8. (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  9. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  10. (cwallezohnoyoudont@chromium.org)
  11. (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  12. (grtohnoyoudont@chromium.org)
  13. (lsuderohnoyoudont@google.com)
  14. (dtapuskaohnoyoudont@chromium.org)
  15. (andruudohnoyoudont@chromium.org)
  16. (hiroshigeohnoyoudont@chromium.org)
  17. (andruudohnoyoudont@chromium.org)
  18. (treibohnoyoudont@chromium.org)
  19. (aaronhkohnoyoudont@google.com)
  20. (djeanohnoyoudont@google.com)
  21. (rayankansohnoyoudont@google.com)
  22. (timvolodineohnoyoudont@chromium.org)
  23. (pshmakovohnoyoudont@google.com)
  24. (eugenebutohnoyoudont@google.com)
  25. (eugenebutohnoyoudont@google.com)
  26. (guidouohnoyoudont@chromium.org)
  27. (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  28. (nektarohnoyoudont@chromium.org)
  29. (thakisohnoyoudont@chromium.org)
  30. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  31. (fserbohnoyoudont@chromium.org)
  32. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  33. (vasiliiohnoyoudont@chromium.org)
  34. (tonikitooohnoyoudont@igalia.com)

Timing:

Create N/A
Start Friday, 09-Nov-18 16:29:58 UTC
End Friday, 09-Nov-18 17:13:24 UTC
Pending N/A
Execution 43 mins 25 secs

All Changes:

  1. PersonalDataManager: Rename AccountStorageForServer(Cards->Data)

    Changed by treibohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:31:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 41c87263ae4560b264e15ec45be4832be2e79e86

    Comments

    PersonalDataManager: Rename AccountStorageForServer(Cards->Data)
    
    The account storage is now used for both server cards and server
    addresses.
    
    Bug: 864519
    Change-Id: Ia5fb5ebc4bd4e334b162378923ccd04562d4cac9
    Reviewed-on: https://chromium-review.googlesource.com/c/1329241
    Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606831}

    Changed files

    • chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
    • components/autofill/core/browser/personal_data_manager.cc
    • components/autofill/core/browser/personal_data_manager.h
  2. use SkFontHinting

    Changed by reedohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 14:32:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a6d7fa9a9e6b3fe2c1c33cb52460998b0a991cf

    Comments

    use SkFontHinting
    
    Bug: skia:2664
    Change-Id: I22633705f2f21f95a223a193a1437d2311e5e205
    Reviewed-on: https://chromium-review.googlesource.com/c/1318416
    Commit-Queue: Mike Reed <reed@google.com>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Reviewed-by: Bill Budge <bbudge@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606832}

    Changed files

    • cc/paint/oop_pixeltest.cc
    • cc/paint/paint_flags.cc
    • cc/paint/paint_flags.h
    • chrome/renderer/pepper/pepper_flash_renderer_host.cc
    • content/renderer/render_view_fuchsia.cc
    • content/renderer/render_view_linux.cc
    • skia/config/SkUserConfig.h
    • third_party/blink/public/platform/web_font_render_style.h
    • third_party/blink/renderer/platform/fonts/font_metrics.cc
    • third_party/blink/renderer/platform/fonts/mac/font_platform_data_mac.mm
    • third_party/blink/renderer/platform/fonts/web_font_render_style.cc
    • third_party/blink/renderer/platform/graphics/logging_canvas.cc
  3. RC: Compress all chrome://discards resources.

    Changed by siggiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:35:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e826ee9592541ae9d53fd23c51761adf9df17cfc

    Comments

    RC: Compress all chrome://discards resources.
    
    I don't know whether to trust these numbers, but this is what I see
    for my local Windows release 32 bit build.
    
    Uncompressed:
    3,034,139 browser_resources.pak
    233,038,336 mini_installer.exe
    
    Compressed:
    2,869,382 browser_resources.pak
    232,873,472 mini_installer.exe
    
    Bug: 891310
    Change-Id: I3db92ad65afc97b80a9acfbd2fabf486739d7822
    Reviewed-on: https://chromium-review.googlesource.com/c/1327406
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606833}

    Changed files

    • chrome/browser/browser_resources.grd
    • chrome/browser/ui/webui/discards/discards_ui.cc
  4. [ios] Deletes unused code that was migrated from ios/clean.

    Changed by rohitraoohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:41:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6e3ace0051b91c7144046c60acd04c7d658c9b09

    Comments

    [ios] Deletes unused code that was migrated from ios/clean.
    
    BUG=None
    
    Change-Id: I3a14f465f152e9b1b514802723093e9702edc001
    Reviewed-on: https://chromium-review.googlesource.com/c/1326487
    Reviewed-by: edchin <edchin@chromium.org>
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: edchin <edchin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606834}

    Changed files

    • ios/chrome/browser/browser_state/BUILD.gn
    • ios/chrome/browser/browser_state/browser_state_keyed_service_factories.mm
    • ios/chrome/browser/ui/coordinators/BUILD.gn
    • ios/chrome/browser/ui/coordinators/browser_coordinator+internal.h
    • ios/chrome/browser/ui/coordinators/browser_coordinator.h
    • ios/chrome/browser/ui/coordinators/browser_coordinator.mm
    • ios/chrome/browser/ui/coordinators/browser_coordinator_test.h
    • ios/chrome/browser/ui/coordinators/browser_coordinator_test.mm
    • ios/chrome/browser/ui/coordinators/browser_coordinator_test_util.h
    • ios/chrome/browser/ui/coordinators/browser_coordinator_test_util.mm
    • ios/chrome/browser/ui/coordinators/browser_coordinator_unittest.mm
    • ios/chrome/browser/ui/coordinators/test_browser_coordinator.h
    • ios/chrome/browser/ui/coordinators/test_browser_coordinator.mm
    • ios/chrome/browser/ui/main_content/BUILD.gn
    • ios/chrome/browser/ui/main_content/main_content_coordinator.h
    • ios/chrome/browser/ui/main_content/main_content_coordinator.mm
    • ios/chrome/browser/ui/main_content/main_content_coordinator_unittest.mm
    • ios/chrome/browser/ui/overlays/BUILD.gn
    • ios/chrome/browser/ui/overlays/OWNERS
    • ios/chrome/browser/ui/overlays/browser_overlay_queue.h
    • ios/chrome/browser/ui/overlays/browser_overlay_queue.mm
    • ios/chrome/browser/ui/overlays/overlay_coordinator+internal.h
    • ios/chrome/browser/ui/overlays/overlay_coordinator.h
    • ios/chrome/browser/ui/overlays/overlay_coordinator.mm
    • ios/chrome/browser/ui/overlays/overlay_queue.h
    • ios/chrome/browser/ui/overlays/overlay_queue.mm
    • ios/chrome/browser/ui/overlays/overlay_queue_manager.h
    • ios/chrome/browser/ui/overlays/overlay_queue_manager.mm
    • ios/chrome/browser/ui/overlays/overlay_queue_manager_observer.h
    • ios/chrome/browser/ui/overlays/overlay_queue_manager_unittest.mm
    • ios/chrome/browser/ui/overlays/overlay_queue_observer.h
    • ios/chrome/browser/ui/overlays/overlay_queue_unittest.mm
    • ios/chrome/browser/ui/overlays/overlay_scheduler.h
    • ios/chrome/browser/ui/overlays/overlay_scheduler.mm
    • ios/chrome/browser/ui/overlays/overlay_scheduler_observer.h
    • ios/chrome/browser/ui/overlays/overlay_scheduler_unittest.mm
    • ios/chrome/browser/ui/overlays/overlay_service.h
    • ios/chrome/browser/ui/overlays/overlay_service_factory.h
    • ios/chrome/browser/ui/overlays/overlay_service_factory.mm
    • ios/chrome/browser/ui/overlays/overlay_service_impl.h
    • ios/chrome/browser/ui/overlays/overlay_service_impl.mm
    • ios/chrome/browser/ui/overlays/overlay_service_observer.h
    • ios/chrome/browser/ui/overlays/overlay_service_observer_bridge.h
    • ios/chrome/browser/ui/overlays/overlay_service_observer_bridge.mm
    • ios/chrome/browser/ui/overlays/test/BUILD.gn
    • ios/chrome/browser/ui/overlays/test/overlay_coordinator_test.h
    • ios/chrome/browser/ui/overlays/test/overlay_coordinator_test.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_coordinator.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_coordinator.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_parent_coordinator.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_parent_coordinator.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue_manager_observer.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue_manager_observer.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue_observer.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue_observer.mm
    • ios/chrome/browser/ui/overlays/web_state_overlay_queue.h
    • ios/chrome/browser/ui/overlays/web_state_overlay_queue.mm
    • ios/chrome/test/BUILD.gn
  5. Enable multiple WorkerFetchContext per one global scope

    Changed by hiroshigeohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:46:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7ede5922f5c054c81b5ea049651775ab0503582c

    Comments

    Enable multiple WorkerFetchContext per one global scope
    
    Currently WorkerFetchContext has the ownership of
    some objects originated from WebWorkerFetchContext.
    To create multiple WorkerFetchContexts
    for one WorkerOrWorkletGlobalScope/WebWorkerFetchContext,
    this CL moves these ownership outside WorkerFetchContext.
    Namely,
    - url_loader_factory_ and script_loader_factory_
      from WorkerFetchContext to WebWorketFetchContext subclasses, and
    - subresource_filter_ from WorkerFetchContext to
      WorkerOrWorkletGl
    ...skip...
    eated,
    while previously it was created when
    WorkerFetchContext::CreateURLLoader() is called for the first time.
    
    Bug: 880027, 903579
    Change-Id: I84a8bafee25b7f293201a271d198260e2dfb8e68
    Reviewed-on: https://chromium-review.googlesource.com/c/1193385
    Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606835}

    Changed files

    • content/renderer/loader/web_worker_fetch_context_impl.cc
    • content/renderer/loader/web_worker_fetch_context_impl.h
    • content/renderer/service_worker/service_worker_fetch_context_impl.cc
    • content/renderer/service_worker/service_worker_fetch_context_impl.h
    • third_party/blink/public/platform/web_worker_fetch_context.h
    • third_party/blink/renderer/core/loader/worker_fetch_context.cc
    • third_party/blink/renderer/core/loader/worker_fetch_context.h
    • third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
    • third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.h
  6. Apk for test proguard flags ignoring classes which don't exist

    Changed by smaierohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:50:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b4fffd63b4281c67f7e142087c476ce903a5a08a

    Comments

    Apk for test proguard flags ignoring classes which don't exist
    
    Bug: 872904
    Change-Id: Ib178be906c8d74ecabd7cfafeba8e7cf3a3398ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1327331
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Reviewed-by: Sam Maier <smaier@chromium.org>
    Commit-Queue: Sam Maier <smaier@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606836}

    Changed files

    • chrome/android/java/apk_for_test.flags
  7. Add a provider for the Passwords UI in Settings

    Changed by ioanapohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:51:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision feda313fc19c2032e21eed604a1a0e58d42587ee

    Comments

    Add a provider for the Passwords UI in Settings
    
    This CL introduces ManagePasswordsUIProvider, a class which aims to allow
    for alternative UI surfaces to be shown if available.
    
    Bug: 903249
    Change-Id: I8c03f2f539772044bd5ba0fa944fd5e441d43c76
    Reviewed-on: https://chromium-review.googlesource.com/c/1326488
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Ioana Pandele <ioanap@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606837}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java
    • chrome/android/java/src/org/chromium/chrome/browser/password_manager/ManagePasswordsUIProvider.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
    • chrome/android/java_sources.gni
  8. Roll src-internal c458532c0628..6166365225d6 (2 commits)

    Changed by chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 14:56:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 02a2080524dcf1a59efd81b88b8a6526fc6224ee

    Comments

    Roll src-internal c458532c0628..6166365225d6 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c458532c0628..6166365225d6
    
    
    Created with:
      gclient setdep -r src-internal@6166365225d6
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I57783466072640b229610c2550d50f9c46d0c4e9
    Reviewed-on: https://chromium-review.googlesource.com/c/1329043
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606838}

    Changed files

    • DEPS
  9. Roll src/third_party/perfetto 606ed681f4ea..fd986312652f (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 15:03:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 01d002523922e64775a90ae4fbcb831f3aebf024

    Comments

    Roll src/third_party/perfetto 606ed681f4ea..fd986312652f (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/606ed681f4ea..fd986312652f
    
    
    git log 606ed681f4ea..fd986312652f --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 hjd@google.com Merge "perfetto-ui: Fix UI with counter only traces"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@fd986312652f
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documenta
    ...skip...
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I602c7205239349ff0faf4467740388c6cb05725f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329044
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606839}

    Changed files

    • DEPS
  10. testing/buildbot: add fake bots to run Dawn's GPU tests.

    Changed by cwallezohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:05:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9f2b5efa43dfe2ff69fab31ba83c352ecf8e62ab

    Comments

    testing/buildbot: add fake bots to run Dawn's GPU tests.
    
    BUG=chromium:901830
    
    Change-Id: I5c5b0b08fadddc34f6a2d176ae39ebfae7e7f706
    Reviewed-on: https://chromium-review.googlesource.com/c/1326157
    Commit-Queue: Corentin Wallez <cwallez@chromium.org>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606840}

    Changed files

    • testing/buildbot/chromium.gpu.fyi.json
    • testing/buildbot/generate_buildbot_json.py
    • testing/buildbot/gn_isolate_map.pyl
    • testing/buildbot/test_suites.pyl
    • testing/buildbot/waterfalls.pyl
  11. Import wpt@47f0061f15dd2973dab11d87c03f0c8264d32e02

    Changed by wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 15:09:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c42eb303c89bfba751ae499abfb7252e2ceb7532

    Comments

    Import wpt@47f0061f15dd2973dab11d87c03f0c8264d32e02
    
    Using wpt-import in Chromium 43d0eed3db77a5e6167b5ebbf6ecb3710790272a.
    With Chromium commits locally applied on WPT:
    270d4abddc "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content."
    
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExp
    ...skip...
    an reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    NOAUTOREVERT=true
    TBR=foolip
    
    No-Export: true
    Change-Id: I4bcac484d08efe8d6e6412d40b1c7d73ffe512d5
    Reviewed-on: https://chromium-review.googlesource.com/c/1329061
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606841}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/selection-api.idl
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/webrtc.idl
    • third_party/WebKit/LayoutTests/external/wpt/webrtc/idlharness.https.window-expected.txt
    • third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/idlharness.https.window-expected.txt
  12. Fix the icons for the app menu and the upgrade item in it when an update is available.

    Changed by grtohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:12:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a5a766d75a0eb8006212cb5cee94d704650c787b

    Comments

    Fix the icons for the app menu and the upgrade item in it when an update is available.
    
    A regression was introduced in r581520 that caused the wrong icon and/or
    the wrong coloring to be used in some circumstances. This CL fixes this
    in two parts:
    
    - AppMenuIconController may decide that the "annoyance level" from a
      pending update is too low to bother the user. One bug introduced in
      r581520 was that the controller still notified delegates that the
      UPGRADE_NOTIFICATION icon type should be used in 
    ...skip...
    nu
      item directly on the UpgradeDetector. Rather, it now queries the
      AppMenuIconController. This ensures that the same logic is used for
      both the badging of the app menu and for the presence of the upgrade
      item in the menu.
    
    BUG=898958
    
    Change-Id: I4b761844365968a24bc69030d711122fcaf16e28
    Reviewed-on: https://chromium-review.googlesource.com/c/1312475
    Commit-Queue: Greg Thompson <grt@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606842}

    Changed files

    • chrome/browser/ui/toolbar/app_menu_icon_controller.cc
    • chrome/browser/ui/toolbar/app_menu_icon_controller.h
    • chrome/browser/ui/toolbar/app_menu_icon_controller_unittest.cc
    • chrome/browser/ui/toolbar/app_menu_model.cc
    • chrome/browser/ui/toolbar/app_menu_model.h
    • chrome/browser/ui/toolbar/app_menu_model_unittest.cc
    • chrome/browser/ui/views/toolbar/browser_app_menu_button.cc
    • chrome/browser/ui/views/toolbar/browser_app_menu_button.h
    • chrome/browser/ui/views/toolbar/toolbar_view.cc
    • chrome/browser/ui/views/toolbar/toolbar_view.h
    • chrome/test/BUILD.gn
  13. [Autofill Assistant] Fixes Payement Request details bug.

    Changed by lsuderohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:13:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision be08662134b0c40ff6913cf531e2fefed5c2d4d9

    Comments

    [Autofill Assistant] Fixes Payement Request details bug.
    
    Before all details where asked each time.
    
    Bug: 806868
    Change-Id: Ie3a278e2882d4829cfe2c54ac641d10abf5af2e6
    Reviewed-on: https://chromium-review.googlesource.com/c/1329167
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Commit-Queue: Lukasz Suder <lsuder@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606843}

    Changed files

    • components/autofill_assistant/browser/actions/get_payment_information_action.cc
  14. Retire NotificationInlineReplies runtime enabled flag.

    Changed by dtapuskaohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:15:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5395d94feaf7a04c1a7fd9832d3750c636d6dea1

    Comments

    Retire NotificationInlineReplies runtime enabled flag.
    
    NotificationInlineReplies shipped in M70.
    
    BUG=834580
    
    Change-Id: Ibed1612aae4c21a239e9328d7134cd75169c713a
    Reviewed-on: https://chromium-review.googlesource.com/c/1323615
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606844}

    Changed files

    • third_party/blink/renderer/modules/notifications/notification_action.idl
    • third_party/blink/renderer/modules/notifications/notification_event.idl
    • third_party/blink/renderer/modules/notifications/notification_event_init.idl
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  15. Add UseCounter for unknown namespace usage in selectors.

    Changed by andruudohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:21:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3c413c91c21481af23cfb54d742e80fd2b589608

    Comments

    Add UseCounter for unknown namespace usage in selectors.
    
    R=chrishtr@chromium.org
    
    Bug: 901938
    Change-Id: I9e20fe19f2c97b98f8250c6c9914512b5a73d8c7
    Reviewed-on: https://chromium-review.googlesource.com/c/1318891
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606845}

    Changed files

    • third_party/blink/public/platform/web_feature.mojom
    • third_party/blink/renderer/core/css/parser/css_selector_parser.cc
    • third_party/blink/renderer/core/frame/use_counter_test.cc
    • tools/metrics/histograms/enums.xml
  16. Add redirected cases to CSP/import tests in wpt/worklets

    Changed by hiroshigeohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:21:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9ff65400edef4c2d8e8ed01f1e2bd60c1c55aa8c

    Comments

    Add redirected cases to CSP/import tests in wpt/worklets
    
    Also this CL replaces some of empty-worklet-script.js usage
    in CSP tests with empty-worklet-script-with-cors-header.js
    to make sure worklets are rejected due to CSP, not CORS.
    
    Change-Id: Ie463d206254c4c6728a79dae0ad79e4f7e333b92
    Reviewed-on: https://chromium-review.googlesource.com/c/1312146
    Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606846}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/csp-tests.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-insecure-origin-empty-worklet-script.sub.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-insecure-origin-redirected-empty-worklet-script.sub.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-remote-origin-empty-worklet-script.sub.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-remote-origin-redirected-empty-worklet-script.sub.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-tests.js
  17. Fix MergeAndOverrideOnConflict for custom properties.

    Changed by andruudohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:25:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3052bf26cacf33ea7dd70fda7cccb5bebb28cfe9

    Comments

    Fix MergeAndOverrideOnConflict for custom properties.
    
    Utilizing CSSPropertyName, to make the code much nicer.
    
    R=futhark@chromium.org
    
    Change-Id: I10733cabe27cc271eaaf3ecf62fa7713cf74eac3
    Reviewed-on: https://chromium-review.googlesource.com/c/1323650
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606847}

    Changed files

    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/css/css_property_value.cc
    • third_party/blink/renderer/core/css/css_property_value.h
    • third_party/blink/renderer/core/css/css_property_value_set.cc
    • third_party/blink/renderer/core/css/css_property_value_set.h
    • third_party/blink/renderer/core/css/css_property_value_set_test.cc
  18. SyncStandaloneTransport: Add integration test for "Reset Sync" from dashboard

    Changed by treibohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:27:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 413493e0052d3f0537cf96d619849e8acf248658

    Comments

    SyncStandaloneTransport: Add integration test for "Reset Sync" from dashboard
    
    Bug: 856179
    Change-Id: I0fb499c5bb5c0de6df4fa7c2f46d3b0b35f5f0df
    Reviewed-on: https://chromium-review.googlesource.com/c/1326901
    Commit-Queue: Marc Treib <treib@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606848}

    Changed files

    • chrome/browser/sync/test/integration/single_client_standalone_transport_sync_test.cc
    • components/sync/test/fake_server/fake_server.cc
    • components/sync/test/fake_server/fake_server.h
  19. Add RAF tests to blink_perf.canvas benchmark.

    Changed by aaronhkohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:28:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7149ab705c9a7c1c9c57c960c05e2de216680c7d

    Comments

    Add RAF tests to blink_perf.canvas benchmark.
    
    Current canvas benchmarks only measure CPU time.
    Using requestAnimationFrame (raf) in javascript we can
    measure CPU + raster + GPU time. This CL adds a mode to
    blink_perf.py that runs canvas all canvas test in a way
    that takes raster and GPU time into account.
    
    Roughly doubles the duration of `blink_perf.canvas`
    benchmark from ~2 minutes to ~4 minutes on a linux desktop.
    
    Bug: 894043
    Change-Id: I2fdd13af75615802266fa39a01db3e883f2c95bc
    Reviewed-on: https://chromium-review.googlesource.com/c/1300038
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
    Reviewed-by: Fernando Serboncini <fserb@chromium.org>
    Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606849}

    Changed files

    • docs/speed/benchmark/harnesses/blink_perf.md
    • third_party/blink/perf_tests/canvas/OWNERS
    • third_party/blink/perf_tests/canvas/gpu-bound-shader.html
    • third_party/blink/perf_tests/canvas/resources/canvas_runner.js
    • third_party/blink/perf_tests/canvas/sheets-render.html
    • third_party/blink/perf_tests/canvas/upload-webgl-to-texture.html
    • tools/perf/benchmark.csv
    • tools/perf/benchmarks/blink_perf.py
    • tools/perf/contrib/blink_layoutng_perf/blink_layoutng_perf.py
    • tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py
    • tools/perf/contrib/blink_perf_xml_http_request/blink_perf_xml_http_request.py
    • tools/perf/core/shard_maps/android-nexus5x-perf_map.json
    • tools/perf/core/shard_maps/android_nexus5_perf_map.json
    • tools/perf/core/shard_maps/android_nexus5x_webview_perf_map.json
    • tools/perf/core/shard_maps/android_nexus6_webview_perf_map.json
    • tools/perf/core/shard_maps/linux-perf_map.json
    • tools/perf/core/shard_maps/mac-10_12_laptop_low_end-perf_map.json
    • tools/perf/core/shard_maps/mac-10_13_laptop_high_end-perf_map.json
    • tools/perf/core/shard_maps/win-10-perf_map.json
    • tools/perf/core/shard_maps/win_7_nvidia_gpu_perf_map.json
    • tools/perf/core/shard_maps/win_7_perf_map.json
  20. [ios] add manual fallback credit card and address coordinator

    Changed by djeanohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:34:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b02a7719f78de1e78ded7807aa4d139f8c2b77d6

    Comments

    [ios] add manual fallback credit card and address coordinator
    
    And a common base class.
    
    Bug: 845472
    Change-Id: I12999d306804227e605e270c9b4f14bd8ee6a2bb
    Reviewed-on: https://chromium-review.googlesource.com/c/1318914
    Reviewed-by: Eric Noyau <noyau@chromium.org>
    Commit-Queue: David Jean <djean@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606850}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
    • ios/chrome/browser/ui/autofill/manual_fill/address_coordinator.h
    • ios/chrome/browser/ui/autofill/manual_fill/address_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/address_list_delegate.h
    • ios/chrome/browser/ui/autofill/manual_fill/card_coordinator.h
    • ios/chrome/browser/ui/autofill/manual_fill/card_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/card_list_delegate.h
    • ios/chrome/browser/ui/autofill/manual_fill/fallback_coordinator.h
    • ios/chrome/browser/ui/autofill/manual_fill/fallback_coordinator.mm
  21. [Background Fetch] Report uploadTotal in the registration

    Changed by rayankansohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:46:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a2e1006e2f0960cea11264c2cb65c73d0334b90

    Comments

    [Background Fetch] Report uploadTotal in the registration
    
    Also sets up some useful testing helpers for future upload features.
    
    Bug: 774054
    Change-Id: I9aea33086b228357d9a160bd35b0a37ceaa30592
    Reviewed-on: https://chromium-review.googlesource.com/c/1329149
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606851}

    Changed files

    • content/browser/background_fetch/background_fetch_data_manager_unittest.cc
    • content/browser/background_fetch/background_fetch_test_data_manager.cc
    • content/browser/background_fetch/background_fetch_test_data_manager.h
    • content/browser/background_fetch/storage/create_metadata_task.cc
  22. [AW NS] Add CTS test filter for Android WebView

    Changed by timvolodineohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:47:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e57afbcbc0d8a4fff7a9d8df6164bf0f6dcedd75

    Comments

    [AW NS] Add CTS test filter for Android WebView
    
    The idea of this CTS filter is similar to the filter we have for
    instrumentation tests, i.e.
    mojo.fyi.network_webview_instrumentation_test_apk.filter. It contains
    failing tests and their corresponding issues / root causes.
    
    The current filter contains results from a local run for a subset of
    tests (the actual CTS is not running yet). The CTS filter also
    augments the instrumentation test filter for test coverage that is
    missing from instrumentation tests.
    
    BUG=903822,902330,841556
    
    Change-Id: I006744652d8ae0a5755f0084704c9f91542d4f8d
    Reviewed-on: https://chromium-review.googlesource.com/c/1319677
    Commit-Queue: Tim Volodine <timvolodine@chromium.org>
    Reviewed-by: Clark DuVall <cduvall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606852}

    Changed files

    • testing/buildbot/filters/mojo.fyi.network_webview_CTS_test.filter
  23. Refactor Trusted Web Activity UI code to MVC

    Changed by pshmakovohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:56:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3a5daa30c703af7c6e90dd5088cdbd5fdcfdc7d0

    Comments

    Refactor Trusted Web Activity UI code to MVC
    
    The code is restructured according to the high-level MVC picture, but
    low-level details such as view binding mechanism are not used, as
    it seems to be an overkill at this point. We can easily install those
    mechanisms in future should the model become more complicated.
    
    Verification is extracted to TrustedWebActivityVerifier in the
    controller layer. Several controllers observe verification and update
    the model. Several independent Views are observing the changes in the
    model and updating themselves accordingly.
    
    Change-Id: I8882da2d648fcea21b85fd4a1c0568dd00e47113
    Reviewed-on: https://chromium-review.googlesource.com/c/1323069
    Reviewed-by: Peter Conn <peconn@chromium.org>
    Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606853}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/ClientAppDataRegister.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosure.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityOpenTimeRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityUi.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/TrustedWebActivityCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/TrustedWebActivityModel.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/ClientAppDataRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/PersistentNotificationController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityDisclosureController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityOpenTimeRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityToolbarController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityVerifier.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/PersistentNotificationView.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/TrustedWebActivityDisclosureView.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/TrustedWebActivityToolbarView.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/dependency_injection/CustomTabActivityComponent.java
    • chrome/android/java_sources.gni
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosureTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/ClientAppDataRecorderTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityDisclosureControllerTest.java
  24. Update SadTabTabHelper to work with SadTabCoordinator.

    Changed by eugenebutohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:56:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9773a84184a277ad674bbe729aa26677f1f3c800

    Comments

    Update SadTabTabHelper to work with SadTabCoordinator.
    
    SadTabTabHelper now calls sadTabTabHelperDidHide: and
    sadTabTabHelper:didShowForRepeatedFailure:
    
    Bug: 901563
    Change-Id: If2b75702c951c247d44368b681ce360bbb6464d5
    Reviewed-on: https://chromium-review.googlesource.com/c/1327167
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606854}

    Changed files

    • ios/chrome/browser/web/sad_tab_tab_helper.h
    • ios/chrome/browser/web/sad_tab_tab_helper.mm
    • ios/chrome/browser/web/sad_tab_tab_helper_unittest.mm
  25. Call WebStateObserver::PageLoaded after loading placeholder URL.

    Changed by eugenebutohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 16:00:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 386114b5bacc02e12b584786671d67b6080f02e7

    Comments

    Call WebStateObserver::PageLoaded after loading placeholder URL.
    
    Before this CL PageLoaded was called right from
    didFailProvisionalNavigation:, where URL may still represent the
    previous page.
    
    Bug: 903497
    Change-Id: I712dd120340353f37d2fe739c5b05e843cb11d7a
    Reviewed-on: https://chromium-review.googlesource.com/c/1327608
    Reviewed-by: Danyao Wang <danyao@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606855}

    Changed files

    • ios/web/web_state/ui/crw_web_controller.mm
  26. Wire the resizeMode property to the constraints parsing mechanism.

    Changed by guidouohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:02:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 75c6c086d575a9e131e70eaf6512a0da14150442

    Comments

    Wire the resizeMode property to the constraints parsing mechanism.
    
    This CL adds resizeMode support for MediaStreamTrack.getConstraints()
    and marks resizeMode as a supported constrainable property.
    
    Support for getUserMedia(), applyConstraints() and getCapabilities()
    will be added in follow-up CLs in this series.
    
    Intent to Ship:
    https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V2srjdzRCXE
    
    Bug: 854980
    Change-Id: Ia23b8119768ab67ab498f0f8e2267aeb388f9fc3
    Reviewed-on: https://chromium-review.googlesource.com/c/1309749
    Reviewed-by: Henrik Boström <hbos@chromium.org>
    Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    Commit-Queue: Guido Urdaneta <guidou@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606856}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaDevices-getSupportedConstraints.html
    • third_party/WebKit/LayoutTests/fast/mediastream/MediaDevices-getSupportedConstraints.html
    • third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getConstraints.html
    • third_party/blink/public/platform/web_media_constraints.h
    • third_party/blink/renderer/modules/mediastream/media_constraints_impl.cc
    • third_party/blink/renderer/modules/mediastream/media_stream_track.cc
    • third_party/blink/renderer/modules/mediastream/media_track_constraint_set.idl
    • third_party/blink/renderer/modules/mediastream/media_track_supported_constraints.idl
    • third_party/blink/renderer/platform/exported/web_media_constraints.cc
  27. Roll src-internal 6166365225d6..827de2c806ba (3 commits)

    Changed by chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 16:04:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 56904b670753b8f8a1f5131ef61b9e1027f34c6e

    Comments

    Roll src-internal 6166365225d6..827de2c806ba (3 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6166365225d6..827de2c806ba
    
    
    Created with:
      gclient setdep -r src-internal@827de2c806ba
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I3e94550aad679738b88e45953fbc781a647de4ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1329361
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606857}

    Changed files

    • DEPS
  28. Ensures that selection test data files are non-empty on the bots by adding data dependency to the BUILD file

    Changed by nektarohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:06:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7669a6683a5f927ae9a3fa2c2d7802e2a8d5c165

    Comments

    Ensures that selection test data files are non-empty on the bots by adding data dependency to the BUILD file
    
    In case the files are somehow not found or unreadable on the bots, the tests should fail.
    R=dmazzoni@chromium.org
    
    Change-Id: I31668ab7a1b023a9eeda251b3ae0e7079f262171
    Reviewed-on: https://chromium-review.googlesource.com/c/1324232
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606858}

    Changed files

    • third_party/blink/renderer/modules/BUILD.gn
    • third_party/blink/renderer/modules/accessibility/testing/accessibility_selection_test.cc
  29. Remove v8_context_snapshot.bin determinism hack.

    Changed by thakisohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:08:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d2acccc10cf8afd5a3709f5fd562d700d6b96979

    Comments

    Remove v8_context_snapshot.bin determinism hack.
    
    Reverts parts of
    https://chromium-review.googlesource.com/c/chromium/src/+/1293791 that should
    no longer be needed after https://chromium-review.googlesource.com/c/1304441
    
    Bug: 870584
    Change-Id: I76fa59eb5c88c34cd222f2a40c983a4f4e615b27
    Reviewed-on: https://chromium-review.googlesource.com/c/1328823
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606859}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/v8_context_snapshot.cc
  30. Roll src/third_party/skia 88e15bdaf539..c244c2fbbbf8 (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 16:10:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99e210e29e5e55c29142398eb11e164801f7d0c8

    Comments

    Roll src/third_party/skia 88e15bdaf539..c244c2fbbbf8 (1 commits)
    
    https://skia.googlesource.com/skia.git/+log/88e15bdaf539..c244c2fbbbf8
    
    
    git log 88e15bdaf539..c244c2fbbbf8 --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 mtklein@google.com remove SkBlitMask::PlatformRowProcs
    
    
    Created with:
      gclient setdep -r src/third_party/skia@c244c2fbbbf8
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.
    ...skip...
    rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    TBR=allanmac@chromium.org
    
    Change-Id: I59ebc97baec374297a4ec2b6ba5761d443086155
    Reviewed-on: https://chromium-review.googlesource.com/c/1329045
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606860}

    Changed files

    • DEPS
  31. Save transform context for filters

    Changed by fserbohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:11:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d07d7323809b59b52b1237dacb94330cc9dab4bd

    Comments

    Save transform context for filters
    
    Otherwise we get weird behavior on filters while transforming.
    
    TBR=
    
    Bug: 901759
    Change-Id: I1d487f500024a309bdb4002ba19a20387b3bb251
    Reviewed-on: https://chromium-review.googlesource.com/c/1329342
    Reviewed-by: Fernando Serboncini <fserb@chromium.org>
    Commit-Queue: Fernando Serboncini <fserb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606861}

    Changed files

    • third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.h
  32. Roll src/third_party/perfetto fd986312652f..cf90797ef05a (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 16:12:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5657f328e5325aa821d8714a3f7686c078603a43

    Comments

    Roll src/third_party/perfetto fd986312652f..cf90797ef05a (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/fd986312652f..cf90797ef05a
    
    
    git log fd986312652f..cf90797ef05a --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 lalitm@google.com Merge "trace_processor: associate rss stat and mem info events with process"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@cf90797ef05a
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-c
    ...skip...
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: Iae90928bbe8ba71f08a8b348c2f4165763d2fc9f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329362
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606862}

    Changed files

    • DEPS
  33. Ignore blur events caused by the password generation.

    Changed by vasiliiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:18:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision acf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6

    Comments

    Ignore blur events caused by the password generation.
    
    When PasswordGenerationAgent copies the password value from the password field
    to "Confirm Password" filed, a blur event is generated. It hides the currently
    open generation prompt. Those events are just side-effects of how the class
    works and should be ignored.
    
    Bug: 899756,850079
    Change-Id: Ia5d4f0184900fda97118252c48209ffcf1ce3444
    Reviewed-on: https://chromium-review.googlesource.com/c/1327205
    Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Ioana Pandele <ioanap@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606863}

    Changed files

    • chrome/renderer/autofill/fake_password_manager_client.cc
    • chrome/renderer/autofill/fake_password_manager_client.h
    • chrome/renderer/autofill/password_generation_agent_browsertest.cc
    • components/autofill/content/renderer/autofill_agent.cc
    • components/autofill/content/renderer/password_generation_agent.cc
    • components/autofill/content/renderer/password_generation_agent.h
  34. Use network::ResourceRequestInfo::proxy_server instead of was_fetched_via_proxy

    Changed by tonikitooohnoyoudont@igalia.com
    Changed at Friday, 09-Nov-18 16:24:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f513b7c0c1803fe4688b8eee2dab06f48dabf081

    Comments

    Use network::ResourceRequestInfo::proxy_server instead of was_fetched_via_proxy
    
    ... and remove the later.
    
    This is a follow up of mmenke's request in [1].
    
    [1] https://crrev.com/c/1251642/3/services/network/url_loader.cc#70
    
    TBR=nparker@chromium (components/safe_browsing/browser/threat_details_cache.cc)
    TBR=jam@chromium.org (content/browser/loader/resource_loader.cc)
    
    BUG=773295
    
    Change-Id: I932315bec7d1790dbc8726eeb1decce6e76172b1
    Reviewed-on: https://chromium-review.googlesource.com/c/1320769
    Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606864}

    Changed files

    • components/policy/core/common/cloud/device_management_service.cc
    • components/safe_browsing/browser/threat_details_cache.cc
    • content/browser/loader/resource_loader.cc
    • services/network/public/cpp/resource_response.cc
    • services/network/public/cpp/resource_response_info.cc
    • services/network/public/cpp/resource_response_info.h
    • services/network/url_loader.cc