Home | Search
Login

Builder Android Cronet Builder Asan Build #7816 Canonical Ubuntu

Results:

build successful

Trigger Info:

Execution:

Steps and Logfiles:

Show:
  1. ( 37 mins 35 secs ) steps
    running steps via annotated script
  2. ( 11 secs ) update_scripts
    update_scripts
  3. ( 4 ms ) LUCI Migration
    LUCI Migration
  4. ( 4 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 5 ms ) setup_build
    setup_build
    running recipe: "cronet"
  6. ( 4 ms ) cleanup index.lock
    cleanup index.lock
  7. ( 7 mins 23 secs ) bot_update
    bot_update
    [52GB/442GB used (11%)]
  8. ( 4 ms ) clean local files
    clean local files
  9. ( 3 ms ) ensure_goma
    ensure_goma
  10. ( 4 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  11. ( 3 ms ) clobber
    clobber
  12. ( 1 mins 56 secs ) gclient runhooks
    gclient runhooks
  13. ( 4 ms ) lookup GN args
    lookup GN args
     
    Count of GN args (24) exceeds limit (15), presented in logs instead
  14. ( 7 secs ) generate_build_files
    generate_build_files
  15. ( 1 ms ) clang_revision
    clang_revision
  16. ( 3 ms ) preprocess_for_goma
    preprocess_for_goma
  17. ( 1 ms ) preprocess_for_goma.goma cache directory
    preprocess_for_goma.goma cache directory
  18. ( 5 secs ) preprocess_for_goma.start_goma
    preprocess_for_goma.start_goma
  19. ( 3 ms ) preprocess_for_goma.start cloudtail
    preprocess_for_goma.start cloudtail
  20. ( 4 mins 36 secs ) compile
    compile
  21. ( 3 ms ) compile confirm no-op
    compile confirm no-op
  22. ( 3 ms ) postprocess_for_goma
    postprocess_for_goma
  23. ( 4 ms ) postprocess_for_goma.goma_jsonstatus
    postprocess_for_goma.goma_jsonstatus
  24. ( 3 ms ) postprocess_for_goma.goma_stat
    postprocess_for_goma.goma_stat
  25. ( 3 ms ) postprocess_for_goma.stop_goma
    postprocess_for_goma.stop_goma
  26. ( 10 secs ) postprocess_for_goma.upload_log
    postprocess_for_goma.upload_log
  27. ( 3 ms ) postprocess_for_goma.stop cloudtail
    postprocess_for_goma.stop cloudtail
  28. ( 3 ms ) get version
    get version
  29. ( 3 ms ) create adb symlink
    create adb symlink
  30. ( 3 ms ) spawn_logcat_monitor
    spawn_logcat_monitor
  31. ( 3 ms ) spawn_device_monitor
    spawn_device_monitor
  32. ( 3 ms ) authorize_adb_devices
    authorize_adb_devices
  33. ( 40 secs ) device_recovery
    device_recovery
  34. ( 2 mins 38 secs ) provision_devices
    provision_devices
  35. ( 3 ms ) device_status
    device_status
    Online devices: 4
  36. ( 1 ms ) get_clang_version
    get_clang_version
  37. ( 3 ms ) Set up ASAN on devices
    Set up ASAN on devices
  38. ( 1 ms ) Set up ASAN on devices.List adb devices
    Set up ASAN on devices.List adb devices
  39. ( 1 ms ) Set up ASAN on devices.Root devices
    Set up ASAN on devices.Root devices
  40. ( 1 ms ) Set up ASAN on devices.0aa6b19043e4b976
    Set up ASAN on devices.0aa6b19043e4b976
  41. ( 1 ms ) Set up ASAN on devices.06596466005cab1a
    Set up ASAN on devices.06596466005cab1a
  42. ( 1 ms ) Set up ASAN on devices.05c34aa83444c162
    Set up ASAN on devices.05c34aa83444c162
  43. ( 1 ms ) Set up ASAN on devices.0accc2af43e4affc
    Set up ASAN on devices.0accc2af43e4affc
  44. ( 17 secs ) Set up ASAN on devices.wait_for_devices
    Set up ASAN on devices.wait_for_devices
  45. ( 43 secs ) cronet_unittests_android
    cronet_unittests_android
  46. ( 9 mins 40 secs ) net_unittests
    net_unittests
  47. ( 16 secs ) cronet_sample_test_apk
    cronet_sample_test_apk
  48. ( 4 ms ) cronet_sample_test_apk: generate result details
    cronet_sample_test_apk: generate result details
  49. ( 18 secs ) cronet_smoketests_missing_native_library_instrumentation_apk
    cronet_smoketests_missing_native_library_instrumentation_apk
  50. ( 4 ms ) cronet_smoketests_missing_native_library_instrumentation_apk: generate result details
    cronet_smoketests_missing_native_library_instrumentation_apk: generate result details
  51. ( 15 secs ) cronet_smoketests_platform_only_instrumentation_apk
    cronet_smoketests_platform_only_instrumentation_apk
  52. ( 4 ms ) cronet_smoketests_platform_only_instrumentation_apk: generate result details
    cronet_smoketests_platform_only_instrumentation_apk: generate result details
  53. ( 5 mins 3 secs ) cronet_test_instrumentation_apk
    cronet_test_instrumentation_apk
  54. ( 4 ms ) cronet_test_instrumentation_apk: generate result details
    cronet_test_instrumentation_apk: generate result details
  55. ( 3 ms ) shutdown_device_monitor
    shutdown_device_monitor
  56. ( 3 ms ) logcat_dump
    logcat_dump
  57. ( 3 ms ) gsutil upload
    gsutil upload
  58. ( 27 secs ) stack_tool_with_logcat_dump
    stack_tool_with_logcat_dump
  59. ( 6 ms ) stack_tool_for_tombstones
    stack_tool_for_tombstones
  60. ( 1 mins 5 secs ) stack_tool_for_asan
    stack_tool_for_asan
  61. ( 4 ms ) Tear down ASAN on devices
    Tear down ASAN on devices
  62. ( 4 ms ) Tear down ASAN on devices.0aa6b19043e4b976
    Tear down ASAN on devices.0aa6b19043e4b976
  63. ( 3 ms ) Tear down ASAN on devices.06596466005cab1a
    Tear down ASAN on devices.06596466005cab1a
  64. ( 3 ms ) Tear down ASAN on devices.05c34aa83444c162
    Tear down ASAN on devices.05c34aa83444c162
  65. ( 3 ms ) Tear down ASAN on devices.0accc2af43e4affc
    Tear down ASAN on devices.0accc2af43e4affc
  66. ( 13 secs ) Tear down ASAN on devices.wait_for_devices
    Tear down ASAN on devices.wait_for_devices
  67. ( 4 ms ) test_report
    test_report
  68. ( 4 ms ) recipe result
    recipe result

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromium/bb/chromium.android/Android_Cronet_Builder_Asan/7816/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.android/Android_Cronet_Builder_Asan/7816" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" Annotation(bot_update)
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" Annotation(bot_update)
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" Annotation(bot_update)
got_src_revision "703e2b8a5b805ecd4fba4bffb76095125330cec4" Annotation(bot_update)
got_src_revision_cp "refs/heads/master@{#599196}" Annotation(bot_update)
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" Annotation(bot_update)
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" Annotation(bot_update)
got_v8_revision_cp "refs/heads/7.1.302@{#1}" Annotation(bot_update)
got_webrtc_revision "55d1af14751ad10e0cae741240f013ea67039f45" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#25138}" Annotation(bot_update)
got_clang_revision "344066-1" Annotation(clang_revision)
build_data_dir "/b/rr/tmp2VsrgV" Annotation(steps)
build_id "buildbot/chromium.android/Android Cronet Builder Asan/7816" Annotation(steps)
builder_id "master.chromium.android:Android Cronet Builder Asan" Annotation(steps)
blamelist ["andruud@chromium.org","blink-w3c-test-autoroller@chromium.org","blundell@chromium.org","chromium-autoroll@skia-public.iam.gserviceaccount.com","chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com","clamy@chromium.org","davidovic@google.com","dgozman@chromium.org","dullweber@chromium.org","findit-for-me@appspot.gserviceaccount.com","futhark@chromium.org","mstensho@chromium.org","orphis@chromium.org","penghuang@chromium.org","shuchen@google.com","szermatt@chromium.org","treib@chromium.org","wanderview@chromium.org","xidachen@chromium.org"] Build
branch "master" Build
buildnumber 7816 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1539345662 Build
revision "703e2b8a5b805ecd4fba4bffb76095125330cec4" Build
slavename "build69-b1" BuildSlave
buildername "Android Cronet Builder Asan" Builder
git_revision "703e2b8a5b805ecd4fba4bffb76095125330cec4" Change
scheduler "chromium_commits" Scheduler
buildbotURL "https://build.chromium.org/p/chromium.android/" master.cfg
mastername "chromium.android" master.cfg
workdir "/b/build/slave/Android_Cronet_Builder_Asan" slave

Blamelist:

  1. (clamyohnoyoudont@chromium.org)
  2. (andruudohnoyoudont@chromium.org)
  3. (blundellohnoyoudont@chromium.org)
  4. (orphisohnoyoudont@chromium.org)
  5. (orphisohnoyoudont@chromium.org)
  6. (futharkohnoyoudont@chromium.org)
  7. (davidovicohnoyoudont@google.com)
  8. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  9. (xidachenohnoyoudont@chromium.org)
  10. (dullweberohnoyoudont@chromium.org)
  11. (mstenshoohnoyoudont@chromium.org)
  12. (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  13. (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  14. (blundellohnoyoudont@chromium.org)
  15. (findit-for-meohnoyoudont@appspot.gserviceaccount.com)
  16. (shuchenohnoyoudont@google.com)
  17. (wanderviewohnoyoudont@chromium.org)
  18. (penghuangohnoyoudont@chromium.org)
  19. (szermattohnoyoudont@chromium.org)
  20. (treibohnoyoudont@chromium.org)
  21. (dgozmanohnoyoudont@chromium.org)

Timing:

Create N/A
Start Friday, 12-Oct-18 13:50:50 UTC
End Friday, 12-Oct-18 14:28:26 UTC
Pending N/A
Execution 37 mins 35 secs

All Changes:

  1. Create NavigationRequest from LoadURLParams

    Changed by clamyohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 11:59:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5193caa162249e66ecec99fbf1e94fd38557b672

    Comments

    Create NavigationRequest from LoadURLParams
    
    This CL allows to create the NavigationRequest directly from
    LoadURLParams for new navigations.
    
    Bug: 803859
    Change-Id: Ic0f3f368ade86fe57bb549ae6c1d5711f1b58d0e
    Reviewed-on: https://chromium-review.googlesource.com/c/1097407
    Commit-Queue: Camille Lamy <clamy@chromium.org>
    Reviewed-by: Charlie Reis <creis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599176}

    Changed files

    • content/browser/frame_host/navigation_controller_impl.cc
    • content/browser/frame_host/navigation_controller_impl.h
    • content/browser/frame_host/navigation_entry_impl.cc
    • content/browser/frame_host/navigation_request.cc
    • content/browser/frame_host/navigation_request.h
    • content/browser/frame_host/navigator_impl.cc
    • content/browser/frame_host/render_frame_host_manager_unittest.cc
  2. [css-properties-values-api] Support StylePropertyMap.append.

    Changed by andruudohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:05:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 84056b7e0dee6cb71b889254c2f33c0b338002fb

    Comments

    [css-properties-values-api] Support StylePropertyMap.append.
    
    This CL makes it possible to append values to list-valued properties.
    
    To do this, we must produce a CSSStyleValueVector which holds the final
    value produced by the append (i.e. the concatenation of the existing
    values and the incoming values). Then (like for StylePropertyMap.set),
    a CSSVariableReferenceValue with equivalent tokens is created from that
    vector.
    
    Bonus: Fix names of some tests to make it easier to read the output.
    
    R=chrishtr@chromium.org
    
    Bug: 641877
    Change-Id: I0d58f66255a9ff7e14c1ee8f4d243353b9a4a0da
    Reviewed-on: https://chromium-review.googlesource.com/c/1270967
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599177}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/css/css-properties-values-api/typedom.tentative.html
    • third_party/blink/renderer/core/css/cssom/style_property_map.cc
    • third_party/blink/renderer/core/css/cssom/style_property_map_read_only.cc
    • third_party/blink/renderer/core/css/cssom/style_property_map_read_only.h
  3. Enable IdentityTestEnvironment to take in IdentityManager's dependencies

    Changed by blundellohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:09:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b64e54c9a221efad82a4a60956cd3b58ac371059

    Comments

    Enable IdentityTestEnvironment to take in IdentityManager's dependencies
    
    Currently, IdentityTestEnvironment internally constructs all the
    dependencies of IdentityManager as well as the IdentityManager object
    itself. This behavior is nice for hiding the fact that IdentityManager
    has these dependencies from consumers, but doesn't allow for
    usage of IdentityTestEnviroment in incremental conversion of tests that
    have broad direct usage of these dependencies. Concretely,
    profile_sync_test_util.h provides 
    ...skip...
    .  It also moves ownership of
    IdentityManager from that internal object to IdentityTestEnvironment
    itself so that it can be created/owned independent of that internal
    object.
    
    A followup CL will use this new constructor.
    
    Bug: 886599
    Change-Id: I4c6a503dcc11c327193f80bc7d7c48e467c6919b
    Reviewed-on: https://chromium-review.googlesource.com/c/1273298
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599178}

    Changed files

    • services/identity/public/cpp/identity_test_environment.cc
    • services/identity/public/cpp/identity_test_environment.h
  4. Revert "Make DriveFS opt-out in FilesApp tests."

    Changed by orphisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:11:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 70d0138d92d063b4d3032ffae54c950cf7c13f41

    Comments

    Revert "Make DriveFS opt-out in FilesApp tests."
    
    This reverts commit e9c79d562d8d3b789cca95b6909aa600a1dd39d2.
    
    Reason for revert: single_process_mash_browser_tests failing on chromium.memory/Linux ChromiumOS MSan Tests
    Bug: 894799
    
    Original change's description:
    > Make DriveFS opt-out in FilesApp tests.
    > 
    > Bug: 891197
    > Change-Id: Id3101a43cfe97e652d71f720b5f312b933af1113
    > Reviewed-on: https://chromium-review.googlesource.com/c/1277133
    > Reviewed-by: Noel Gordon <noel@chromium.org>
    > Commit-Queue: Sam McNally <sammc@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599117}
    
    TBR=noel@chromium.org,sammc@chromium.org
    
    Change-Id: If9140eb468d1e27aeb217a3202b638aa0f4e20f7
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 891197
    Reviewed-on: https://chromium-review.googlesource.com/c/1278757
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599179}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
  5. Revert "[blink] Control ScriptStreamer with ScriptResource"

    Changed by orphisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:16:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7590d68012b9cf52c14e3f44e019ea36ecc2d9e

    Comments

    Revert "[blink] Control ScriptStreamer with ScriptResource"
    
    This reverts commit 7bd9163502462762e58d8010577dbf36aeef6c13.
    
    Reason for revert: fast/css-grid-layout/grid-columns-rows-get-set.html is flaky
    Bug: 894792, 894795
    
    Original change's description:
    > [blink] Control ScriptStreamer with ScriptResource
    > 
    > Move the ScriptStreamer control logic from ClassicPendingScript to
    > ScriptResource. In the future, this will allow us to start streaming
    > a ScriptResource before the ClassicPendingScript is 
    ...skip...
    refs/heads/master@{#599148}
    
    TBR=kinuko@chromium.org,rmcilroy@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
    
    Change-Id: Id8e8df8f960c60c88762cdf837e7ba9eb74944d6
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:865098
    Reviewed-on: https://chromium-review.googlesource.com/c/1278758
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599180}

    Changed files

    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt
    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
    • third_party/blink/renderer/bindings/core/v8/script_streamer.cc
    • third_party/blink/renderer/bindings/core/v8/script_streamer.h
    • third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
    • third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
    • third_party/blink/renderer/core/inspector/inspector_trace_events.cc
    • third_party/blink/renderer/core/loader/document_loader.cc
    • third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
    • third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.h
    • third_party/blink/renderer/core/script/classic_pending_script.cc
    • third_party/blink/renderer/core/script/classic_pending_script.h
    • third_party/blink/renderer/core/script/document_write_intervention.cc
    • third_party/blink/renderer/core/script/pending_script.h
    • third_party/blink/renderer/platform/loader/fetch/resource.cc
    • third_party/blink/renderer/platform/loader/fetch/resource.h
    • tools/metrics/histograms/enums.xml
  6. Don't update style for focusability when render-blocking.

    Changed by futharkohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:16:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 369b6fca37d5b416775fd7fafdbc6bde78a18bf8

    Comments

    Don't update style for focusability when render-blocking.
    
    WebNode::IsFocusable() updated style and layout tree, without ignoring
    pending stylesheets, which meant generating a display:none placeholder
    style for the root node. Instead, early return from IsFocusable() when
    we are blocking rendering.
    
    Bug: 521692
    
    Change-Id: Idd6cfcf800e4173cfc1bdcb916728c7a0186edf9
    Reviewed-on: https://chromium-review.googlesource.com/c/1245787
    Reviewed-by: Stefan Zager <szager@chromium.org>
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599181}

    Changed files

    • third_party/blink/renderer/core/exported/web_node.cc
    • third_party/blink/renderer/core/exported/web_node_test.cc
  7. Reland "[sync::test] Add single client integration test for custom passphrase"

    Changed by davidovicohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 12:18:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d1df3c494cc8dc1ef26ec3514b74b27c3047a4db

    Comments

    Reland "[sync::test] Add single client integration test for custom passphrase"
    
    This is a reland of 475bfe9da1df9ab55685e0a9ce1a62d8e50536f1. Fixed test
    failures which happened because some DCHECKs had side effects.
    
    Original change's description:
    > [sync::test] Add single client integration test for custom passphrase
    >
    > Add a Sync integration test which exercises custom passphrase flows, including
    > the handling and proper functioning of the newly added key derivation method
    > (scrypt).
    >
    > Add an i
    ...skip...
     David Davidović <davidovic@google.com>
    > Reviewed-by: vitaliii <vitaliii@chromium.org>
    > Reviewed-by: Marc Treib <treib@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#598912}
    
    Bug: 894148
    Change-Id: I752acff5815531c0c83ebefb43fb620a785e3ca3
    Reviewed-on: https://chromium-review.googlesource.com/c/1278790
    Commit-Queue: David Davidović <davidovic@google.com>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Reviewed-by: vitaliii <vitaliii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599182}

    Changed files

    • chrome/browser/sync/test/integration/bookmarks_helper.cc
    • chrome/browser/sync/test/integration/bookmarks_helper.h
    • chrome/browser/sync/test/integration/encryption_helper.cc
    • chrome/browser/sync/test/integration/encryption_helper.h
    • chrome/browser/sync/test/integration/profile_sync_service_harness.cc
    • chrome/browser/sync/test/integration/profile_sync_service_harness.h
    • chrome/browser/sync/test/integration/single_client_custom_passphrase_sync_test.cc
    • chrome/browser/sync/test/integration/sync_test.cc
    • chrome/browser/sync/test/integration/sync_test.h
    • chrome/test/BUILD.gn
    • components/sync/engine_impl/loopback_server/loopback_server.cc
    • components/sync/engine_impl/loopback_server/loopback_server.h
    • components/sync/test/fake_server/fake_server.cc
    • components/sync/test/fake_server/fake_server.h
  8. Roll src/third_party/webrtc 28d200c24624..55d1af14751a (2 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 12:35:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9729f6efb4bae858cc91b281091f2df86433da8a

    Comments

    Roll src/third_party/webrtc 28d200c24624..55d1af14751a (2 commits)
    
    https://webrtc.googlesource.com/src.git/+log/28d200c24624..55d1af14751a
    
    
    git log 28d200c24624..55d1af14751a --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 terelius@webrtc.org Remove support for microsecond resolution in RtcEventLogs.
    2018-10-12 sprang@webrtc.org Move TemporalLayers to api/video_codecs.
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@55d1af14751a
    
    The AutoRoll server is located here: https://auto
    ...skip...
    ary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I15b74c4ebe322c1004b1ba8d1cfb25d82b65614c
    Reviewed-on: https://chromium-review.googlesource.com/c/1278709
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599183}

    Changed files

    • DEPS
  9. Rename OnHasTouchEventHandlersForTest in InputRouterImpl

    Changed by xidachenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:40:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0f7980b37fba64a72e95e35f17633e6cb3915321

    Comments

    Rename OnHasTouchEventHandlersForTest in InputRouterImpl
    
    The call site of this function is resetting the |allowed_touch_action_|
    only, so rename this function to ForceResetTouchActionForTest.
    
    This CL should not introduce any behavior change.
    
    Bug: None
    Change-Id: I253d73f4f21bdb6268f43ce535453412f4b32c51
    Reviewed-on: https://chromium-review.googlesource.com/c/1277947
    Commit-Queue: Xida Chen <xidachen@chromium.org>
    Reviewed-by: James MacLean <wjmaclean@chromium.org>
    Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
    Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599184}

    Changed files

    • content/browser/renderer_host/input/input_router_impl.cc
    • content/browser/renderer_host/input/input_router_impl.h
    • content/browser/renderer_host/input/touch_action_filter.cc
    • content/browser/renderer_host/input/touch_action_filter.h
    • content/browser/site_per_process_hit_test_browsertest.cc
    • content/public/test/browser_test_utils.cc
  10. Log UserDeletedCookieOrCacheFromDialog from Android

    Changed by dullweberohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:43:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aeec7095a6a5129132a4fe7e5f5f0abeb2cf8ff3

    Comments

    Log UserDeletedCookieOrCacheFromDialog from Android
    
    We currently log the UserDeletedCookieOrCacheFromDialog histogram from
    Desktop. On Android we only know about total cookie/cache deletion
    and not those started from CBD.
    This CL adds logging of the UserDeletedCookieOrCacheFromDialog histogram
    to the CBD dialog on Android.
    
    Change-Id: I51c1ff6d3c5dc6f531f5bfccc59f522718b1abef
    Reviewed-on: https://chromium-review.googlesource.com/c/1276605
    Commit-Queue: Christian Dullweber <dullweber@chromium.org>
    Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599185}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesBasic.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java
    • content/public/android/BUILD.gn
    • content/public/browser/browsing_data_remover.h
  11. [LayoutNG] Mark nopaint-after-layer-destruction.html as passing again.

    Changed by mstenshoohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:45:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 17f212ee41ac78c428f851f24fa76ffee0ec8c3d

    Comments

    [LayoutNG] Mark nopaint-after-layer-destruction.html as passing again.
    
    Needed some rebaselining on Mac.
    
    Attempted to mark it as passing here:
    https://chromium-review.googlesource.com/c/1277649
    
    Then a sheriff marked it as failing again:
    https://chromium-review.googlesource.com/c/chromium/src/+/1278785
    
    TBR=kojii@chromium.org,orphis@chromium.org
    
    Change-Id: I4b282cba19e6c94f032c127f70672cf4cfe133ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1278805
    Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599186}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/platform/mac/fast/block/float/nopaint-after-layer-destruction-expected.txt
    • third_party/WebKit/LayoutTests/platform/mac/virtual/layout_ng/fast/block/float/nopaint-after-layer-destruction-expected.png
  12. Roll src-internal f37e9866851d..2cecd6e79600 (1 commits)

    Changed by chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 12:56:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2f64dae1358dab03fb6fb5e12fc444dad20d38f4

    Comments

    Roll src-internal f37e9866851d..2cecd6e79600 (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f37e9866851d..2cecd6e79600
    
    
    Created with:
      gclient setdep -r src-internal@2cecd6e79600
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Iac9c77c5c0927e0ca3862bf5171f5972e5c40ca7
    Reviewed-on: https://chromium-review.googlesource.com/c/1278711
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599187}

    Changed files

    • DEPS
  13. Import wpt@e8a20c396e2ed7b7b8b2cacd3128f959e710a243

    Changed by blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:59:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c12ec9eedc27e721f93de806016cfcf26225fde9

    Comments

    Import wpt@e8a20c396e2ed7b7b8b2cacd3128f959e710a243
    
    Using wpt-import in Chromium 68550e484d7eecf6bd1d39fca300644ab2c21f5d.
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25974
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    NOAUTOREVERT=true
    TBR=lukebjerring
    
    No-Export: true
    Change-Id: I132a332cdc953a69e5c54c550a9bb4e5d08c9bb5
    Reviewed-on: https://chromium-review.googlesource.com/c/1277603
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599188}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/webrtc.idl
  14. Start using IdentityTestEnvironment in ProfileSyncServiceBundle

    Changed by blundellohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:10:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 863a437d0fdbbba19ad5446420b72d2f91748a72

    Comments

    Start using IdentityTestEnvironment in ProfileSyncServiceBundle
    
    ProfileSyncServiceBundle owns and exposes signin-related objects for
    use by sync tests. These signin-related objects include ones that are
    deprecated by IdentityManager and no longer used directly in the
    production code being tested; however, up until now it has not been
    feasible to convert this test utility to using IdentityTestEnvironment,
    as doing so would have required converting the widespread usage of this
    utility in one go.
    
    We re
    ...skip...
    e.h and provide an
    example of its usage to eliminate a direct usage of the deprecated
    classes. Once the conversion is complete, ProfileSyncServiceBundle can
    then be changed to *only* hold an IdentityTestEnvironment object.
    
    Bug: 886600, 886599
    Change-Id: I205c3567fc0a9bcd6f7b613c00a247c302d71be5
    Reviewed-on: https://chromium-review.googlesource.com/c/1273065
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599189}

    Changed files

    • components/browser_sync/BUILD.gn
    • components/browser_sync/profile_sync_service_autofill_unittest.cc
    • components/browser_sync/profile_sync_test_util.cc
    • components/browser_sync/profile_sync_test_util.h
  15. Revert "Files app: Select My files when there are no volumes"

    Changed by findit-for-meohnoyoudont@appspot.gserviceaccount.com
    Changed at Friday, 12-Oct-18 13:17:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 402571f89e1aff1627ccf491110764c74029e3de

    Comments

    Revert "Files app: Select My files when there are no volumes"
    
    This reverts commit 5cd8c123e452c0b76fbbcaf53e82d86ca7d54930.
    
    Reason for revert:
    
    Findit (https://goo.gl/kROfz5) identified CL at revision 599026 as the
    culprit for flakes in the build cycles as shown on:
    https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNWNkOGMxMjNlNDUyYzBiNzZmYmJjYWY1M2U4MmQ4NmNhN2Q1NDkzMAw
    
    Sample Failed Build: https://ci.chromium.org/buildbo
    ...skip...
    ewed-on: https://chromium-review.googlesource.com/c/1272418
    > Reviewed-by: Noel Gordon <noel@chromium.org>
    > Reviewed-by: Sam McNally <sammc@chromium.org>
    > Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599026}
    
    Change-Id: I883485c8fc1bdcc22dba93cc4b03b7c157dcb5f2
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 893161, 884967, 889703
    Reviewed-on: https://chromium-review.googlesource.com/c/1278063
    Cr-Commit-Position: refs/heads/master@{#599190}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
    • chromeos/components/drivefs/fake_drivefs.cc
    • ui/file_manager/file_manager/foreground/js/directory_model.js
    • ui/file_manager/file_manager/foreground/js/file_manager.js
    • ui/file_manager/integration_tests/file_manager/file_display.js
  16. Avoid using gypi_to_gn.py.

    Changed by shuchenohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 13:25:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b85f543af1e343404dde1a2c51067b2ed5ac08cb

    Comments

    Avoid using gypi_to_gn.py.
    
    Change-Id: I9bac8317577feaadfa00ec88661175b7338ced4a
    Reviewed-on: https://chromium-review.googlesource.com/c/1267596
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Shu Chen <shuchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599191}

    Changed files

    • third_party/google_input_tools/README.chromium
    • third_party/google_input_tools/builder.py
    • third_party/google_input_tools/closure.gni
    • third_party/google_input_tools/inputview.gni
    • third_party/google_input_tools/inputview.gypi
    • third_party/google_input_tools/update.py
    • ui/keyboard/BUILD.gn
  17. Make DataPipeBytesConsumer support ReadableStream loading better.

    Changed by wanderviewohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:36:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c43eba9311573672d0773beed07f117d08eed09f

    Comments

    Make DataPipeBytesConsumer support ReadableStream loading better.
    
    This CL fixes some edge condition interactions when being loaded as
    a ReadableStream.  In particular, it:
    
    1. Properly distinguishes between the end of the DataPipe and a closed
       DataPipe with bytes left to be read.  A ReadableStream that is not
       actively draining the pipe could get closed too early.
    2. Responses must support explicit completion in order to handle error
       conditions properly.  This CL makes DataPipeBytesConsumer w
    ...skip...
    explicit signal before closing.
    3. Service worker navigation preload is updated to provide the explicit
       completion signals.
    
    Bug: 894815
    Change-Id: I8cff3de94aa2dcbc8deb4a9601a95c13b8ab94d9
    Reviewed-on: https://chromium-review.googlesource.com/c/1272715
    Commit-Queue: Ben Kelly <wanderview@chromium.org>
    Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599192}

    Changed files

    • content/browser/service_worker/service_worker_browsertest.cc
    • third_party/blink/renderer/core/fetch/bytes_consumer.h
    • third_party/blink/renderer/core/fetch/data_pipe_bytes_consumer.cc
    • third_party/blink/renderer/core/fetch/data_pipe_bytes_consumer.h
    • third_party/blink/renderer/core/fetch/data_pipe_bytes_consumer_test.cc
    • third_party/blink/renderer/core/fetch/fetch_data_loader.cc
    • third_party/blink/renderer/core/fetch/fetch_data_loader.h
    • third_party/blink/renderer/modules/service_worker/fetch_event.cc
    • third_party/blink/renderer/modules/service_worker/fetch_event.h
    • third_party/blink/renderer/modules/service_worker/fetch_respond_with_observer.cc
  18. Hook up skia makeYUVAPromiseTexture API

    Changed by penghuangohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:39:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 33ca177f048a1d593c5486b46f09ac9ea91071a9

    Comments

    Hook up skia makeYUVAPromiseTexture API
    
    Know issues:
     * Skia only draws Y plane.
     * makeYUVAPromiseTexture() will release context, even if it failed.
     * Skia doesn't accept GL_RGBA8 format for a yuva plane
    
    Bug: 824382
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    Change-Id: Ic8da2b3de574ef2a0d527c79f34d383a676a3bc0
    Reviewed-on: https://chromium-review.googlesource.com/c/1262421
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Commit-Queue: Peng Huang <penghuang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599193}

    Changed files

    • components/viz/service/display/skia_output_surface.h
    • components/viz/service/display/skia_renderer.cc
    • components/viz/service/display_embedder/skia_output_surface_impl.cc
    • components/viz/service/display_embedder/skia_output_surface_impl.h
    • components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
    • components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.h
  19. [Autofill Assistant] Add Mathias and I as owners

    Changed by szermattohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:39:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b71114eba7ab4e982eaf03186b12503c8ca49c4

    Comments

    [Autofill Assistant] Add Mathias and I as owners
    
    Change-Id: I71ed01f39d1c81c62828d8e4900091e7941e7ab1
    Reviewed-on: https://chromium-review.googlesource.com/c/1278399
    Reviewed-by: Ganggui Tang <gogerald@chromium.org>
    Commit-Queue: Ganggui Tang <gogerald@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599194}

    Changed files

    • components/autofill_assistant/OWNERS
  20. ProfileSyncService cleanup: Remove platform_sync_allowed_provider_

    Changed by treibohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:42:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f0d63432c51741e6dc0bf48f0b84e4afb63f887f

    Comments

    ProfileSyncService cleanup: Remove platform_sync_allowed_provider_
    
    ProfileSyncService::platform_sync_allowed_provider_ was a callback that
    returned whether Android's "Master Sync" toggle is enabled, and so Sync
    shouldn't start up. However, PSS didn't know when the value changed, so
    the callback was kinda useless, and PSS could easily get into an
    inconsistent state (where there is a disable reason, but Sync is still
    running). Things were working out in practice only because the Android
    UI code also called RequestStart/Stop as necessary.
    So, since PSS needs change notifications anyway, let's make that
    explicit: This CL replaces the callback by a bool, which can be set
    explicitly.
    
    Bug: 867901
    Change-Id: I5b7e9f4657d1f565d9643984eb52ec1df26b5c90
    Reviewed-on: https://chromium-review.googlesource.com/c/1269870
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599195}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java
    • chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java
    • chrome/browser/sync/profile_sync_service_android.cc
    • chrome/browser/sync/profile_sync_service_android.h
    • components/browser_sync/profile_sync_service.cc
    • components/browser_sync/profile_sync_service.h
  21. Restore FrameLoadRequest::HrefTranslate

    Changed by dgozmanohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:42:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 703e2b8a5b805ecd4fba4bffb76095125330cec4

    Comments

    Restore FrameLoadRequest::HrefTranslate
    
    This was accidentaly removed as part of FrameLoadRequest cleanup.
    
    Bug: none
    Change-Id: I58bf324729d397a2f0340831fd116ab749f7a213
    Reviewed-on: https://chromium-review.googlesource.com/c/1278290
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599196}

    Changed files

    • third_party/blink/renderer/core/html/html_anchor_element.cc
    • third_party/blink/renderer/core/loader/frame_load_request.h