Home | Search
Login

Builder Android Cronet Builder Asan Build #6678 Canonical Ubuntu

Results:

build successful

Trigger Info:

Execution:

Steps and Logfiles:

Show:
  1. ( 35 mins 52 secs ) steps
    running steps via annotated script
  2. ( 10 secs ) update_scripts
    update_scripts
  3. ( 3 ms ) setup_properties
    setup_properties
  4. ( 3 ms ) LUCI Migration
    LUCI Migration
  5. ( 4 ms ) LogDog Bootstrap
    LogDog Bootstrap
  6. ( 5 ms ) setup_build
    setup_build
    running recipe: "cronet"
  7. ( 19 secs ) remove .cipd
    remove .cipd
  8. ( 2 mins 6 secs ) cleanup index.lock
    cleanup index.lock
  9. ( 4 mins 56 secs ) bot_update
    bot_update
    [102GB/442GB used (23%)]
  10. ( 4 ms ) clean local files
    clean local files
  11. ( 3 ms ) ensure_goma
    ensure_goma
  12. ( 4 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  13. ( 3 ms ) clobber
    clobber
  14. ( 51 secs ) gclient runhooks
    gclient runhooks
  15. ( 55 secs ) generate_build_files
    generate_build_files
  16. ( 3 ms ) clang_revision
    clang_revision
  17. ( 2 ms ) preprocess_for_goma
    preprocess_for_goma
  18. ( 2 ms ) preprocess_for_goma.goma cache directory
    preprocess_for_goma.goma cache directory
  19. ( 2 ms ) preprocess_for_goma.start_goma
    preprocess_for_goma.start_goma
  20. ( 2 ms ) preprocess_for_goma.start cloudtail
    preprocess_for_goma.start cloudtail
  21. ( 4 mins 40 secs ) compile
    compile
  22. ( 3 ms ) compile confirm no-op
    compile confirm no-op
  23. ( 3 ms ) postprocess_for_goma
    postprocess_for_goma
  24. ( 4 ms ) postprocess_for_goma.goma_jsonstatus
    postprocess_for_goma.goma_jsonstatus
  25. ( 3 ms ) postprocess_for_goma.goma_stat
    postprocess_for_goma.goma_stat
  26. ( 3 ms ) postprocess_for_goma.stop_goma
    postprocess_for_goma.stop_goma
  27. ( 11 secs ) postprocess_for_goma.upload_log
    postprocess_for_goma.upload_log
  28. ( 3 ms ) postprocess_for_goma.stop cloudtail
    postprocess_for_goma.stop cloudtail
  29. ( 3 ms ) get version
    get version
  30. ( 3 ms ) create adb symlink
    create adb symlink
  31. ( 3 ms ) spawn_logcat_monitor
    spawn_logcat_monitor
  32. ( 5 ms ) spawn_device_monitor
    spawn_device_monitor
  33. ( 3 ms ) authorize_adb_devices
    authorize_adb_devices
  34. ( 9 secs ) device_recovery
    device_recovery
  35. ( 2 mins 39 secs ) provision_devices
    provision_devices
  36. ( 9 ms ) device_status
    device_status
    Online devices: 4
  37. ( 3 ms ) get_clang_version
    get_clang_version
  38. ( 3 ms ) Set up ASAN on devices
    Set up ASAN on devices
  39. ( 4 ms ) Set up ASAN on devices.List adb devices
    Set up ASAN on devices.List adb devices
  40. ( 4 ms ) Set up ASAN on devices.Root devices
    Set up ASAN on devices.Root devices
  41. ( 3 ms ) Set up ASAN on devices.0aa6b19043e4b976
    Set up ASAN on devices.0aa6b19043e4b976
  42. ( 3 ms ) Set up ASAN on devices.06596466005cab1a
    Set up ASAN on devices.06596466005cab1a
  43. ( 3 ms ) Set up ASAN on devices.05c34aa83444c162
    Set up ASAN on devices.05c34aa83444c162
  44. ( 5 secs ) Set up ASAN on devices.0accc2af43e4affc
    Set up ASAN on devices.0accc2af43e4affc
  45. ( 13 secs ) Set up ASAN on devices.wait_for_devices
    Set up ASAN on devices.wait_for_devices
  46. ( 47 secs ) cronet_unittests_android
    cronet_unittests_android
  47. ( 9 mins 56 secs ) net_unittests
    net_unittests
  48. ( 16 secs ) cronet_sample_test_apk
    cronet_sample_test_apk
  49. ( 4 ms ) cronet_sample_test_apk: generate result details
    cronet_sample_test_apk: generate result details
  50. ( 19 secs ) cronet_smoketests_missing_native_library_instrumentation_apk
    cronet_smoketests_missing_native_library_instrumentation_apk
  51. ( 4 ms ) cronet_smoketests_missing_native_library_instrumentation_apk: generate result details
    cronet_smoketests_missing_native_library_instrumentation_apk: generate result details
  52. ( 16 secs ) cronet_smoketests_platform_only_instrumentation_apk
    cronet_smoketests_platform_only_instrumentation_apk
  53. ( 1 ms ) cronet_smoketests_platform_only_instrumentation_apk: generate result details
    cronet_smoketests_platform_only_instrumentation_apk: generate result details
  54. ( 4 mins 51 secs ) cronet_test_instrumentation_apk
    cronet_test_instrumentation_apk
  55. ( 3 ms ) cronet_test_instrumentation_apk: generate result details
    cronet_test_instrumentation_apk: generate result details
  56. ( 3 ms ) shutdown_device_monitor
    shutdown_device_monitor
  57. ( 3 ms ) logcat_dump
    logcat_dump
  58. ( 3 ms ) gsutil upload
    gsutil upload
  59. ( 26 secs ) stack_tool_with_logcat_dump
    stack_tool_with_logcat_dump
  60. ( 4 ms ) stack_tool_for_tombstones
    stack_tool_for_tombstones
  61. ( 1 mins 4 secs ) stack_tool_for_asan
    stack_tool_for_asan
  62. ( 3 ms ) Tear down ASAN on devices
    Tear down ASAN on devices
  63. ( 2 ms ) Tear down ASAN on devices.0aa6b19043e4b976
    Tear down ASAN on devices.0aa6b19043e4b976
  64. ( 2 ms ) Tear down ASAN on devices.06596466005cab1a
    Tear down ASAN on devices.06596466005cab1a
  65. ( 2 ms ) Tear down ASAN on devices.05c34aa83444c162
    Tear down ASAN on devices.05c34aa83444c162
  66. ( 2 ms ) Tear down ASAN on devices.0accc2af43e4affc
    Tear down ASAN on devices.0accc2af43e4affc
  67. ( 8 secs ) Tear down ASAN on devices.wait_for_devices
    Tear down ASAN on devices.wait_for_devices
  68. ( 4 ms ) test_report
    test_report
  69. ( 4 ms ) recipe result
    recipe result

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromium/bb/chromium.android/Android_Cronet_Builder_Asan/6678/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.android/Android_Cronet_Builder_Asan/6678" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" Annotation(bot_update)
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" Annotation(bot_update)
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" Annotation(bot_update)
got_src_revision "840dc0a7c0eacb82070efe833ef3aacc7b2e89cb" Annotation(bot_update)
got_src_revision_cp "refs/heads/master@{#574712}" Annotation(bot_update)
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" Annotation(bot_update)
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" Annotation(bot_update)
got_v8_revision_cp "refs/heads/6.9.352@{#1}" Annotation(bot_update)
got_webrtc_revision "895617fa9bc36c240b37d47402cdb341ecadf994" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#23955}" Annotation(bot_update)
got_clang_revision "336424-1" Annotation(clang_revision)
recipe "cronet" Annotation(setup_properties)
blamelist ["acondor@chromium.org","aee@chromium.org","asimjour@chromium.org","blink-w3c-test-autoroller@chromium.org","bpastene@chromium.org","bsazonov@chromium.org","chelu@chromium.org","chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","danyao@chromium.org","dmurph@chromium.org","ekaramad@chromium.org","erikchen@chromium.org","fdoray@chromium.org","ftirelo@chromium.org","fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","iclelland@chromium.org","jam@chromium.org","japhet@chromium.org","jsaul@google.com","karandeepb@chromium.org","kbr@chromium.org","kmilka@chromium.org","kpaulhamus@chromium.org","kraynov@chromium.org","kvitekp@chromium.org","luoe@chromium.org","lushnikov@chromium.org","mahmadi@chromium.org","martinkr@google.com","nburris@google.com","nektar@chromium.org","npm@chromium.org","perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","rdaum@chromium.org","rmcelrath@chromium.org","scottchen@chromium.org","sergeyu@chromium.org","skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","spqchan@chromium.org","tbansal@chromium.org","tguilbert@chromium.org","thestig@chromium.org","tiborg@chromium.org","uwyiming@google.com","webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","wez@chromium.org","wfh@chromium.org"] Build
branch "master" Build
buildnumber 6678 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1531422845 Build
revision "840dc0a7c0eacb82070efe833ef3aacc7b2e89cb" Build
slavename "build69-b1" BuildSlave
buildername "Android Cronet Builder Asan" Builder
git_revision "840dc0a7c0eacb82070efe833ef3aacc7b2e89cb" Change
scheduler "chromium_commits" Scheduler
buildbotURL "https://build.chromium.org/p/chromium.android/" master.cfg
mastername "chromium.android" master.cfg
workdir "/b/build/slave/Android_Cronet_Builder_Asan" slave

Blamelist:

  1. (luoeohnoyoudont@chromium.org)
  2. (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  3. (kmilkaohnoyoudont@chromium.org)
  4. (kbrohnoyoudont@chromium.org)
  5. (scottchenohnoyoudont@chromium.org)
  6. (cheluohnoyoudont@chromium.org)
  7. (thestigohnoyoudont@chromium.org)
  8. (bsazonovohnoyoudont@chromium.org)
  9. (chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  10. (dmurphohnoyoudont@chromium.org)
  11. (perfetto-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  12. (kbrohnoyoudont@chromium.org)
  13. (ftireloohnoyoudont@chromium.org)
  14. (iclellandohnoyoudont@chromium.org)
  15. (fuchsia-sdk-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  16. (kpaulhamusohnoyoudont@chromium.org)
  17. (acondorohnoyoudont@chromium.org)
  18. (wezohnoyoudont@chromium.org)
  19. (aeeohnoyoudont@chromium.org)
  20. (erikchenohnoyoudont@chromium.org)
  21. (sergeyuohnoyoudont@chromium.org)
  22. (tbansalohnoyoudont@chromium.org)
  23. (danyaoohnoyoudont@chromium.org)
  24. (rdaumohnoyoudont@chromium.org)
  25. (asimjourohnoyoudont@chromium.org)
  26. (nektarohnoyoudont@chromium.org)
  27. (tguilbertohnoyoudont@chromium.org)
  28. (lushnikovohnoyoudont@chromium.org)
  29. (bpasteneohnoyoudont@chromium.org)
  30. (spqchanohnoyoudont@chromium.org)
  31. (kraynovohnoyoudont@chromium.org)
  32. (nburrisohnoyoudont@google.com)
  33. (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  34. (martinkrohnoyoudont@google.com)
  35. (mahmadiohnoyoudont@chromium.org)
  36. (erikchenohnoyoudont@chromium.org)
  37. (rmcelrathohnoyoudont@chromium.org)
  38. (ekaramadohnoyoudont@chromium.org)
  39. (uwyimingohnoyoudont@google.com)
  40. (tiborgohnoyoudont@chromium.org)
  41. (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  42. (wfhohnoyoudont@chromium.org)
  43. (jamohnoyoudont@chromium.org)
  44. (japhetohnoyoudont@chromium.org)
  45. (kvitekpohnoyoudont@chromium.org)
  46. (jsaulohnoyoudont@google.com)
  47. (karandeepbohnoyoudont@chromium.org)
  48. (npmohnoyoudont@chromium.org)
  49. (fdorayohnoyoudont@chromium.org)

Timing:

Create N/A
Start Thursday, 12-Jul-18 20:58:20 UTC
End Thursday, 12-Jul-18 21:34:13 UTC
Pending N/A
Execution 35 mins 52 secs

All Changes:

  1. DevTools: clicking clear on input should focus

    Changed by luoeohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:11:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cdc1f3d342363df455d02fde8bc04d44f5331e5e

    Comments

    DevTools: clicking clear on input should focus
    
    The act of clicking the 'x' clear button blurs focus. This CL ensures
    the input focuses afterwards.
    
    Bug: 831059
    Change-Id: I848296c0981873cd878f5aaaead9654809811349
    Reviewed-on: https://chromium-review.googlesource.com/1134577
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Commit-Queue: Erik Luo <luoe@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574664}

    Changed files

    • third_party/blink/renderer/devtools/front_end/ui/Toolbar.js
  2. Roll src/third_party/skia 56a426a516d0..5551a94b9e0f (15 commits)

    Changed by skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 19:12:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 521effcf577f74a61bd5d6a35074ed2e3d20abd0

    Comments

    Roll src/third_party/skia 56a426a516d0..5551a94b9e0f (15 commits)
    
    https://skia.googlesource.com/skia.git/+log/56a426a516d0..5551a94b9e0f
    
    
    git log 56a426a516d0..5551a94b9e0f --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 mtklein@chromium.org update color management for color shaders
    2018-07-12 brianosman@google.com Update SRGBReadWritePixelsTest again, to only test opaque colors
    2018-07-12 fmalita@chromium.org PathKit/WASM tweaks
    2018-07-12 mtklein@chromium.org update mode color filter col
    ...skip...
    sty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=robertphillips@chromium.org
    
    Change-Id: I31983fe5eb6e60f68f6b46ed52741dd82999eb78
    Reviewed-on: https://chromium-review.googlesource.com/1135209
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574665}

    Changed files

    • DEPS
  3. [NTP] Add Google Photos option for custom backgrounds

    Changed by kmilkaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:13:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d87ed83235c1f5505f58b0d51923dfe11db9faae

    Comments

    [NTP] Add Google Photos option for custom backgrounds
    
    Allow users to select one of their photos from Google Photos and set it
    as the NTP background image. Currently only supports users who are
    already signed in to their Google account.
    
    Bug: 848012
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Idef07f3cd107199a8e308fc883c96b9a8da37b1e
    Reviewed-on: https://chromium-review.googlesource.com/1130100
    Commit-Queue: Kyle Milka <kmilka@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574666}

    Changed files

    • chrome/browser/resources/local_ntp/custom_backgrounds.css
    • chrome/browser/resources/local_ntp/custom_backgrounds.js
    • chrome/browser/resources/local_ntp/local_ntp.html
    • chrome/browser/search/background/ntp_background_data.cc
    • chrome/browser/search/background/ntp_background_data.h
    • chrome/browser/search/background/ntp_background_service.cc
    • chrome/browser/search/local_ntp_source.cc
    • chrome/test/data/local_ntp/local_ntp_browsertest.html
  4. Update GPU pixel wrangling graphs for macOS 10.13.5 upgrade.

    Changed by kbrohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:14:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 32b92d2bc9ae9c12e01f7879de715843ac849ae8

    Comments

    Update GPU pixel wrangling graphs for macOS 10.13.5 upgrade.
    
    Tbr: ynovikov@chromium.org
    Bug: 856799
    Change-Id: I6d7265037477715df7ca7e31290ef88f7ad4f668
    Reviewed-on: https://chromium-review.googlesource.com/1135657
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574667}

    Changed files

    • docs/gpu/pixel_wrangling.md
  5. Settings: fix sync-account-controls banner overflowing border-radius.

    Changed by scottchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:15:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 66d0e64aa958612d6b9cf38b9b8409925487458b

    Comments

    Settings: fix sync-account-controls banner overflowing border-radius.
    
    Bug: 860265
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Ie85c25b7b777463569f4d3b4f01f8a8e524c84f5
    Reviewed-on: https://chromium-review.googlesource.com/1133977
    Commit-Queue: Scott Chen <scottchen@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574668}

    Changed files

    • chrome/browser/resources/settings/people_page/people_page.html
    • chrome/browser/resources/settings/people_page/sync_account_control.html
  6. Add bad IPC message check at the browser.

    Changed by cheluohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:15:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f9ecec290e797566bdbbe41459d68a4045e29b5e

    Comments

    Add bad IPC message check at the browser.
    
    Add bad IPC message check to UpdateAnchorElementMetrics. The browser
    will kill the renderer process when it receives a bad message.
    
    Bug: 850624
    Change-Id: I750b6d54e556ddc659cb693844922234b9e845ce
    Reviewed-on: https://chromium-review.googlesource.com/1128259
    Commit-Queue: Lu Chen <chelu@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574669}

    Changed files

    • chrome/browser/navigation_predictor/navigation_predictor.cc
    • chrome/browser/navigation_predictor/navigation_predictor.h
    • chrome/browser/navigation_predictor/navigation_predictor_unittest.cc
    • tools/metrics/histograms/histograms.xml
  7. Move PDFiumEngine doc/form/loading members into PDFiumDocument.

    Changed by thestigohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:16:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 94754366872ddaafeb4ec141f971ee47d3350c59

    Comments

    Move PDFiumEngine doc/form/loading members into PDFiumDocument.
    
    Change-Id: I11c1ecff9305a75f66c3de5443fde4d0423163d2
    Reviewed-on: https://chromium-review.googlesource.com/1112498
    Reviewed-by: dsinclair <dsinclair@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574670}

    Changed files

    • pdf/BUILD.gn
    • pdf/pdfium/pdfium_document.cc
    • pdf/pdfium/pdfium_document.h
    • pdf/pdfium/pdfium_engine.cc
    • pdf/pdfium/pdfium_engine.h
  8. [Unity][Android] Update string for payments sync datatype

    Changed by bsazonovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:17:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab5e146619a4ce43dd36939245a2b6a9a254ef90

    Comments

    [Unity][Android] Update string for payments sync datatype
    
    This CL changes the string used for payments in
    'Sync and Google services' preferences screen.
    
    Bug: 814728
    Change-Id: Ib1932ef94ad6f6b90efa5a59e0ef0500775b9496
    Reviewed-on: https://chromium-review.googlesource.com/1135321
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574671}

    Changed files

    • chrome/android/java/res/xml/sync_customization_preferences.xml
    • chrome/android/java/strings/android_chrome_strings.grd
  9. Roll src/third_party/chromite 3973c26575e2..ca73efa2232f (1 commits)

    Changed by chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 19:18:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0113967ab2dcdc45364c7cfa35fd095856d7ede5

    Comments

    Roll src/third_party/chromite 3973c26575e2..ca73efa2232f (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/3973c26575e2..ca73efa2232f
    
    
    git log 3973c26575e2..ca73efa2232f --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 stevenjb@chromium.org deploy_chrome: Always prompt to remove rootfs verification
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@ca73efa2232f
    
    The AutoRoll server is located here: https://chromite-chromium-roll.skia.org
    
    Documentation for
    ...skip...
    ho should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I910679c20d35bb32e7f9e089bdde8a437a37961c
    Reviewed-on: https://chromium-review.googlesource.com/1135208
    Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574672}

    Changed files

    • DEPS
  10. [SessionStorage] Always delete Session Storage database on Android

    Changed by dmurphohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:18:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 154ac5551c1e0ff8c877b4cd0e26ad6ea30d4860

    Comments

    [SessionStorage] Always delete Session Storage database on Android
    
    Android doesn't have session restore code run, and this code is what
    cleaned up old session storage namespaces from previous browser runs.
    
    So on Android, the session storage context will delete the database
    on startup.
    
    R=mek@chromium.org
    
    Bug: 860030
    Change-Id: Ia7c349811e4970d05a071a0de9ad50117d771855
    Reviewed-on: https://chromium-review.googlesource.com/1125260
    Commit-Queue: Daniel Murphy <dmurph@chromium.org>
    Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574673}

    Changed files

    • content/browser/dom_storage/dom_storage_context_wrapper.cc
    • content/browser/dom_storage/session_storage_context_mojo.cc
    • content/browser/dom_storage/session_storage_context_mojo.h
    • content/browser/dom_storage/session_storage_context_mojo_unittest.cc
  11. Roll src/third_party/perfetto f37ffaf9b1a1..2af75f76f0e6 (2 commits)

    Changed by perfetto-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 19:21:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7b6920828c5fa9f72dce1b84c9ae95711ae037e5

    Comments

    Roll src/third_party/perfetto f37ffaf9b1a1..2af75f76f0e6 (2 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/f37ffaf9b1a1..2af75f76f0e6
    
    
    git log f37ffaf9b1a1..2af75f76f0e6 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 michaschwab@google.com Merge "Improve Context Architecture, add "isOnCanvas" method"
    2018-07-12 michaschwab@google.com Improve Context Architecture, add "isOnCanvas" method
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@2af75f76f0e
    ...skip...
    oll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I4222bc49a1619c3cc2972a496dd5e7e961d03363
    Reviewed-on: https://chromium-review.googlesource.com/1135213
    Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574674}

    Changed files

    • DEPS
  12. Complete upgrade of Retina Macs to 10.13.5.

    Changed by kbrohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:21:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 43d34bd136540d0ff14ed70bfc2a69019338595d

    Comments

    Complete upgrade of Retina Macs to 10.13.5.
    
    Turn off the multi-dimension trigger script.
    
    Fix the configuration of "Optional Mac Retina Release (AMD)"; a
    mistake was made in the earlier CL beginning the upgrade, and the jobs
    didn't auto-migrate from 10.12.6 to 10.13.5.
    
    Bug: 856799
    Tbr: ynovikov@chromium.org
    Change-Id: Ifcceed16154c47ffaa5b682149780bc53f4a101b
    Reviewed-on: https://chromium-review.googlesource.com/1135651
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574675}

    Changed files

    • testing/buildbot/chromium.gpu.fyi.json
    • testing/buildbot/chromium.gpu.json
    • testing/buildbot/waterfalls.pyl
  13. Reland: [af] Adjust dropdown so it doesn't look so close to the input element

    Changed by ftireloohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:22:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 03daf4e42f99ef9329ec05fc186c1936ffa718a9

    Comments

    Reland: [af] Adjust dropdown so it doesn't look so close to the input element
    
    This relands commit f1c12e6, which was reverted by commit c71c2c1.
    
    The reason for the revert was a crash introduced by c53515c, and
    reverting that commit was very hard due to merge conflicts.
    
    Bug: 847980
    Change-Id: Ib1b6931d3ac697e78c27a6cbcc7e082f0da4b6ef
    Reviewed-on: https://chromium-review.googlesource.com/1135446
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574676}

    Changed files

    • chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
  14. Clean up feature policy flags.

    Changed by iclellandohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:32:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 77533434f64cde2813381a26cce2247a62070a21

    Comments

    Clean up feature policy flags.
    
    This fixes the default feature list, ensuring that features only appear
    in it if they are actually enabled with the correct runtime feature
    flags. Even if they are shipped as 'stable', they can still be disabled,
    and should not be parsed in that case, or appear in the output of
    document.policy.allowedFeatures().
    
    Bug: 862601
    Change-Id: I207a17818ed6696e9d029b86adcf42e4b58b6516
    Reviewed-on: https://chromium-review.googlesource.com/1133307
    Reviewed-by: Jeremy Roman <jbroman@chromium.org>
    Commit-Queue: Ian Clelland <iclelland@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574677}

    Changed files

    • third_party/blink/renderer/platform/feature_policy/feature_policy.cc
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  15. Roll Fuchsia SDK from cf3c39f9e29d to 64ef9c9bec71

    Changed by fuchsia-sdk-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 19:34:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0708b273b84747404d79725f8be67c90f3047079

    Comments

    Roll Fuchsia SDK from cf3c39f9e29d to 64ef9c9bec71
    
    
    The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
    TBR=cr-fuchsia+bot@chromium.org
    
    Change-Id: I44aa919993e7873807987396622c8fcb0bf2a17f
    Reviewed-on: https://chromium-review.googlesource.com/1135632
    Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574678}

    Changed files

    • build/fuchsia/sdk.sha1
  16. Disable flaky SitePerProcessHitTestBrowserTest

    Changed by kpaulhamusohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:35:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3e031a4fd51a2eefc216a0f80f4bb139e1812b6c

    Comments

    Disable flaky SitePerProcessHitTestBrowserTest
    
    [OverlapSurfaceHitTestTest]
    
    TBR=sunxd@chromium.org
    
    Bug: 833380
    Change-Id: I7991db84dd9201e59089f08a536bcab00b23d379
    Reviewed-on: https://chromium-review.googlesource.com/1135648
    Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
    Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574679}

    Changed files

    • content/browser/site_per_process_hit_test_browsertest.cc
  17. VR: Update textures only if dirty

    Changed by acondorohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:38:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7b520e5b526c4e1ed0a2344a79e42eb6fcf5c298

    Comments

    VR: Update textures only if dirty
    
    This prevents from performing unnecessary context switches.
    
    Bug: 861799
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I5da0e41dda9edb0243c9bbc9c944bdc2cdfaaf39
    Reviewed-on: https://chromium-review.googlesource.com/1133298
    Reviewed-by: Christopher Grant <cjgrant@chromium.org>
    Reviewed-by: Ian Vollick <vollick@chromium.org>
    Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574680}

    Changed files

    • chrome/browser/android/vr/vr_shell_gl.cc
    • chrome/browser/vr/elements/textured_element.cc
    • chrome/browser/vr/elements/textured_element.h
    • chrome/browser/vr/elements/ui_element.cc
    • chrome/browser/vr/elements/ui_element.h
    • chrome/browser/vr/test/ui_test.cc
    • chrome/browser/vr/ui.cc
    • chrome/browser/vr/ui.h
    • chrome/browser/vr/ui_scene.cc
    • chrome/browser/vr/ui_scene.h
  18. Fix race-condition in SchedulerSingleThreadTaskRunnerManager::Start().

    Changed by wezohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:42:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 291f0a739f2c952d402f76d3750b9a2340269c18

    Comments

    Fix race-condition in SchedulerSingleThreadTaskRunnerManager::Start().
    
    SchedulerSingleThreadTaskRunnerManager allows SingleThreadTaskRunners to
    be created and tasks posted to them before the worker threads are
    actually started. The call to Start() the required workers was calling
    both Start() and WakeUp() on each of them, the latter being unnecessary
    since if a worker needs to process work then it must already have been
    woken, when the work was PostTask()d into it.
    
    Besides removing an unnecessary wake-up, this resolves a subtle race-
    condition between wake-up and a potential worker clean-up (see bug).
    
    Bug: 862582
    Change-Id: I9c4246cec4b1bda6d728e5e1656bb2c5ca7c0f0a
    Reviewed-on: https://chromium-review.googlesource.com/1133279
    Commit-Queue: Wez <wez@chromium.org>
    Reviewed-by: Robert Liao <robliao@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574681}

    Changed files

    • base/task_scheduler/scheduler_single_thread_task_runner_manager.cc
  19. WebUI: update text to use primary/secondary colors for style refresh

    Changed by aeeohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:47:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0ceaa55ab4070c9fc1bce4a599d62362576b1322

    Comments

    WebUI: update text to use primary/secondary colors for style refresh
    
    Bug: 849857
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Ia64cd1565af8f50a4af8b5c08f82d9a13df00acf
    Reviewed-on: https://chromium-review.googlesource.com/1133959
    Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574682}

    Changed files

    • chrome/browser/resources/md_downloads/item.html
    • chrome/browser/resources/md_extensions/detail_view.html
    • chrome/browser/resources/md_extensions/error_page.html
    • chrome/browser/resources/md_extensions/manager.html
    • chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
    • chrome/browser/resources/settings/device_page/storage.html
    • chrome/browser/resources/settings/internet_page/network_summary_item.html
    • chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
    • chrome/browser/resources/settings/people_page/setup_pin_dialog.html
    • chrome/browser/resources/settings/settings_page/settings_subpage_search.html
    • chrome/browser/resources/settings/settings_shared_css.html
    • chrome/browser/resources/settings/site_settings/zoom_levels.html
    • ui/webui/resources/cr_elements/chromeos/network/cr_network_list_item.html
    • ui/webui/resources/cr_elements/paper_tabs_style_css.html
  20. Add high water mark in background profiling triggers for memlog.

    Changed by erikchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:47:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3483cb3aa6a9343b22e8ec39e81cb2fc864970a3

    Comments

    Add high water mark in background profiling triggers for memlog.
    
    Previously, a memlog report would be uploaded if a fixed threshold was exceeded.
    After that point, the timer frequency would be reduced to prevent too many
    reports from being uploaded.
    
    In this CL, we use a fixed, higher frequency timer to check memory usage. We
    upload an initial report if the fixed thresholds are exceeded, and then upload
    more reports each time the high water mark is exceeded by a significant amount.
    This allows us to catch higher-velocity memory leaks, that might otherwise cause
    the process to be killed before a report would be uploaded with the previous
    mechanism.
    
    Change-Id: I706314810d962c51e4126157363f44ce64868721
    Reviewed-on: https://chromium-review.googlesource.com/1132099
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Reviewed-by: Siddhartha S <ssid@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574683}

    Changed files

    • chrome/browser/profiling_host/background_profiling_triggers.cc
    • chrome/browser/profiling_host/background_profiling_triggers.h
    • chrome/browser/profiling_host/background_profiling_triggers_unittest.cc
  21. [Fuchsia] Remove package detection in base::PathProviderFuchsia()

    Changed by sergeyuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:48:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4f9d9e774d5d41a5d8073b156348eee4bde25753

    Comments

    [Fuchsia] Remove package detection in base::PathProviderFuchsia()
    
    Previously PathProvider was trying to detect if it's packaged or not.
    That logic is no longer needed because we can assume that all binaries
    produced in chromium are packaged.
    
    Change-Id: I963afac5342d44b8d8188c07ffb927d6b4fac271
    Reviewed-on: https://chromium-review.googlesource.com/1134586
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574684}

    Changed files

    • base/base_paths_fuchsia.cc
  22. Network quality servicification of RTT and downlink estimates

    Changed by tbansalohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:56:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 88c8cc52351f93d11e0bfac3b75ded5b420b131b

    Comments

    Network quality servicification of RTT and downlink estimates
    
    Send the RTT and downlink estimates over the mojo channel
    to the browser process. The RTT and downlink estimates are
    sent over an existing mojo message which carrier the current
    effective connection type estimate.
    
    The mojo message is sent only if there is a significant change
    in the values of either the RTT or the downlink estimate.
    
    In the next CL, I will move the network quality consumers
    in the browser process over to NetworkQualityTracker.
    
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: I01bbc7af2e7e3cf41f69e7ac19f8edd9ec59de90
    Bug: 819244
    Reviewed-on: https://chromium-review.googlesource.com/1130233
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Helen Li <xunjieli@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574685}

    Changed files

    • chrome/browser/net/network_quality_tracker_browsertest.cc
    • services/network/network_quality_estimator_manager.cc
    • services/network/network_quality_estimator_manager.h
    • services/network/network_quality_estimator_manager_unittest.cc
    • services/network/public/cpp/network_quality_tracker.cc
    • services/network/public/cpp/network_quality_tracker.h
    • services/network/public/cpp/network_quality_tracker_unittest.cc
    • services/network/public/mojom/network_quality_estimator_manager.mojom
  23. [Nav Experiment] Parameterize HistoryStateOperationsTest.

    Changed by danyaoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:57:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 32bdecc1fac228cf335811bea0f31e2a29153f29

    Comments

    [Nav Experiment] Parameterize HistoryStateOperationsTest.
    
    So both LegacyNavigationManager and WKBasedNavigationManager can be
    tested on trybots.
    
    Fixed test expectation for StateReplacementBackForward to match the
    behavior of WebKit (and Safari on other platforms).
    
    Bug: 862724
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ic01dcabf2e6ef6903d8f8ee348798951007660cc
    Reviewed-on: https://chromium-review.googlesource.com/1134472
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574686}

    Changed files

    • ios/web/navigation/history_state_operations_inttest.mm
  24. [chromecast] Support for top-down drag gesture.

    Changed by rdaumohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:00:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7281e2b2ea7ce739c6106b6005a2d58a9eedb86a

    Comments

    [chromecast] Support for top-down drag gesture.
    
    Bug: internal b/111304882
    Test: unit test and manual
    Change-Id: Iab32b58098a02eb054faeb94625e312d274cdae1
    Reviewed-on: https://chromium-review.googlesource.com/1135692
    Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
    Commit-Queue: Alex Sakhartchouk <alexst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574687}

    Changed files

    • chromecast/browser/cast_content_window.h
    • chromecast/browser/cast_gesture_dispatcher.cc
    • chromecast/browser/cast_gesture_dispatcher.h
    • chromecast/browser/cast_gesture_dispatcher_test.cc
  25. VR: fix autofill popup size

    Changed by asimjourohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:01:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9d07f06bb5c43657ce38efc57039e36287eac2a6

    Comments

    VR: fix autofill popup size
    
    Break SetAlertDialogSize into to methods. One to set the relative
    size to the main content, another one to set the absolute size.
    Also added comment to hosted_platform_ui to clarify the size of
    the rectangle in the model.
    
    Bug: 863071
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Ie102fcb00865d66052e4bb3c7817831fdcfe5dfa
    Reviewed-on: https://chromium-review.googlesource.com/1132140
    Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
    Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574688}

    Changed files

    • chrome/browser/android/vr/vr_shell_gl.cc
    • chrome/browser/vr/model/hosted_platform_ui.h
    • chrome/browser/vr/ui.cc
    • chrome/browser/vr/ui.h
  26. Improved performance of AXPosition::operator less than

    Changed by nektarohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:01:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision adeaf13d9c8651fcf83c9e5a6a7d1173f1eb27e1

    Comments

    Improved performance of AXPosition::operator less than
    
    Only move up or down the tree using text equivalent positions (by calling CreateParentPosition and AsLeafTextPosition) when we absolutely need to.
    R=dmazzoni@chromium.org
    
    Tested: VoiceOver on Mac by navigating in Gmail and checking how many times you hear "Busy"
    Change-Id: Id9469e52ef87b8b8a0c6c5fac5325abec415382d
    Bug: 861567
    Reviewed-on: https://chromium-review.googlesource.com/1133334
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Nektarios Paisios <nektar@chromium.org>
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574689}

    Changed files

    • ui/accessibility/ax_node_position_unittest.cc
    • ui/accessibility/ax_position.h
  27. Move content::MediaController to media/base

    Changed by tguilbertohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:02:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2784a2c6630a8de538a7b2bf6d993823d321a489

    Comments

    Move content::MediaController to media/base
    
    The MediaController interface and the upcoming MediaStatusObserver do
    not have to live in content/public/browser. The media/base folder and
    the media namespace is a more generic place for them to live, even if
    most of the code that will use them lives in content.
    
    Bug: 820277
    Change-Id: I2f91cd88c6f5238723aae8aeff1c323c02f738d4
    Reviewed-on: https://chromium-review.googlesource.com/1134090
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574690}

    Changed files

    • chrome/browser/media/android/remote/media_controller_bridge.h
    • chrome/browser/media/android/router/media_router_android.cc
    • chrome/browser/media/android/router/media_router_android.h
    • chrome/browser/media/android/router/media_router_android_bridge.cc
    • chrome/browser/media/android/router/media_router_android_bridge.h
    • chrome/browser/media/router/media_router.h
    • chrome/browser/media/router/media_router_base.cc
    • chrome/browser/media/router/media_router_base.h
    • chrome/browser/media/router/presentation/presentation_service_delegate_impl.cc
    • chrome/browser/media/router/presentation/presentation_service_delegate_impl.h
    • content/browser/media/flinging_renderer.cc
    • content/browser/media/flinging_renderer.h
    • content/browser/media/flinging_renderer_unittest.cc
    • content/browser/presentation/presentation_service_impl_unittest.cc
    • content/public/browser/BUILD.gn
    • content/public/browser/presentation_service_delegate.h
    • media/base/BUILD.gn
    • media/base/media_controller.h
  28. Make content::PermissionManager a delegate of PermissionController

    Changed by lushnikovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:02:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ebff0440cc1ada42a20446c0f6d9ddf0619f64df

    Comments

    Make content::PermissionManager a delegate of PermissionController
    
    One-pager describing this refactoring: https://goo.gl/24gkCb
    
    Today, `content/` layer provides `permission_manager.h` interface that
    is supposed to be implemented by embedders and simultaneously used
    as API in `content/` layer. This leaves us with no place in content/ layer
    where we can put DevTools instrumentation.
    
    This patch separates content API from embedder interface. With this
    patch, `content/` layer provides 2 interfaces:
    - co
    ...skip...
    ionManager()` into `TestBrowserContext::SetPermissionControllerDelegate()`.
    
    R=dgozman
    TBR=sdefresne, tobiasjs, slan, thakis
    BUG=631464
    
    Change-Id: I5f6f1ea5b28e284c462a5055d9b072f12f30ce19
    Reviewed-on: https://chromium-review.googlesource.com/1111340
    Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574691}

    Changed files

    • android_webview/browser/aw_permission_manager.cc
    • chrome/browser/net/reporting_permissions_checker.cc
    • chrome/browser/notifications/platform_notification_service_impl.cc
    • chrome/browser/permissions/permission_manager.cc
    • chromecast/browser/cast_permission_manager.cc
    • components/domain_reliability/service.cc
    • components/domain_reliability/service_unittest.cc
    • components/payments/content/installable_payment_app_crawler.cc
    • content/browser/BUILD.gn
    • content/browser/background_sync/background_sync_manager.cc
    • content/browser/browser_context.cc
    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/generic_sensor/sensor_provider_proxy_impl.cc
    • content/browser/generic_sensor/sensor_provider_proxy_impl.h
    • content/browser/geolocation/geolocation_service_impl.cc
    • content/browser/geolocation/geolocation_service_impl.h
    • content/browser/geolocation/geolocation_service_impl_unittest.cc
    • content/browser/notifications/blink_notification_service_impl.cc
    • content/browser/payments/payment_app_provider_impl.cc
    • content/browser/permissions/permission_controller_impl.cc
    • content/browser/permissions/permission_controller_impl.h
    • content/browser/permissions/permission_service_context.cc
    • content/browser/permissions/permission_service_impl.cc
    • content/browser/push_messaging/push_messaging_manager.cc
    • content/public/browser/BUILD.gn
    • content/public/browser/browser_context.h
    • content/public/browser/permission_controller.h
    • content/public/browser/permission_manager.h
    • content/public/test/mock_permission_manager.cc
    • content/shell/browser/layout_test/layout_test_permission_manager.cc
    • content/shell/browser/shell_permission_manager.cc
    • headless/lib/browser/headless_permission_manager.cc
  29. milo: Add link to chromiumos tryserver to chromium's console.

    Changed by bpasteneohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:03:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6678ca5e07d42a16c0e63b123543672ab94c3c29

    Comments

    milo: Add link to chromiumos tryserver to chromium's console.
    
    And alphabetize the list.
    
    R=hinoka
    
    Change-Id: I28d7c354c153f848fae7098e57b67445345cb850
    Reviewed-on: https://chromium-review.googlesource.com/1135691
    Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    Commit-Queue: Ben Pastene <bpastene@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574692}

    Changed files

    • infra/config/global/luci-milo.cfg
  30. [Mac] Refactor BrowserWindowTouchBarMac

    Changed by spqchanohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:05:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e95b7292bae44c8e6fb9af5801f102ae28587d6c

    Comments

    [Mac] Refactor BrowserWindowTouchBarMac
    
    Separate BrowserWindowTouchBarMac into two classes:
    BrowserWindowDefaultTouchBar and
    BrowserWindowTouchBarController.
    
    BrowserWindowTouchBarController determines what
    touch bar should be used for browser window.
    BrowserWindowDefaultTouchBar creates a default
    touch bar for the browser.
    
    These changes are split from a bigger change to
    hook up touch bar support for web textfield in
    MacViews:
    
    https://chromium-review.googlesource.com/c/chromium/src/+/1132597
    
    Bug: 856391
    Change-Id: I9be31c65bd0acc2ec4d39b5e2f6b06fc30e36bf7
    Reviewed-on: https://chromium-review.googlesource.com/1133705
    Commit-Queue: Sarah Chan <spqchan@chromium.org>
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574693}

    Changed files

    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/browser_window_touch_bar_mac.h
    • chrome/browser/ui/cocoa/browser_window_controller.h
    • chrome/browser/ui/cocoa/browser_window_controller.mm
    • chrome/browser/ui/cocoa/framed_browser_window.mm
    • chrome/browser/ui/cocoa/touchbar/browser_window_default_touch_bar.h
    • chrome/browser/ui/cocoa/touchbar/browser_window_default_touch_bar.mm
    • chrome/browser/ui/cocoa/touchbar/browser_window_default_touch_bar_unittest.mm
    • chrome/browser/ui/cocoa/touchbar/browser_window_touch_bar_controller.h
    • chrome/browser/ui/cocoa/touchbar/browser_window_touch_bar_controller.mm
    • chrome/browser/ui/cocoa/touchbar/browser_window_touch_bar_controller_browsertest.mm
    • chrome/browser/ui/views/frame/browser_frame_mac.mm
    • chrome/test/BUILD.gn
  31. Remove components/viz/test dependency from blink platform.

    Changed by kraynovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:07:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8a7df13b2932f8f83559de4c263c972e08f9301b

    Comments

    Remove components/viz/test dependency from blink platform.
    
    cc::OrderedSimpleTestTaskRunner isn't used there anymore.
    
    Bug: 841735
    Change-Id: I88a5bfa2ebaf01a08943396ce20f63c483a19b3a
    Reviewed-on: https://chromium-review.googlesource.com/1133177
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Commit-Queue: Greg Kraynov <kraynov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574694}

    Changed files

    • third_party/blink/renderer/platform/scheduler/BUILD.gn
    • third_party/blink/renderer/platform/scheduler/child/DEPS
    • third_party/blink/renderer/platform/scheduler/common/DEPS
    • third_party/blink/renderer/platform/scheduler/main_thread/DEPS
    • third_party/blink/renderer/platform/scheduler/renderer/DEPS
    • third_party/blink/renderer/platform/scheduler/worker/DEPS
    • third_party/blink/renderer/platform/testing/DEPS
  32. Chrome Cleanup UI: Extract GetLastUsedProfile call from scanner results

    Changed by nburrisohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 20:11:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision feda02794921ad4eca0b4c5d15c21bc0461e73fa

    Comments

    Chrome Cleanup UI: Extract GetLastUsedProfile call from scanner results
    
    Chrome runs into a fatal error when the cleaner detects unwanted
    software. This is because ChromeCleanerScannerResults is created in the
    IO thread, and ProfileManager::GetLastUsedProfile requires the UI
    thread. The tests passed because they run a test browser process.
    
    - Extract extension name fetching to a separate function.
    - Call this function in tests so they're not affected.
    - Follow-up CL: Call this function once the scanner results are on the
    UI thread, before they're sent to the web UI.
    
    Bug: 853339
    Change-Id: I9cc2425f7b196e923a22b2afd1e8eee7fca61f5b
    Reviewed-on: https://chromium-review.googlesource.com/1135194
    Commit-Queue: Nick Burris <nburris@google.com>
    Reviewed-by: proberge <proberge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574695}

    Changed files

    • chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win_unittest.cc
    • chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win_unittest.cc
    • chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_scanner_results.cc
    • chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_scanner_results.h
  33. Roll src/third_party/webrtc 798ee75d2365..895617fa9bc3 (3 commits)

    Changed by webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 20:12:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 460febcbc6e56f2355493a4f43188b08753c2dc6

    Comments

    Roll src/third_party/webrtc 798ee75d2365..895617fa9bc3 (3 commits)
    
    https://webrtc.googlesource.com/src.git/+log/798ee75d2365..895617fa9bc3
    
    
    git log 798ee75d2365..895617fa9bc3 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 buildbot@webrtc.org Roll chromium_revision efbdada3f7..f7c234b027 (574489:574598)
    2018-07-12 magjed@webrtc.org Android: Add helper functions for comparing H264 codecs
    2018-07-12 saza@webrtc.org Remove useless import of arm.gni
    
    
    Created with:
      gclient setdep -r src/thir
    ...skip...
    mac:mac_chromium_archive_rel_ng
    
    BUG=chromium:None,chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I07750ee2f3c028532fb0dfbfa0386eeeb119c8f8
    Reviewed-on: https://chromium-review.googlesource.com/1135612
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574696}

    Changed files

    • DEPS
  34. device/fido/mac: integrate with browsing data deletion

    Changed by martinkrohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 20:13:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d54b58e5b08b96664080795a01e0bd2373952e6e

    Comments

    device/fido/mac: integrate with browsing data deletion
    
    This updates browsing data deletion for DATA_TYPE_PASSWORDS to call
    device::fido::mac::DeleteWebAuthnCredentials, which deletes credentials
    created by the macOS platform authenticator from the OS keychain.
    
    Also combine the two Touch ID specific configuration methods in
    {Chrome,}AuthenticatorRequestDelegate and introduce a static variant for
    Chrome.
    
    Bug: 678128
    Change-Id: I0034e0815da068fb27c1ea60cad95f958956838e
    Reviewed-on: https://chromium-review.googlesource.com/1125177
    Commit-Queue: Martin Kreichgauer <martinkr@google.com>
    Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Christian Dullweber <dullweber@chromium.org>
    Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574697}

    Changed files

    • chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
    • chrome/browser/webauthn/chrome_authenticator_request_delegate.cc
    • chrome/browser/webauthn/chrome_authenticator_request_delegate.h
    • chrome/browser/webauthn/chrome_authenticator_request_delegate_unittest.cc
    • content/browser/webauth/authenticator_impl.cc
    • content/public/browser/authenticator_request_client_delegate.cc
    • content/public/browser/authenticator_request_client_delegate.h
    • device/fido/mac/authenticator.h
  35. Revert "[AF][IOS] Scan page for form changes when a field is focused"

    Changed by mahmadiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:13:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4b937d53836386e51532fbe870938b33ce0455ed

    Comments

    Revert "[AF][IOS] Scan page for form changes when a field is focused"
    
    This reverts commit 77318515062e22c6dbcb5b4ae8c6daa4ef70d5b9.
    
    Reason for revert:
    This change caused a regression (crbug.com/860225). The cause of the regression is that when user focuses a field in order to edit it, Autofill::OnFormsSeen is called which in turn updates the cached form with the new user entered values. Once submitted, form values are discarded as they're thought to be the initial form values on page load. In its cu
    ...skip...
    >
    > Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#570713}
    
    TBR=olivierrobin@chromium.org,mahmadi@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 855696, 860225
    Change-Id: Icc39e67e6d502d75451dbec83d6271255639ee4c
    Reviewed-on: https://chromium-review.googlesource.com/1135671
    Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
    Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574698}

    Changed files

    • components/autofill/ios/browser/autofill_agent.mm
  36. Remove assertion from DetachToOwnWindow on macOS 10.10.

    Changed by erikchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:16:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b20bb048913985eae71b480db2a2017173ef73a2

    Comments

    Remove assertion from DetachToOwnWindow on macOS 10.10.
    
    On macOS 10.10, AppKit appears to use the test's generated events to
    asynchronously reactivate the first window. There's no way to tell when this
    asynchronous reactivation will happen, so just avoid checking the assertion in
    the test. This problem appears constrained to how we generate test events, and
    not to the actual behavior of Chrome.
    
    Bug: 862859
    Change-Id: Ibab56946bef3aea9aac3123d3d8aefdb7974d063
    Reviewed-on: https://chromium-review.googlesource.com/1135305
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574699}

    Changed files

    • chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
  37. Migrate PrivetTrafficDetector to use NetworkConnectionTracker.

    Changed by rmcelrathohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:20:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9b78521765f33993e81dfba771127fe9d5eb4add

    Comments

    Migrate PrivetTrafficDetector to use NetworkConnectionTracker.
    
    This migrates PrivetTrafficDetector from using
    net::NetworkChangeNotifier to content::NetworkConnectionTracker, which
    works with the network service enabled.
    
    Bug: 859134
    Change-Id: I06f2ecbe142bbed9a8772f69ab109b0c0dc32581
    Reviewed-on: https://chromium-review.googlesource.com/1123681
    Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
    Reviewed-by: Lei Zhang <thestig@chromium.org>
    Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574700}

    Changed files

    • chrome/browser/printing/cloud_print/privet_traffic_detector.cc
    • chrome/browser/printing/cloud_print/privet_traffic_detector.h
  38. Reset listener properties after provisional load

    Changed by ekaramadohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:25:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8afd07cc1159e077da359175edefd419a090fb7d

    Comments

    Reset listener properties after provisional load
    
    When provisional load is committed in FrameLoader and the corresponding
    frame is a LocalRoot, the EventListenerProperties are reset to none for
    touch and wheel listeners. This update is then propagate through render
    widget and LayterTreeHost to the browser and the CC correspondingly.
    
    However, if the local root is provisional the call is dropped in
    ChromeClientImpl. This would include all cross-process navigations which
    end up in a provisional frame.
    
    This change will make sure the initial updates for
    EventListenerProperties for a local root are sent after
    WebLocalFrameClient is notified about committing provisional load.
    
    Bug: 850994
    Change-Id: I686ab51277bf675d93bd744d6d0208977ac06b5c
    Reviewed-on: https://chromium-review.googlesource.com/1126329
    Commit-Queue: Ehsan Karamad <ekaramad@google.com>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574701}

    Changed files

    • content/browser/renderer_host/input/input_router_impl.h
    • content/browser/renderer_host/render_widget_host_browsertest.cc
    • third_party/blink/renderer/core/exported/local_frame_client_impl.cc
    • third_party/blink/renderer/core/loader/frame_loader.cc
  39. Record when a user presses Enter on a web page.

    Changed by uwyimingohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 20:28:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fb5a18d97233f6a11c4606fa3b085d2b7ba0ff11

    Comments

    Record when a user presses Enter on a web page.
    
    This change adds a feature that allows the Action Recorder Extension to
    detect when a user presses the Enter key on a page, and records this
    action. Pressing the Enter key is a common action that a user invokes to
    submit a form.
    
    Bug: 855284
    Change-Id: Ia0ec4ab99683266f09a422a4f7ae24fe52eb0b0b
    Reviewed-on: https://chromium-review.googlesource.com/1135523
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Commit-Queue: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574702}

    Changed files

    • components/test/data/autofill/automated_integration/action_recorder_extension/content/action_handler.js
    • components/test/data/autofill/automated_integration/action_recorder_extension/content/panel.js
  40. Android: Do not generate R.java from android_apk AndroidManifest.xml

    Changed by tiborgohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:29:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 01020f3bca281b6de9bd9deacbe849cbc1255cfa

    Comments

    Android: Do not generate R.java from android_apk AndroidManifest.xml
    
    In order to implement synchronized proguarding we cannot have multiple
    R class with the same package. Thus, prevent creation of R files with
    manifest's package when creating APKs.
    
    Bug: 862696
    Change-Id: I51253c0434f18e19ea627710beaa85b8690b175c
    Reviewed-on: https://chromium-review.googlesource.com/1134414
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574703}

    Changed files

    • build/android/gyp/compile_resources.py
    • build/android/gyp/util/resource_utils.py
  41. Import wpt@df05bcb7c5c82e300805d7c11121453ec4036e32

    Changed by blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:29:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e40e820481f52c0cc29b1841542b4e24465909bd

    Comments

    Import wpt@df05bcb7c5c82e300805d7c11121453ec4036e32
    
    Using wpt-import in Chromium a7edd65b959ed3edbb808bd0bd2c914e5a92cfff.
    With Chromium commits locally applied on WPT:
    a9045946af "Add a fail-fast for longtask layouttests"
    
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21190
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectatio
    ...skip...
    googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    jsbell@chromium.org, mek@chromium.org:
      external/wpt/FileAPI
    
    TBR=foolip
    
    No-Export: true
    Change-Id: I99e9ecbe3e626ec461f4663c7d48a6896f6a9616
    Reviewed-on: https://chromium-review.googlesource.com/1135585
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574704}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json
    • third_party/WebKit/LayoutTests/external/wpt/FileAPI/idlharness.html
    • third_party/WebKit/LayoutTests/external/wpt/FileAPI/idlharness.worker.js
  42. Update Flash plugin metadata versions to latest version.

    Changed by wfhohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:31:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e233c1d178562ac6171d190f1e4d9ec9a94ac11e

    Comments

    Update Flash plugin metadata versions to latest version.
    
    https://helpx.adobe.com/security/products/flash-player/apsb18-24.html
    
    BUG=412078
    TBR=jschuh@chromium.org
    
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Iecc32fe539d6d16418086f9d8b4e44fde19bdd69
    Reviewed-on: https://chromium-review.googlesource.com/1135713
    Commit-Queue: Will Harris <wfh@chromium.org>
    Reviewed-by: Will Harris <wfh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574705}

    Changed files

    • chrome/browser/resources/plugin_metadata/plugins_linux.json
    • chrome/browser/resources/plugin_metadata/plugins_mac.json
    • chrome/browser/resources/plugin_metadata/plugins_win.json
  43. Stop using ResourceContext::GetHostResolver().

    Changed by jamohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:32:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ed5e651e10cd158bf786b33c0dcd77d714244d2e

    Comments

    Stop using ResourceContext::GetHostResolver().
    
    ResourceContext is deprecated, and after r567879 it returns nullptr when network service is enabled.
    
    Instead get the HostResolver from the URLRequestContext. Also remove ResourceContext::GetHostResolver() as it's no longer used.
    
    Bug: 853696
    Change-Id: Ic09dac09f14e4aaf0e20dd990246cc51ae35e933
    Reviewed-on: https://chromium-review.googlesource.com/1135366
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574706}

    Changed files

    • android_webview/browser/aw_resource_context.cc
    • android_webview/browser/aw_resource_context.h
    • chrome/browser/profiles/profile_io_data.cc
    • chrome/browser/profiles/profile_io_data.h
    • chromecast/browser/cast_browser_context.cc
    • content/browser/renderer_host/p2p/socket_dispatcher_host.cc
    • content/browser/renderer_host/p2p/socket_dispatcher_host.h
    • content/browser/renderer_host/pepper/pepper_host_resolver_message_filter.cc
    • content/browser/renderer_host/pepper/pepper_host_resolver_message_filter.h
    • content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc
    • content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.h
    • content/browser/renderer_host/render_process_host_impl.cc
    • content/public/browser/resource_context.h
    • content/public/test/mock_resource_context.cc
    • content/public/test/mock_resource_context.h
    • content/shell/browser/shell_browser_context.cc
    • content/shell/browser/shell_browser_context.h
    • content/shell/browser/shell_url_request_context_getter.cc
    • content/shell/browser/shell_url_request_context_getter.h
    • extensions/browser/api/dns/dns_api.cc
    • extensions/browser/api/dns/dns_api.h
    • extensions/browser/api/dns/host_resolver_wrapper.cc
    • extensions/browser/api/dns/host_resolver_wrapper.h
    • extensions/browser/api/socket/socket_api.cc
    • extensions/browser/api/socket/socket_api.h
    • headless/lib/browser/headless_browser_context_impl.cc
    • webrunner/browser/webrunner_browser_context.cc
  44. Clone service worker objects to nested workers

    Changed by japhetohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:36:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 62cb57146b83dcd0b2b2add48c4cfe02b3d770b9

    Comments

    Clone service worker objects to nested workers
    
    Bug: 31666
    Change-Id: I8db30dee7c6b72430eb4083536fca73606de76e8
    Reviewed-on: https://chromium-review.googlesource.com/1130101
    Commit-Queue: Nate Chapin <japhet@chromium.org>
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574707}

    Changed files

    • content/renderer/loader/web_worker_fetch_context_impl.cc
    • content/renderer/loader/web_worker_fetch_context_impl.h
    • content/renderer/render_frame_impl.cc
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/claim-worker-fetch.https-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/claim-worker-fetch.https.html
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/claim-nested-worker-fetch-iframe.html
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/claim-nested-worker-fetch-parent-worker.js
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/nested_load_worker.js
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/worker-interception-iframe.https.html
  45. Implemented headless compositor protocol tests for basic rAF, GIF and CSS animations. (III)

    Changed by kvitekpohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:37:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dcd804265b610b002db7023e6c180bd12e1e29bb

    Comments

    Implemented headless compositor protocol tests for basic rAF, GIF and CSS animations. (III)
    
    Browser flags that are required for BeginFrameControl are now set only
    for compositor specific tests thus preventing virtual time flakyness.
    
    Reinstate VirtualTimeErrorLoop test since this change fixes its
    flakiness.
    
    Change-Id: I0b01a81df1b8be63da316b27f7404f929f1e0fd1
    Reviewed-on: https://chromium-review.googlesource.com/1133711
    Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
    Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574708}

    Changed files

    • headless/test/DEPS
    • headless/test/data/protocol/emulation/compositor-basic-raf-expected.txt
    • headless/test/data/protocol/emulation/compositor-basic-raf.js
    • headless/test/data/protocol/emulation/compositor-css-animation-test-expected.txt
    • headless/test/data/protocol/emulation/compositor-css-animation-test.js
    • headless/test/data/protocol/emulation/compositor-image-animation-test-expected.txt
    • headless/test/data/protocol/emulation/compositor-image-animation-test.js
    • headless/test/data/protocol/emulation/resources/animated_square.gif
    • headless/test/data/protocol/emulation/resources/compositor-basic-raf.html
    • headless/test/data/protocol/emulation/resources/compositor-css-animation.html
    • headless/test/data/protocol/emulation/resources/compositor-image-animation.html
    • headless/test/headless_protocol_browsertest.cc
  46. [Autofill] Log metric for whether card upload cardholder name was edited

    Changed by jsaulohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 20:40:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1447fae2e377e748f4ddb532a99f6c5ba7319c98

    Comments

    [Autofill] Log metric for whether card upload cardholder name was edited
    
    Bug: 848955
    Change-Id: I8febd9c3471b58b962d3706eede4be506b092044
    Reviewed-on: https://chromium-review.googlesource.com/1134089
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Commit-Queue: Jared Saul <jsaul@google.com>
    Cr-Commit-Position: refs/heads/master@{#574709}

    Changed files

    • chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
    • chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
    • components/autofill/core/browser/autofill_metrics.cc
    • components/autofill/core/browser/autofill_metrics.h
    • tools/metrics/histograms/histograms.xml
  47. Change RulesMonitorService::HasRegisteredRuleset to take an extension_id.

    Changed by karandeepbohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:47:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b96ae12ef5fa70c2389e5b23da5a924eb4dff359

    Comments

    Change RulesMonitorService::HasRegisteredRuleset to take an extension_id.
    
    This CL changes RulesMonitorService::HasRegisteredRuleset to take an
    extension_id instead of an extension pointer.
    
    BUG=None
    
    Change-Id: If6d220b7bcaf9be473ff819961f5ed9fe67f681f
    Reviewed-on: https://chromium-review.googlesource.com/1134519
    Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
    Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574710}

    Changed files

    • extensions/browser/api/declarative_net_request/declarative_net_request_api.cc
    • extensions/browser/api/declarative_net_request/rules_monitor_service.cc
    • extensions/browser/api/declarative_net_request/rules_monitor_service.h
  48. Use UMA_HISTOGRAM_TIMES or saturated_cast to report milliseconds

    Changed by npmohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:49:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3e44f3be427bb7222e8e20640e261d620478e8bc

    Comments

    Use UMA_HISTOGRAM_TIMES or saturated_cast to report milliseconds
    
    This CL changes Blink code from using Count(delta.InMilliseconds()) to:
    * UMA_HISTOGRAM_TIMES where possible.
    * Otherwise, UMA_HISTOGRAM_CUSTOM_COUNTS if possible.
    * Otherwise, saturated_cast.
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I4f6e2ae0fb318b906ec75c546bea519cd130b09e
    Reviewed-on: https://chromium-review.googlesource.com/1134083
    Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
    Reviewed-by: Jeremy Roman <jbroman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574711}

    Changed files

    • third_party/blink/renderer/core/editing/spellcheck/spell_check_requester.cc
    • third_party/blink/renderer/core/html/media/autoplay_uma_helper.cc
    • third_party/blink/renderer/core/html/parser/css_preload_scanner.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_timeline_metrics.cc
    • third_party/blink/renderer/modules/notifications/notification_image_loader.cc
    • third_party/blink/renderer/platform/heap/heap_stats_collector.cc
    • third_party/blink/renderer/platform/heap/heap_stats_collector.h
    • third_party/blink/renderer/platform/heap/heap_stats_collector_test.cc
    • third_party/blink/renderer/platform/heap/thread_state.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
  49. RC: Record Chrome usage time when a LifecycleUnit is hidden.

    Changed by fdorayohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:54:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 840dc0a7c0eacb82070efe833ef3aacc7b2e89cb

    Comments

    RC: Record Chrome usage time when a LifecycleUnit is hidden.
    
    With this CL, the total Chrome usage time measured by UsageClock is
    recorded in a LifecycleUnit when it is hidden. In an upcoming CL, this
    will be used to discard a LifecycleUnit after a given amount of Chrome
    usage time has elapsed since it was hidden.
    
    We also record the wall time when a LifecycleUnit is hidden, because
    freezing occurs when a LifeycleUnit has been hidden for a given amount
    of wall clock time, not Chrome usage time.
    
    Bug: 775644
    Change-Id: I76d504e9bbf3eb86ded1203e4e117086faf93277
    Reviewed-on: https://chromium-review.googlesource.com/1133593
    Commit-Queue: François Doray <fdoray@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574712}

    Changed files

    • chrome/browser/browser_process_impl.cc
    • chrome/browser/browser_process_impl.h
    • chrome/browser/resource_coordinator/lifecycle_unit.h
    • chrome/browser/resource_coordinator/lifecycle_unit_base.cc
    • chrome/browser/resource_coordinator/lifecycle_unit_base.h
    • chrome/browser/resource_coordinator/lifecycle_unit_base_unittest.cc
    • chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
    • chrome/browser/resource_coordinator/tab_lifecycle_unit.h
    • chrome/browser/resource_coordinator/tab_lifecycle_unit_source.cc
    • chrome/browser/resource_coordinator/tab_lifecycle_unit_source.h
    • chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc
    • chrome/browser/resource_coordinator/tab_manager.cc
    • chrome/browser/resource_coordinator/tab_manager.h
    • chrome/browser/resource_coordinator/tab_manager_stats_collector.cc
    • chrome/browser/resource_coordinator/test_lifecycle_unit.cc
    • chrome/browser/resource_coordinator/test_lifecycle_unit.h
    • chrome/test/base/testing_browser_process.cc
    • chrome/test/base/testing_browser_process.h