Home | Search
Login

Builder Android Cronet Builder Asan Build #6673 Canonical Ubuntu

Results:

build successful

Trigger Info:

Execution:

Steps and Logfiles:

Show:
  1. ( 35 mins 29 secs ) steps
    running steps via annotated script
  2. ( 10 secs ) update_scripts
    update_scripts
  3. ( 3 ms ) setup_properties
    setup_properties
  4. ( 3 ms ) LUCI Migration
    LUCI Migration
  5. ( 3 ms ) LogDog Bootstrap
    LogDog Bootstrap
  6. ( 2 ms ) setup_build
    setup_build
    running recipe: "cronet"
  7. ( 19 secs ) remove .cipd
    remove .cipd
  8. ( 1 mins 52 secs ) cleanup index.lock
    cleanup index.lock
  9. ( 4 mins 49 secs ) bot_update
    bot_update
    [102GB/442GB used (23%)]
  10. ( 4 ms ) clean local files
    clean local files
  11. ( 3 ms ) ensure_goma
    ensure_goma
  12. ( 4 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  13. ( 3 ms ) clobber
    clobber
  14. ( 12 secs ) gclient runhooks
    gclient runhooks
  15. ( 1 mins 33 secs ) generate_build_files
    generate_build_files
  16. ( 4 ms ) clang_revision
    clang_revision
  17. ( 3 ms ) preprocess_for_goma
    preprocess_for_goma
  18. ( 3 ms ) preprocess_for_goma.goma cache directory
    preprocess_for_goma.goma cache directory
  19. ( 3 ms ) preprocess_for_goma.start_goma
    preprocess_for_goma.start_goma
  20. ( 3 ms ) preprocess_for_goma.start cloudtail
    preprocess_for_goma.start cloudtail
  21. ( 4 mins 58 secs ) compile
    compile
  22. ( 3 ms ) compile confirm no-op
    compile confirm no-op
  23. ( 3 ms ) postprocess_for_goma
    postprocess_for_goma
  24. ( 4 ms ) postprocess_for_goma.goma_jsonstatus
    postprocess_for_goma.goma_jsonstatus
  25. ( 3 ms ) postprocess_for_goma.goma_stat
    postprocess_for_goma.goma_stat
  26. ( 3 ms ) postprocess_for_goma.stop_goma
    postprocess_for_goma.stop_goma
  27. ( 10 secs ) postprocess_for_goma.upload_log
    postprocess_for_goma.upload_log
  28. ( 3 ms ) postprocess_for_goma.stop cloudtail
    postprocess_for_goma.stop cloudtail
  29. ( 3 ms ) get version
    get version
  30. ( 3 ms ) create adb symlink
    create adb symlink
  31. ( 3 ms ) spawn_logcat_monitor
    spawn_logcat_monitor
  32. ( 3 ms ) spawn_device_monitor
    spawn_device_monitor
  33. ( 3 ms ) authorize_adb_devices
    authorize_adb_devices
  34. ( 9 secs ) device_recovery
    device_recovery
  35. ( 2 mins 35 secs ) provision_devices
    provision_devices
  36. ( 9 ms ) device_status
    device_status
    Online devices: 4
  37. ( 3 ms ) get_clang_version
    get_clang_version
  38. ( 3 ms ) Set up ASAN on devices
    Set up ASAN on devices
  39. ( 4 ms ) Set up ASAN on devices.List adb devices
    Set up ASAN on devices.List adb devices
  40. ( 4 ms ) Set up ASAN on devices.Root devices
    Set up ASAN on devices.Root devices
  41. ( 3 ms ) Set up ASAN on devices.0aa6b19043e4b976
    Set up ASAN on devices.0aa6b19043e4b976
  42. ( 3 ms ) Set up ASAN on devices.06596466005cab1a
    Set up ASAN on devices.06596466005cab1a
  43. ( 3 ms ) Set up ASAN on devices.05c34aa83444c162
    Set up ASAN on devices.05c34aa83444c162
  44. ( 5 secs ) Set up ASAN on devices.0accc2af43e4affc
    Set up ASAN on devices.0accc2af43e4affc
  45. ( 13 secs ) Set up ASAN on devices.wait_for_devices
    Set up ASAN on devices.wait_for_devices
  46. ( 47 secs ) cronet_unittests_android
    cronet_unittests_android
  47. ( 9 mins 43 secs ) net_unittests
    net_unittests
  48. ( 17 secs ) cronet_sample_test_apk
    cronet_sample_test_apk
  49. ( 4 ms ) cronet_sample_test_apk: generate result details
    cronet_sample_test_apk: generate result details
  50. ( 19 secs ) cronet_smoketests_missing_native_library_instrumentation_apk
    cronet_smoketests_missing_native_library_instrumentation_apk
  51. ( 4 ms ) cronet_smoketests_missing_native_library_instrumentation_apk: generate result details
    cronet_smoketests_missing_native_library_instrumentation_apk: generate result details
  52. ( 16 secs ) cronet_smoketests_platform_only_instrumentation_apk
    cronet_smoketests_platform_only_instrumentation_apk
  53. ( 4 ms ) cronet_smoketests_platform_only_instrumentation_apk: generate result details
    cronet_smoketests_platform_only_instrumentation_apk: generate result details
  54. ( 4 mins 54 secs ) cronet_test_instrumentation_apk
    cronet_test_instrumentation_apk
  55. ( 4 ms ) cronet_test_instrumentation_apk: generate result details
    cronet_test_instrumentation_apk: generate result details
  56. ( 3 ms ) shutdown_device_monitor
    shutdown_device_monitor
  57. ( 3 ms ) logcat_dump
    logcat_dump
  58. ( 3 ms ) gsutil upload
    gsutil upload
  59. ( 25 secs ) stack_tool_with_logcat_dump
    stack_tool_with_logcat_dump
  60. ( 4 ms ) stack_tool_for_tombstones
    stack_tool_for_tombstones
  61. ( 1 mins ) stack_tool_for_asan
    stack_tool_for_asan
  62. ( 3 ms ) Tear down ASAN on devices
    Tear down ASAN on devices
  63. ( 4 ms ) Tear down ASAN on devices.0aa6b19043e4b976
    Tear down ASAN on devices.0aa6b19043e4b976
  64. ( 3 ms ) Tear down ASAN on devices.06596466005cab1a
    Tear down ASAN on devices.06596466005cab1a
  65. ( 3 ms ) Tear down ASAN on devices.05c34aa83444c162
    Tear down ASAN on devices.05c34aa83444c162
  66. ( 3 ms ) Tear down ASAN on devices.0accc2af43e4affc
    Tear down ASAN on devices.0accc2af43e4affc
  67. ( 8 secs ) Tear down ASAN on devices.wait_for_devices
    Tear down ASAN on devices.wait_for_devices
  68. ( 4 ms ) test_report
    test_report
  69. ( 4 ms ) recipe result
    recipe result

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromium/bb/chromium.android/Android_Cronet_Builder_Asan/6673/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.android/Android_Cronet_Builder_Asan/6673" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" Annotation(bot_update)
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" Annotation(bot_update)
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" Annotation(bot_update)
got_src_revision "ab9d0ad4ed6a95ee7675fabb4d16cf63d286dba2" Annotation(bot_update)
got_src_revision_cp "refs/heads/master@{#574531}" Annotation(bot_update)
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" Annotation(bot_update)
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" Annotation(bot_update)
got_v8_revision_cp "refs/heads/6.9.352@{#1}" Annotation(bot_update)
got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#23944}" Annotation(bot_update)
got_clang_revision "336424-1" Annotation(clang_revision)
recipe "cronet" Annotation(setup_properties)
blamelist ["afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","foolip@chromium.org","lizeb@chromium.org","mathp@chromium.org","mkwst@chromium.org","pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","petermayo@chromium.org","shik@chromium.org","yhirano@chromium.org","yoshiki@chromium.org"] Build
branch "master" Build
buildnumber 6673 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1531393564 Build
revision "ab9d0ad4ed6a95ee7675fabb4d16cf63d286dba2" Build
slavename "build69-b1" BuildSlave
buildername "Android Cronet Builder Asan" Builder
git_revision "ab9d0ad4ed6a95ee7675fabb4d16cf63d286dba2" Change
scheduler "chromium_commits" Scheduler
buildbotURL "https://build.chromium.org/p/chromium.android/" master.cfg
mastername "chromium.android" master.cfg
workdir "/b/build/slave/Android_Cronet_Builder_Asan" slave

Blamelist:

  1. (afdo-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  2. (mkwstohnoyoudont@chromium.org)
  3. (foolipohnoyoudont@chromium.org)
  4. (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  5. (mathpohnoyoudont@chromium.org)
  6. (yhiranoohnoyoudont@chromium.org)
  7. (petermayoohnoyoudont@chromium.org)
  8. (lizebohnoyoudont@chromium.org)
  9. (shikohnoyoudont@chromium.org)
  10. (yoshikiohnoyoudont@chromium.org)

Timing:

Create N/A
Start Thursday, 12-Jul-18 12:20:14 UTC
End Thursday, 12-Jul-18 12:55:43 UTC
Pending N/A
Execution 35 mins 29 secs

All Changes:

  1. Roll AFDO from 69.0.3488.0_rc-r1 to 69.0.3489.0_rc-r1

    Changed by afdo-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 11:04:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a837f9d78ab2670ad242acd3651e0bf1f29a2a39

    Comments

    Roll AFDO from 69.0.3488.0_rc-r1 to 69.0.3489.0_rc-r1
    
    This CL may cause a small binary size increase, roughly proportional
    to how long it's been since our last AFDO profile roll. For larger
    increases (around or exceeding 100KB), please file a bug against
    gbiv@chromium.org. Additional context: https://crbug.com/805539
    
    The AutoRoll server is located here: https://afdo-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    I
    ...skip...
     contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=gbiv@chromium.org
    
    Change-Id: I0095acd5d9522beaf64a43baf3bb71106038fe7c
    Reviewed-on: https://chromium-review.googlesource.com/1134870
    Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574522}

    Changed files

    • chrome/android/profiles/newest.txt
  2. Revert "Make NetworkConnectionTracker survive network service crashes and restarts"

    Changed by mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 11:11:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 197e9188dc5be69cb34e1ebd67f86a1146439367

    Comments

    Revert "Make NetworkConnectionTracker survive network service crashes and restarts"
    
    This reverts commit cec0800c372ef670f59999fb3f028013d36b866c.
    
    Reason for revert:
    
    Findit (https://goo.gl/kROfz5) identified this CL at revision 574314 as the culprit
    for introducing flakiness in the tests as shown on:
    https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vY2VjMDgwMGMzNzJlZjY3MGY1OTk5OWZiM2YwMjgwMTNkMzZiODY2Yww
    
    TBR=xunjieli@chro
    ...skip...
    lek <jam@chromium.org>
    > Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574314}
    
    TBR=jam@chromium.org,xunjieli@chromium.org,tbansal@chromium.org
    
    Change-Id: I2524f0e04441097e06585f4f2e4cdb948a419641
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 821009
    Reviewed-on: https://chromium-review.googlesource.com/1135006
    Reviewed-by: Mike West <mkwst@chromium.org>
    Commit-Queue: Mike West <mkwst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574523}

    Changed files

    • chrome/browser/browser_process_impl.cc
    • chrome/browser/net/network_connection_tracker_browsertest.cc
    • chrome/browser/net/network_quality_tracker_browsertest.cc
    • content/public/browser/network_connection_tracker.cc
    • content/public/browser/network_connection_tracker.h
    • content/public/browser/network_connection_tracker_unittest.cc
  3. Mark textdecoder-fatal-single-byte.any.worker.html flaky to unblock WPT import

    Changed by foolipohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 11:24:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3dea5439837339b97168cdbbf6a45bfa27748b16

    Comments

    Mark textdecoder-fatal-single-byte.any.worker.html flaky to unblock WPT import
    
    TBR=robertma
    
    Bug: 862938
    Change-Id: I9ceda537526da02ebadc9799d58fb042d7f339d3
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/1134770
    Commit-Queue: Philip J├Ągenstedt <foolip@chromium.org>
    Reviewed-by: Philip J├Ągenstedt <foolip@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574524}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  4. Roll src/third_party/pdfium d8882193737a..68d04f284423 (1 commits)

    Changed by pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 11:28:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a1f9c10c3ca23a47aa60fe21a5b990c9d7cd589a

    Comments

    Roll src/third_party/pdfium d8882193737a..68d04f284423 (1 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/d8882193737a..68d04f284423
    
    
    git log d8882193737a..68d04f284423 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 art-snake@yandex-team.ru Reland "Avoid duplicate data buffering in CPDF_SyntaxParser::ReadStream()."
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@68d04f284423
    
    The AutoRoll server is located here: https://pdfium-roll.skia.org
    
    Documentation for the AutoR
    ...skip...
    current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I09ab0d06005fa49756095e583c16e039d0c8df3c
    Reviewed-on: https://chromium-review.googlesource.com/1134846
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574525}

    Changed files

    • DEPS
  5. [NTP] Adding mathp@ as owner of components/search

    Changed by mathpohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 11:31:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1bc34891c3dbe8da1ac513111db7c7d2efd56f20

    Comments

    [NTP] Adding mathp@ as owner of components/search
    
    Few reasons for this:
    - My team and myself are now owners of the feature
    - Both current owners are gone through the end of July
    - I am owners of other parts of the NTP code (resources, data sources) as well
      as server-side code; as such, I think I'm qualified.
    
    Bug: None
    Change-Id: Ic1261dacba81a420500240c5a55bc547fb8b6c14
    Reviewed-on: https://chromium-review.googlesource.com/1133767
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Commit-Queue: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574526}

    Changed files

    • components/search/OWNERS
  6. [Fetch] Use wrapper tracing to express references between wrappers

    Changed by yhiranoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 11:53:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a7c8ee607674efabc720016992893e2226ce3a0

    Comments

    [Fetch] Use wrapper tracing to express references between wrappers
    
    This is a reland of
    https://crrev.com/8057f58cb22579bc685efa50c579325ed047d51a which has
    been reverted due to a crash issue. The crash was caused by a missing
    TraceWrapperMember in blink::Response. This CL fixes that, and adds
    a layout test to verify that.
    
    Original CL: https://chromium-review.googlesource.com/c/1124270
    
    Bug: 862440
    Change-Id: I2842b957f223cfb32fee2aa9048b550010cb2e45
    Reviewed-on: https://chromium-review.googlesource.com/1134642
    Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    Reviewed-by: Adam Rice <ricea@chromium.org>
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574527}

    Changed files

    • third_party/WebKit/LayoutTests/http/tests/fetch/chromium/body-wrapper-tracing.html
    • third_party/blink/renderer/core/fetch/body_stream_buffer.cc
    • third_party/blink/renderer/core/fetch/body_stream_buffer.h
    • third_party/blink/renderer/core/fetch/fetch_request_data.cc
    • third_party/blink/renderer/core/fetch/fetch_request_data.h
    • third_party/blink/renderer/core/fetch/fetch_response_data.cc
    • third_party/blink/renderer/core/fetch/fetch_response_data.h
    • third_party/blink/renderer/core/fetch/request.cc
    • third_party/blink/renderer/core/fetch/request.h
    • third_party/blink/renderer/core/fetch/response.cc
    • third_party/blink/renderer/core/fetch/response.h
    • third_party/blink/renderer/modules/service_worker/fetch_event.cc
    • third_party/blink/renderer/modules/service_worker/fetch_event.h
    • third_party/blink/renderer/platform/bindings/v8_private_property.h
  7. Re-enable opening-handshake/003-sets-origin.worker.html

    Changed by petermayoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 11:58:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d18929b41e24487865c4ed9da46129e6b037beeb

    Comments

    Re-enable opening-handshake/003-sets-origin.worker.html
    
    These tests no longer timeout.  The flakiness dashboard is green
    for a long time.
    
    Bug: 803558
    Change-Id: I2924740d2c736419fdc5130e546f557c8d874151
    Reviewed-on: https://chromium-review.googlesource.com/1134094
    Reviewed-by: Robert Ma <robertma@chromium.org>
    Commit-Queue: Peter Mayo <petermayo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574528}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  8. blink/wtf: Really move MovableStrings when DCHECK_IS_ON.

    Changed by lizebohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:09:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d1fef2b1ad38fe1ef8c3914fb5dadc39bae80b9b

    Comments

    blink/wtf: Really move MovableStrings when DCHECK_IS_ON.
    
    When a MovableString is parked, actually park the content, and poison
    the previous allocation. This is intended to find cached raw pointer
    accesses, which are not allowed beyond the UI thread task per the
    contract of the class.
    Enabled only when DCHECK_IS_ON to prevent potential crashes.
    
    Changes with and without DCHECK()s:
    - Cache some String properties in MovableStringImpl
    - Add a parked_strings_ to MovableStringTable for accounting, and
      update tests accordingly.
    
    Changes with DCHECK()s:
    - Add a parked_string_ member to MovableStringImpl
    - Copy the string to the parked version in Park(), and poison the
      previous allocation.
    - Restore the string in Unpark().
    
    Bug: 837659
    Change-Id: Ib7631d5e12471826c9e71a424e30d26cf8f1f042
    Reviewed-on: https://chromium-review.googlesource.com/1133169
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Benoit L <lizeb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574529}

    Changed files

    • third_party/blink/renderer/platform/wtf/text/movable_string.cc
    • third_party/blink/renderer/platform/wtf/text/movable_string.h
    • third_party/blink/renderer/platform/wtf/text/movable_string_test.cc
  9. media: sync the camera metadata definitions

    Changed by shikohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:13:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 38884d4717c2517cb832722d0fa4871a89d19799

    Comments

    media: sync the camera metadata definitions
    
    We need some new metadata tags for external camera, so regenerate and
    sync all of them in arc-camera, chromium, and ARC++.
    
    Some "arc" are replaced by "cros" manually.
    
    BUG=b:77833131
    TEST=Verify CCA works on Nautilus.
    
    Change-Id: I308e258d9b72acdd825591041a67ce7352dce6a8
    Reviewed-on: https://chromium-review.googlesource.com/1117970
    Reviewed-by: Ricky Liang <jcliang@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Shik Chen <shik@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574530}

    Changed files

    • media/capture/video/chromeos/mojo/camera_metadata_tags.mojom
  10. Activate widget correctly when the inline reply opens on ARC notification

    Changed by yoshikiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:13:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab9d0ad4ed6a95ee7675fabb4d16cf63d286dba2

    Comments

    Activate widget correctly when the inline reply opens on ARC notification
    
    When a non-ARC normal window (eg. Chrome browser window) was active, the
    inline textbox didn't work for the second time and later. This CL solves
    this issue.
    
    This was because the widget was not activated correctly (IsActive() was
    true but CanActivate() was false) in that case. This CL removes the
    IsActive() guard to make the widget active correctly whenever the inline
    reply opens.
    
    Bug: b/111100376
    Bug: 858938
    Test: manual (inline reply can be used multiple times)
    
    Change-Id: I65d7604be5d24ff1e6c56336a76a5951d6066b39
    Reviewed-on: https://chromium-review.googlesource.com/1133039
    Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
    Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574531}

    Changed files

    • ash/system/message_center/arc/arc_notification_content_view.cc