Home | Search
Login

Builder Android Cronet Builder (dbg) Build #10917 Canonical Ubuntu

Results:

build successful

Trigger Info:

Execution:

Steps and Logfiles:

Show:
  1. ( 32 mins 47 secs ) steps
    running steps via annotated script
  2. ( 10 secs ) update_scripts
    update_scripts
  3. ( 1 ms ) LUCI Migration
    LUCI Migration
  4. ( 1 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 5 ms ) setup_build
    setup_build
    running recipe: "cronet"
  6. ( 4 ms ) cleanup index.lock
    cleanup index.lock
  7. ( 7 mins 42 secs ) bot_update
    bot_update
    [53GB/442GB used (11%)]
  8. ( 5 secs ) clean local files
    clean local files
  9. ( 3 ms ) ensure_goma
    ensure_goma
  10. ( 4 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  11. ( 3 ms ) clobber
    clobber
  12. ( 1 mins 54 secs ) gclient runhooks
    gclient runhooks
  13. ( 5 ms ) lookup GN args
    lookup GN args
     
    Count of GN args (21) exceeds limit (15), presented in logs instead
  14. ( 11 secs ) generate_build_files
    generate_build_files
  15. ( 3 ms ) preprocess_for_goma
    preprocess_for_goma
  16. ( 4 ms ) preprocess_for_goma.goma cache directory
    preprocess_for_goma.goma cache directory
  17. ( 6 secs ) preprocess_for_goma.start_goma
    preprocess_for_goma.start_goma
  18. ( 3 ms ) preprocess_for_goma.start cloudtail
    preprocess_for_goma.start cloudtail
  19. ( 5 mins 16 secs ) compile
    compile
  20. ( 3 ms ) compile confirm no-op
    compile confirm no-op
  21. ( 3 ms ) postprocess_for_goma
    postprocess_for_goma
  22. ( 4 ms ) postprocess_for_goma.goma_jsonstatus
    postprocess_for_goma.goma_jsonstatus
  23. ( 3 ms ) postprocess_for_goma.goma_stat
    postprocess_for_goma.goma_stat
  24. ( 3 ms ) postprocess_for_goma.stop_goma
    postprocess_for_goma.stop_goma
  25. ( 7 secs ) postprocess_for_goma.upload_log
    postprocess_for_goma.upload_log
  26. ( 3 ms ) postprocess_for_goma.stop cloudtail
    postprocess_for_goma.stop cloudtail
  27. ( 5 ms ) sizes
    sizes
    sizes
    <div class="BuildResultInfo">
    </div>
  28. ( 3 ms ) get version
    get version
  29. ( 3 ms ) create adb symlink
    create adb symlink
  30. ( 3 ms ) spawn_logcat_monitor
    spawn_logcat_monitor
  31. ( 3 ms ) spawn_device_monitor
    spawn_device_monitor
  32. ( 5 secs ) authorize_adb_devices
    authorize_adb_devices
  33. ( 5 secs ) device_recovery
    device_recovery
  34. ( 2 mins 53 secs ) provision_devices
    provision_devices
  35. ( 9 ms ) device_status
    device_status
    Online devices: 4
  36. ( 25 secs ) cronet_unittests_android
    cronet_unittests_android
  37. ( 6 mins 38 secs ) net_unittests
    net_unittests
  38. ( 12 secs ) cronet_sample_test_apk
    cronet_sample_test_apk
  39. ( 4 ms ) cronet_sample_test_apk: generate result details
    cronet_sample_test_apk: generate result details
  40. ( 16 secs ) cronet_smoketests_missing_native_library_instrumentation_apk
    cronet_smoketests_missing_native_library_instrumentation_apk
  41. ( 4 ms ) cronet_smoketests_missing_native_library_instrumentation_apk: generate result details
    cronet_smoketests_missing_native_library_instrumentation_apk: generate result details
  42. ( 13 secs ) cronet_smoketests_platform_only_instrumentation_apk
    cronet_smoketests_platform_only_instrumentation_apk
  43. ( 4 ms ) cronet_smoketests_platform_only_instrumentation_apk: generate result details
    cronet_smoketests_platform_only_instrumentation_apk: generate result details
  44. ( 4 mins 28 secs ) cronet_test_instrumentation_apk
    cronet_test_instrumentation_apk
  45. ( 4 ms ) cronet_test_instrumentation_apk: generate result details
    cronet_test_instrumentation_apk: generate result details
  46. ( 3 ms ) shutdown_device_monitor
    shutdown_device_monitor
  47. ( 3 ms ) logcat_dump
    logcat_dump
  48. ( 3 ms ) gsutil upload
    gsutil upload
  49. ( 28 secs ) stack_tool_with_logcat_dump
    stack_tool_with_logcat_dump
  50. ( 4 ms ) stack_tool_for_tombstones
    stack_tool_for_tombstones
  51. ( 4 ms ) test_report
    test_report
  52. ( 4 ms ) recipe result
    recipe result

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromium/bb/chromium.android/Android_Cronet_Builder__dbg_/10917/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.android/Android_Cronet_Builder__dbg_/10917" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" Annotation(bot_update)
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" Annotation(bot_update)
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" Annotation(bot_update)
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" Annotation(bot_update)
got_src_revision "162f0b1678e9c6b559ee7931f910cff372d9e5e2" Annotation(bot_update)
got_src_revision_cp "refs/heads/master@{#606877}" Annotation(bot_update)
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" Annotation(bot_update)
got_v8_revision "31b2546b348e864539ade15897eac971b3c0e402" Annotation(bot_update)
got_v8_revision_cp "refs/heads/7.2.286@{#1}" Annotation(bot_update)
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#25544}" Annotation(bot_update)
build_data_dir "/b/rr/tmpq54d8v" Annotation(steps)
build_id "buildbot/chromium.android/Android Cronet Builder (dbg)/10917" Annotation(steps)
builder_id "master.chromium.android:Android Cronet Builder (dbg)" Annotation(steps)
blamelist ["aaronhk@google.com","andruud@chromium.org","buldina@chromium.org","chlily@chromium.org","chromium-autoroll@skia-public.iam.gserviceaccount.com","chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com","digit@google.com","djean@google.com","dtapuska@chromium.org","eugenebut@google.com","fserb@chromium.org","guidou@chromium.org","hiroshige@chromium.org","jhawkins@chromium.org","mcarlen@chromium.org","mrsuyi@chromium.org","nektar@chromium.org","pdr@chromium.org","pshmakov@google.com","rayankans@google.com","scottmg@chromium.org","skobes@chromium.org","skym@google.com","thakis@chromium.org","thestig@chromium.org","timvolodine@chromium.org","tonikitoo@igalia.com","treib@chromium.org","vasilii@chromium.org"] Build
branch "master" Build
buildnumber 10917 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1541776588 Build
revision "162f0b1678e9c6b559ee7931f910cff372d9e5e2" Build
slavename "build69-b1" BuildSlave
buildername "Android Cronet Builder (dbg)" Builder
git_revision "162f0b1678e9c6b559ee7931f910cff372d9e5e2" Change
scheduler "chromium_commits" Scheduler
buildbotURL "https://build.chromium.org/p/chromium.android/" master.cfg
mastername "chromium.android" master.cfg
workdir "/b/build/slave/Android_Cronet_Builder__dbg_" slave

Blamelist:

  1. (dtapuskaohnoyoudont@chromium.org)
  2. (andruudohnoyoudont@chromium.org)
  3. (hiroshigeohnoyoudont@chromium.org)
  4. (andruudohnoyoudont@chromium.org)
  5. (treibohnoyoudont@chromium.org)
  6. (aaronhkohnoyoudont@google.com)
  7. (djeanohnoyoudont@google.com)
  8. (rayankansohnoyoudont@google.com)
  9. (timvolodineohnoyoudont@chromium.org)
  10. (pshmakovohnoyoudont@google.com)
  11. (eugenebutohnoyoudont@google.com)
  12. (eugenebutohnoyoudont@google.com)
  13. (guidouohnoyoudont@chromium.org)
  14. (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  15. (nektarohnoyoudont@chromium.org)
  16. (thakisohnoyoudont@chromium.org)
  17. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  18. (fserbohnoyoudont@chromium.org)
  19. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  20. (vasiliiohnoyoudont@chromium.org)
  21. (tonikitooohnoyoudont@igalia.com)
  22. (jhawkinsohnoyoudont@chromium.org)
  23. (digitohnoyoudont@google.com)
  24. (mrsuyiohnoyoudont@chromium.org)
  25. (thestigohnoyoudont@chromium.org)
  26. (djeanohnoyoudont@google.com)
  27. (mcarlenohnoyoudont@chromium.org)
  28. (dtapuskaohnoyoudont@chromium.org)
  29. (scottmgohnoyoudont@chromium.org)
  30. (skymohnoyoudont@google.com)
  31. (pdrohnoyoudont@chromium.org)
  32. (buldinaohnoyoudont@chromium.org)
  33. (chlilyohnoyoudont@chromium.org)
  34. (skobesohnoyoudont@chromium.org)

Timing:

Create N/A
Start Friday, 09-Nov-18 17:17:22 UTC
End Friday, 09-Nov-18 17:50:10 UTC
Pending N/A
Execution 32 mins 47 secs

All Changes:

  1. Retire NotificationInlineReplies runtime enabled flag.

    Changed by dtapuskaohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:15:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5395d94feaf7a04c1a7fd9832d3750c636d6dea1

    Comments

    Retire NotificationInlineReplies runtime enabled flag.
    
    NotificationInlineReplies shipped in M70.
    
    BUG=834580
    
    Change-Id: Ibed1612aae4c21a239e9328d7134cd75169c713a
    Reviewed-on: https://chromium-review.googlesource.com/c/1323615
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606844}

    Changed files

    • third_party/blink/renderer/modules/notifications/notification_action.idl
    • third_party/blink/renderer/modules/notifications/notification_event.idl
    • third_party/blink/renderer/modules/notifications/notification_event_init.idl
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  2. Add UseCounter for unknown namespace usage in selectors.

    Changed by andruudohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:21:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3c413c91c21481af23cfb54d742e80fd2b589608

    Comments

    Add UseCounter for unknown namespace usage in selectors.
    
    R=chrishtr@chromium.org
    
    Bug: 901938
    Change-Id: I9e20fe19f2c97b98f8250c6c9914512b5a73d8c7
    Reviewed-on: https://chromium-review.googlesource.com/c/1318891
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606845}

    Changed files

    • third_party/blink/public/platform/web_feature.mojom
    • third_party/blink/renderer/core/css/parser/css_selector_parser.cc
    • third_party/blink/renderer/core/frame/use_counter_test.cc
    • tools/metrics/histograms/enums.xml
  3. Add redirected cases to CSP/import tests in wpt/worklets

    Changed by hiroshigeohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:21:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9ff65400edef4c2d8e8ed01f1e2bd60c1c55aa8c

    Comments

    Add redirected cases to CSP/import tests in wpt/worklets
    
    Also this CL replaces some of empty-worklet-script.js usage
    in CSP tests with empty-worklet-script-with-cors-header.js
    to make sure worklets are rejected due to CSP, not CORS.
    
    Change-Id: Ie463d206254c4c6728a79dae0ad79e4f7e333b92
    Reviewed-on: https://chromium-review.googlesource.com/c/1312146
    Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606846}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/csp-tests.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-insecure-origin-empty-worklet-script.sub.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-insecure-origin-redirected-empty-worklet-script.sub.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-remote-origin-empty-worklet-script.sub.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-remote-origin-redirected-empty-worklet-script.sub.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-tests.js
  4. Fix MergeAndOverrideOnConflict for custom properties.

    Changed by andruudohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:25:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3052bf26cacf33ea7dd70fda7cccb5bebb28cfe9

    Comments

    Fix MergeAndOverrideOnConflict for custom properties.
    
    Utilizing CSSPropertyName, to make the code much nicer.
    
    R=futhark@chromium.org
    
    Change-Id: I10733cabe27cc271eaaf3ecf62fa7713cf74eac3
    Reviewed-on: https://chromium-review.googlesource.com/c/1323650
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606847}

    Changed files

    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/css/css_property_value.cc
    • third_party/blink/renderer/core/css/css_property_value.h
    • third_party/blink/renderer/core/css/css_property_value_set.cc
    • third_party/blink/renderer/core/css/css_property_value_set.h
    • third_party/blink/renderer/core/css/css_property_value_set_test.cc
  5. SyncStandaloneTransport: Add integration test for "Reset Sync" from dashboard

    Changed by treibohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:27:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 413493e0052d3f0537cf96d619849e8acf248658

    Comments

    SyncStandaloneTransport: Add integration test for "Reset Sync" from dashboard
    
    Bug: 856179
    Change-Id: I0fb499c5bb5c0de6df4fa7c2f46d3b0b35f5f0df
    Reviewed-on: https://chromium-review.googlesource.com/c/1326901
    Commit-Queue: Marc Treib <treib@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606848}

    Changed files

    • chrome/browser/sync/test/integration/single_client_standalone_transport_sync_test.cc
    • components/sync/test/fake_server/fake_server.cc
    • components/sync/test/fake_server/fake_server.h
  6. Add RAF tests to blink_perf.canvas benchmark.

    Changed by aaronhkohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:28:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7149ab705c9a7c1c9c57c960c05e2de216680c7d

    Comments

    Add RAF tests to blink_perf.canvas benchmark.
    
    Current canvas benchmarks only measure CPU time.
    Using requestAnimationFrame (raf) in javascript we can
    measure CPU + raster + GPU time. This CL adds a mode to
    blink_perf.py that runs canvas all canvas test in a way
    that takes raster and GPU time into account.
    
    Roughly doubles the duration of `blink_perf.canvas`
    benchmark from ~2 minutes to ~4 minutes on a linux desktop.
    
    Bug: 894043
    Change-Id: I2fdd13af75615802266fa39a01db3e883f2c95bc
    Reviewed-on: https://chromium-review.googlesource.com/c/1300038
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
    Reviewed-by: Fernando Serboncini <fserb@chromium.org>
    Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606849}

    Changed files

    • docs/speed/benchmark/harnesses/blink_perf.md
    • third_party/blink/perf_tests/canvas/OWNERS
    • third_party/blink/perf_tests/canvas/gpu-bound-shader.html
    • third_party/blink/perf_tests/canvas/resources/canvas_runner.js
    • third_party/blink/perf_tests/canvas/sheets-render.html
    • third_party/blink/perf_tests/canvas/upload-webgl-to-texture.html
    • tools/perf/benchmark.csv
    • tools/perf/benchmarks/blink_perf.py
    • tools/perf/contrib/blink_layoutng_perf/blink_layoutng_perf.py
    • tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py
    • tools/perf/contrib/blink_perf_xml_http_request/blink_perf_xml_http_request.py
    • tools/perf/core/shard_maps/android-nexus5x-perf_map.json
    • tools/perf/core/shard_maps/android_nexus5_perf_map.json
    • tools/perf/core/shard_maps/android_nexus5x_webview_perf_map.json
    • tools/perf/core/shard_maps/android_nexus6_webview_perf_map.json
    • tools/perf/core/shard_maps/linux-perf_map.json
    • tools/perf/core/shard_maps/mac-10_12_laptop_low_end-perf_map.json
    • tools/perf/core/shard_maps/mac-10_13_laptop_high_end-perf_map.json
    • tools/perf/core/shard_maps/win-10-perf_map.json
    • tools/perf/core/shard_maps/win_7_nvidia_gpu_perf_map.json
    • tools/perf/core/shard_maps/win_7_perf_map.json
  7. [ios] add manual fallback credit card and address coordinator

    Changed by djeanohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:34:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b02a7719f78de1e78ded7807aa4d139f8c2b77d6

    Comments

    [ios] add manual fallback credit card and address coordinator
    
    And a common base class.
    
    Bug: 845472
    Change-Id: I12999d306804227e605e270c9b4f14bd8ee6a2bb
    Reviewed-on: https://chromium-review.googlesource.com/c/1318914
    Reviewed-by: Eric Noyau <noyau@chromium.org>
    Commit-Queue: David Jean <djean@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606850}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
    • ios/chrome/browser/ui/autofill/manual_fill/address_coordinator.h
    • ios/chrome/browser/ui/autofill/manual_fill/address_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/address_list_delegate.h
    • ios/chrome/browser/ui/autofill/manual_fill/card_coordinator.h
    • ios/chrome/browser/ui/autofill/manual_fill/card_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/card_list_delegate.h
    • ios/chrome/browser/ui/autofill/manual_fill/fallback_coordinator.h
    • ios/chrome/browser/ui/autofill/manual_fill/fallback_coordinator.mm
  8. [Background Fetch] Report uploadTotal in the registration

    Changed by rayankansohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:46:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a2e1006e2f0960cea11264c2cb65c73d0334b90

    Comments

    [Background Fetch] Report uploadTotal in the registration
    
    Also sets up some useful testing helpers for future upload features.
    
    Bug: 774054
    Change-Id: I9aea33086b228357d9a160bd35b0a37ceaa30592
    Reviewed-on: https://chromium-review.googlesource.com/c/1329149
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606851}

    Changed files

    • content/browser/background_fetch/background_fetch_data_manager_unittest.cc
    • content/browser/background_fetch/background_fetch_test_data_manager.cc
    • content/browser/background_fetch/background_fetch_test_data_manager.h
    • content/browser/background_fetch/storage/create_metadata_task.cc
  9. [AW NS] Add CTS test filter for Android WebView

    Changed by timvolodineohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:47:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e57afbcbc0d8a4fff7a9d8df6164bf0f6dcedd75

    Comments

    [AW NS] Add CTS test filter for Android WebView
    
    The idea of this CTS filter is similar to the filter we have for
    instrumentation tests, i.e.
    mojo.fyi.network_webview_instrumentation_test_apk.filter. It contains
    failing tests and their corresponding issues / root causes.
    
    The current filter contains results from a local run for a subset of
    tests (the actual CTS is not running yet). The CTS filter also
    augments the instrumentation test filter for test coverage that is
    missing from instrumentation tests.
    
    BUG=903822,902330,841556
    
    Change-Id: I006744652d8ae0a5755f0084704c9f91542d4f8d
    Reviewed-on: https://chromium-review.googlesource.com/c/1319677
    Commit-Queue: Tim Volodine <timvolodine@chromium.org>
    Reviewed-by: Clark DuVall <cduvall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606852}

    Changed files

    • testing/buildbot/filters/mojo.fyi.network_webview_CTS_test.filter
  10. Refactor Trusted Web Activity UI code to MVC

    Changed by pshmakovohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:56:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3a5daa30c703af7c6e90dd5088cdbd5fdcfdc7d0

    Comments

    Refactor Trusted Web Activity UI code to MVC
    
    The code is restructured according to the high-level MVC picture, but
    low-level details such as view binding mechanism are not used, as
    it seems to be an overkill at this point. We can easily install those
    mechanisms in future should the model become more complicated.
    
    Verification is extracted to TrustedWebActivityVerifier in the
    controller layer. Several controllers observe verification and update
    the model. Several independent Views are observing the changes in the
    model and updating themselves accordingly.
    
    Change-Id: I8882da2d648fcea21b85fd4a1c0568dd00e47113
    Reviewed-on: https://chromium-review.googlesource.com/c/1323069
    Reviewed-by: Peter Conn <peconn@chromium.org>
    Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606853}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/ClientAppDataRegister.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosure.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityOpenTimeRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityUi.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/TrustedWebActivityCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/TrustedWebActivityModel.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/ClientAppDataRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/PersistentNotificationController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityDisclosureController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityOpenTimeRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityToolbarController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityVerifier.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/PersistentNotificationView.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/TrustedWebActivityDisclosureView.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/TrustedWebActivityToolbarView.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/dependency_injection/CustomTabActivityComponent.java
    • chrome/android/java_sources.gni
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosureTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/ClientAppDataRecorderTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityDisclosureControllerTest.java
  11. Update SadTabTabHelper to work with SadTabCoordinator.

    Changed by eugenebutohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:56:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9773a84184a277ad674bbe729aa26677f1f3c800

    Comments

    Update SadTabTabHelper to work with SadTabCoordinator.
    
    SadTabTabHelper now calls sadTabTabHelperDidHide: and
    sadTabTabHelper:didShowForRepeatedFailure:
    
    Bug: 901563
    Change-Id: If2b75702c951c247d44368b681ce360bbb6464d5
    Reviewed-on: https://chromium-review.googlesource.com/c/1327167
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606854}

    Changed files

    • ios/chrome/browser/web/sad_tab_tab_helper.h
    • ios/chrome/browser/web/sad_tab_tab_helper.mm
    • ios/chrome/browser/web/sad_tab_tab_helper_unittest.mm
  12. Call WebStateObserver::PageLoaded after loading placeholder URL.

    Changed by eugenebutohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 16:00:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 386114b5bacc02e12b584786671d67b6080f02e7

    Comments

    Call WebStateObserver::PageLoaded after loading placeholder URL.
    
    Before this CL PageLoaded was called right from
    didFailProvisionalNavigation:, where URL may still represent the
    previous page.
    
    Bug: 903497
    Change-Id: I712dd120340353f37d2fe739c5b05e843cb11d7a
    Reviewed-on: https://chromium-review.googlesource.com/c/1327608
    Reviewed-by: Danyao Wang <danyao@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606855}

    Changed files

    • ios/web/web_state/ui/crw_web_controller.mm
  13. Wire the resizeMode property to the constraints parsing mechanism.

    Changed by guidouohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:02:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 75c6c086d575a9e131e70eaf6512a0da14150442

    Comments

    Wire the resizeMode property to the constraints parsing mechanism.
    
    This CL adds resizeMode support for MediaStreamTrack.getConstraints()
    and marks resizeMode as a supported constrainable property.
    
    Support for getUserMedia(), applyConstraints() and getCapabilities()
    will be added in follow-up CLs in this series.
    
    Intent to Ship:
    https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V2srjdzRCXE
    
    Bug: 854980
    Change-Id: Ia23b8119768ab67ab498f0f8e2267aeb388f9fc3
    Reviewed-on: https://chromium-review.googlesource.com/c/1309749
    Reviewed-by: Henrik Boström <hbos@chromium.org>
    Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    Commit-Queue: Guido Urdaneta <guidou@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606856}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaDevices-getSupportedConstraints.html
    • third_party/WebKit/LayoutTests/fast/mediastream/MediaDevices-getSupportedConstraints.html
    • third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getConstraints.html
    • third_party/blink/public/platform/web_media_constraints.h
    • third_party/blink/renderer/modules/mediastream/media_constraints_impl.cc
    • third_party/blink/renderer/modules/mediastream/media_stream_track.cc
    • third_party/blink/renderer/modules/mediastream/media_track_constraint_set.idl
    • third_party/blink/renderer/modules/mediastream/media_track_supported_constraints.idl
    • third_party/blink/renderer/platform/exported/web_media_constraints.cc
  14. Roll src-internal 6166365225d6..827de2c806ba (3 commits)

    Changed by chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 16:04:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 56904b670753b8f8a1f5131ef61b9e1027f34c6e

    Comments

    Roll src-internal 6166365225d6..827de2c806ba (3 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6166365225d6..827de2c806ba
    
    
    Created with:
      gclient setdep -r src-internal@827de2c806ba
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I3e94550aad679738b88e45953fbc781a647de4ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1329361
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606857}

    Changed files

    • DEPS
  15. Ensures that selection test data files are non-empty on the bots by adding data dependency to the BUILD file

    Changed by nektarohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:06:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7669a6683a5f927ae9a3fa2c2d7802e2a8d5c165

    Comments

    Ensures that selection test data files are non-empty on the bots by adding data dependency to the BUILD file
    
    In case the files are somehow not found or unreadable on the bots, the tests should fail.
    R=dmazzoni@chromium.org
    
    Change-Id: I31668ab7a1b023a9eeda251b3ae0e7079f262171
    Reviewed-on: https://chromium-review.googlesource.com/c/1324232
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606858}

    Changed files

    • third_party/blink/renderer/modules/BUILD.gn
    • third_party/blink/renderer/modules/accessibility/testing/accessibility_selection_test.cc
  16. Remove v8_context_snapshot.bin determinism hack.

    Changed by thakisohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:08:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d2acccc10cf8afd5a3709f5fd562d700d6b96979

    Comments

    Remove v8_context_snapshot.bin determinism hack.
    
    Reverts parts of
    https://chromium-review.googlesource.com/c/chromium/src/+/1293791 that should
    no longer be needed after https://chromium-review.googlesource.com/c/1304441
    
    Bug: 870584
    Change-Id: I76fa59eb5c88c34cd222f2a40c983a4f4e615b27
    Reviewed-on: https://chromium-review.googlesource.com/c/1328823
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606859}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/v8_context_snapshot.cc
  17. Roll src/third_party/skia 88e15bdaf539..c244c2fbbbf8 (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 16:10:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99e210e29e5e55c29142398eb11e164801f7d0c8

    Comments

    Roll src/third_party/skia 88e15bdaf539..c244c2fbbbf8 (1 commits)
    
    https://skia.googlesource.com/skia.git/+log/88e15bdaf539..c244c2fbbbf8
    
    
    git log 88e15bdaf539..c244c2fbbbf8 --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 mtklein@google.com remove SkBlitMask::PlatformRowProcs
    
    
    Created with:
      gclient setdep -r src/third_party/skia@c244c2fbbbf8
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.
    ...skip...
    rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    TBR=allanmac@chromium.org
    
    Change-Id: I59ebc97baec374297a4ec2b6ba5761d443086155
    Reviewed-on: https://chromium-review.googlesource.com/c/1329045
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606860}

    Changed files

    • DEPS
  18. Save transform context for filters

    Changed by fserbohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:11:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d07d7323809b59b52b1237dacb94330cc9dab4bd

    Comments

    Save transform context for filters
    
    Otherwise we get weird behavior on filters while transforming.
    
    TBR=
    
    Bug: 901759
    Change-Id: I1d487f500024a309bdb4002ba19a20387b3bb251
    Reviewed-on: https://chromium-review.googlesource.com/c/1329342
    Reviewed-by: Fernando Serboncini <fserb@chromium.org>
    Commit-Queue: Fernando Serboncini <fserb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606861}

    Changed files

    • third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.h
  19. Roll src/third_party/perfetto fd986312652f..cf90797ef05a (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 16:12:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5657f328e5325aa821d8714a3f7686c078603a43

    Comments

    Roll src/third_party/perfetto fd986312652f..cf90797ef05a (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/fd986312652f..cf90797ef05a
    
    
    git log fd986312652f..cf90797ef05a --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 lalitm@google.com Merge "trace_processor: associate rss stat and mem info events with process"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@cf90797ef05a
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-c
    ...skip...
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: Iae90928bbe8ba71f08a8b348c2f4165763d2fc9f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329362
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606862}

    Changed files

    • DEPS
  20. Ignore blur events caused by the password generation.

    Changed by vasiliiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:18:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision acf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6

    Comments

    Ignore blur events caused by the password generation.
    
    When PasswordGenerationAgent copies the password value from the password field
    to "Confirm Password" filed, a blur event is generated. It hides the currently
    open generation prompt. Those events are just side-effects of how the class
    works and should be ignored.
    
    Bug: 899756,850079
    Change-Id: Ia5d4f0184900fda97118252c48209ffcf1ce3444
    Reviewed-on: https://chromium-review.googlesource.com/c/1327205
    Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Ioana Pandele <ioanap@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606863}

    Changed files

    • chrome/renderer/autofill/fake_password_manager_client.cc
    • chrome/renderer/autofill/fake_password_manager_client.h
    • chrome/renderer/autofill/password_generation_agent_browsertest.cc
    • components/autofill/content/renderer/autofill_agent.cc
    • components/autofill/content/renderer/password_generation_agent.cc
    • components/autofill/content/renderer/password_generation_agent.h
  21. Use network::ResourceRequestInfo::proxy_server instead of was_fetched_via_proxy

    Changed by tonikitooohnoyoudont@igalia.com
    Changed at Friday, 09-Nov-18 16:24:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f513b7c0c1803fe4688b8eee2dab06f48dabf081

    Comments

    Use network::ResourceRequestInfo::proxy_server instead of was_fetched_via_proxy
    
    ... and remove the later.
    
    This is a follow up of mmenke's request in [1].
    
    [1] https://crrev.com/c/1251642/3/services/network/url_loader.cc#70
    
    TBR=nparker@chromium (components/safe_browsing/browser/threat_details_cache.cc)
    TBR=jam@chromium.org (content/browser/loader/resource_loader.cc)
    
    BUG=773295
    
    Change-Id: I932315bec7d1790dbc8726eeb1decce6e76172b1
    Reviewed-on: https://chromium-review.googlesource.com/c/1320769
    Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606864}

    Changed files

    • components/policy/core/common/cloud/device_management_service.cc
    • components/safe_browsing/browser/threat_details_cache.cc
    • content/browser/loader/resource_loader.cc
    • services/network/public/cpp/resource_response.cc
    • services/network/public/cpp/resource_response_info.cc
    • services/network/public/cpp/resource_response_info.h
    • services/network/url_loader.cc
  22. Proximity Auth: Remove kMultiDeviceApi flagging from ProxAuthWebuiHandler.

    Changed by jhawkinsohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:30:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d7bfd5bb2031d217d0e0f87240b4ce16705abb3d

    Comments

    Proximity Auth: Remove kMultiDeviceApi flagging from ProxAuthWebuiHandler.
    
    R=hansberry@chromium.org
    
    Bug: 899324
    Test: none
    Change-Id: Iac6aacb1b40608d261d6c13b12fd37bfd6b0df8f
    Reviewed-on: https://chromium-review.googlesource.com/c/1325393
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
    Commit-Queue: James Hawkins <jhawkins@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606865}

    Changed files

    • chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
    • chromeos/components/proximity_auth/webui/proximity_auth_ui.cc
    • chromeos/components/proximity_auth/webui/proximity_auth_ui.h
    • chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.cc
    • chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.h
  23. Android: Fix resource extraction from splits for Hebrew and others.

    Changed by digitohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 16:32:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 77b7b35987d9420138ebc3fcb7d24d786bf5549c

    Comments

    Android: Fix resource extraction from splits for Hebrew and others.
    
    This CL fixes a bug in the logic used to locate locale .pak files
    inside bundle splits. The reason for the bug is that bundletool
    wants to use deprecated language names (i.e. 'iw' instead of 'he')
    to store asset files.
    
    As an example, for Hebrew, Chrome was looking at:
    
      assets/locales#lang_he/he.pak
    
    While the file was really stored under:
    
      assets/locales#lang_iw/he.pak
    
    The CL fixes the issue for Hebrew, Yiddish and Indonesian and
    Filipino.
    
    BUG=902915
    R=benmason@chromium.org, tiborg@chromium.org, yfriedman@chromium.org, twellington@chromium.org
    
    Change-Id: I420158c30ba33c6203495af9453877722271e104
    Reviewed-on: https://chromium-review.googlesource.com/c/1327203
    Commit-Queue: David Turner <digit@chromium.org>
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606866}

    Changed files

    • ui/android/java/src/org/chromium/ui/base/LocalizationUtils.java
    • ui/android/java/src/org/chromium/ui/resources/ResourceExtractor.java
    • ui/android/junit/src/org/chromium/ui/base/LocalizationUtilsTest.java
  24. Remove JavaScript const/let/lambda presubmit check for iOS9.

    Changed by mrsuyiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:44:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a81bed5026f4a47ed9a0b690b0a950260f6e3e06

    Comments

    Remove JavaScript const/let/lambda presubmit check for iOS9.
    
    iOS9 is not supported by Chrome iOS and iGSA anymore, the presubmit check
    for risky ES6 grammar(const/let/lambda) can be removed now.
    
    Change-Id: I5a35d54097dbd215393aaba78868107befdc93b6
    Reviewed-on: https://chromium-review.googlesource.com/c/1329249
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Yi Su <mrsuyi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606867}

    Changed files

    • PRESUBMIT.py
    • PRESUBMIT_test.py
  25. Fix a typo in bisect-builds.py.

    Changed by thestigohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:46:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1c8c6f7ecd6a1927225c2257544c6d370441854f

    Comments

    Fix a typo in bisect-builds.py.
    
    Windows archives extract out into a directory called chrome-win. There
    is no chrome-winp directory.
    
    TBR=robertocn@chromium.org
    
    Change-Id: Ia5ee2725e107f32c44105ca396e28a4c0a06844c
    Reviewed-on: https://chromium-review.googlesource.com/c/1313731
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Ben Pastene <bpastene@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606868}

    Changed files

    • tools/bisect-builds.py
  26. [ios] plug in manual fallback for credit card and address

    Changed by djeanohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 16:50:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ec464d0a7b2ab771c1c7642a3568de17f4904b29

    Comments

    [ios] plug in manual fallback for credit card and address
    
    Bug: 845472
    Change-Id: Ie26e9022b60612b5ef90c7e9b2bde4202e6e745c
    Reviewed-on: https://chromium-review.googlesource.com/c/1319594
    Commit-Queue: David Jean <djean@chromium.org>
    Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606869}

    Changed files

    • ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/fallback_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.h
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm
  27. [Autofill Assistant] Integrate Payment Request.

    Changed by mcarlenohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:54:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 56a06fd5e79c627d247ce9976c217ea14a17c9c5

    Comments

    [Autofill Assistant] Integrate Payment Request.
    
    This patch is the first step to integrate the payment request UI into
    the autofill assistant sheet.
    
    The patch has and leaves a few rough edges but we'll deal with that
    piece by piece. In particular, the dismiss logic needs to be handled
    differently, so does the error view logic.
    
    Note: The DimmingDialog is reverted to package default visibility since
    the dependency from autofill assistant is removed here.
    
    Bug: 806868
    Change-Id: I25b83b804e13bbdec5d2a1688dd01cd085615b38
    Reviewed-on: https://chromium-review.googlesource.com/c/1324451
    Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
    Reviewed-by: Ganggui Tang <gogerald@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606870}

    Changed files

    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_payment_request.xml
    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_payment_request_bottom_bar.xml
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantPaymentRequest.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/BottomBarAnimations.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/PaymentRequestUI.java
    • chrome/android/java/src/org/chromium/chrome/browser/payments/ui/DimmingDialog.java
  28. Retire PerformanceNavigationTiming2 runtime enabled flag.

    Changed by dtapuskaohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:56:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 48519d5c39fc3533942f8107cce3df766e1d45b2

    Comments

    Retire PerformanceNavigationTiming2 runtime enabled flag.
    
    Feature first shipped in M57.
    
    BUG=611276
    
    Change-Id: Ib4b514df4f72b29333b534e6978ea8fa3dea5128
    Reviewed-on: https://chromium-review.googlesource.com/c/1323628
    Reviewed-by: David Bokan <bokan@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606871}

    Changed files

    • third_party/blink/renderer/core/timing/performance_navigation_timing.idl
    • third_party/blink/renderer/core/timing/window_performance.cc
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  29. fuchsia: Update sdk build job link in docs

    Changed by scottmgohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:02:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4e05b6f1c53bf3cfa376b672b70ed83643274b56

    Comments

    fuchsia: Update sdk build job link in docs
    
    Change-Id: I203f142ee84ecefeb36adaf9da175404f75194eb
    Reviewed-on: https://chromium-review.googlesource.com/c/1329506
    Commit-Queue: Scott Graham <scottmg@chromium.org>
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606872}

    Changed files

    • docs/fuchsia_sdk_updates.md
  30. [Feed] When rescheduling, just set period to 1 day instead of going to

    Changed by skymohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 17:02:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1dc99fe0bd2792457e4cc526e945df228ec47234

    Comments

    [Feed] When rescheduling, just set period to 1 day instead of going to
    native.
    
    Bug: 901331
    Change-Id: I65b3d748cb96669fa78a712552f82a44873debf3
    Reviewed-on: https://chromium-review.googlesource.com/c/1315929
    Commit-Queue: Sky Malice <skym@chromium.org>
    Reviewed-by: Filip Gorski <fgorski@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606873}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedRefreshTask.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedScheduler.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedSchedulerBridge.java
  31. [BlinkGenPropertyTrees] Stop incorrect clearing of property tree changed

    Changed by pdrohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:08:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6f5a1bd0249536b05ba2d3b45f175e742d1a6a47

    Comments

    [BlinkGenPropertyTrees] Stop incorrect clearing of property tree changed
    
    PaintPropertyTreeNode::Changed is used for in-layer raster invalidation,
    and cc damage for both SPV2 and BGPT. https://crrev.com/606472 failed
    to account for the case when non-transient paint controllers in
    GraphicsLayers would clear property tree changed values before the
    values could be used for damage.
    
    As a reminder, with BlinkGenPropertyTrees, each GraphicsLayer keeps a
    non-transient paint controller, and at the end of pain
    ...skip...
    nto the transient paint controller.
    
    This patch changes BGPT to clear all property tree changed bits after
    damage has been calculated in PaintArtifactCompositor. It is implemented
    with a recursive walk of the GraphicsLayer tree.
    
    Bug: 899628
    Change-Id: Ibc7d65d6ab8875508b9c3dd18ab6db1230bf1308
    Reviewed-on: https://chromium-review.googlesource.com/c/1327804
    Commit-Queue: Philip Rogers <pdr@chromium.org>
    Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606874}

    Changed files

    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/paint/invalidation/clip/clip-path-constant-repaint-expected.txt
    • third_party/blink/renderer/core/exported/web_layer_test.cc
    • third_party/blink/renderer/core/frame/local_frame_view.cc
    • third_party/blink/renderer/platform/graphics/graphics_layer_test.cc
    • third_party/blink/renderer/platform/graphics/paint/paint_artifact.cc
    • third_party/blink/renderer/platform/graphics/paint/paint_controller.cc
    • third_party/blink/renderer/platform/graphics/paint/paint_controller.h
    • third_party/blink/renderer/platform/graphics/paint/paint_property_node.h
  32. [ChromeDriver] Add tests names where Chrome retried to start to logs

    Changed by buldinaohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:10:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e02c93aa236dd55c50eafd019f865e192192ac34

    Comments

    [ChromeDriver] Add tests names where Chrome retried to start to logs
    
    Change-Id: I6d2cf48b16562f60e35b2d499bfbbe25c12533c1
    Reviewed-on: https://chromium-review.googlesource.com/c/1327168
    Reviewed-by: John Chen <johnchen@chromium.org>
    Commit-Queue: Tatiana Buldina <buldina@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606875}

    Changed files

    • chrome/test/chromedriver/client/chromedriver.py
    • chrome/test/chromedriver/test/run_py_tests.py
  33. Add reprioritization to SSLConnectJobs

    Changed by chlilyohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:13:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8a9302e29c7625fd7cdc65f374fc7f00550c21aa

    Comments

    Add reprioritization to SSLConnectJobs
    
    This change allows the priority of an SSLConnectJob to be changed. If
    the reprioritization occurs while the job is establishing its underlying
    connection, the priority change is also passed down to the lower-level
    socket pool.
    
    Bug: 166689
    Change-Id: I87d1e536846443901cc628423f4615c3ffa7542a
    Reviewed-on: https://chromium-review.googlesource.com/c/1327423
    Commit-Queue: Lily Chen <chlily@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606876}

    Changed files

    • net/socket/socket_test_util.cc
    • net/socket/socket_test_util.h
    • net/socket/ssl_client_socket_pool.cc
    • net/socket/ssl_client_socket_pool.h
    • net/socket/ssl_client_socket_pool_unittest.cc
  34. Add and report LayoutStability.JankScore UKM.

    Changed by skobesohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:14:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 162f0b1678e9c6b559ee7931f910cff372d9e5e2

    Comments

    Add and report LayoutStability.JankScore UKM.
    
    We prolong the lifetime of UkmPageLoadMetricsObserver to permit jank
    score reporting at session end for tabs that start or become hidden,
    but avoid extra reporting of other metrics by checking was_hidden_.
    
    The OnFinalLayoutStabilityUpdate hook is removed in favor of passing
    PageRenderData to existing hooks through PageLoadExtraInfo.  This lets
    the observer decide when to report.
    
    UKM collection review doc: go/lsukmrev
    
    Bug: 581518
    Change-Id: I2983dff155872f3080474e09df784d20b3cb08d3
    Reviewed-on: https://chromium-review.googlesource.com/c/1299917
    Commit-Queue: Steve Kobes <skobes@chromium.org>
    Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606877}

    Changed files

    • chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
    • chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
    • chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
    • chrome/browser/page_load_metrics/page_load_metrics_observer.cc
    • chrome/browser/page_load_metrics/page_load_metrics_observer.h
    • chrome/browser/page_load_metrics/page_load_tracker.cc
    • tools/metrics/ukm/ukm.xml